std.Build: check for native CPU when serializing CrossTarget by mlugg · Pull Request #16860 · ziglang/zig

mlugg · 2023-08-16T20:37:18Z

When using std.Build.dependency with target options, dependencies
would sometimes get targets which are equivalent but have distinct
names, e.g. native vs native-native. This is a somewhat broad issue,
and it's unclear how to fix it more generally - perhaps we should
special-case CrossTarget in options passing, or maybe targets should
have a canonical name which we guarantee to use everywhere aside from
raw user input.

However, this commit fixes the most egregious issue, which was an active
blocker to using the package manager for some users. This was caused by
the CPU changing from native to a specific descriptor (e.g.
skylake+sgx), which then changed the behavior of zigTriple.

Resolves: #16856

When using `std.Build.dependency` with target options, dependencies would sometimes get targets which are equivalent but have distinct names, e.g. `native` vs `native-native`. This is a somewhat broad issue, and it's unclear how to fix it more generally - perhaps we should special-case CrossTarget in options passing, or maybe targets should have a canonical name which we guarantee to use everywhere aside from raw user input. However, this commit fixes the most egregious issue, which was an active blocker to using the package manager for some users. This was caused by the CPU changing from `native` to a specific descriptor (e.g. `skylake+sgx`), which then changed the behavior of `zigTriple`. Resolves: ziglang#16856

andrewrk · 2023-08-17T01:05:33Z

Thanks.

mlugg · 2023-08-16T20:37:18Z

When using std.Build.dependency with target options, dependencies
would sometimes get targets which are equivalent but have distinct
names, e.g. native vs native-native. This is a somewhat broad issue,
and it's unclear how to fix it more generally - perhaps we should
special-case CrossTarget in options passing, or maybe targets should
have a canonical name which we guarantee to use everywhere aside from
raw user input.

However, this commit fixes the most egregious issue, which was an active
blocker to using the package manager for some users. This was caused by
the CPU changing from native to a specific descriptor (e.g.
skylake+sgx), which then changed the behavior of zigTriple.

Resolves: #16856

When using `std.Build.dependency` with target options, dependencies would sometimes get targets which are equivalent but have distinct names, e.g. `native` vs `native-native`. This is a somewhat broad issue, and it's unclear how to fix it more generally - perhaps we should special-case CrossTarget in options passing, or maybe targets should have a canonical name which we guarantee to use everywhere aside from raw user input. However, this commit fixes the most egregious issue, which was an active blocker to using the package manager for some users. This was caused by the CPU changing from `native` to a specific descriptor (e.g. `skylake+sgx`), which then changed the behavior of `zigTriple`. Resolves: ziglang#16856

andrewrk · 2023-08-17T01:05:33Z

Thanks.

mlugg · 2023-08-16T20:37:18Z

When using std.Build.dependency with target options, dependencies
would sometimes get targets which are equivalent but have distinct
names, e.g. native vs native-native. This is a somewhat broad issue,
and it's unclear how to fix it more generally - perhaps we should
special-case CrossTarget in options passing, or maybe targets should
have a canonical name which we guarantee to use everywhere aside from
raw user input.

However, this commit fixes the most egregious issue, which was an active
blocker to using the package manager for some users. This was caused by
the CPU changing from native to a specific descriptor (e.g.
skylake+sgx), which then changed the behavior of zigTriple.

Resolves: #16856

When using `std.Build.dependency` with target options, dependencies would sometimes get targets which are equivalent but have distinct names, e.g. `native` vs `native-native`. This is a somewhat broad issue, and it's unclear how to fix it more generally - perhaps we should special-case CrossTarget in options passing, or maybe targets should have a canonical name which we guarantee to use everywhere aside from raw user input. However, this commit fixes the most egregious issue, which was an active blocker to using the package manager for some users. This was caused by the CPU changing from `native` to a specific descriptor (e.g. `skylake+sgx`), which then changed the behavior of `zigTriple`. Resolves: ziglang#16856

andrewrk · 2023-08-17T01:05:33Z

Thanks.

mlugg · 2023-08-16T20:37:18Z

When using std.Build.dependency with target options, dependencies
would sometimes get targets which are equivalent but have distinct
names, e.g. native vs native-native. This is a somewhat broad issue,
and it's unclear how to fix it more generally - perhaps we should
special-case CrossTarget in options passing, or maybe targets should
have a canonical name which we guarantee to use everywhere aside from
raw user input.

However, this commit fixes the most egregious issue, which was an active
blocker to using the package manager for some users. This was caused by
the CPU changing from native to a specific descriptor (e.g.
skylake+sgx), which then changed the behavior of zigTriple.

Resolves: #16856

When using `std.Build.dependency` with target options, dependencies would sometimes get targets which are equivalent but have distinct names, e.g. `native` vs `native-native`. This is a somewhat broad issue, and it's unclear how to fix it more generally - perhaps we should special-case CrossTarget in options passing, or maybe targets should have a canonical name which we guarantee to use everywhere aside from raw user input. However, this commit fixes the most egregious issue, which was an active blocker to using the package manager for some users. This was caused by the CPU changing from `native` to a specific descriptor (e.g. `skylake+sgx`), which then changed the behavior of `zigTriple`. Resolves: ziglang#16856

andrewrk · 2023-08-17T01:05:33Z

Thanks.

mlugg · 2023-08-16T20:37:18Z

When using std.Build.dependency with target options, dependencies
would sometimes get targets which are equivalent but have distinct
names, e.g. native vs native-native. This is a somewhat broad issue,
and it's unclear how to fix it more generally - perhaps we should
special-case CrossTarget in options passing, or maybe targets should
have a canonical name which we guarantee to use everywhere aside from
raw user input.

However, this commit fixes the most egregious issue, which was an active
blocker to using the package manager for some users. This was caused by
the CPU changing from native to a specific descriptor (e.g.
skylake+sgx), which then changed the behavior of zigTriple.

Resolves: #16856

When using `std.Build.dependency` with target options, dependencies would sometimes get targets which are equivalent but have distinct names, e.g. `native` vs `native-native`. This is a somewhat broad issue, and it's unclear how to fix it more generally - perhaps we should special-case CrossTarget in options passing, or maybe targets should have a canonical name which we guarantee to use everywhere aside from raw user input. However, this commit fixes the most egregious issue, which was an active blocker to using the package manager for some users. This was caused by the CPU changing from `native` to a specific descriptor (e.g. `skylake+sgx`), which then changed the behavior of `zigTriple`. Resolves: ziglang#16856

andrewrk · 2023-08-17T01:05:33Z

Thanks.

mlugg · 2023-08-16T20:37:18Z

When using std.Build.dependency with target options, dependencies
would sometimes get targets which are equivalent but have distinct
names, e.g. native vs native-native. This is a somewhat broad issue,
and it's unclear how to fix it more generally - perhaps we should
special-case CrossTarget in options passing, or maybe targets should
have a canonical name which we guarantee to use everywhere aside from
raw user input.

However, this commit fixes the most egregious issue, which was an active
blocker to using the package manager for some users. This was caused by
the CPU changing from native to a specific descriptor (e.g.
skylake+sgx), which then changed the behavior of zigTriple.

Resolves: #16856

When using `std.Build.dependency` with target options, dependencies would sometimes get targets which are equivalent but have distinct names, e.g. `native` vs `native-native`. This is a somewhat broad issue, and it's unclear how to fix it more generally - perhaps we should special-case CrossTarget in options passing, or maybe targets should have a canonical name which we guarantee to use everywhere aside from raw user input. However, this commit fixes the most egregious issue, which was an active blocker to using the package manager for some users. This was caused by the CPU changing from `native` to a specific descriptor (e.g. `skylake+sgx`), which then changed the behavior of `zigTriple`. Resolves: ziglang#16856

andrewrk · 2023-08-17T01:05:33Z

Thanks.

mlugg · 2023-08-16T20:37:18Z

When using std.Build.dependency with target options, dependencies
would sometimes get targets which are equivalent but have distinct
names, e.g. native vs native-native. This is a somewhat broad issue,
and it's unclear how to fix it more generally - perhaps we should
special-case CrossTarget in options passing, or maybe targets should
have a canonical name which we guarantee to use everywhere aside from
raw user input.

However, this commit fixes the most egregious issue, which was an active
blocker to using the package manager for some users. This was caused by
the CPU changing from native to a specific descriptor (e.g.
skylake+sgx), which then changed the behavior of zigTriple.

Resolves: #16856

When using `std.Build.dependency` with target options, dependencies would sometimes get targets which are equivalent but have distinct names, e.g. `native` vs `native-native`. This is a somewhat broad issue, and it's unclear how to fix it more generally - perhaps we should special-case CrossTarget in options passing, or maybe targets should have a canonical name which we guarantee to use everywhere aside from raw user input. However, this commit fixes the most egregious issue, which was an active blocker to using the package manager for some users. This was caused by the CPU changing from `native` to a specific descriptor (e.g. `skylake+sgx`), which then changed the behavior of `zigTriple`. Resolves: ziglang#16856

andrewrk · 2023-08-17T01:05:33Z

Thanks.

mlugg · 2023-08-16T20:37:18Z

When using std.Build.dependency with target options, dependencies
would sometimes get targets which are equivalent but have distinct
names, e.g. native vs native-native. This is a somewhat broad issue,
and it's unclear how to fix it more generally - perhaps we should
special-case CrossTarget in options passing, or maybe targets should
have a canonical name which we guarantee to use everywhere aside from
raw user input.

However, this commit fixes the most egregious issue, which was an active
blocker to using the package manager for some users. This was caused by
the CPU changing from native to a specific descriptor (e.g.
skylake+sgx), which then changed the behavior of zigTriple.

Resolves: #16856

When using `std.Build.dependency` with target options, dependencies would sometimes get targets which are equivalent but have distinct names, e.g. `native` vs `native-native`. This is a somewhat broad issue, and it's unclear how to fix it more generally - perhaps we should special-case CrossTarget in options passing, or maybe targets should have a canonical name which we guarantee to use everywhere aside from raw user input. However, this commit fixes the most egregious issue, which was an active blocker to using the package manager for some users. This was caused by the CPU changing from `native` to a specific descriptor (e.g. `skylake+sgx`), which then changed the behavior of `zigTriple`. Resolves: ziglang#16856

andrewrk · 2023-08-17T01:05:33Z

Thanks.

andrewrk merged commit 000aa30 into ziglang:masterAug 17, 2023