Uh oh!
There was an error while loading. Please reload this page.
Add a sort functionality to linked lists - #17981
Merged
Merged
Conversation
Vexu
enabled auto-merge (squash)
November 21, 2023 12:03
auto-merge was automatically disabled
November 24, 2023 17:45
Head branch was pushed to by a user without write access
Vexu
enabled auto-merge (squash)
November 24, 2023 18:13
andrewrk
commented
Nov 25, 2023
Member
Reverted in e834e95 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The algorithms provided by std.sort are currently only able to deal with slices and converting a linked list to a slice before sorting it is not exactly efficient so this is a different scenario than e.g. for ArrayLists (#3917).
I think in this case it would make sense to provide a specialised function for linked lists, especially for merge sort (which I have implemented here for std.SinglyLinkedList) as it can run in place on a linked list.