Uh oh!
There was an error while loading. Please reload this page.
add type check to zirSwitchBlockErrUnion - #18593
Merged
Merged
Conversation
Rexicon226
commented
Jan 16, 2024
ContributorAuthor
I know what I did wrong, one sec! 🤣 |
Contributor
Is it worth adding a compile error test in |
Rexicon226
commented
Jan 17, 2024
ContributorAuthor
Ah, good point. |
ContributorAuthor
I wonder if this is something that should error somewhere in the |
dweiller
commented
Jan 17, 2024
Contributor
I don't think it can happen in astgen - the case in the issue could, but not something like: consta=true;
acatch|e|switch (e) {
// ...
}; |
Rexicon226
commented
Jan 17, 2024
ContributorAuthor
Yeah, you're right. Was just a thought. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes#18592