Update wasi-libc to d03829489904d38c624f6de9983190f1e5e7c9c5 - #19614

Merged
alexrp merged 3 commits into
ziglang:masterfrom
jedisct1:wasi-libc-update
Feb 6, 2025
Merged

Update wasi-libc to d03829489904d38c624f6de9983190f1e5e7c9c5#19614
alexrp merged 3 commits into
ziglang:masterfrom
jedisct1:wasi-libc-update

Conversation

@jedisct1

Copy link
Copy Markdown
Contributor

Most notable improvements include realpath and stubs for statvfs, chmod, etc.

Other changes are for WASI 0.2 which is going to be painful to support since 3rd party tools written in Rust may become necessary in addition to LLVM (WebAssembly/wasi-sdk#402)

@jedisct1

Copy link
Copy Markdown
ContributorAuthor

This also removes junk we were shipping but irrelevant to webassembly.

@lin72h

Copy link
Copy Markdown

10KLoc reduce, feel so good

@jedisct1

Copy link
Copy Markdown
ContributorAuthor

Added the wasi-libc libdl shim, so that tools such as py2wasm can use zig cc.

Comment threadlib/libc/wasi/libc-bottom-half/sources/preopens.c
@andrewrk

Copy link
Copy Markdown
Member

man. wasi-libc kinda sucks. how about we provide libc via zig code instead?

@jedisct1

jedisct1 commented Jun 8, 2024

Copy link
Copy Markdown
ContributorAuthor

wasi-libc is horrible. And it's getting worse with the wasi preview 2 bits.

But rewriting it in Zig would be a lot of work.

Comment threadsrc/wasi_libc.zig
Comment threadlib/std/Target.zig Outdated
@alexrp

Copy link
Copy Markdown
Member

@jedisct1 I've rebased this on master locally, do you mind if I force-push to your branch? I'd like to get this in for 0.14.0.

@jedisct1

Copy link
Copy Markdown
ContributorAuthor

Sure, go ahead!

There's been changes in wasi-libc since that PR, but the build system has become a giant spaghetti mess.

@alexrp

Copy link
Copy Markdown
Member

Yeah, I figure this is likely to be our last wasi-libc update, what with all the Rust tooling they're apparently mixing in due to the component model stuff. #2879 is probably going to be the way forward in the long term (unless we develop our own component model tooling).

@alexrpalexrp added this to the 0.14.0 milestone Jan 29, 2025
@alexrp

Copy link
Copy Markdown
Member

@andrewrk you ok with taking this as our (probably) last wasi-libc update? (At least unless/until we develop self-hosted component model tooling.)

@alexrp
alexrp requested a review from andrewrkFebruary 3, 2025 15:04
@jedisct1

Copy link
Copy Markdown
ContributorAuthor

wasi-libc still supports wasi.0.1 (aka wasi-core, wasip1, etc). So it can still be updated; I don't think the Rust tools are required for it.

@andrewrk

Copy link
Copy Markdown
Member

you ok with taking this as our (probably) last wasi-libc update?

Yes 👍

@alexrp
alexrp merged commit 1a1389c into ziglang:masterFeb 6, 2025
Comment threadsrc/wasi_libc.zig
crt1_reactor_o,
crt1_command_o,
libc_a,
libdl_a,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this strikes me as strange... wasi doesn't support dynamic linking, so what in the world is this library?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weakvoid*dlopen(constchar*name, intflags)
{
error="dlopen not implemented";
returnNULL;
}
weakvoid*dlsym(void*library, constchar*name)
{
error="dlsym not implemented";
returnNULL;
}

oh.

ok, well, it won't be very difficult to implement this in zig 🙄

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is just another one of those "emulated" WASI libraries that do nothing so existing software can compile. For whatever reason it doesn't follow the usual naming pattern.

FWIW, these all strike me as silly and I wouldn't be opposed to removing them, but that'd probably be separate work.

@alexrpalexrp removed this from the 0.14.0 milestone Feb 21, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@jedisct1@lin72h@andrewrk@alexrp@rektide
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

Update wasi-libc to d03829489904d38c624f6de9983190f1e5e7c9c5 - #19614

Merged
alexrp merged 3 commits into
ziglang:masterfrom
jedisct1:wasi-libc-update
Feb 6, 2025
Merged

Update wasi-libc to d03829489904d38c624f6de9983190f1e5e7c9c5#19614
alexrp merged 3 commits into
ziglang:masterfrom
jedisct1:wasi-libc-update

Conversation

@jedisct1

Copy link
Copy Markdown
Contributor

Most notable improvements include realpath and stubs for statvfs, chmod, etc.

Other changes are for WASI 0.2 which is going to be painful to support since 3rd party tools written in Rust may become necessary in addition to LLVM (WebAssembly/wasi-sdk#402)

@jedisct1

Copy link
Copy Markdown
ContributorAuthor

This also removes junk we were shipping but irrelevant to webassembly.

@lin72h

Copy link
Copy Markdown

10KLoc reduce, feel so good

@jedisct1

Copy link
Copy Markdown
ContributorAuthor

Added the wasi-libc libdl shim, so that tools such as py2wasm can use zig cc.

Comment threadlib/libc/wasi/libc-bottom-half/sources/preopens.c
@andrewrk

Copy link
Copy Markdown
Member

man. wasi-libc kinda sucks. how about we provide libc via zig code instead?

@jedisct1

jedisct1 commented Jun 8, 2024

Copy link
Copy Markdown
ContributorAuthor

wasi-libc is horrible. And it's getting worse with the wasi preview 2 bits.

But rewriting it in Zig would be a lot of work.

Comment threadsrc/wasi_libc.zig
Comment threadlib/std/Target.zig Outdated
@alexrp

Copy link
Copy Markdown
Member

@jedisct1 I've rebased this on master locally, do you mind if I force-push to your branch? I'd like to get this in for 0.14.0.

@jedisct1

Copy link
Copy Markdown
ContributorAuthor

Sure, go ahead!

There's been changes in wasi-libc since that PR, but the build system has become a giant spaghetti mess.

@alexrp

Copy link
Copy Markdown
Member

Yeah, I figure this is likely to be our last wasi-libc update, what with all the Rust tooling they're apparently mixing in due to the component model stuff. #2879 is probably going to be the way forward in the long term (unless we develop our own component model tooling).

@alexrpalexrp added this to the 0.14.0 milestone Jan 29, 2025
@alexrp

Copy link
Copy Markdown
Member

@andrewrk you ok with taking this as our (probably) last wasi-libc update? (At least unless/until we develop self-hosted component model tooling.)

@alexrp
alexrp requested a review from andrewrkFebruary 3, 2025 15:04
@jedisct1

Copy link
Copy Markdown
ContributorAuthor

wasi-libc still supports wasi.0.1 (aka wasi-core, wasip1, etc). So it can still be updated; I don't think the Rust tools are required for it.

@andrewrk

Copy link
Copy Markdown
Member

you ok with taking this as our (probably) last wasi-libc update?

Yes 👍

@alexrp
alexrp merged commit 1a1389c into ziglang:masterFeb 6, 2025
Comment threadsrc/wasi_libc.zig
crt1_reactor_o,
crt1_command_o,
libc_a,
libdl_a,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this strikes me as strange... wasi doesn't support dynamic linking, so what in the world is this library?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weakvoid*dlopen(constchar*name, intflags)
{
error="dlopen not implemented";
returnNULL;
}
weakvoid*dlsym(void*library, constchar*name)
{
error="dlsym not implemented";
returnNULL;
}

oh.

ok, well, it won't be very difficult to implement this in zig 🙄

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is just another one of those "emulated" WASI libraries that do nothing so existing software can compile. For whatever reason it doesn't follow the usual naming pattern.

FWIW, these all strike me as silly and I wouldn't be opposed to removing them, but that'd probably be separate work.

@alexrpalexrp removed this from the 0.14.0 milestone Feb 21, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@jedisct1@lin72h@andrewrk@alexrp@rektide
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Update wasi-libc to d03829489904d38c624f6de9983190f1e5e7c9c5 - #19614

Merged
alexrp merged 3 commits into
ziglang:masterfrom
jedisct1:wasi-libc-update
Feb 6, 2025
Merged

Update wasi-libc to d03829489904d38c624f6de9983190f1e5e7c9c5#19614
alexrp merged 3 commits into
ziglang:masterfrom
jedisct1:wasi-libc-update

Conversation

@jedisct1

Copy link
Copy Markdown
Contributor

Most notable improvements include realpath and stubs for statvfs, chmod, etc.

Other changes are for WASI 0.2 which is going to be painful to support since 3rd party tools written in Rust may become necessary in addition to LLVM (WebAssembly/wasi-sdk#402)

@jedisct1

Copy link
Copy Markdown
ContributorAuthor

This also removes junk we were shipping but irrelevant to webassembly.

@lin72h

Copy link
Copy Markdown

10KLoc reduce, feel so good

@jedisct1

Copy link
Copy Markdown
ContributorAuthor

Added the wasi-libc libdl shim, so that tools such as py2wasm can use zig cc.

Comment threadlib/libc/wasi/libc-bottom-half/sources/preopens.c
@andrewrk

Copy link
Copy Markdown
Member

man. wasi-libc kinda sucks. how about we provide libc via zig code instead?

@jedisct1

jedisct1 commented Jun 8, 2024

Copy link
Copy Markdown
ContributorAuthor

wasi-libc is horrible. And it's getting worse with the wasi preview 2 bits.

But rewriting it in Zig would be a lot of work.

Comment threadsrc/wasi_libc.zig
Comment threadlib/std/Target.zig Outdated
@alexrp

Copy link
Copy Markdown
Member

@jedisct1 I've rebased this on master locally, do you mind if I force-push to your branch? I'd like to get this in for 0.14.0.

@jedisct1

Copy link
Copy Markdown
ContributorAuthor

Sure, go ahead!

There's been changes in wasi-libc since that PR, but the build system has become a giant spaghetti mess.

@alexrp

Copy link
Copy Markdown
Member

Yeah, I figure this is likely to be our last wasi-libc update, what with all the Rust tooling they're apparently mixing in due to the component model stuff. #2879 is probably going to be the way forward in the long term (unless we develop our own component model tooling).

@alexrpalexrp added this to the 0.14.0 milestone Jan 29, 2025
@alexrp

Copy link
Copy Markdown
Member

@andrewrk you ok with taking this as our (probably) last wasi-libc update? (At least unless/until we develop self-hosted component model tooling.)

@alexrp
alexrp requested a review from andrewrkFebruary 3, 2025 15:04
@jedisct1

Copy link
Copy Markdown
ContributorAuthor

wasi-libc still supports wasi.0.1 (aka wasi-core, wasip1, etc). So it can still be updated; I don't think the Rust tools are required for it.

@andrewrk

Copy link
Copy Markdown
Member

you ok with taking this as our (probably) last wasi-libc update?

Yes 👍

@alexrp
alexrp merged commit 1a1389c into ziglang:masterFeb 6, 2025
Comment threadsrc/wasi_libc.zig
crt1_reactor_o,
crt1_command_o,
libc_a,
libdl_a,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this strikes me as strange... wasi doesn't support dynamic linking, so what in the world is this library?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weakvoid*dlopen(constchar*name, intflags)
{
error="dlopen not implemented";
returnNULL;
}
weakvoid*dlsym(void*library, constchar*name)
{
error="dlsym not implemented";
returnNULL;
}

oh.

ok, well, it won't be very difficult to implement this in zig 🙄

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is just another one of those "emulated" WASI libraries that do nothing so existing software can compile. For whatever reason it doesn't follow the usual naming pattern.

FWIW, these all strike me as silly and I wouldn't be opposed to removing them, but that'd probably be separate work.

@alexrpalexrp removed this from the 0.14.0 milestone Feb 21, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@jedisct1@lin72h@andrewrk@alexrp@rektide
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Update wasi-libc to d03829489904d38c624f6de9983190f1e5e7c9c5 - #19614

Merged
alexrp merged 3 commits into
ziglang:masterfrom
jedisct1:wasi-libc-update
Feb 6, 2025
Merged

Update wasi-libc to d03829489904d38c624f6de9983190f1e5e7c9c5#19614
alexrp merged 3 commits into
ziglang:masterfrom
jedisct1:wasi-libc-update

Conversation

@jedisct1

Copy link
Copy Markdown
Contributor

Most notable improvements include realpath and stubs for statvfs, chmod, etc.

Other changes are for WASI 0.2 which is going to be painful to support since 3rd party tools written in Rust may become necessary in addition to LLVM (WebAssembly/wasi-sdk#402)

@jedisct1

Copy link
Copy Markdown
ContributorAuthor

This also removes junk we were shipping but irrelevant to webassembly.

@lin72h

Copy link
Copy Markdown

10KLoc reduce, feel so good

@jedisct1

Copy link
Copy Markdown
ContributorAuthor

Added the wasi-libc libdl shim, so that tools such as py2wasm can use zig cc.

Comment threadlib/libc/wasi/libc-bottom-half/sources/preopens.c
@andrewrk

Copy link
Copy Markdown
Member

man. wasi-libc kinda sucks. how about we provide libc via zig code instead?

@jedisct1

jedisct1 commented Jun 8, 2024

Copy link
Copy Markdown
ContributorAuthor

wasi-libc is horrible. And it's getting worse with the wasi preview 2 bits.

But rewriting it in Zig would be a lot of work.

Comment threadsrc/wasi_libc.zig
Comment threadlib/std/Target.zig Outdated
@alexrp

Copy link
Copy Markdown
Member

@jedisct1 I've rebased this on master locally, do you mind if I force-push to your branch? I'd like to get this in for 0.14.0.

@jedisct1

Copy link
Copy Markdown
ContributorAuthor

Sure, go ahead!

There's been changes in wasi-libc since that PR, but the build system has become a giant spaghetti mess.

@alexrp

Copy link
Copy Markdown
Member

Yeah, I figure this is likely to be our last wasi-libc update, what with all the Rust tooling they're apparently mixing in due to the component model stuff. #2879 is probably going to be the way forward in the long term (unless we develop our own component model tooling).

@alexrpalexrp added this to the 0.14.0 milestone Jan 29, 2025
@alexrp

Copy link
Copy Markdown
Member

@andrewrk you ok with taking this as our (probably) last wasi-libc update? (At least unless/until we develop self-hosted component model tooling.)

@alexrp
alexrp requested a review from andrewrkFebruary 3, 2025 15:04
@jedisct1

Copy link
Copy Markdown
ContributorAuthor

wasi-libc still supports wasi.0.1 (aka wasi-core, wasip1, etc). So it can still be updated; I don't think the Rust tools are required for it.

@andrewrk

Copy link
Copy Markdown
Member

you ok with taking this as our (probably) last wasi-libc update?

Yes 👍

@alexrp
alexrp merged commit 1a1389c into ziglang:masterFeb 6, 2025
Comment threadsrc/wasi_libc.zig
crt1_reactor_o,
crt1_command_o,
libc_a,
libdl_a,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this strikes me as strange... wasi doesn't support dynamic linking, so what in the world is this library?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weakvoid*dlopen(constchar*name, intflags)
{
error="dlopen not implemented";
returnNULL;
}
weakvoid*dlsym(void*library, constchar*name)
{
error="dlsym not implemented";
returnNULL;
}

oh.

ok, well, it won't be very difficult to implement this in zig 🙄

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is just another one of those "emulated" WASI libraries that do nothing so existing software can compile. For whatever reason it doesn't follow the usual naming pattern.

FWIW, these all strike me as silly and I wouldn't be opposed to removing them, but that'd probably be separate work.

@alexrpalexrp removed this from the 0.14.0 milestone Feb 21, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@jedisct1@lin72h@andrewrk@alexrp@rektide
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

Update wasi-libc to d03829489904d38c624f6de9983190f1e5e7c9c5 - #19614

Merged
alexrp merged 3 commits into
ziglang:masterfrom
jedisct1:wasi-libc-update
Feb 6, 2025
Merged

Update wasi-libc to d03829489904d38c624f6de9983190f1e5e7c9c5#19614
alexrp merged 3 commits into
ziglang:masterfrom
jedisct1:wasi-libc-update

Conversation

@jedisct1

Copy link
Copy Markdown
Contributor

Most notable improvements include realpath and stubs for statvfs, chmod, etc.

Other changes are for WASI 0.2 which is going to be painful to support since 3rd party tools written in Rust may become necessary in addition to LLVM (WebAssembly/wasi-sdk#402)

@jedisct1

Copy link
Copy Markdown
ContributorAuthor

This also removes junk we were shipping but irrelevant to webassembly.

@lin72h

Copy link
Copy Markdown

10KLoc reduce, feel so good

@jedisct1

Copy link
Copy Markdown
ContributorAuthor

Added the wasi-libc libdl shim, so that tools such as py2wasm can use zig cc.

Comment threadlib/libc/wasi/libc-bottom-half/sources/preopens.c
@andrewrk

Copy link
Copy Markdown
Member

man. wasi-libc kinda sucks. how about we provide libc via zig code instead?

@jedisct1

jedisct1 commented Jun 8, 2024

Copy link
Copy Markdown
ContributorAuthor

wasi-libc is horrible. And it's getting worse with the wasi preview 2 bits.

But rewriting it in Zig would be a lot of work.

Comment threadsrc/wasi_libc.zig
Comment threadlib/std/Target.zig Outdated
@alexrp

Copy link
Copy Markdown
Member

@jedisct1 I've rebased this on master locally, do you mind if I force-push to your branch? I'd like to get this in for 0.14.0.

@jedisct1

Copy link
Copy Markdown
ContributorAuthor

Sure, go ahead!

There's been changes in wasi-libc since that PR, but the build system has become a giant spaghetti mess.

@alexrp

Copy link
Copy Markdown
Member

Yeah, I figure this is likely to be our last wasi-libc update, what with all the Rust tooling they're apparently mixing in due to the component model stuff. #2879 is probably going to be the way forward in the long term (unless we develop our own component model tooling).

@alexrpalexrp added this to the 0.14.0 milestone Jan 29, 2025
@alexrp

Copy link
Copy Markdown
Member

@andrewrk you ok with taking this as our (probably) last wasi-libc update? (At least unless/until we develop self-hosted component model tooling.)

@alexrp
alexrp requested a review from andrewrkFebruary 3, 2025 15:04
@jedisct1

Copy link
Copy Markdown
ContributorAuthor

wasi-libc still supports wasi.0.1 (aka wasi-core, wasip1, etc). So it can still be updated; I don't think the Rust tools are required for it.

@andrewrk

Copy link
Copy Markdown
Member

you ok with taking this as our (probably) last wasi-libc update?

Yes 👍

@alexrp
alexrp merged commit 1a1389c into ziglang:masterFeb 6, 2025
Comment threadsrc/wasi_libc.zig
crt1_reactor_o,
crt1_command_o,
libc_a,
libdl_a,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this strikes me as strange... wasi doesn't support dynamic linking, so what in the world is this library?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weakvoid*dlopen(constchar*name, intflags)
{
error="dlopen not implemented";
returnNULL;
}
weakvoid*dlsym(void*library, constchar*name)
{
error="dlsym not implemented";
returnNULL;
}

oh.

ok, well, it won't be very difficult to implement this in zig 🙄

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is just another one of those "emulated" WASI libraries that do nothing so existing software can compile. For whatever reason it doesn't follow the usual naming pattern.

FWIW, these all strike me as silly and I wouldn't be opposed to removing them, but that'd probably be separate work.

@alexrpalexrp removed this from the 0.14.0 milestone Feb 21, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@jedisct1@lin72h@andrewrk@alexrp@rektide
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Update wasi-libc to d03829489904d38c624f6de9983190f1e5e7c9c5 - #19614

Merged
alexrp merged 3 commits into
ziglang:masterfrom
jedisct1:wasi-libc-update
Feb 6, 2025
Merged

Update wasi-libc to d03829489904d38c624f6de9983190f1e5e7c9c5#19614
alexrp merged 3 commits into
ziglang:masterfrom
jedisct1:wasi-libc-update

Conversation

@jedisct1

Copy link
Copy Markdown
Contributor

Most notable improvements include realpath and stubs for statvfs, chmod, etc.

Other changes are for WASI 0.2 which is going to be painful to support since 3rd party tools written in Rust may become necessary in addition to LLVM (WebAssembly/wasi-sdk#402)

@jedisct1

Copy link
Copy Markdown
ContributorAuthor

This also removes junk we were shipping but irrelevant to webassembly.

@lin72h

Copy link
Copy Markdown

10KLoc reduce, feel so good

@jedisct1

Copy link
Copy Markdown
ContributorAuthor

Added the wasi-libc libdl shim, so that tools such as py2wasm can use zig cc.

Comment threadlib/libc/wasi/libc-bottom-half/sources/preopens.c
@andrewrk

Copy link
Copy Markdown
Member

man. wasi-libc kinda sucks. how about we provide libc via zig code instead?

@jedisct1

jedisct1 commented Jun 8, 2024

Copy link
Copy Markdown
ContributorAuthor

wasi-libc is horrible. And it's getting worse with the wasi preview 2 bits.

But rewriting it in Zig would be a lot of work.

Comment threadsrc/wasi_libc.zig
Comment threadlib/std/Target.zig Outdated
@alexrp

Copy link
Copy Markdown
Member

@jedisct1 I've rebased this on master locally, do you mind if I force-push to your branch? I'd like to get this in for 0.14.0.

@jedisct1

Copy link
Copy Markdown
ContributorAuthor

Sure, go ahead!

There's been changes in wasi-libc since that PR, but the build system has become a giant spaghetti mess.

@alexrp

Copy link
Copy Markdown
Member

Yeah, I figure this is likely to be our last wasi-libc update, what with all the Rust tooling they're apparently mixing in due to the component model stuff. #2879 is probably going to be the way forward in the long term (unless we develop our own component model tooling).

@alexrpalexrp added this to the 0.14.0 milestone Jan 29, 2025
@alexrp

Copy link
Copy Markdown
Member

@andrewrk you ok with taking this as our (probably) last wasi-libc update? (At least unless/until we develop self-hosted component model tooling.)

@alexrp
alexrp requested a review from andrewrkFebruary 3, 2025 15:04
@jedisct1

Copy link
Copy Markdown
ContributorAuthor

wasi-libc still supports wasi.0.1 (aka wasi-core, wasip1, etc). So it can still be updated; I don't think the Rust tools are required for it.

@andrewrk

Copy link
Copy Markdown
Member

you ok with taking this as our (probably) last wasi-libc update?

Yes 👍

@alexrp
alexrp merged commit 1a1389c into ziglang:masterFeb 6, 2025
Comment threadsrc/wasi_libc.zig
crt1_reactor_o,
crt1_command_o,
libc_a,
libdl_a,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this strikes me as strange... wasi doesn't support dynamic linking, so what in the world is this library?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weakvoid*dlopen(constchar*name, intflags)
{
error="dlopen not implemented";
returnNULL;
}
weakvoid*dlsym(void*library, constchar*name)
{
error="dlsym not implemented";
returnNULL;
}

oh.

ok, well, it won't be very difficult to implement this in zig 🙄

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is just another one of those "emulated" WASI libraries that do nothing so existing software can compile. For whatever reason it doesn't follow the usual naming pattern.

FWIW, these all strike me as silly and I wouldn't be opposed to removing them, but that'd probably be separate work.

@alexrpalexrp removed this from the 0.14.0 milestone Feb 21, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@jedisct1@lin72h@andrewrk@alexrp@rektide
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Update wasi-libc to d03829489904d38c624f6de9983190f1e5e7c9c5 - #19614

Merged
alexrp merged 3 commits into
ziglang:masterfrom
jedisct1:wasi-libc-update
Feb 6, 2025
Merged

Update wasi-libc to d03829489904d38c624f6de9983190f1e5e7c9c5#19614
alexrp merged 3 commits into
ziglang:masterfrom
jedisct1:wasi-libc-update

Conversation

@jedisct1

Copy link
Copy Markdown
Contributor

Most notable improvements include realpath and stubs for statvfs, chmod, etc.

Other changes are for WASI 0.2 which is going to be painful to support since 3rd party tools written in Rust may become necessary in addition to LLVM (WebAssembly/wasi-sdk#402)

@jedisct1

Copy link
Copy Markdown
ContributorAuthor

This also removes junk we were shipping but irrelevant to webassembly.

@lin72h

Copy link
Copy Markdown

10KLoc reduce, feel so good

@jedisct1

Copy link
Copy Markdown
ContributorAuthor

Added the wasi-libc libdl shim, so that tools such as py2wasm can use zig cc.

Comment threadlib/libc/wasi/libc-bottom-half/sources/preopens.c
@andrewrk

Copy link
Copy Markdown
Member

man. wasi-libc kinda sucks. how about we provide libc via zig code instead?

@jedisct1

jedisct1 commented Jun 8, 2024

Copy link
Copy Markdown
ContributorAuthor

wasi-libc is horrible. And it's getting worse with the wasi preview 2 bits.

But rewriting it in Zig would be a lot of work.

Comment threadsrc/wasi_libc.zig
Comment threadlib/std/Target.zig Outdated
@alexrp

Copy link
Copy Markdown
Member

@jedisct1 I've rebased this on master locally, do you mind if I force-push to your branch? I'd like to get this in for 0.14.0.

@jedisct1

Copy link
Copy Markdown
ContributorAuthor

Sure, go ahead!

There's been changes in wasi-libc since that PR, but the build system has become a giant spaghetti mess.

@alexrp

Copy link
Copy Markdown
Member

Yeah, I figure this is likely to be our last wasi-libc update, what with all the Rust tooling they're apparently mixing in due to the component model stuff. #2879 is probably going to be the way forward in the long term (unless we develop our own component model tooling).

@alexrpalexrp added this to the 0.14.0 milestone Jan 29, 2025
@alexrp

Copy link
Copy Markdown
Member

@andrewrk you ok with taking this as our (probably) last wasi-libc update? (At least unless/until we develop self-hosted component model tooling.)

@alexrp
alexrp requested a review from andrewrkFebruary 3, 2025 15:04
@jedisct1

Copy link
Copy Markdown
ContributorAuthor

wasi-libc still supports wasi.0.1 (aka wasi-core, wasip1, etc). So it can still be updated; I don't think the Rust tools are required for it.

@andrewrk

Copy link
Copy Markdown
Member

you ok with taking this as our (probably) last wasi-libc update?

Yes 👍

@alexrp
alexrp merged commit 1a1389c into ziglang:masterFeb 6, 2025
Comment threadsrc/wasi_libc.zig
crt1_reactor_o,
crt1_command_o,
libc_a,
libdl_a,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this strikes me as strange... wasi doesn't support dynamic linking, so what in the world is this library?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weakvoid*dlopen(constchar*name, intflags)
{
error="dlopen not implemented";
returnNULL;
}
weakvoid*dlsym(void*library, constchar*name)
{
error="dlsym not implemented";
returnNULL;
}

oh.

ok, well, it won't be very difficult to implement this in zig 🙄

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is just another one of those "emulated" WASI libraries that do nothing so existing software can compile. For whatever reason it doesn't follow the usual naming pattern.

FWIW, these all strike me as silly and I wouldn't be opposed to removing them, but that'd probably be separate work.

@alexrpalexrp removed this from the 0.14.0 milestone Feb 21, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@jedisct1@lin72h@andrewrk@alexrp@rektide
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

Update wasi-libc to d03829489904d38c624f6de9983190f1e5e7c9c5 - #19614

Merged
alexrp merged 3 commits into
ziglang:masterfrom
jedisct1:wasi-libc-update
Feb 6, 2025
Merged

Update wasi-libc to d03829489904d38c624f6de9983190f1e5e7c9c5#19614
alexrp merged 3 commits into
ziglang:masterfrom
jedisct1:wasi-libc-update

Conversation

@jedisct1

Copy link
Copy Markdown
Contributor

Most notable improvements include realpath and stubs for statvfs, chmod, etc.

Other changes are for WASI 0.2 which is going to be painful to support since 3rd party tools written in Rust may become necessary in addition to LLVM (WebAssembly/wasi-sdk#402)

@jedisct1

Copy link
Copy Markdown
ContributorAuthor

This also removes junk we were shipping but irrelevant to webassembly.

@lin72h

Copy link
Copy Markdown

10KLoc reduce, feel so good

@jedisct1

Copy link
Copy Markdown
ContributorAuthor

Added the wasi-libc libdl shim, so that tools such as py2wasm can use zig cc.

Comment threadlib/libc/wasi/libc-bottom-half/sources/preopens.c
@andrewrk

Copy link
Copy Markdown
Member

man. wasi-libc kinda sucks. how about we provide libc via zig code instead?

@jedisct1

jedisct1 commented Jun 8, 2024

Copy link
Copy Markdown
ContributorAuthor

wasi-libc is horrible. And it's getting worse with the wasi preview 2 bits.

But rewriting it in Zig would be a lot of work.

Comment threadsrc/wasi_libc.zig
Comment threadlib/std/Target.zig Outdated
@alexrp

Copy link
Copy Markdown
Member

@jedisct1 I've rebased this on master locally, do you mind if I force-push to your branch? I'd like to get this in for 0.14.0.

@jedisct1

Copy link
Copy Markdown
ContributorAuthor

Sure, go ahead!

There's been changes in wasi-libc since that PR, but the build system has become a giant spaghetti mess.

@alexrp

Copy link
Copy Markdown
Member

Yeah, I figure this is likely to be our last wasi-libc update, what with all the Rust tooling they're apparently mixing in due to the component model stuff. #2879 is probably going to be the way forward in the long term (unless we develop our own component model tooling).

@alexrpalexrp added this to the 0.14.0 milestone Jan 29, 2025
@alexrp

Copy link
Copy Markdown
Member

@andrewrk you ok with taking this as our (probably) last wasi-libc update? (At least unless/until we develop self-hosted component model tooling.)

@alexrp
alexrp requested a review from andrewrkFebruary 3, 2025 15:04
@jedisct1

Copy link
Copy Markdown
ContributorAuthor

wasi-libc still supports wasi.0.1 (aka wasi-core, wasip1, etc). So it can still be updated; I don't think the Rust tools are required for it.

@andrewrk

Copy link
Copy Markdown
Member

you ok with taking this as our (probably) last wasi-libc update?

Yes 👍

@alexrp
alexrp merged commit 1a1389c into ziglang:masterFeb 6, 2025
Comment threadsrc/wasi_libc.zig
crt1_reactor_o,
crt1_command_o,
libc_a,
libdl_a,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this strikes me as strange... wasi doesn't support dynamic linking, so what in the world is this library?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weakvoid*dlopen(constchar*name, intflags)
{
error="dlopen not implemented";
returnNULL;
}
weakvoid*dlsym(void*library, constchar*name)
{
error="dlsym not implemented";
returnNULL;
}

oh.

ok, well, it won't be very difficult to implement this in zig 🙄

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is just another one of those "emulated" WASI libraries that do nothing so existing software can compile. For whatever reason it doesn't follow the usual naming pattern.

FWIW, these all strike me as silly and I wouldn't be opposed to removing them, but that'd probably be separate work.

@alexrpalexrp removed this from the 0.14.0 milestone Feb 21, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@jedisct1@lin72h@andrewrk@alexrp@rektide