Uh oh!
There was an error while loading. Please reload this page.
Update wasi-libc to d03829489904d38c624f6de9983190f1e5e7c9c5 - #19614
Conversation
jedisct1
commented
Apr 11, 2024
This also removes junk we were shipping but irrelevant to webassembly. |
lin72h
commented
Apr 12, 2024
10KLoc reduce, feel so good |
jedisct1
commented
Apr 18, 2024
Added the wasi-libc |
Uh oh!
There was an error while loading. Please reload this page.
andrewrk
commented
Jun 8, 2024
man. wasi-libc kinda sucks. how about we provide libc via zig code instead? |
But rewriting it in Zig would be a lot of work. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
alexrp
commented
Jan 29, 2025
@jedisct1 I've rebased this on master locally, do you mind if I force-push to your branch? I'd like to get this in for 0.14.0. |
jedisct1
commented
Jan 29, 2025
Sure, go ahead! There's been changes in |
alexrp
commented
Jan 29, 2025
Yeah, I figure this is likely to be our last wasi-libc update, what with all the Rust tooling they're apparently mixing in due to the component model stuff. #2879 is probably going to be the way forward in the long term (unless we develop our own component model tooling). |
alexrp
commented
Feb 3, 2025
@andrewrk you ok with taking this as our (probably) last wasi-libc update? (At least unless/until we develop self-hosted component model tooling.) |
jedisct1
commented
Feb 3, 2025
|
andrewrk
commented
Feb 6, 2025
Yes 👍 |
| crt1_reactor_o, | ||
| crt1_command_o, | ||
| libc_a, | ||
| libdl_a, |
There was a problem hiding this comment.
this strikes me as strange... wasi doesn't support dynamic linking, so what in the world is this library?
There was a problem hiding this comment.
weakvoid*dlopen(constchar*name, intflags)
{
error="dlopen not implemented";
returnNULL;
}
weakvoid*dlsym(void*library, constchar*name)
{
error="dlsym not implemented";
returnNULL;
}oh.
ok, well, it won't be very difficult to implement this in zig 🙄
There was a problem hiding this comment.
It is just another one of those "emulated" WASI libraries that do nothing so existing software can compile. For whatever reason it doesn't follow the usual naming pattern.
FWIW, these all strike me as silly and I wouldn't be opposed to removing them, but that'd probably be separate work.
Most notable improvements include
realpathand stubs forstatvfs,chmod, etc.Other changes are for WASI 0.2 which is going to be painful to support since 3rd party tools written in Rust may become necessary in addition to LLVM (WebAssembly/wasi-sdk#402)