`std.Target`: Assorted corrections, plus cleanup around ELF/COFF machine types by alexrp · Pull Request #21020 · ziglang/zig

alexrp · 2024-08-10T18:12:03Z

No description provided.

alexrp · 2024-08-14T06:01:09Z

Unrelated hang on aarch64-macos-debug.

…e OSs. Reference for versions: https://developer.apple.com/support/xcode

AIX does not have a stable syscall interface; libc is required.

The arc tag means ARCv2.

EM_MIPS_RS3_LE is obsolete; all mips targets just use EM_MIPS. Also, fun fact: EM_MIPS_RS3_LE is actually big endian!

…e(). All of these were mapping to types that are little endian. In fact, I can find no evidence that either Windows or UEFI have ever been used on big endian systems.

It's entirely unclear whether this should map to POWERPC or POWERPCFP, and as I can find no evidence of people producing PE files for PowerPC since Windows NT, let's just not make a likely-wrong guess. We can revisit this if the need ever actually arises.

This does the same thing as std.Target.Cpu.Arch.toCoffMachine(). Just use that.

This enables them to give more correct results. Contributes to #20771.

…ine().

andrewrk · 2024-08-16T05:13:37Z

Thanks!

alexrp · 2024-08-10T18:12:03Z

No description provided.

alexrp · 2024-08-14T06:01:09Z

Unrelated hang on aarch64-macos-debug.

…e OSs. Reference for versions: https://developer.apple.com/support/xcode

AIX does not have a stable syscall interface; libc is required.

The arc tag means ARCv2.

EM_MIPS_RS3_LE is obsolete; all mips targets just use EM_MIPS. Also, fun fact: EM_MIPS_RS3_LE is actually big endian!

…e(). All of these were mapping to types that are little endian. In fact, I can find no evidence that either Windows or UEFI have ever been used on big endian systems.

It's entirely unclear whether this should map to POWERPC or POWERPCFP, and as I can find no evidence of people producing PE files for PowerPC since Windows NT, let's just not make a likely-wrong guess. We can revisit this if the need ever actually arises.

This does the same thing as std.Target.Cpu.Arch.toCoffMachine(). Just use that.

This enables them to give more correct results. Contributes to #20771.

…ine().

andrewrk · 2024-08-16T05:13:37Z

Thanks!

alexrp · 2024-08-10T18:12:03Z

No description provided.

alexrp · 2024-08-14T06:01:09Z

Unrelated hang on aarch64-macos-debug.

…e OSs. Reference for versions: https://developer.apple.com/support/xcode

AIX does not have a stable syscall interface; libc is required.

The arc tag means ARCv2.

EM_MIPS_RS3_LE is obsolete; all mips targets just use EM_MIPS. Also, fun fact: EM_MIPS_RS3_LE is actually big endian!

…e(). All of these were mapping to types that are little endian. In fact, I can find no evidence that either Windows or UEFI have ever been used on big endian systems.

It's entirely unclear whether this should map to POWERPC or POWERPCFP, and as I can find no evidence of people producing PE files for PowerPC since Windows NT, let's just not make a likely-wrong guess. We can revisit this if the need ever actually arises.

This does the same thing as std.Target.Cpu.Arch.toCoffMachine(). Just use that.

This enables them to give more correct results. Contributes to #20771.

…ine().

andrewrk · 2024-08-16T05:13:37Z

Thanks!

alexrp · 2024-08-10T18:12:03Z

No description provided.

alexrp · 2024-08-14T06:01:09Z

Unrelated hang on aarch64-macos-debug.

…e OSs. Reference for versions: https://developer.apple.com/support/xcode

AIX does not have a stable syscall interface; libc is required.

The arc tag means ARCv2.

EM_MIPS_RS3_LE is obsolete; all mips targets just use EM_MIPS. Also, fun fact: EM_MIPS_RS3_LE is actually big endian!

…e(). All of these were mapping to types that are little endian. In fact, I can find no evidence that either Windows or UEFI have ever been used on big endian systems.

It's entirely unclear whether this should map to POWERPC or POWERPCFP, and as I can find no evidence of people producing PE files for PowerPC since Windows NT, let's just not make a likely-wrong guess. We can revisit this if the need ever actually arises.

This does the same thing as std.Target.Cpu.Arch.toCoffMachine(). Just use that.

This enables them to give more correct results. Contributes to #20771.

…ine().

andrewrk · 2024-08-16T05:13:37Z

Thanks!

alexrp · 2024-08-10T18:12:03Z

No description provided.

alexrp · 2024-08-14T06:01:09Z

Unrelated hang on aarch64-macos-debug.

…e OSs. Reference for versions: https://developer.apple.com/support/xcode

AIX does not have a stable syscall interface; libc is required.

The arc tag means ARCv2.

EM_MIPS_RS3_LE is obsolete; all mips targets just use EM_MIPS. Also, fun fact: EM_MIPS_RS3_LE is actually big endian!

…e(). All of these were mapping to types that are little endian. In fact, I can find no evidence that either Windows or UEFI have ever been used on big endian systems.

It's entirely unclear whether this should map to POWERPC or POWERPCFP, and as I can find no evidence of people producing PE files for PowerPC since Windows NT, let's just not make a likely-wrong guess. We can revisit this if the need ever actually arises.

This does the same thing as std.Target.Cpu.Arch.toCoffMachine(). Just use that.

This enables them to give more correct results. Contributes to #20771.

…ine().

andrewrk · 2024-08-16T05:13:37Z

Thanks!

alexrp · 2024-08-10T18:12:03Z

No description provided.

alexrp · 2024-08-14T06:01:09Z

Unrelated hang on aarch64-macos-debug.

…e OSs. Reference for versions: https://developer.apple.com/support/xcode

AIX does not have a stable syscall interface; libc is required.

The arc tag means ARCv2.

EM_MIPS_RS3_LE is obsolete; all mips targets just use EM_MIPS. Also, fun fact: EM_MIPS_RS3_LE is actually big endian!

…e(). All of these were mapping to types that are little endian. In fact, I can find no evidence that either Windows or UEFI have ever been used on big endian systems.

It's entirely unclear whether this should map to POWERPC or POWERPCFP, and as I can find no evidence of people producing PE files for PowerPC since Windows NT, let's just not make a likely-wrong guess. We can revisit this if the need ever actually arises.

This does the same thing as std.Target.Cpu.Arch.toCoffMachine(). Just use that.

This enables them to give more correct results. Contributes to #20771.

…ine().

andrewrk · 2024-08-16T05:13:37Z

Thanks!

alexrp · 2024-08-10T18:12:03Z

No description provided.

alexrp · 2024-08-14T06:01:09Z

Unrelated hang on aarch64-macos-debug.

…e OSs. Reference for versions: https://developer.apple.com/support/xcode

AIX does not have a stable syscall interface; libc is required.

The arc tag means ARCv2.

EM_MIPS_RS3_LE is obsolete; all mips targets just use EM_MIPS. Also, fun fact: EM_MIPS_RS3_LE is actually big endian!

…e(). All of these were mapping to types that are little endian. In fact, I can find no evidence that either Windows or UEFI have ever been used on big endian systems.

It's entirely unclear whether this should map to POWERPC or POWERPCFP, and as I can find no evidence of people producing PE files for PowerPC since Windows NT, let's just not make a likely-wrong guess. We can revisit this if the need ever actually arises.

This does the same thing as std.Target.Cpu.Arch.toCoffMachine(). Just use that.

This enables them to give more correct results. Contributes to #20771.

…ine().

andrewrk · 2024-08-16T05:13:37Z

Thanks!

alexrp · 2024-08-10T18:12:03Z

No description provided.

alexrp · 2024-08-14T06:01:09Z

Unrelated hang on aarch64-macos-debug.

…e OSs. Reference for versions: https://developer.apple.com/support/xcode

AIX does not have a stable syscall interface; libc is required.

The arc tag means ARCv2.

EM_MIPS_RS3_LE is obsolete; all mips targets just use EM_MIPS. Also, fun fact: EM_MIPS_RS3_LE is actually big endian!

…e(). All of these were mapping to types that are little endian. In fact, I can find no evidence that either Windows or UEFI have ever been used on big endian systems.

It's entirely unclear whether this should map to POWERPC or POWERPCFP, and as I can find no evidence of people producing PE files for PowerPC since Windows NT, let's just not make a likely-wrong guess. We can revisit this if the need ever actually arises.

This does the same thing as std.Target.Cpu.Arch.toCoffMachine(). Just use that.

This enables them to give more correct results. Contributes to #20771.

…ine().

andrewrk · 2024-08-16T05:13:37Z

Thanks!

alexrp mentioned this pull request Aug 13, 2024
Proposal: std.Target: Add more architecture tags. #20835
Closed

alexrp added 14 commits August 15, 2024 10:55

std.Target: Make some functions handle driverkit alongside other Appl…
0def4e0
…e OSs. Reference for versions: https://developer.apple.com/support/xcode

std.Target: Fix isGnuLibC() to handle hurd too.
fc93ab7

std.Target: Change requiresLibC() to return true for aix.
1e67221
AIX does not have a stable syscall interface; libc is required.

std.Target: Clean up Arch.toElfMachine().
9246c88

std.Target: Fix Arch.toElfMachine() for arc.
6c27cab
The arc tag means ARCv2.

std.Target: Fix Arch.toElfMachine() for mips.
490b328
EM_MIPS_RS3_LE is obsolete; all mips targets just use EM_MIPS. Also, fun fact: EM_MIPS_RS3_LE is actually big endian!

std.Target: Clean up Arch.toCoffMachine().
8516a6a

std.Target: Don't match big endian architectures in Arch.toCoffMachin…
b24fc35
…e(). All of these were mapping to types that are little endian. In fact, I can find no evidence that either Windows or UEFI have ever been used on big endian systems.

std.coff: Remove MachineType.fromTargetCpuArch().
ac9ca7d
This does the same thing as std.Target.Cpu.Arch.toCoffMachine(). Just use that.

std.coff: Capitalize MachineType.{Unknown,Thumb} for consistency.
b01c595

std.Target: Pull toCoffMachine()/toElfMachine() up from Arch to Target.
5504386
This enables them to give more correct results. Contributes to #20771.

std.Target: Return the correct value for elfiamcu in toElfMachine().
9b5c992

std.Target: Return the correct value for 32-bit sparc v9 in toElfMach…
6db9ad7
…ine().

andrewrk merged commit 05c7968 into ziglang:masterAug 16, 2024

alexrp deleted the target-fixes branch August 16, 2024 05:42

alexrp mentioned this pull request Aug 23, 2024
std.{coff,elf}: Remove the {MachineType,EM}.toTargetCpuArch() functions. #21177
Merged