Uh oh!
There was an error while loading. Please reload this page.
Faster tokenizer - #21367
Merged
Merged
Conversation
RetroDev256force-pushed
the
faster-tokenizer
branch
from
September 9, 2024 23:11
b64fdee to
8acb8ebCompareContributorAuthor
Seems like it needs a zig1.wasm update. I'll leave that to you guys. |
Contributor
Run |
andrewrk
commented
Sep 10, 2024
Member
Nice work! Looks like the LLVM backend is having trouble lowering this on wasm32-wasi. Feel free to leave that to ZSF core team, we can take it from here. |
alexrp
commented
Sep 10, 2024
Member
This needs a rebase after #21371. |
RetroDev256
commented
Sep 10, 2024
ContributorAuthor
Managed to fit in my lunch break :) |
Member
Thanks for the merge! |
Notably, contains the implementation of labeled switch expressions and decl literals.
andrewrkforce-pushed
the
faster-tokenizer
branch
from
September 10, 2024 23:15
f40808b to
0e84fedCompareandrewrk
enabled auto-merge
September 10, 2024 23:16
andrewrk
commented
Sep 10, 2024
Member
I have rebased and force-pushed the branch to your fork and set to auto-merge. If my work here looks OK, please sit tight and this will be landed soon. |
DivergentClouds pushed a commit
to DivergentClouds/zig
that referenced
this pull request
Sep 24, 2024
Update the zig tokenizer to use labeled switch statements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the zig tokenizer to use labeled switch statements :)
The benchmarks (and binary size) speaks for itself: