Uh oh!
There was an error while loading. Please reload this page.
Sema: add missing coercion to bool for condbr_inline - #21422
Merged
Conversation
mlugg
marked this pull request as draft
September 15, 2024 12:44
mlugg
commented
Sep 15, 2024
MemberAuthor
Canceled the workflow and marked PR as draft, since it can't merged until a zig1.wasm update, and it'd be silly to do one just for this. |
mlugg added a commit
to mlugg/zig
that referenced
this pull request
Oct 19, 2024
As well as being necessary for the `CallingConvention` changes, this update includes the following notable changes: * Fix unlabeled `break` targeting the wrong scope in the presence of labeled continue, unblocking ziglang#21422 * Implement `@FieldType` * Implement `@splat` on arrays Signed-off-by: mlugg <mlugg@mlugg.co.uk>
mlugg
marked this pull request as ready for review
October 27, 2024 22:18
Also, start using labeled switch statements when dispatching maybe-runtime instructions like condbr to comptime-only variants like condbr_inline. This can't be merged until we get a zig1.wasm update due to ziglang#21385. Resolves: ziglang#21405
mluggforce-pushed
the
condbr-inline-sema-loop
branch
from
October 27, 2024 22:18
b80262a to
27ac46aComparemlugg
enabled auto-merge (rebase)
October 27, 2024 22:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, start using labeled switch statements when dispatching maybe-runtime instructions like condbr to comptime-only variants like condbr_inline.
This can't be merged until we get a zig1.wasm update due to #21385.
Resolves: #21405