Uh oh!
There was an error while loading. Please reload this page.
std.zig.system: use both PATH and hardcoded locations to find env - #21540
Merged
Conversation
alexrp
commented
Oct 5, 2024
Member
This has a merge conflict that looks to stem from #21430. |
BratishkaErikforce-pushed
the
search-env-in-path
branch
from
October 5, 2024 08:23
a28605c to
914de5fCompareBratishkaErik
commented
Oct 5, 2024
ContributorAuthor
Thanks, fixed :) |
BratishkaErikforce-pushed
the
search-env-in-path
branch
from
November 3, 2024 10:22
914de5f to
12c2773CompareBratishkaErikforce-pushed
the
search-env-in-path
branch
from
December 25, 2024 15:11
12c2773 to
fa1e05cCompareSigned-off-by: Eric Joldasov <bratishkaerik@landless-city.net>
Should help systems that have main `env` binary in different location than hardcoded `/usr/bin/env` **during build** (not neccessarily always), like Nix/Guix, Termux, Gentoo Prefix etc. Related: https://www.github.com/ziglang/zig/issues/12156https://www.github.com/ziglang/zig/issues/14146https://www.github.com/ziglang/zig/issues/14577https://www.github.com/ziglang/zig/issues/15898 Source for logic: https://www.github.com/ziglang/zig/issues/14146#issuecomment-2308984936 Signed-off-by: Eric Joldasov <bratishkaerik@landless-city.net>
BratishkaErikforce-pushed
the
search-env-in-path
branch
from
January 20, 2025 09:29
fa1e05c to
a79e421Compareandrewrk
commented
Jan 21, 2025
Member
Thanks. |
Closed
andrewrk
commented
Jan 21, 2025
Member
Reverted in 0bacb79 |
Fri3dNstuff pushed a commit
to Fri3dNstuff/zig
that referenced
this pull request
Jan 27, 2025
…v-in-path" It caused an assertion failure when building Zig from source. This reverts commit 0595feb, reversing changes made to 744771d. closesziglang#22566closesziglang#22568
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should help systems that have main
envbinary in different location than hardcoded/usr/bin/envduring build (not neccessarily always), like Nix/Guix, Termux, Gentoo Prefix etc.Theoretically should close following issues, but it needs more testing from affected users:
#12156
#14146
#14577
#15898
Source for logic: #14146 (comment)