Uh oh!
There was an error while loading. Please reload this page.
@memcpy: Don't check for aliasing if the type being copied has a bitSize of in 0 - #21658
@memcpy: Don't check for aliasing if the type being copied has a bitSize of in 0 #21658JonathanHallstrom wants to merge 2 commits into
Conversation
Rexicon226
left a comment
There was a problem hiding this comment.
I'm unsure if this is an issue that needs fixing. @memcpying requires memory to be involved, and ZSTs do not have any memory representation neither comptime nor runtime. Just my 2c.
Uh oh!
There was an error while loading. Please reload this page.
The issue is #21655 , where correct code for a generic data structure in status-quo would need special-casing. |
Rexicon226
commented
Oct 10, 2024
Gotcha thanks, didn't see that. |
JonathanHallstrom
commented
Oct 11, 2024
Seem CI is still failing, maybe not emitting anything in the case of zero bit types will fix it? |
JonathanHallstrom
commented
Oct 11, 2024
This way of implementing it feels a little bit sketchy, maybe it should just be an early return? |
Uh oh!
There was an error while loading. Please reload this page.
JonathanHallstrom
commented
Nov 1, 2024
i seem to have messed something up in git |
f5eb38e to
595c146Comparemlugg
commented
Jan 26, 2025
This isn't quite safe due to some edge cases with comptime-only types. I'm going to wait until myself and @alexrp finish our discussion with Andrew on |
alexrp
commented
Jan 29, 2025
mlugg
commented
Jan 29, 2025
Oops, I forgot to implement this into #22631. I'll look into this shortly. |
mlugg
commented
Feb 1, 2025
Superseded by #22708. |
Should close#21655
Unable to verify myself due to issues with building zig locally