lib/std/os/uefi/protocol/file.zig: change io adapter fns to const ptr

[dotcarmen]

The rest of the methods in this type expect a *const File, and the type definitions even specify *const File. It's also only possible to construct a *const File ie

constuefi=@import("std").uefi;
constfs=tryboot_services.openProtocolSt(uefi.protocol.SimpleFileSystem, uefi.handle);
varvol: *constuefi.protocol.File=undefined;
tryfs.openVolume(&vol).err();

where fs.openVolume expects a **const File. As such, calling vol.reader() results in a type error, since a *const File can't be downcasted to *File

[dotcarmen]

tbh, the rest of the API could use some consistency 😅 for example BlockIo's methods use *BlockIo instead of *const BlockIo. I can follow-up this pr with additional corrections if desired

[linusg]

The rest of the methods in this type expect a *const File

I believe all of these are incorrect - even though it's fine to treat self as a const pointer from the Zig compiler's perspective, this only works because the UEFI API function pointers are also (incorrectly) typed this way - they definitely get mutated in the underlying implementation (seek offset for instance). Being able to read and write from a *const File is nonsense, so I'd rather not paper over it like this.

[dotcarmen]

ack - i'll invert the PR to use *File as appropriate then.

I figured this File type is more akin to a FD than file handle, where ie seek data is held elsewhere in memory, but I agree with you that doesn't really excuse the immutable requirement.

[linusg]

This Rust UEFI wrapper is probably the closest thing we'll find to std.os.uefi, it also uses mutable self: https://github.com/rust-osdev/uefi-rs/blob/main/uefi/src/proto/media/file/mod.rs

[dotcarmen]

i'm now working on #23214, can you check it out and let me know if i'm doing things right or wrong?

[dotcarmen]

The rest of the methods in this type expect a *const File, and the type definitions even specify *const File. It's also only possible to construct a *const File ie

constuefi=@import("std").uefi;
constfs=tryboot_services.openProtocolSt(uefi.protocol.SimpleFileSystem, uefi.handle);
varvol: *constuefi.protocol.File=undefined;
tryfs.openVolume(&vol).err();

where fs.openVolume expects a **const File. As such, calling vol.reader() results in a type error, since a *const File can't be downcasted to *File

[dotcarmen]

tbh, the rest of the API could use some consistency 😅 for example BlockIo's methods use *BlockIo instead of *const BlockIo. I can follow-up this pr with additional corrections if desired

[linusg]

The rest of the methods in this type expect a *const File

I believe all of these are incorrect - even though it's fine to treat self as a const pointer from the Zig compiler's perspective, this only works because the UEFI API function pointers are also (incorrectly) typed this way - they definitely get mutated in the underlying implementation (seek offset for instance). Being able to read and write from a *const File is nonsense, so I'd rather not paper over it like this.

[dotcarmen]

ack - i'll invert the PR to use *File as appropriate then.

I figured this File type is more akin to a FD than file handle, where ie seek data is held elsewhere in memory, but I agree with you that doesn't really excuse the immutable requirement.

[linusg]

This Rust UEFI wrapper is probably the closest thing we'll find to std.os.uefi, it also uses mutable self: https://github.com/rust-osdev/uefi-rs/blob/main/uefi/src/proto/media/file/mod.rs

[dotcarmen]

i'm now working on #23214, can you check it out and let me know if i'm doing things right or wrong?

[dotcarmen]

The rest of the methods in this type expect a *const File, and the type definitions even specify *const File. It's also only possible to construct a *const File ie

constuefi=@import("std").uefi;
constfs=tryboot_services.openProtocolSt(uefi.protocol.SimpleFileSystem, uefi.handle);
varvol: *constuefi.protocol.File=undefined;
tryfs.openVolume(&vol).err();

where fs.openVolume expects a **const File. As such, calling vol.reader() results in a type error, since a *const File can't be downcasted to *File

[dotcarmen]

tbh, the rest of the API could use some consistency 😅 for example BlockIo's methods use *BlockIo instead of *const BlockIo. I can follow-up this pr with additional corrections if desired

[linusg]

The rest of the methods in this type expect a *const File

I believe all of these are incorrect - even though it's fine to treat self as a const pointer from the Zig compiler's perspective, this only works because the UEFI API function pointers are also (incorrectly) typed this way - they definitely get mutated in the underlying implementation (seek offset for instance). Being able to read and write from a *const File is nonsense, so I'd rather not paper over it like this.

[dotcarmen]

ack - i'll invert the PR to use *File as appropriate then.

I figured this File type is more akin to a FD than file handle, where ie seek data is held elsewhere in memory, but I agree with you that doesn't really excuse the immutable requirement.

[linusg]

This Rust UEFI wrapper is probably the closest thing we'll find to std.os.uefi, it also uses mutable self: https://github.com/rust-osdev/uefi-rs/blob/main/uefi/src/proto/media/file/mod.rs

[dotcarmen]

i'm now working on #23214, can you check it out and let me know if i'm doing things right or wrong?

[dotcarmen]

The rest of the methods in this type expect a *const File, and the type definitions even specify *const File. It's also only possible to construct a *const File ie

constuefi=@import("std").uefi;
constfs=tryboot_services.openProtocolSt(uefi.protocol.SimpleFileSystem, uefi.handle);
varvol: *constuefi.protocol.File=undefined;
tryfs.openVolume(&vol).err();

where fs.openVolume expects a **const File. As such, calling vol.reader() results in a type error, since a *const File can't be downcasted to *File

[dotcarmen]

tbh, the rest of the API could use some consistency 😅 for example BlockIo's methods use *BlockIo instead of *const BlockIo. I can follow-up this pr with additional corrections if desired

[linusg]

The rest of the methods in this type expect a *const File

I believe all of these are incorrect - even though it's fine to treat self as a const pointer from the Zig compiler's perspective, this only works because the UEFI API function pointers are also (incorrectly) typed this way - they definitely get mutated in the underlying implementation (seek offset for instance). Being able to read and write from a *const File is nonsense, so I'd rather not paper over it like this.

[dotcarmen]

ack - i'll invert the PR to use *File as appropriate then.

I figured this File type is more akin to a FD than file handle, where ie seek data is held elsewhere in memory, but I agree with you that doesn't really excuse the immutable requirement.

[linusg]

This Rust UEFI wrapper is probably the closest thing we'll find to std.os.uefi, it also uses mutable self: https://github.com/rust-osdev/uefi-rs/blob/main/uefi/src/proto/media/file/mod.rs

[dotcarmen]

i'm now working on #23214, can you check it out and let me know if i'm doing things right or wrong?

[dotcarmen]

The rest of the methods in this type expect a *const File, and the type definitions even specify *const File. It's also only possible to construct a *const File ie

constuefi=@import("std").uefi;
constfs=tryboot_services.openProtocolSt(uefi.protocol.SimpleFileSystem, uefi.handle);
varvol: *constuefi.protocol.File=undefined;
tryfs.openVolume(&vol).err();

where fs.openVolume expects a **const File. As such, calling vol.reader() results in a type error, since a *const File can't be downcasted to *File

[dotcarmen]

tbh, the rest of the API could use some consistency 😅 for example BlockIo's methods use *BlockIo instead of *const BlockIo. I can follow-up this pr with additional corrections if desired

[linusg]

The rest of the methods in this type expect a *const File

I believe all of these are incorrect - even though it's fine to treat self as a const pointer from the Zig compiler's perspective, this only works because the UEFI API function pointers are also (incorrectly) typed this way - they definitely get mutated in the underlying implementation (seek offset for instance). Being able to read and write from a *const File is nonsense, so I'd rather not paper over it like this.

[dotcarmen]

ack - i'll invert the PR to use *File as appropriate then.

I figured this File type is more akin to a FD than file handle, where ie seek data is held elsewhere in memory, but I agree with you that doesn't really excuse the immutable requirement.

[linusg]

This Rust UEFI wrapper is probably the closest thing we'll find to std.os.uefi, it also uses mutable self: https://github.com/rust-osdev/uefi-rs/blob/main/uefi/src/proto/media/file/mod.rs

[dotcarmen]

i'm now working on #23214, can you check it out and let me know if i'm doing things right or wrong?

[dotcarmen]

The rest of the methods in this type expect a *const File, and the type definitions even specify *const File. It's also only possible to construct a *const File ie

constuefi=@import("std").uefi;
constfs=tryboot_services.openProtocolSt(uefi.protocol.SimpleFileSystem, uefi.handle);
varvol: *constuefi.protocol.File=undefined;
tryfs.openVolume(&vol).err();

where fs.openVolume expects a **const File. As such, calling vol.reader() results in a type error, since a *const File can't be downcasted to *File

[dotcarmen]

tbh, the rest of the API could use some consistency 😅 for example BlockIo's methods use *BlockIo instead of *const BlockIo. I can follow-up this pr with additional corrections if desired

[linusg]

The rest of the methods in this type expect a *const File

I believe all of these are incorrect - even though it's fine to treat self as a const pointer from the Zig compiler's perspective, this only works because the UEFI API function pointers are also (incorrectly) typed this way - they definitely get mutated in the underlying implementation (seek offset for instance). Being able to read and write from a *const File is nonsense, so I'd rather not paper over it like this.

[dotcarmen]

ack - i'll invert the PR to use *File as appropriate then.

I figured this File type is more akin to a FD than file handle, where ie seek data is held elsewhere in memory, but I agree with you that doesn't really excuse the immutable requirement.

[linusg]

This Rust UEFI wrapper is probably the closest thing we'll find to std.os.uefi, it also uses mutable self: https://github.com/rust-osdev/uefi-rs/blob/main/uefi/src/proto/media/file/mod.rs

[dotcarmen]

i'm now working on #23214, can you check it out and let me know if i'm doing things right or wrong?

[dotcarmen]

The rest of the methods in this type expect a *const File, and the type definitions even specify *const File. It's also only possible to construct a *const File ie

constuefi=@import("std").uefi;
constfs=tryboot_services.openProtocolSt(uefi.protocol.SimpleFileSystem, uefi.handle);
varvol: *constuefi.protocol.File=undefined;
tryfs.openVolume(&vol).err();

where fs.openVolume expects a **const File. As such, calling vol.reader() results in a type error, since a *const File can't be downcasted to *File

[dotcarmen]

tbh, the rest of the API could use some consistency 😅 for example BlockIo's methods use *BlockIo instead of *const BlockIo. I can follow-up this pr with additional corrections if desired

[linusg]

The rest of the methods in this type expect a *const File

I believe all of these are incorrect - even though it's fine to treat self as a const pointer from the Zig compiler's perspective, this only works because the UEFI API function pointers are also (incorrectly) typed this way - they definitely get mutated in the underlying implementation (seek offset for instance). Being able to read and write from a *const File is nonsense, so I'd rather not paper over it like this.

[dotcarmen]

ack - i'll invert the PR to use *File as appropriate then.

I figured this File type is more akin to a FD than file handle, where ie seek data is held elsewhere in memory, but I agree with you that doesn't really excuse the immutable requirement.

[linusg]

This Rust UEFI wrapper is probably the closest thing we'll find to std.os.uefi, it also uses mutable self: https://github.com/rust-osdev/uefi-rs/blob/main/uefi/src/proto/media/file/mod.rs

[dotcarmen]

i'm now working on #23214, can you check it out and let me know if i'm doing things right or wrong?