Uh oh!
There was an error while loading. Please reload this page.
std.os.uefi.protocol.HiiDatabase: manage .buffer_too_small statuses - #23444
Closed
dotcarmen wants to merge 3 commits into
Closed
std.os.uefi.protocol.HiiDatabase: manage .buffer_too_small statuses#23444dotcarmen wants to merge 3 commits into
dotcarmen wants to merge 3 commits into
Conversation
dotcarmen
commented
Apr 2, 2025
ContributorAuthor
@linusg :) |
dotcarmenforce-pushed
the
uefi-hii-db-buffers
branch
from
April 2, 2025 21:48
d0f89de to
341f491Comparedotcarmen
commented
Apr 2, 2025
ContributorAuthor
nevermind, hii_database is generally broken (it appears to me exportPackageLists is just generally wrong) and i'd rather fix it in the same pr as the rest of the implementation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
similar to #23443, there's some problems with
HiiDatabase.listPackageListsandHiiDatabase.exportPackageLists, in that they may return.buffer_too_smallif thebuffer_lenargument is too small to safely return all data.this PR changes these functions to return a tuplestruct { usize, ?ReturnType }whereReturnTypeis the buffer written by the function.this PR adds helper functions to determine the size of the buffers needed for these functions to succeed.