Skip to content

std.process.Child: fix double path normalization in spawnWindows - #24562

Merged
alexrp merged 2 commits into
ziglang:masterfrom
h57624paen:fix-win-spawn-double-normalize
Aug 3, 2025
Merged

std.process.Child: fix double path normalization in spawnWindows#24562
alexrp merged 2 commits into
ziglang:masterfrom
h57624paen:fix-win-spawn-double-normalize

Conversation

@h57624paen

@h57624paenh57624paen commented Jul 24, 2025

Copy link
Copy Markdown
Contributor

besides simply being redundant work, the now removed normalize call would cause spawn to errantly fail (BadPath) when passing a relative path which traversed 'above' the current working directory. This case is already handled by leaving normalization to the windows.wToPrefixedFileW call in windowsCreateProcessPathExt

squeek502
squeek502 reviewed Jul 24, 2025
View reviewed changes
Comment threadlib/std/process/Child.zig Outdated
squeek502
squeek502 reviewed Jul 24, 2025
View reviewed changes
Comment threadlib/std/process/Child.zig Outdated
squeek502
squeek502 reviewed Jul 24, 2025
View reviewed changes
Comment threadlib/std/process/Child.zig
@h57624paen
h57624paenforce-pushed the fix-win-spawn-double-normalize branch from be3c8b3 to 6019633CompareJuly 25, 2025 05:27
h57624paen
h57624paen commented Jul 25, 2025
View reviewed changes
Comment threadtest/standalone/child_process/main.zig Outdated
squeek502
squeek502 reviewed Jul 25, 2025
View reviewed changes
Comment threadtest/standalone/windows_spawn/main.zig
squeek502
squeek502 reviewed Jul 25, 2025
View reviewed changes
Comment threadtest/standalone/child_process/main.zig Outdated
squeek502
squeek502 reviewed Jul 25, 2025
View reviewed changes
Comment threadtest/standalone/windows_spawn/main.zig Outdated
squeek502
squeek502 reviewed Jul 25, 2025
View reviewed changes
Comment threadtest/standalone/windows_spawn/main.zig Outdated
h57624paenand others added 2 commits July 26, 2025 01:34
@h57624paen
std.process.Child: fix double path normalization in spawnWindows
afa66f6
besides simply being redundant work, the now removed normalize call would cause
spawn to errantly fail (BadPath) when passing a relative path which traversed
'above' the current working directory. This case is already handled by leaving
normalization to the windows.wToPrefixedFileW call in
windowsCreateProcessPathExt
@squeek502@h57624paen
child_process standalone test: Test spawning a path with leading ..
0f41063
Also check that FileNotFound is consistently returned when the path is missing.
The new `run_relative` step will test spawning paths like:
child_path: ../84385e7e669db0967d7a42765011dbe0/child
missing_child_path: ../84385e7e669db0967d7a42765011dbe0/child_intentionally_missing
@h57624paen
h57624paenforce-pushed the fix-win-spawn-double-normalize branch from 6019633 to 0f41063CompareJuly 26, 2025 05:38
squeek502
squeek502 approved these changes Jul 26, 2025
View reviewed changes

@squeek502squeek502 left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

For context to those reviewing, the normalizePath calls that are being removed were an artifact of the Windows ChildProcess rework in #13993 coming before #15768 which made the normalizePath calls obsolete.

This PR removes the obsolete normalization and adds tests to check that behavior didn't regress.

@alexrp
alexrp merged commit a5f891d into ziglang:masterAug 3, 2025
10 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@squeek502squeek502squeek502 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@h57624paen@squeek502@alexrp