Uh oh!
There was an error while loading. Please reload this page.
std.Io: delete GenericWriter, AnyWriter, and null_writer - #25036
Merged
Conversation
squeek502
commented
Aug 27, 2025
Member
I'll work on updating |
andrewrkforce-pushed
the
GenericWriter
branch
4 times, most recently
from
August 28, 2025 20:55
54f711d to
7f0e17dCompareThese are some hastily made, untested changes to get things compiling again, since Ryan is working on a better upgrade patchset in the meantime.
perhaps these APIs have the defaults backwards, eh?
tracked by #25067 and I already have a fix cooking in another branch
I didn't notice the check+swap before.
There was some bug in this branch, and rather than diagnosing it, I fully finished porting over to new Reader API. Did it fix the bug?
andrewrk
enabled auto-merge
August 29, 2025 08:37
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Aug 29, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up from #24329.
Also delete some delimiter methods from GenericReader.
These things were all deprecated in favor of the new concrete Reader and Writer APIs.