Uh oh!
There was an error while loading. Please reload this page.
implement #1107 - #2799
Merged
Merged
Conversation
added error for switch prong with different payloads and support for capturing payload on switch prongs with payloads of the same type
ContributorAuthor
this would introduce an error for capture groups on diff --git a/src/ir.cpp b/src/ir.cpp
index d4cb5f90..ad788e9f 100644
--- a/src/ir.cpp+++ b/src/ir.cpp@@ -19311,6 +19311,9 @@ static IrInstruction *ir_analyze_instruction_switch_else_var(IrAnalyze *ira,
ref_type->data.pointer.allow_zero);
return ir_analyze_ptr_cast(ira, &instruction->base, target_value_ptr, new_target_value_ptr_type,
&instruction->base, false);
+ } else if (target_type->id == ZigTypeIdUnion) {+ ir_add_error(ira, &instruction->base, buf_create_from_str("capture group not allowed on else prong"));+ return ira->codegen->invalid_instruction;
}
return target_value_ptr;
|
emekoi
marked this pull request as ready for review
July 1, 2019 07:34
andrewrk
commented
Jul 2, 2019
Member
Can you add a new behavioral test? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this closes#1107.