std.os read/write functions + sendfile by andrewrk · Pull Request #4612 · ziglang/zig

andrewrk · 2020-03-03T07:57:55Z

This merges #4131 and then does the following:

rework os.sendfile and add macosx support, and a fallback
implementation for any OS.
fix sendto compile error
std.os write functions support partial writes. closesstd.os.writev does not handle partial writes #3443.
std.os pread / pwrite functions can now return error.Unseekable.
std.fs.File read/write functions now have readAll/writeAll variants
which loop to complete operations even when partial reads/writes
happen.
Audit std.os read/write functions with respect to Linux returning
EINVAL for lengths greater than 0x7fff0000.
std.os read/write shim functions do not unnecessarily loop. Since
partial reads/writes are part of the API, the caller will be forced
to loop anyway, and so that would just be code bloat.
Improve doc comments
Add a non-trivial test for std.os.sendfile
Fix std.os.pread on 32 bit Linux
Add missing SYS_sendfile bit on aarch64

This changset adds a `sendfile(2)` syscall bindings to the linux bits component. Where available, the `sendfile64(2)` syscall will be transparently called. A wrapping function has also been added to the std.os to transform errno returns to Zig errors. Change-Id: I86769fc4382c0771e3656e7b21137bafd99a4411

* rework os.sendfile and add macosx support, and a fallback implementation for any OS. * fix sendto compile error * std.os write functions support partial writes. closes#3443. * std.os pread / pwrite functions can now return `error.Unseekable`. * std.fs.File read/write functions now have readAll/writeAll variants which loop to complete operations even when partial reads/writes happen. * Audit std.os read/write functions with respect to Linux returning EINVAL for lengths greater than 0x7fff0000. * std.os read/write shim functions do not unnecessarily loop. Since partial reads/writes are part of the API, the caller will be forced to loop anyway, and so that would just be code bloat. * Improve doc comments * Add a non-trivial test for std.os.sendfile * Fix std.os.pread on 32 bit Linux * Add missing SYS_sendfile bit on aarch64

shawnl · 2020-03-03T08:07:31Z

What about copy_file_range(2) ?

andrewrk · 2020-03-03T08:12:10Z

What about copy_file_range(2) ?

That will be a nice separate enhancement

daurnimator · 2020-03-03T08:40:00Z


 else => {
-_ = unexpectedErrno(err);
+const discard = unexpectedErrno(err);


Why does this need an assignment?

because it's an error

hrm. why don't we support discarding error values (not error unions) via assignment to _?

daurnimator · 2020-03-06T13:02:48Z

FYI this broke zig hello world examples all over the place as file.write now returns a !usize rather than a !void. Although streams got writeOnce+write, files didn't.

EvanCarroll · 2023-09-18T21:46:53Z

Shouldn't this optimization also exist on fifo.pump?

andrewrk · 2020-03-03T07:57:55Z

This merges #4131 and then does the following:

rework os.sendfile and add macosx support, and a fallback
implementation for any OS.
fix sendto compile error
std.os write functions support partial writes. closesstd.os.writev does not handle partial writes #3443.
std.os pread / pwrite functions can now return error.Unseekable.
std.fs.File read/write functions now have readAll/writeAll variants
which loop to complete operations even when partial reads/writes
happen.
Audit std.os read/write functions with respect to Linux returning
EINVAL for lengths greater than 0x7fff0000.
std.os read/write shim functions do not unnecessarily loop. Since
partial reads/writes are part of the API, the caller will be forced
to loop anyway, and so that would just be code bloat.
Improve doc comments
Add a non-trivial test for std.os.sendfile
Fix std.os.pread on 32 bit Linux
Add missing SYS_sendfile bit on aarch64

This changset adds a `sendfile(2)` syscall bindings to the linux bits component. Where available, the `sendfile64(2)` syscall will be transparently called. A wrapping function has also been added to the std.os to transform errno returns to Zig errors. Change-Id: I86769fc4382c0771e3656e7b21137bafd99a4411

* rework os.sendfile and add macosx support, and a fallback implementation for any OS. * fix sendto compile error * std.os write functions support partial writes. closes#3443. * std.os pread / pwrite functions can now return `error.Unseekable`. * std.fs.File read/write functions now have readAll/writeAll variants which loop to complete operations even when partial reads/writes happen. * Audit std.os read/write functions with respect to Linux returning EINVAL for lengths greater than 0x7fff0000. * std.os read/write shim functions do not unnecessarily loop. Since partial reads/writes are part of the API, the caller will be forced to loop anyway, and so that would just be code bloat. * Improve doc comments * Add a non-trivial test for std.os.sendfile * Fix std.os.pread on 32 bit Linux * Add missing SYS_sendfile bit on aarch64

shawnl · 2020-03-03T08:07:31Z

What about copy_file_range(2) ?

andrewrk · 2020-03-03T08:12:10Z

What about copy_file_range(2) ?

That will be a nice separate enhancement

daurnimator · 2020-03-03T08:40:00Z


 else => {
-_ = unexpectedErrno(err);
+const discard = unexpectedErrno(err);


Why does this need an assignment?

because it's an error

hrm. why don't we support discarding error values (not error unions) via assignment to _?

daurnimator · 2020-03-06T13:02:48Z

FYI this broke zig hello world examples all over the place as file.write now returns a !usize rather than a !void. Although streams got writeOnce+write, files didn't.

EvanCarroll · 2023-09-18T21:46:53Z

Shouldn't this optimization also exist on fifo.pump?

andrewrk · 2020-03-03T07:57:55Z

This merges #4131 and then does the following:

rework os.sendfile and add macosx support, and a fallback
implementation for any OS.
fix sendto compile error
std.os write functions support partial writes. closesstd.os.writev does not handle partial writes #3443.
std.os pread / pwrite functions can now return error.Unseekable.
std.fs.File read/write functions now have readAll/writeAll variants
which loop to complete operations even when partial reads/writes
happen.
Audit std.os read/write functions with respect to Linux returning
EINVAL for lengths greater than 0x7fff0000.
std.os read/write shim functions do not unnecessarily loop. Since
partial reads/writes are part of the API, the caller will be forced
to loop anyway, and so that would just be code bloat.
Improve doc comments
Add a non-trivial test for std.os.sendfile
Fix std.os.pread on 32 bit Linux
Add missing SYS_sendfile bit on aarch64

This changset adds a `sendfile(2)` syscall bindings to the linux bits component. Where available, the `sendfile64(2)` syscall will be transparently called. A wrapping function has also been added to the std.os to transform errno returns to Zig errors. Change-Id: I86769fc4382c0771e3656e7b21137bafd99a4411

* rework os.sendfile and add macosx support, and a fallback implementation for any OS. * fix sendto compile error * std.os write functions support partial writes. closes#3443. * std.os pread / pwrite functions can now return `error.Unseekable`. * std.fs.File read/write functions now have readAll/writeAll variants which loop to complete operations even when partial reads/writes happen. * Audit std.os read/write functions with respect to Linux returning EINVAL for lengths greater than 0x7fff0000. * std.os read/write shim functions do not unnecessarily loop. Since partial reads/writes are part of the API, the caller will be forced to loop anyway, and so that would just be code bloat. * Improve doc comments * Add a non-trivial test for std.os.sendfile * Fix std.os.pread on 32 bit Linux * Add missing SYS_sendfile bit on aarch64

shawnl · 2020-03-03T08:07:31Z

What about copy_file_range(2) ?

andrewrk · 2020-03-03T08:12:10Z

What about copy_file_range(2) ?

That will be a nice separate enhancement

daurnimator · 2020-03-03T08:40:00Z


 else => {
-_ = unexpectedErrno(err);
+const discard = unexpectedErrno(err);


Why does this need an assignment?

because it's an error

hrm. why don't we support discarding error values (not error unions) via assignment to _?

daurnimator · 2020-03-06T13:02:48Z

FYI this broke zig hello world examples all over the place as file.write now returns a !usize rather than a !void. Although streams got writeOnce+write, files didn't.

EvanCarroll · 2023-09-18T21:46:53Z

Shouldn't this optimization also exist on fifo.pump?

andrewrk · 2020-03-03T07:57:55Z

This merges #4131 and then does the following:

rework os.sendfile and add macosx support, and a fallback
implementation for any OS.
fix sendto compile error
std.os write functions support partial writes. closesstd.os.writev does not handle partial writes #3443.
std.os pread / pwrite functions can now return error.Unseekable.
std.fs.File read/write functions now have readAll/writeAll variants
which loop to complete operations even when partial reads/writes
happen.
Audit std.os read/write functions with respect to Linux returning
EINVAL for lengths greater than 0x7fff0000.
std.os read/write shim functions do not unnecessarily loop. Since
partial reads/writes are part of the API, the caller will be forced
to loop anyway, and so that would just be code bloat.
Improve doc comments
Add a non-trivial test for std.os.sendfile
Fix std.os.pread on 32 bit Linux
Add missing SYS_sendfile bit on aarch64

This changset adds a `sendfile(2)` syscall bindings to the linux bits component. Where available, the `sendfile64(2)` syscall will be transparently called. A wrapping function has also been added to the std.os to transform errno returns to Zig errors. Change-Id: I86769fc4382c0771e3656e7b21137bafd99a4411

* rework os.sendfile and add macosx support, and a fallback implementation for any OS. * fix sendto compile error * std.os write functions support partial writes. closes#3443. * std.os pread / pwrite functions can now return `error.Unseekable`. * std.fs.File read/write functions now have readAll/writeAll variants which loop to complete operations even when partial reads/writes happen. * Audit std.os read/write functions with respect to Linux returning EINVAL for lengths greater than 0x7fff0000. * std.os read/write shim functions do not unnecessarily loop. Since partial reads/writes are part of the API, the caller will be forced to loop anyway, and so that would just be code bloat. * Improve doc comments * Add a non-trivial test for std.os.sendfile * Fix std.os.pread on 32 bit Linux * Add missing SYS_sendfile bit on aarch64

shawnl · 2020-03-03T08:07:31Z

What about copy_file_range(2) ?

andrewrk · 2020-03-03T08:12:10Z

What about copy_file_range(2) ?

That will be a nice separate enhancement

daurnimator · 2020-03-03T08:40:00Z


 else => {
-_ = unexpectedErrno(err);
+const discard = unexpectedErrno(err);


Why does this need an assignment?

because it's an error

hrm. why don't we support discarding error values (not error unions) via assignment to _?

daurnimator · 2020-03-06T13:02:48Z

FYI this broke zig hello world examples all over the place as file.write now returns a !usize rather than a !void. Although streams got writeOnce+write, files didn't.

EvanCarroll · 2023-09-18T21:46:53Z

Shouldn't this optimization also exist on fifo.pump?

andrewrk · 2020-03-03T07:57:55Z

This merges #4131 and then does the following:

rework os.sendfile and add macosx support, and a fallback
implementation for any OS.
fix sendto compile error
std.os write functions support partial writes. closesstd.os.writev does not handle partial writes #3443.
std.os pread / pwrite functions can now return error.Unseekable.
std.fs.File read/write functions now have readAll/writeAll variants
which loop to complete operations even when partial reads/writes
happen.
Audit std.os read/write functions with respect to Linux returning
EINVAL for lengths greater than 0x7fff0000.
std.os read/write shim functions do not unnecessarily loop. Since
partial reads/writes are part of the API, the caller will be forced
to loop anyway, and so that would just be code bloat.
Improve doc comments
Add a non-trivial test for std.os.sendfile
Fix std.os.pread on 32 bit Linux
Add missing SYS_sendfile bit on aarch64

This changset adds a `sendfile(2)` syscall bindings to the linux bits component. Where available, the `sendfile64(2)` syscall will be transparently called. A wrapping function has also been added to the std.os to transform errno returns to Zig errors. Change-Id: I86769fc4382c0771e3656e7b21137bafd99a4411

* rework os.sendfile and add macosx support, and a fallback implementation for any OS. * fix sendto compile error * std.os write functions support partial writes. closes#3443. * std.os pread / pwrite functions can now return `error.Unseekable`. * std.fs.File read/write functions now have readAll/writeAll variants which loop to complete operations even when partial reads/writes happen. * Audit std.os read/write functions with respect to Linux returning EINVAL for lengths greater than 0x7fff0000. * std.os read/write shim functions do not unnecessarily loop. Since partial reads/writes are part of the API, the caller will be forced to loop anyway, and so that would just be code bloat. * Improve doc comments * Add a non-trivial test for std.os.sendfile * Fix std.os.pread on 32 bit Linux * Add missing SYS_sendfile bit on aarch64

shawnl · 2020-03-03T08:07:31Z

What about copy_file_range(2) ?

andrewrk · 2020-03-03T08:12:10Z

What about copy_file_range(2) ?

That will be a nice separate enhancement

daurnimator · 2020-03-03T08:40:00Z


 else => {
-_ = unexpectedErrno(err);
+const discard = unexpectedErrno(err);


Why does this need an assignment?

because it's an error

hrm. why don't we support discarding error values (not error unions) via assignment to _?

daurnimator · 2020-03-06T13:02:48Z

FYI this broke zig hello world examples all over the place as file.write now returns a !usize rather than a !void. Although streams got writeOnce+write, files didn't.

EvanCarroll · 2023-09-18T21:46:53Z

Shouldn't this optimization also exist on fifo.pump?

andrewrk · 2020-03-03T07:57:55Z

This merges #4131 and then does the following:

rework os.sendfile and add macosx support, and a fallback
implementation for any OS.
fix sendto compile error
std.os write functions support partial writes. closesstd.os.writev does not handle partial writes #3443.
std.os pread / pwrite functions can now return error.Unseekable.
std.fs.File read/write functions now have readAll/writeAll variants
which loop to complete operations even when partial reads/writes
happen.
Audit std.os read/write functions with respect to Linux returning
EINVAL for lengths greater than 0x7fff0000.
std.os read/write shim functions do not unnecessarily loop. Since
partial reads/writes are part of the API, the caller will be forced
to loop anyway, and so that would just be code bloat.
Improve doc comments
Add a non-trivial test for std.os.sendfile
Fix std.os.pread on 32 bit Linux
Add missing SYS_sendfile bit on aarch64

This changset adds a `sendfile(2)` syscall bindings to the linux bits component. Where available, the `sendfile64(2)` syscall will be transparently called. A wrapping function has also been added to the std.os to transform errno returns to Zig errors. Change-Id: I86769fc4382c0771e3656e7b21137bafd99a4411

* rework os.sendfile and add macosx support, and a fallback implementation for any OS. * fix sendto compile error * std.os write functions support partial writes. closes#3443. * std.os pread / pwrite functions can now return `error.Unseekable`. * std.fs.File read/write functions now have readAll/writeAll variants which loop to complete operations even when partial reads/writes happen. * Audit std.os read/write functions with respect to Linux returning EINVAL for lengths greater than 0x7fff0000. * std.os read/write shim functions do not unnecessarily loop. Since partial reads/writes are part of the API, the caller will be forced to loop anyway, and so that would just be code bloat. * Improve doc comments * Add a non-trivial test for std.os.sendfile * Fix std.os.pread on 32 bit Linux * Add missing SYS_sendfile bit on aarch64

shawnl · 2020-03-03T08:07:31Z

What about copy_file_range(2) ?

andrewrk · 2020-03-03T08:12:10Z

What about copy_file_range(2) ?

That will be a nice separate enhancement

daurnimator · 2020-03-03T08:40:00Z


 else => {
-_ = unexpectedErrno(err);
+const discard = unexpectedErrno(err);


Why does this need an assignment?

because it's an error

hrm. why don't we support discarding error values (not error unions) via assignment to _?

daurnimator · 2020-03-06T13:02:48Z

FYI this broke zig hello world examples all over the place as file.write now returns a !usize rather than a !void. Although streams got writeOnce+write, files didn't.

EvanCarroll · 2023-09-18T21:46:53Z

Shouldn't this optimization also exist on fifo.pump?

andrewrk · 2020-03-03T07:57:55Z

This merges #4131 and then does the following:

rework os.sendfile and add macosx support, and a fallback
implementation for any OS.
fix sendto compile error
std.os write functions support partial writes. closesstd.os.writev does not handle partial writes #3443.
std.os pread / pwrite functions can now return error.Unseekable.
std.fs.File read/write functions now have readAll/writeAll variants
which loop to complete operations even when partial reads/writes
happen.
Audit std.os read/write functions with respect to Linux returning
EINVAL for lengths greater than 0x7fff0000.
std.os read/write shim functions do not unnecessarily loop. Since
partial reads/writes are part of the API, the caller will be forced
to loop anyway, and so that would just be code bloat.
Improve doc comments
Add a non-trivial test for std.os.sendfile
Fix std.os.pread on 32 bit Linux
Add missing SYS_sendfile bit on aarch64

This changset adds a `sendfile(2)` syscall bindings to the linux bits component. Where available, the `sendfile64(2)` syscall will be transparently called. A wrapping function has also been added to the std.os to transform errno returns to Zig errors. Change-Id: I86769fc4382c0771e3656e7b21137bafd99a4411

* rework os.sendfile and add macosx support, and a fallback implementation for any OS. * fix sendto compile error * std.os write functions support partial writes. closes#3443. * std.os pread / pwrite functions can now return `error.Unseekable`. * std.fs.File read/write functions now have readAll/writeAll variants which loop to complete operations even when partial reads/writes happen. * Audit std.os read/write functions with respect to Linux returning EINVAL for lengths greater than 0x7fff0000. * std.os read/write shim functions do not unnecessarily loop. Since partial reads/writes are part of the API, the caller will be forced to loop anyway, and so that would just be code bloat. * Improve doc comments * Add a non-trivial test for std.os.sendfile * Fix std.os.pread on 32 bit Linux * Add missing SYS_sendfile bit on aarch64

shawnl · 2020-03-03T08:07:31Z

What about copy_file_range(2) ?

andrewrk · 2020-03-03T08:12:10Z

What about copy_file_range(2) ?

That will be a nice separate enhancement

daurnimator · 2020-03-03T08:40:00Z


 else => {
-_ = unexpectedErrno(err);
+const discard = unexpectedErrno(err);


Why does this need an assignment?

because it's an error

hrm. why don't we support discarding error values (not error unions) via assignment to _?

daurnimator · 2020-03-06T13:02:48Z

FYI this broke zig hello world examples all over the place as file.write now returns a !usize rather than a !void. Although streams got writeOnce+write, files didn't.

EvanCarroll · 2023-09-18T21:46:53Z

Shouldn't this optimization also exist on fifo.pump?

andrewrk · 2020-03-03T07:57:55Z

This merges #4131 and then does the following:

rework os.sendfile and add macosx support, and a fallback
implementation for any OS.
fix sendto compile error
std.os write functions support partial writes. closesstd.os.writev does not handle partial writes #3443.
std.os pread / pwrite functions can now return error.Unseekable.
std.fs.File read/write functions now have readAll/writeAll variants
which loop to complete operations even when partial reads/writes
happen.
Audit std.os read/write functions with respect to Linux returning
EINVAL for lengths greater than 0x7fff0000.
std.os read/write shim functions do not unnecessarily loop. Since
partial reads/writes are part of the API, the caller will be forced
to loop anyway, and so that would just be code bloat.
Improve doc comments
Add a non-trivial test for std.os.sendfile
Fix std.os.pread on 32 bit Linux
Add missing SYS_sendfile bit on aarch64

This changset adds a `sendfile(2)` syscall bindings to the linux bits component. Where available, the `sendfile64(2)` syscall will be transparently called. A wrapping function has also been added to the std.os to transform errno returns to Zig errors. Change-Id: I86769fc4382c0771e3656e7b21137bafd99a4411

* rework os.sendfile and add macosx support, and a fallback implementation for any OS. * fix sendto compile error * std.os write functions support partial writes. closes#3443. * std.os pread / pwrite functions can now return `error.Unseekable`. * std.fs.File read/write functions now have readAll/writeAll variants which loop to complete operations even when partial reads/writes happen. * Audit std.os read/write functions with respect to Linux returning EINVAL for lengths greater than 0x7fff0000. * std.os read/write shim functions do not unnecessarily loop. Since partial reads/writes are part of the API, the caller will be forced to loop anyway, and so that would just be code bloat. * Improve doc comments * Add a non-trivial test for std.os.sendfile * Fix std.os.pread on 32 bit Linux * Add missing SYS_sendfile bit on aarch64

shawnl · 2020-03-03T08:07:31Z

What about copy_file_range(2) ?

andrewrk · 2020-03-03T08:12:10Z

What about copy_file_range(2) ?

That will be a nice separate enhancement

daurnimator · 2020-03-03T08:40:00Z


 else => {
-_ = unexpectedErrno(err);
+const discard = unexpectedErrno(err);


Why does this need an assignment?

because it's an error

hrm. why don't we support discarding error values (not error unions) via assignment to _?

daurnimator · 2020-03-06T13:02:48Z

FYI this broke zig hello world examples all over the place as file.write now returns a !usize rather than a !void. Although streams got writeOnce+write, files didn't.

EvanCarroll · 2023-09-18T21:46:53Z

Shouldn't this optimization also exist on fifo.pump?

terinjokesand others added 3 commits March 2, 2020 12:54

fix macosx and freebsd build failures
859fc85

andrewrk mentioned this pull request Mar 3, 2020
std.os read/write functions + sendfile #4611
Closed

more macos fixes
a66c727

daurnimator reviewed Mar 3, 2020
View reviewed changes

disable sendfile test on mips
9d6cc75

andrewrk merged commit 226b801 into masterMar 3, 2020

andrewrk deleted the os-read-write-sendfile branch March 3, 2020 15:15

andrewrk added the breaking Implementing this issue could cause existing code to no longer compile or have different behavior. label Mar 3, 2020

EvanCarroll mentioned this pull request Sep 18, 2023
Not fair to zig, need to use sendfile. orhun/zig-http-benchmarks#16
Open

terinjokesand others added 3 commits March 2, 2020 12:54

fix macosx and freebsd build failures
859fc85

andrewrk mentioned this pull request Mar 3, 2020
std.os read/write functions + sendfile #4611
Closed

more macos fixes
a66c727

daurnimator reviewed Mar 3, 2020
View reviewed changes

disable sendfile test on mips
9d6cc75

andrewrk merged commit 226b801 into masterMar 3, 2020

andrewrk deleted the os-read-write-sendfile branch March 3, 2020 15:15

andrewrk added the breaking Implementing this issue could cause existing code to no longer compile or have different behavior. label Mar 3, 2020

EvanCarroll mentioned this pull request Sep 18, 2023
Not fair to zig, need to use sendfile. orhun/zig-http-benchmarks#16
Open

terinjokesand others added 3 commits March 2, 2020 12:54

fix macosx and freebsd build failures
859fc85

andrewrk mentioned this pull request Mar 3, 2020
std.os read/write functions + sendfile #4611
Closed

more macos fixes
a66c727

daurnimator reviewed Mar 3, 2020
View reviewed changes

disable sendfile test on mips
9d6cc75

andrewrk merged commit 226b801 into masterMar 3, 2020

andrewrk deleted the os-read-write-sendfile branch March 3, 2020 15:15

andrewrk added the breaking Implementing this issue could cause existing code to no longer compile or have different behavior. label Mar 3, 2020

EvanCarroll mentioned this pull request Sep 18, 2023
Not fair to zig, need to use sendfile. orhun/zig-http-benchmarks#16
Open

terinjokesand others added 3 commits March 2, 2020 12:54

fix macosx and freebsd build failures
859fc85

andrewrk mentioned this pull request Mar 3, 2020
std.os read/write functions + sendfile #4611
Closed

more macos fixes
a66c727

daurnimator reviewed Mar 3, 2020
View reviewed changes

disable sendfile test on mips
9d6cc75

andrewrk merged commit 226b801 into masterMar 3, 2020

andrewrk deleted the os-read-write-sendfile branch March 3, 2020 15:15

andrewrk added the breaking Implementing this issue could cause existing code to no longer compile or have different behavior. label Mar 3, 2020

EvanCarroll mentioned this pull request Sep 18, 2023
Not fair to zig, need to use sendfile. orhun/zig-http-benchmarks#16
Open

terinjokesand others added 3 commits March 2, 2020 12:54

fix macosx and freebsd build failures
859fc85

andrewrk mentioned this pull request Mar 3, 2020
std.os read/write functions + sendfile #4611
Closed

more macos fixes
a66c727

daurnimator reviewed Mar 3, 2020
View reviewed changes

disable sendfile test on mips
9d6cc75

andrewrk merged commit 226b801 into masterMar 3, 2020

andrewrk deleted the os-read-write-sendfile branch March 3, 2020 15:15

andrewrk added the breaking Implementing this issue could cause existing code to no longer compile or have different behavior. label Mar 3, 2020

EvanCarroll mentioned this pull request Sep 18, 2023
Not fair to zig, need to use sendfile. orhun/zig-http-benchmarks#16
Open

terinjokesand others added 3 commits March 2, 2020 12:54

fix macosx and freebsd build failures
859fc85

andrewrk mentioned this pull request Mar 3, 2020
std.os read/write functions + sendfile #4611
Closed

more macos fixes
a66c727

daurnimator reviewed Mar 3, 2020
View reviewed changes

disable sendfile test on mips
9d6cc75

andrewrk merged commit 226b801 into masterMar 3, 2020

andrewrk deleted the os-read-write-sendfile branch March 3, 2020 15:15

andrewrk added the breaking Implementing this issue could cause existing code to no longer compile or have different behavior. label Mar 3, 2020

EvanCarroll mentioned this pull request Sep 18, 2023
Not fair to zig, need to use sendfile. orhun/zig-http-benchmarks#16
Open

terinjokesand others added 3 commits March 2, 2020 12:54

fix macosx and freebsd build failures
859fc85

andrewrk mentioned this pull request Mar 3, 2020
std.os read/write functions + sendfile #4611
Closed

more macos fixes
a66c727

daurnimator reviewed Mar 3, 2020
View reviewed changes

disable sendfile test on mips
9d6cc75

andrewrk merged commit 226b801 into masterMar 3, 2020

andrewrk deleted the os-read-write-sendfile branch March 3, 2020 15:15

andrewrk added the breaking Implementing this issue could cause existing code to no longer compile or have different behavior. label Mar 3, 2020

EvanCarroll mentioned this pull request Sep 18, 2023
Not fair to zig, need to use sendfile. orhun/zig-http-benchmarks#16
Open

terinjokesand others added 3 commits March 2, 2020 12:54

fix macosx and freebsd build failures
859fc85

andrewrk mentioned this pull request Mar 3, 2020
std.os read/write functions + sendfile #4611
Closed

more macos fixes
a66c727

daurnimator reviewed Mar 3, 2020
View reviewed changes

disable sendfile test on mips
9d6cc75

andrewrk merged commit 226b801 into masterMar 3, 2020

andrewrk deleted the os-read-write-sendfile branch March 3, 2020 15:15

andrewrk added the breaking Implementing this issue could cause existing code to no longer compile or have different behavior. label Mar 3, 2020

EvanCarroll mentioned this pull request Sep 18, 2023
Not fair to zig, need to use sendfile. orhun/zig-http-benchmarks#16
Open

Uh oh!

Uh oh!

Conversation

andrewrk commented Mar 3, 2020

Uh oh!

shawnl commented Mar 3, 2020

Uh oh!

andrewrk commented Mar 3, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

daurnimator commented Mar 6, 2020

Uh oh!

EvanCarroll commented Sep 18, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Uh oh!

Conversation

andrewrk commented Mar 3, 2020

Uh oh!

shawnl commented Mar 3, 2020

Uh oh!

andrewrk commented Mar 3, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

daurnimator commented Mar 6, 2020

Uh oh!

EvanCarroll commented Sep 18, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Uh oh!

Conversation

andrewrk commented Mar 3, 2020

Uh oh!

shawnl commented Mar 3, 2020

Uh oh!

andrewrk commented Mar 3, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

daurnimator commented Mar 6, 2020

Uh oh!

EvanCarroll commented Sep 18, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

EvanCarroll commented Sep 18, 2023•
edited
Loading

EvanCarroll commented Sep 18, 2023•
edited
Loading

EvanCarroll commented Sep 18, 2023•
edited
Loading

EvanCarroll commented Sep 18, 2023•
edited
Loading