Skip to content

make zig work on OSX via -DZIG_WORKAROUND_4799=ON - #5092

Closed
timotheecour wants to merge 1 commit into
ziglang:masterfrom
timotheecour:pr_fix_4799
Closed

make zig work on OSX via -DZIG_WORKAROUND_4799=ON#5092
timotheecour wants to merge 1 commit into
ziglang:masterfrom
timotheecour:pr_fix_4799

Conversation

@timotheecour

@timotheecourtimotheecour commented Apr 18, 2020

Copy link
Copy Markdown
Contributor

@timotheecourtimotheecour changed the title refs https://github.com/ziglang/zig/issues/4799make zig work on OSX via -DZIG_WORKAROUND_4799=ONApr 18, 2020
@timotheecour

timotheecour commented May 21, 2020

Copy link
Copy Markdown
ContributorAuthor

ping @andrewrk (especially now that the overeager lock bot closed Homebrew/homebrew-core#53198)

@andrewrkandrewrk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I sincerely appreciate you taking the time to make this pull request.

However, I don't want to pile hacks upon hacks. I'm just going to leave this broken, with a documented manual workaround, until it's fixed upstream.

Comment threadREADME.md
cd build
cmake .. -DCMAKE_PREFIX_PATH=$(brew --prefix llvm)
make install
make -j install

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not advisable, will crash people's computers under common circumstances.

@timotheecour

timotheecour commented Jun 25, 2020

Copy link
Copy Markdown
ContributorAuthor

However, I don't want to pile hacks upon hacks. I'm just going to leave this broken, with a documented manual workaround, until it's fixed upstream.

this makes no sense to me. The hack can be removed as soon as it's fixed upstream, it's better in all regards compared to forcing package managers (eg homebrew) to do those manual changes. It's not piling hacks upon hacks, it's just the simplest, practical, least friction solution for everyone.

@andrewrk

Copy link
Copy Markdown
Member

this makes no sense to me. The hack can be removed as soon as it's fixed upstream, it's better in all regards compared to forcing package managers (eg homebrew) to do those manual changes. It's not piling hacks upon hacks, it's just the simplest, practical, least friction solution for everyone.

OK, I reconsidered and I agree with you, thanks for your patience.

@andrewrkandrewrk reopened this Jul 3, 2020
@timotheecour
timotheecour deleted the pr_fix_4799 branch July 3, 2020 06:34
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@timotheecour@andrewrk