Uh oh!
There was an error while loading. Please reload this page.
make zig work on OSX via -DZIG_WORKAROUND_4799=ON - #5092
Conversation
-DZIG_WORKAROUND_4799=ONping @andrewrk (especially now that the overeager lock bot closed Homebrew/homebrew-core#53198) |
andrewrk
left a comment
There was a problem hiding this comment.
I sincerely appreciate you taking the time to make this pull request.
However, I don't want to pile hacks upon hacks. I'm just going to leave this broken, with a documented manual workaround, until it's fixed upstream.
| cd build | ||
| cmake .. -DCMAKE_PREFIX_PATH=$(brew --prefix llvm) | ||
| make install | ||
| make -j install |
There was a problem hiding this comment.
this is not advisable, will crash people's computers under common circumstances.
this makes no sense to me. The hack can be removed as soon as it's fixed upstream, it's better in all regards compared to forcing package managers (eg homebrew) to do those manual changes. It's not piling hacks upon hacks, it's just the simplest, practical, least friction solution for everyone. |
andrewrk
commented
Jul 3, 2020
OK, I reconsidered and I agree with you, thanks for your patience. |
@andrewrk
(what i suggested in osx: error: unable to create target: 'Unable to find target for this triple (no targets are registered)' #5055 (comment))
after merging, could you tag a release (minor or patch, not sure) so that homebrew formula can avoid having to either patch or build from some arbitrary hash and instead use a tag?