Uh oh!
There was an error while loading. Please reload this page.
std.log: (breaking) remove scope parameter from logging functions - #6046
Merged
Conversation
The logging functions in std.log don't take a scope parameter anymore, but use the .default scope. To provide your own scope, use the logging functions in std.log.scoped(.some_other_scope). As per nmichaels' suggestion: #6039 (comment)
heidezomp
commented
Aug 13, 2020
Uh oh!
There was an error while loading. Please reload this page.
This comment has been minimized.
This comment has been minimized.
andrewrk
commented
Aug 17, 2020
Member
Thanks for the follow-up! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logging functions in std.log don't take a scope parameter anymore, but use the .default scope. This is a follow-up to PR #6039 and a further implementation of #5943.
I also updated the standard library (currently only the general purpose allocator uses logging) as well as stage2 to use scoped logging. I tried to run test-std and test-stage2 tests but my old laptop hung during semantic analysis while doing so, so I'm relying on CI here.
Implemented as per @nmichaels' suggestion: #6039 (comment)