Skip to content

Miscellaneous zig std api breaking fix - #1620

Merged
llogick merged 6 commits into
zigtools:masterfrom
jimying:no-trait
Nov 26, 2023
Merged

Miscellaneous zig std api breaking fix#1620
llogick merged 6 commits into
zigtools:masterfrom
jimying:no-trait

Conversation

@jimying

@jimyingjimying commented Nov 23, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Fix zig std api breaking list:

@jimying
zig std had removed meta.trait
3f32ec6
ps: this change need set minimum zig build version to 0.12.0-dev.1686+d5e21a4f1
@jimyingjimying changed the title zig std had removed meta.traitMiscellaneous breaking fixNov 23, 2023
@jimyingjimying changed the title Miscellaneous breaking fixMiscellaneous zig std api breaking fixNov 23, 2023
llogick
llogick reviewed Nov 24, 2023
View reviewed changes

@llogickllogick left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to test that it builds with -Doptimize=ReleaseSafe

https://github.com/jimying/zls/blob/19fbc295569f50322df30f71243dd09c69f288f4/src/binned_allocator.zig#L136-L138

@llogickllogick linked an issue Nov 24, 2023 that may be closed by this pull request
Build error with latest zig build #1622
Closed
@codecov

codecovBot commented Nov 24, 2023•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (d433a58) 73.79% compared to head (eacb199) 73.77%.
Report is 1 commits behind head on master.

FilesPatch %Lines
src/features/completions.zig0.00%1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## master #1620 +/- ##
==========================================
- Coverage 73.79% 73.77% -0.02% 
==========================================
Files 33 33 Lines 8974 8981 +7 ==========================================
+ Hits 6622 6626 +4 - Misses 2352 2355 +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@llogick

llogick commented Nov 24, 2023

Copy link
Copy Markdown
Contributor

/home/runner/.cache/zig/p/1220f9d9dd88b1352b1a2bde4a96f547a1591d66ad0a9d76854d0c2c7fa59eef2508/known-folders.zig:66:44: error: root struct of file 'os.windows' has no member named 'shell32'

Any Windows users willing to do a PR?

@SuperAuguste

SuperAuguste commented Nov 24, 2023

Copy link
Copy Markdown
Member

ziglibs/known-folders#42 :)

llogick
llogick approved these changes Nov 26, 2023
View reviewed changes

@llogickllogick left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

@llogick
llogick merged commit a0affc7 into zigtools:masterNov 26, 2023
@acristoffersacristoffers mentioned this pull request Nov 26, 2023
Closed
@jimying
jimying deleted the no-trait branch November 27, 2023 00:44
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@nektronektronektro approved these changes
@llogickllogickllogick approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Build error with latest zig build

4 participants

@jimying@llogick@SuperAuguste@nektro