Skip to content

🧪 add test for redact_ndjson_lines in log_redactor - #20

Open
zrt219 wants to merge 1 commit into
mainfrom
test-redact-ndjson-lines-13646470839647820395
Open

🧪 add test for redact_ndjson_lines in log_redactor#20
zrt219 wants to merge 1 commit into
mainfrom
test-redact-ndjson-lines-13646470839647820395

Conversation

@zrt219

Copy link
Copy Markdown
Owner

🎯 What: The redact_ndjson_lines generator function in log_redactor.py was untesteed. This PR addresses that testing gap.
📊 Coverage: Tests the iteration of lines (NDJSON logs) that go through redact_ndjson_lines, including preserving the order of generated logs and ignoring blank lines. Tests the batching capabilities and validates that the JSON parsing/serialization works correctly with specific message fields.
Result: Better confidence in the implementation of the generator, expanding the test coverage for the log_redactor integration.


PR created automatically by Jules for task 13646470839647820395 started by @zrt219

Co-authored-by: zrt219 <199104500+zrt219@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@vercel

vercelBot commented Jul 19, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
zrt-bionemoReadyReadyPreview, CommentJul 19, 2026 10:04am

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@zrt219