Skip to content

🧪 Add tests for deidentify_write_stream in spark_streaming.py - #21

Draft
zrt219 wants to merge 1 commit into
mainfrom
test-deidentify-write-stream-9811911099087954334
Draft

🧪 Add tests for deidentify_write_stream in spark_streaming.py#21
zrt219 wants to merge 1 commit into
mainfrom
test-deidentify-write-stream-9811911099087954334

Conversation

@zrt219

Copy link
Copy Markdown
Owner

🎯 What: The testing gap in spark_streaming.py where deidentify_write_stream, the SparkDeidentifyStreamBuilder fluent builder, and write_deidentified_stream were entirely untested.

📊 Coverage: Mock-based testing was added to test:

  • The deidentify_write_stream function returning the SparkDeidentifyStreamBuilder.
  • Various options configured via the fluent API methods on SparkDeidentifyStreamBuilder.
  • Execution pathways terminating in .start() and .sink().
  • Different inputs triggering argument coercions in builder setup branches (like string vs list representations for column arguments).
  • The top level execution helper write_deidentified_stream.

Result: Test coverage improved across the file, bringing ~65 lines across the fluent builder under coverage and ensuring robust protection without the overhead of spinning up real mock Spark contexts.


PR created automatically by Jules for task 9811911099087954334 started by @zrt219

Adds new mock test functions in `openmed/tests/unit/integrations/test_spark_streaming.py` that cover `deidentify_write_stream`, its fluent configuration chain on `SparkDeidentifyStreamBuilder`, and `write_deidentified_stream`. This bumps coverage for `openmed/integrations/spark_streaming.py` across lines 310-508 without spinning up a real Spark context.
Co-authored-by: zrt219 <199104500+zrt219@users.noreply.github.com>
@vercel

vercelBot commented Jul 19, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
zrt-bionemoReadyReadyPreview, CommentJul 19, 2026 10:11am

@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@zrt219