Support DNS hostnames in node announcements - #2234

Merged
t-bast merged 16 commits into
ACINQ:masterfrom
remyers:dnshostnames
Aug 16, 2022
Merged

Support DNS hostnames in node announcements#2234
t-bast merged 16 commits into
ACINQ:masterfrom
remyers:dnshostnames

Conversation

@remyers

@remyersremyers commented Apr 12, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Add support for DNS host names

Notable changes:

  • you can now specify a DNS host name as one of your server.public-ips addresses (see PR #911). Note: you can not specify more than one DNS host name.
  • An IPv4, IPv6 or DNS hostname with port of 0 is invalid as per Bolt #7.
  • DNS host names will not be resolved until Client attempts to connect to a peer.
  • will not rebroadcast a NodeAnnouncement that contains more than one DNS host name
  • the codec does not implement punycode parsing; we should create an issue if we want to support non-ASCII character sets for DNS host names
  • DNS host name addresses must be resolved to determine if they are IPv4 or IPv6 when deciding whether or not to use a proxy.

To do:

See also PR #2202 - Use NodeAddress everywhere
and PR #2296 - drop Tor v2 support

@remyers

remyers commented Apr 29, 2022•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Simple interop testing with CLN v0.10.2-252-gc0e3155 configured with:
./configure --enable-experimental-features --enable-developer

Overview of setup:

Alice [Eclair] @ dnstest1.co.fr <---> Bob [CLN] @ dnstest2.co.fr <---> Carol [Eclair] @ dnstest3.co.fr

Added to local /etc/hosts:

127.0.0.1 dnstest1.co.fr
127.0.1.1 dnstest2.co.fr
127.0.2.1 dnstest3.co.fr

Created a script dns_gossip.sh to test that DNS hostnames are gossiped between Eclair and CLN.

dns_gossip.sh

Launch bicoind with ./scripts/start-bitcoin.sh, run nodes: alice-eclair & bob-clightning & carol-eclair & and then run the test script ./scripts/dns_gossip.sh.

Example result:

$ ./scripts/dns_gossip.sh Alice is 02ca09b2d0fdab441e7e41019e021db360838478484ff191feaf0e49cc13e7a9ba
Bob is 02a821bf4d075dcb88104ab2784ee87ece8979c1e2492c50cac5cdbcaedf686cfc
Carol is 0384f3fca93a670a854f1b9732965b22920c02745f3d91e8084793bf0c7b69f5b5
Adding some Bitcoin to wallets...
Generating a few blocks to confirm wallet balances...
Opening channels between Alice and Bob...
Opening channels between Bob and Carol...
Generating a few blocks to confirm channels...
Creating invoices...
Awaiting gossip sync...
Gossip sync took 14 seconds
Paying invoices...
1. BOB -> CAROL [10,000]
complete
2. ALICE -> BOB [10,000]
payment-sent
3. CAROl -> BOB -> ALICE [5,000]
payment-sent
4. ALICE -> BOB -> CAROL [20,000]
payment-sent
5. BOB -> ALICE [10,000]
complete
6. CAROL -> BOB [5,000]
payment-sent
All invoices paid
"echo All invoices paid" command filed with exit code 0.

To re-run dns_gossip.sh you first must kill the three nodes, reset their databases with ./scripts/reset_all_nodes.sh and then start the nodes again.

remyers
remyers commented May 23, 2022
View reviewed changes
Comment threadeclair-core/src/test/scala/fr/acinq/eclair/io/PeerSpec.scala
// this actor listens to connection requests and creates connections
system.actorOf(ClientSpawner.props(nodeParams.keyPair, nodeParams.socksProxy_opt, nodeParams.peerConnectionConf, TestProbe().ref, TestProbe().ref))

val invalidDnsHostname_opt = NodeAddress.fromParts("eclair.invalid", 9735).toOption

@remyersremyersMay 23, 2022

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: the .invalid top level domain will never resolve.

@rorprorp mentioned this pull request Jun 1, 2022
Merged
t-bast
t-bast reviewed Jul 26, 2022
View reviewed changes

@t-bastt-bast left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic looks good to me, I only have small cosmetic/architectural comments, good job!
This does need a rebase though.

Comment threaddocs/release-notes/eclair-vnext.md Outdated
Comment threadeclair-core/src/main/scala/fr/acinq/eclair/router/Announcements.scala Outdated
Comment threadeclair-core/src/main/scala/fr/acinq/eclair/router/Announcements.scala Outdated
Comment threadeclair-core/src/main/scala/fr/acinq/eclair/tor/Socks5Connection.scala Outdated
Comment threadeclair-core/src/main/scala/fr/acinq/eclair/router/Validation.scala Outdated
Comment threadeclair-core/src/main/scala/fr/acinq/eclair/wire/protocol/LightningMessageTypes.scala Outdated
Comment threadeclair-core/src/test/scala/fr/acinq/eclair/StartupSpec.scala
Comment threadeclair-core/src/test/scala/fr/acinq/eclair/StartupSpec.scala Outdated
Comment threadeclair-core/src/test/scala/fr/acinq/eclair/db/NetworkDbSpec.scala Outdated
Comment threadeclair-core/src/test/scala/fr/acinq/eclair/io/PeerSpec.scala
@remyersremyers changed the title Support DNS hostnames and deprecate Torv2 addresses in announcementsSupport DNS hostnames in node announcementsJul 26, 2022
@remyers

remyers commented Aug 1, 2022

Copy link
Copy Markdown
ContributorAuthor

As per Roasbeef at today's meeting, LND 0.15 will propagate DNS hostnames, so nodes running a version from about a month ago should not disappear if they add dns host names to their node announcements.

@remyers
remyers marked this pull request as ready for review August 12, 2022 10:10
t-bast
t-bast reviewed Aug 12, 2022
View reviewed changes

@t-bastt-bast left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a couple of nits and a question for @pm47 about the sun.net dependency.
This needs a rebase, which should be trivial.

Comment threadeclair-core/src/main/scala/fr/acinq/eclair/wire/protocol/LightningMessageTypes.scala Outdated
Comment threadeclair-core/src/main/scala/fr/acinq/eclair/wire/protocol/CommonCodecs.scala Outdated
Comment threadeclair-core/src/main/scala/fr/acinq/eclair/wire/protocol/LightningMessageTypes.scala Outdated
@codecov-commenter

codecov-commenter commented Aug 15, 2022

Copy link
Copy Markdown

Codecov Report

Merging #2234 (c2df6d2) into master (33e6fac) will decrease coverage by 0.06%.
The diff coverage is 96.15%.

@@ Coverage Diff @@## master #2234 +/- ##
==========================================
- Coverage 84.95% 84.89% -0.07% 
==========================================
Files 198 198 Lines 15255 15277 +22 Branches 633 640 +7 ==========================================
+ Hits 12960 12969 +9 - Misses 2295 2308 +13
Impacted FilesCoverage Δ
...re/src/main/scala/fr/acinq/eclair/NodeParams.scala93.11% <87.50%> (-0.17%)⬇️
...ore/src/main/scala/fr/acinq/eclair/io/Client.scala56.60% <100.00%> (+0.83%)⬆️
...in/scala/fr/acinq/eclair/io/ReconnectionTask.scala98.07% <100.00%> (ø)
...n/scala/fr/acinq/eclair/router/Announcements.scala100.00% <100.00%> (ø)
...main/scala/fr/acinq/eclair/router/Validation.scala94.11% <100.00%> (-1.24%)⬇️
...n/scala/fr/acinq/eclair/tor/Socks5Connection.scala9.37% <100.00%> (+0.71%)⬆️
...a/fr/acinq/eclair/wire/protocol/CommonCodecs.scala97.05% <100.00%> (+0.04%)⬆️
...q/eclair/wire/protocol/LightningMessageTypes.scala94.64% <100.00%> (+0.52%)⬆️
...q/eclair/channel/publish/ReplaceableTxFunder.scala86.91% <0.00%> (-3.67%)⬇️
...cala/fr/acinq/eclair/payment/relay/NodeRelay.scala95.93% <0.00%> (-1.63%)⬇️
... and 5 more

t-bast
t-bast approved these changes Aug 16, 2022
View reviewed changes

@t-bastt-bast left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good job 💯

@t-bast
t-bast merged commit bb6148e into ACINQ:masterAug 16, 2022
@remyers
remyers deleted the dnshostnames branch August 16, 2022 07:38
@m-schmoockm-schmoock mentioned this pull request Nov 30, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pm47pm47pm47 left review comments
@t-bastt-bastt-bast approved these changes

Assignees

No one assigned

Labels

Optech Make Me Famous!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@remyers@codecov-commenter@pm47@t-bast
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Support DNS hostnames in node announcements - #2234
Merged
t-bast merged 16 commits into
ACINQ:masterfrom 
remyers:dnshostnames
Aug 16, 2022
Merged
Support DNS hostnames in node announcements#2234
t-bast merged 16 commits into
ACINQ:masterfrom 
remyers:dnshostnames
Conversation
@remyers
@remyersremyers
commented
Apr 12, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
Add support for DNS host names
Notable changes:
  • you can now specify a DNS host name as one of your server.public-ips addresses (see PR #911). Note: you can not specify more than one DNS host name.
  • An IPv4, IPv6 or DNS hostname with port of 0 is invalid as per Bolt #7.
  • DNS host names will not be resolved until Client attempts to connect to a peer.
  • will not rebroadcast a NodeAnnouncement that contains more than one DNS host name
  • the codec does not implement punycode parsing; we should create an issue if we want to support non-ASCII character sets for DNS host names
  • DNS host name addresses must be resolved to determine if they are IPv4 or IPv6 when deciding whether or not to use a proxy.
To do:
See also PR #2202 - Use NodeAddress everywhere

and PR #2296 - drop Tor v2 support
@remyers
remyers
commented
Apr 29, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Simple interop testing with CLN v0.10.2-252-gc0e3155 configured with:
./configure --enable-experimental-features --enable-developer
Overview of setup:
Alice [Eclair] @ dnstest1.co.fr <---> Bob [CLN] @ dnstest2.co.fr <---> Carol [Eclair] @ dnstest3.co.fr
Added to local /etc/hosts:
127.0.0.1 dnstest1.co.fr
127.0.1.1 dnstest2.co.fr
127.0.2.1 dnstest3.co.fr

Created a script dns_gossip.sh to test that DNS hostnames are gossiped between Eclair and CLN.
dns_gossip.sh
Launch bicoind with ./scripts/start-bitcoin.sh, run nodes: alice-eclair & bob-clightning & carol-eclair & and then run the test script ./scripts/dns_gossip.sh.
Example result:
$ ./scripts/dns_gossip.sh Alice is 02ca09b2d0fdab441e7e41019e021db360838478484ff191feaf0e49cc13e7a9ba
Bob is 02a821bf4d075dcb88104ab2784ee87ece8979c1e2492c50cac5cdbcaedf686cfc
Carol is 0384f3fca93a670a854f1b9732965b22920c02745f3d91e8084793bf0c7b69f5b5
Adding some Bitcoin to wallets...
Generating a few blocks to confirm wallet balances...
Opening channels between Alice and Bob...
Opening channels between Bob and Carol...
Generating a few blocks to confirm channels...
Creating invoices...
Awaiting gossip sync...
Gossip sync took 14 seconds
Paying invoices...
1. BOB -> CAROL [10,000]
complete
2. ALICE -> BOB [10,000]
payment-sent
3. CAROl -> BOB -> ALICE [5,000]
payment-sent
4. ALICE -> BOB -> CAROL [20,000]
payment-sent
5. BOB -> ALICE [10,000]
complete
6. CAROL -> BOB [5,000]
payment-sent
All invoices paid
"echo All invoices paid" command filed with exit code 0.

To re-run dns_gossip.sh you first must kill the three nodes, reset their databases with ./scripts/reset_all_nodes.sh and then start the nodes again.
remyers
remyers
commented
May 23, 2022
View reviewed changes
Comment threadeclair-core/src/test/scala/fr/acinq/eclair/io/PeerSpec.scala
 // this actor listens to connection requests and creates connections
 system.actorOf(ClientSpawner.props(nodeParams.keyPair, nodeParams.socksProxy_opt, nodeParams.peerConnectionConf, TestProbe().ref, TestProbe().ref))

 val invalidDnsHostname_opt = NodeAddress.fromParts("eclair.invalid", 9735).toOption
@remyersremyersMay 23, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: the .invalid top level domain will never resolve.
@rorprorp
mentioned this pull request
Jun 1, 2022
 Merged

t-bast
t-bast
reviewed
Jul 26, 2022
View reviewed changes
@t-bastt-bast
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic looks good to me, I only have small cosmetic/architectural comments, good job!

This does need a rebase though.
Comment threaddocs/release-notes/eclair-vnext.md
Outdated

Comment threadeclair-core/src/main/scala/fr/acinq/eclair/router/Announcements.scala
Outdated

Comment threadeclair-core/src/main/scala/fr/acinq/eclair/router/Announcements.scala
Outdated

Comment threadeclair-core/src/main/scala/fr/acinq/eclair/tor/Socks5Connection.scala
Outdated

Comment threadeclair-core/src/main/scala/fr/acinq/eclair/router/Validation.scala
Outdated

Comment threadeclair-core/src/main/scala/fr/acinq/eclair/wire/protocol/LightningMessageTypes.scala
Outdated

Comment threadeclair-core/src/test/scala/fr/acinq/eclair/StartupSpec.scala
Comment threadeclair-core/src/test/scala/fr/acinq/eclair/StartupSpec.scala
Outdated

Comment threadeclair-core/src/test/scala/fr/acinq/eclair/db/NetworkDbSpec.scala
Outdated

Comment threadeclair-core/src/test/scala/fr/acinq/eclair/io/PeerSpec.scala
@remyersremyers
changed the title
Support DNS hostnames and deprecate Torv2 addresses in announcementsSupport DNS hostnames in node announcementsJul 26, 2022
@remyers
remyers
commented
Aug 1, 2022

Copy link


Copy Markdown

ContributorAuthor
As per Roasbeef at today's meeting, LND 0.15 will propagate DNS hostnames, so nodes running a version from about a month ago should not disappear if they add dns host names to their node announcements.
@remyers
remyers
marked this pull request as ready for review
August 12, 2022 10:10
t-bast
t-bast
reviewed
Aug 12, 2022
View reviewed changes
@t-bastt-bast
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a couple of nits and a question for @pm47 about the sun.net dependency.

This needs a rebase, which should be trivial.
Comment threadeclair-core/src/main/scala/fr/acinq/eclair/wire/protocol/LightningMessageTypes.scala
Outdated

Comment threadeclair-core/src/main/scala/fr/acinq/eclair/wire/protocol/CommonCodecs.scala
Outdated

Comment threadeclair-core/src/main/scala/fr/acinq/eclair/wire/protocol/LightningMessageTypes.scala
Outdated

@codecov-commenter
codecov-commenter
commented
Aug 15, 2022

Copy link


Copy Markdown

Codecov Report
Merging #2234 (c2df6d2) into master (33e6fac) will decrease coverage by 0.06%.

The diff coverage is 96.15%.
@@ Coverage Diff @@## master #2234 +/- ##
==========================================
- Coverage 84.95% 84.89% -0.07% 
==========================================
Files 198 198 Lines 15255 15277 +22 Branches 633 640 +7 ==========================================
+ Hits 12960 12969 +9 - Misses 2295 2308 +13 
Impacted FilesCoverage Δ
...re/src/main/scala/fr/acinq/eclair/NodeParams.scala93.11% <87.50%> (-0.17%)⬇️
...ore/src/main/scala/fr/acinq/eclair/io/Client.scala56.60% <100.00%> (+0.83%)⬆️
...in/scala/fr/acinq/eclair/io/ReconnectionTask.scala98.07% <100.00%> (ø)
...n/scala/fr/acinq/eclair/router/Announcements.scala100.00% <100.00%> (ø)
...main/scala/fr/acinq/eclair/router/Validation.scala94.11% <100.00%> (-1.24%)⬇️
...n/scala/fr/acinq/eclair/tor/Socks5Connection.scala9.37% <100.00%> (+0.71%)⬆️
...a/fr/acinq/eclair/wire/protocol/CommonCodecs.scala97.05% <100.00%> (+0.04%)⬆️
...q/eclair/wire/protocol/LightningMessageTypes.scala94.64% <100.00%> (+0.52%)⬆️
...q/eclair/channel/publish/ReplaceableTxFunder.scala86.91% <0.00%> (-3.67%)⬇️
...cala/fr/acinq/eclair/payment/relay/NodeRelay.scala95.93% <0.00%> (-1.63%)⬇️
... and 5 more
t-bast
t-bast
approved these changes
Aug 16, 2022
View reviewed changes
@t-bastt-bast
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good job 💯
@t-bast
t-bast
merged commit bb6148e
into
ACINQ:masterAug 16, 2022
@remyers
remyers
deleted the

dnshostnames

branch
August 16, 2022 07:38
@m-schmoockm-schmoock
mentioned this pull request
Nov 30, 2022
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pm47pm47pm47 left review comments
@t-bastt-bastt-bast approved these changes

Assignees


No one assigned


Labels

Optech Make Me Famous!

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@remyers@codecov-commenter@pm47@t-bast

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Support DNS hostnames in node announcements - #2234
Merged
t-bast merged 16 commits into
ACINQ:masterfrom 
remyers:dnshostnames
Aug 16, 2022
Merged
Support DNS hostnames in node announcements#2234
t-bast merged 16 commits into
ACINQ:masterfrom 
remyers:dnshostnames
Conversation
@remyers
@remyersremyers
commented
Apr 12, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
Add support for DNS host names
Notable changes:
  • you can now specify a DNS host name as one of your server.public-ips addresses (see PR #911). Note: you can not specify more than one DNS host name.
  • An IPv4, IPv6 or DNS hostname with port of 0 is invalid as per Bolt #7.
  • DNS host names will not be resolved until Client attempts to connect to a peer.
  • will not rebroadcast a NodeAnnouncement that contains more than one DNS host name
  • the codec does not implement punycode parsing; we should create an issue if we want to support non-ASCII character sets for DNS host names
  • DNS host name addresses must be resolved to determine if they are IPv4 or IPv6 when deciding whether or not to use a proxy.
To do:
See also PR #2202 - Use NodeAddress everywhere

and PR #2296 - drop Tor v2 support
@remyers
remyers
commented
Apr 29, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Simple interop testing with CLN v0.10.2-252-gc0e3155 configured with:
./configure --enable-experimental-features --enable-developer
Overview of setup:
Alice [Eclair] @ dnstest1.co.fr <---> Bob [CLN] @ dnstest2.co.fr <---> Carol [Eclair] @ dnstest3.co.fr
Added to local /etc/hosts:
127.0.0.1 dnstest1.co.fr
127.0.1.1 dnstest2.co.fr
127.0.2.1 dnstest3.co.fr

Created a script dns_gossip.sh to test that DNS hostnames are gossiped between Eclair and CLN.
dns_gossip.sh
Launch bicoind with ./scripts/start-bitcoin.sh, run nodes: alice-eclair & bob-clightning & carol-eclair & and then run the test script ./scripts/dns_gossip.sh.
Example result:
$ ./scripts/dns_gossip.sh Alice is 02ca09b2d0fdab441e7e41019e021db360838478484ff191feaf0e49cc13e7a9ba
Bob is 02a821bf4d075dcb88104ab2784ee87ece8979c1e2492c50cac5cdbcaedf686cfc
Carol is 0384f3fca93a670a854f1b9732965b22920c02745f3d91e8084793bf0c7b69f5b5
Adding some Bitcoin to wallets...
Generating a few blocks to confirm wallet balances...
Opening channels between Alice and Bob...
Opening channels between Bob and Carol...
Generating a few blocks to confirm channels...
Creating invoices...
Awaiting gossip sync...
Gossip sync took 14 seconds
Paying invoices...
1. BOB -> CAROL [10,000]
complete
2. ALICE -> BOB [10,000]
payment-sent
3. CAROl -> BOB -> ALICE [5,000]
payment-sent
4. ALICE -> BOB -> CAROL [20,000]
payment-sent
5. BOB -> ALICE [10,000]
complete
6. CAROL -> BOB [5,000]
payment-sent
All invoices paid
"echo All invoices paid" command filed with exit code 0.

To re-run dns_gossip.sh you first must kill the three nodes, reset their databases with ./scripts/reset_all_nodes.sh and then start the nodes again.
remyers
remyers
commented
May 23, 2022
View reviewed changes
Comment threadeclair-core/src/test/scala/fr/acinq/eclair/io/PeerSpec.scala
 // this actor listens to connection requests and creates connections
 system.actorOf(ClientSpawner.props(nodeParams.keyPair, nodeParams.socksProxy_opt, nodeParams.peerConnectionConf, TestProbe().ref, TestProbe().ref))

 val invalidDnsHostname_opt = NodeAddress.fromParts("eclair.invalid", 9735).toOption
@remyersremyersMay 23, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: the .invalid top level domain will never resolve.
@rorprorp
mentioned this pull request
Jun 1, 2022
 Merged

t-bast
t-bast
reviewed
Jul 26, 2022
View reviewed changes
@t-bastt-bast
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic looks good to me, I only have small cosmetic/architectural comments, good job!

This does need a rebase though.
Comment threaddocs/release-notes/eclair-vnext.md
Outdated

Comment threadeclair-core/src/main/scala/fr/acinq/eclair/router/Announcements.scala
Outdated

Comment threadeclair-core/src/main/scala/fr/acinq/eclair/router/Announcements.scala
Outdated

Comment threadeclair-core/src/main/scala/fr/acinq/eclair/tor/Socks5Connection.scala
Outdated

Comment threadeclair-core/src/main/scala/fr/acinq/eclair/router/Validation.scala
Outdated

Comment threadeclair-core/src/main/scala/fr/acinq/eclair/wire/protocol/LightningMessageTypes.scala
Outdated

Comment threadeclair-core/src/test/scala/fr/acinq/eclair/StartupSpec.scala
Comment threadeclair-core/src/test/scala/fr/acinq/eclair/StartupSpec.scala
Outdated

Comment threadeclair-core/src/test/scala/fr/acinq/eclair/db/NetworkDbSpec.scala
Outdated

Comment threadeclair-core/src/test/scala/fr/acinq/eclair/io/PeerSpec.scala
@remyersremyers
changed the title
Support DNS hostnames and deprecate Torv2 addresses in announcementsSupport DNS hostnames in node announcementsJul 26, 2022
@remyers
remyers
commented
Aug 1, 2022

Copy link


Copy Markdown

ContributorAuthor
As per Roasbeef at today's meeting, LND 0.15 will propagate DNS hostnames, so nodes running a version from about a month ago should not disappear if they add dns host names to their node announcements.
@remyers
remyers
marked this pull request as ready for review
August 12, 2022 10:10
t-bast
t-bast
reviewed
Aug 12, 2022
View reviewed changes
@t-bastt-bast
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a couple of nits and a question for @pm47 about the sun.net dependency.

This needs a rebase, which should be trivial.
Comment threadeclair-core/src/main/scala/fr/acinq/eclair/wire/protocol/LightningMessageTypes.scala
Outdated

Comment threadeclair-core/src/main/scala/fr/acinq/eclair/wire/protocol/CommonCodecs.scala
Outdated

Comment threadeclair-core/src/main/scala/fr/acinq/eclair/wire/protocol/LightningMessageTypes.scala
Outdated

@codecov-commenter
codecov-commenter
commented
Aug 15, 2022

Copy link


Copy Markdown

Codecov Report
Merging #2234 (c2df6d2) into master (33e6fac) will decrease coverage by 0.06%.

The diff coverage is 96.15%.
@@ Coverage Diff @@## master #2234 +/- ##
==========================================
- Coverage 84.95% 84.89% -0.07% 
==========================================
Files 198 198 Lines 15255 15277 +22 Branches 633 640 +7 ==========================================
+ Hits 12960 12969 +9 - Misses 2295 2308 +13 
Impacted FilesCoverage Δ
...re/src/main/scala/fr/acinq/eclair/NodeParams.scala93.11% <87.50%> (-0.17%)⬇️
...ore/src/main/scala/fr/acinq/eclair/io/Client.scala56.60% <100.00%> (+0.83%)⬆️
...in/scala/fr/acinq/eclair/io/ReconnectionTask.scala98.07% <100.00%> (ø)
...n/scala/fr/acinq/eclair/router/Announcements.scala100.00% <100.00%> (ø)
...main/scala/fr/acinq/eclair/router/Validation.scala94.11% <100.00%> (-1.24%)⬇️
...n/scala/fr/acinq/eclair/tor/Socks5Connection.scala9.37% <100.00%> (+0.71%)⬆️
...a/fr/acinq/eclair/wire/protocol/CommonCodecs.scala97.05% <100.00%> (+0.04%)⬆️
...q/eclair/wire/protocol/LightningMessageTypes.scala94.64% <100.00%> (+0.52%)⬆️
...q/eclair/channel/publish/ReplaceableTxFunder.scala86.91% <0.00%> (-3.67%)⬇️
...cala/fr/acinq/eclair/payment/relay/NodeRelay.scala95.93% <0.00%> (-1.63%)⬇️
... and 5 more
t-bast
t-bast
approved these changes
Aug 16, 2022
View reviewed changes
@t-bastt-bast
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good job 💯
@t-bast
t-bast
merged commit bb6148e
into
ACINQ:masterAug 16, 2022
@remyers
remyers
deleted the

dnshostnames

branch
August 16, 2022 07:38
@m-schmoockm-schmoock
mentioned this pull request
Nov 30, 2022
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pm47pm47pm47 left review comments
@t-bastt-bastt-bast approved these changes

Assignees


No one assigned


Labels

Optech Make Me Famous!

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@remyers@codecov-commenter@pm47@t-bast

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Support DNS hostnames in node announcements - #2234
Merged
t-bast merged 16 commits into
ACINQ:masterfrom 
remyers:dnshostnames
Aug 16, 2022
Merged
Support DNS hostnames in node announcements#2234
t-bast merged 16 commits into
ACINQ:masterfrom 
remyers:dnshostnames
Conversation
@remyers
@remyersremyers
commented
Apr 12, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
Add support for DNS host names
Notable changes:
  • you can now specify a DNS host name as one of your server.public-ips addresses (see PR #911). Note: you can not specify more than one DNS host name.
  • An IPv4, IPv6 or DNS hostname with port of 0 is invalid as per Bolt #7.
  • DNS host names will not be resolved until Client attempts to connect to a peer.
  • will not rebroadcast a NodeAnnouncement that contains more than one DNS host name
  • the codec does not implement punycode parsing; we should create an issue if we want to support non-ASCII character sets for DNS host names
  • DNS host name addresses must be resolved to determine if they are IPv4 or IPv6 when deciding whether or not to use a proxy.
To do:
See also PR #2202 - Use NodeAddress everywhere

and PR #2296 - drop Tor v2 support
@remyers
remyers
commented
Apr 29, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Simple interop testing with CLN v0.10.2-252-gc0e3155 configured with:
./configure --enable-experimental-features --enable-developer
Overview of setup:
Alice [Eclair] @ dnstest1.co.fr <---> Bob [CLN] @ dnstest2.co.fr <---> Carol [Eclair] @ dnstest3.co.fr
Added to local /etc/hosts:
127.0.0.1 dnstest1.co.fr
127.0.1.1 dnstest2.co.fr
127.0.2.1 dnstest3.co.fr

Created a script dns_gossip.sh to test that DNS hostnames are gossiped between Eclair and CLN.
dns_gossip.sh
Launch bicoind with ./scripts/start-bitcoin.sh, run nodes: alice-eclair & bob-clightning & carol-eclair & and then run the test script ./scripts/dns_gossip.sh.
Example result:
$ ./scripts/dns_gossip.sh Alice is 02ca09b2d0fdab441e7e41019e021db360838478484ff191feaf0e49cc13e7a9ba
Bob is 02a821bf4d075dcb88104ab2784ee87ece8979c1e2492c50cac5cdbcaedf686cfc
Carol is 0384f3fca93a670a854f1b9732965b22920c02745f3d91e8084793bf0c7b69f5b5
Adding some Bitcoin to wallets...
Generating a few blocks to confirm wallet balances...
Opening channels between Alice and Bob...
Opening channels between Bob and Carol...
Generating a few blocks to confirm channels...
Creating invoices...
Awaiting gossip sync...
Gossip sync took 14 seconds
Paying invoices...
1. BOB -> CAROL [10,000]
complete
2. ALICE -> BOB [10,000]
payment-sent
3. CAROl -> BOB -> ALICE [5,000]
payment-sent
4. ALICE -> BOB -> CAROL [20,000]
payment-sent
5. BOB -> ALICE [10,000]
complete
6. CAROL -> BOB [5,000]
payment-sent
All invoices paid
"echo All invoices paid" command filed with exit code 0.

To re-run dns_gossip.sh you first must kill the three nodes, reset their databases with ./scripts/reset_all_nodes.sh and then start the nodes again.
remyers
remyers
commented
May 23, 2022
View reviewed changes
Comment threadeclair-core/src/test/scala/fr/acinq/eclair/io/PeerSpec.scala
 // this actor listens to connection requests and creates connections
 system.actorOf(ClientSpawner.props(nodeParams.keyPair, nodeParams.socksProxy_opt, nodeParams.peerConnectionConf, TestProbe().ref, TestProbe().ref))

 val invalidDnsHostname_opt = NodeAddress.fromParts("eclair.invalid", 9735).toOption
@remyersremyersMay 23, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: the .invalid top level domain will never resolve.
@rorprorp
mentioned this pull request
Jun 1, 2022
 Merged

t-bast
t-bast
reviewed
Jul 26, 2022
View reviewed changes
@t-bastt-bast
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic looks good to me, I only have small cosmetic/architectural comments, good job!

This does need a rebase though.
Comment threaddocs/release-notes/eclair-vnext.md
Outdated

Comment threadeclair-core/src/main/scala/fr/acinq/eclair/router/Announcements.scala
Outdated

Comment threadeclair-core/src/main/scala/fr/acinq/eclair/router/Announcements.scala
Outdated

Comment threadeclair-core/src/main/scala/fr/acinq/eclair/tor/Socks5Connection.scala
Outdated

Comment threadeclair-core/src/main/scala/fr/acinq/eclair/router/Validation.scala
Outdated

Comment threadeclair-core/src/main/scala/fr/acinq/eclair/wire/protocol/LightningMessageTypes.scala
Outdated

Comment threadeclair-core/src/test/scala/fr/acinq/eclair/StartupSpec.scala
Comment threadeclair-core/src/test/scala/fr/acinq/eclair/StartupSpec.scala
Outdated

Comment threadeclair-core/src/test/scala/fr/acinq/eclair/db/NetworkDbSpec.scala
Outdated

Comment threadeclair-core/src/test/scala/fr/acinq/eclair/io/PeerSpec.scala
@remyersremyers
changed the title
Support DNS hostnames and deprecate Torv2 addresses in announcementsSupport DNS hostnames in node announcementsJul 26, 2022
@remyers
remyers
commented
Aug 1, 2022

Copy link


Copy Markdown

ContributorAuthor
As per Roasbeef at today's meeting, LND 0.15 will propagate DNS hostnames, so nodes running a version from about a month ago should not disappear if they add dns host names to their node announcements.
@remyers
remyers
marked this pull request as ready for review
August 12, 2022 10:10
t-bast
t-bast
reviewed
Aug 12, 2022
View reviewed changes
@t-bastt-bast
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a couple of nits and a question for @pm47 about the sun.net dependency.

This needs a rebase, which should be trivial.
Comment threadeclair-core/src/main/scala/fr/acinq/eclair/wire/protocol/LightningMessageTypes.scala
Outdated

Comment threadeclair-core/src/main/scala/fr/acinq/eclair/wire/protocol/CommonCodecs.scala
Outdated

Comment threadeclair-core/src/main/scala/fr/acinq/eclair/wire/protocol/LightningMessageTypes.scala
Outdated

@codecov-commenter
codecov-commenter
commented
Aug 15, 2022

Copy link


Copy Markdown

Codecov Report
Merging #2234 (c2df6d2) into master (33e6fac) will decrease coverage by 0.06%.

The diff coverage is 96.15%.
@@ Coverage Diff @@## master #2234 +/- ##
==========================================
- Coverage 84.95% 84.89% -0.07% 
==========================================
Files 198 198 Lines 15255 15277 +22 Branches 633 640 +7 ==========================================
+ Hits 12960 12969 +9 - Misses 2295 2308 +13 
Impacted FilesCoverage Δ
...re/src/main/scala/fr/acinq/eclair/NodeParams.scala93.11% <87.50%> (-0.17%)⬇️
...ore/src/main/scala/fr/acinq/eclair/io/Client.scala56.60% <100.00%> (+0.83%)⬆️
...in/scala/fr/acinq/eclair/io/ReconnectionTask.scala98.07% <100.00%> (ø)
...n/scala/fr/acinq/eclair/router/Announcements.scala100.00% <100.00%> (ø)
...main/scala/fr/acinq/eclair/router/Validation.scala94.11% <100.00%> (-1.24%)⬇️
...n/scala/fr/acinq/eclair/tor/Socks5Connection.scala9.37% <100.00%> (+0.71%)⬆️
...a/fr/acinq/eclair/wire/protocol/CommonCodecs.scala97.05% <100.00%> (+0.04%)⬆️
...q/eclair/wire/protocol/LightningMessageTypes.scala94.64% <100.00%> (+0.52%)⬆️
...q/eclair/channel/publish/ReplaceableTxFunder.scala86.91% <0.00%> (-3.67%)⬇️
...cala/fr/acinq/eclair/payment/relay/NodeRelay.scala95.93% <0.00%> (-1.63%)⬇️
... and 5 more
t-bast
t-bast
approved these changes
Aug 16, 2022
View reviewed changes
@t-bastt-bast
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good job 💯
@t-bast
t-bast
merged commit bb6148e
into
ACINQ:masterAug 16, 2022
@remyers
remyers
deleted the

dnshostnames

branch
August 16, 2022 07:38
@m-schmoockm-schmoock
mentioned this pull request
Nov 30, 2022
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pm47pm47pm47 left review comments
@t-bastt-bastt-bast approved these changes

Assignees


No one assigned


Labels

Optech Make Me Famous!

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@remyers@codecov-commenter@pm47@t-bast

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Support DNS hostnames in node announcements - #2234
Merged
t-bast merged 16 commits into
ACINQ:masterfrom 
remyers:dnshostnames
Aug 16, 2022
Merged
Support DNS hostnames in node announcements#2234
t-bast merged 16 commits into
ACINQ:masterfrom 
remyers:dnshostnames
Conversation
@remyers
@remyersremyers
commented
Apr 12, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
Add support for DNS host names
Notable changes:
  • you can now specify a DNS host name as one of your server.public-ips addresses (see PR #911). Note: you can not specify more than one DNS host name.
  • An IPv4, IPv6 or DNS hostname with port of 0 is invalid as per Bolt #7.
  • DNS host names will not be resolved until Client attempts to connect to a peer.
  • will not rebroadcast a NodeAnnouncement that contains more than one DNS host name
  • the codec does not implement punycode parsing; we should create an issue if we want to support non-ASCII character sets for DNS host names
  • DNS host name addresses must be resolved to determine if they are IPv4 or IPv6 when deciding whether or not to use a proxy.
To do:
See also PR #2202 - Use NodeAddress everywhere

and PR #2296 - drop Tor v2 support
@remyers
remyers
commented
Apr 29, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Simple interop testing with CLN v0.10.2-252-gc0e3155 configured with:
./configure --enable-experimental-features --enable-developer
Overview of setup:
Alice [Eclair] @ dnstest1.co.fr <---> Bob [CLN] @ dnstest2.co.fr <---> Carol [Eclair] @ dnstest3.co.fr
Added to local /etc/hosts:
127.0.0.1 dnstest1.co.fr
127.0.1.1 dnstest2.co.fr
127.0.2.1 dnstest3.co.fr

Created a script dns_gossip.sh to test that DNS hostnames are gossiped between Eclair and CLN.
dns_gossip.sh
Launch bicoind with ./scripts/start-bitcoin.sh, run nodes: alice-eclair & bob-clightning & carol-eclair & and then run the test script ./scripts/dns_gossip.sh.
Example result:
$ ./scripts/dns_gossip.sh Alice is 02ca09b2d0fdab441e7e41019e021db360838478484ff191feaf0e49cc13e7a9ba
Bob is 02a821bf4d075dcb88104ab2784ee87ece8979c1e2492c50cac5cdbcaedf686cfc
Carol is 0384f3fca93a670a854f1b9732965b22920c02745f3d91e8084793bf0c7b69f5b5
Adding some Bitcoin to wallets...
Generating a few blocks to confirm wallet balances...
Opening channels between Alice and Bob...
Opening channels between Bob and Carol...
Generating a few blocks to confirm channels...
Creating invoices...
Awaiting gossip sync...
Gossip sync took 14 seconds
Paying invoices...
1. BOB -> CAROL [10,000]
complete
2. ALICE -> BOB [10,000]
payment-sent
3. CAROl -> BOB -> ALICE [5,000]
payment-sent
4. ALICE -> BOB -> CAROL [20,000]
payment-sent
5. BOB -> ALICE [10,000]
complete
6. CAROL -> BOB [5,000]
payment-sent
All invoices paid
"echo All invoices paid" command filed with exit code 0.

To re-run dns_gossip.sh you first must kill the three nodes, reset their databases with ./scripts/reset_all_nodes.sh and then start the nodes again.
remyers
remyers
commented
May 23, 2022
View reviewed changes
Comment threadeclair-core/src/test/scala/fr/acinq/eclair/io/PeerSpec.scala
 // this actor listens to connection requests and creates connections
 system.actorOf(ClientSpawner.props(nodeParams.keyPair, nodeParams.socksProxy_opt, nodeParams.peerConnectionConf, TestProbe().ref, TestProbe().ref))

 val invalidDnsHostname_opt = NodeAddress.fromParts("eclair.invalid", 9735).toOption
@remyersremyersMay 23, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: the .invalid top level domain will never resolve.
@rorprorp
mentioned this pull request
Jun 1, 2022
 Merged

t-bast
t-bast
reviewed
Jul 26, 2022
View reviewed changes
@t-bastt-bast
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic looks good to me, I only have small cosmetic/architectural comments, good job!

This does need a rebase though.
Comment threaddocs/release-notes/eclair-vnext.md
Outdated

Comment threadeclair-core/src/main/scala/fr/acinq/eclair/router/Announcements.scala
Outdated

Comment threadeclair-core/src/main/scala/fr/acinq/eclair/router/Announcements.scala
Outdated

Comment threadeclair-core/src/main/scala/fr/acinq/eclair/tor/Socks5Connection.scala
Outdated

Comment threadeclair-core/src/main/scala/fr/acinq/eclair/router/Validation.scala
Outdated

Comment threadeclair-core/src/main/scala/fr/acinq/eclair/wire/protocol/LightningMessageTypes.scala
Outdated

Comment threadeclair-core/src/test/scala/fr/acinq/eclair/StartupSpec.scala
Comment threadeclair-core/src/test/scala/fr/acinq/eclair/StartupSpec.scala
Outdated

Comment threadeclair-core/src/test/scala/fr/acinq/eclair/db/NetworkDbSpec.scala
Outdated

Comment threadeclair-core/src/test/scala/fr/acinq/eclair/io/PeerSpec.scala
@remyersremyers
changed the title
Support DNS hostnames and deprecate Torv2 addresses in announcementsSupport DNS hostnames in node announcementsJul 26, 2022
@remyers
remyers
commented
Aug 1, 2022

Copy link


Copy Markdown

ContributorAuthor
As per Roasbeef at today's meeting, LND 0.15 will propagate DNS hostnames, so nodes running a version from about a month ago should not disappear if they add dns host names to their node announcements.
@remyers
remyers
marked this pull request as ready for review
August 12, 2022 10:10
t-bast
t-bast
reviewed
Aug 12, 2022
View reviewed changes
@t-bastt-bast
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a couple of nits and a question for @pm47 about the sun.net dependency.

This needs a rebase, which should be trivial.
Comment threadeclair-core/src/main/scala/fr/acinq/eclair/wire/protocol/LightningMessageTypes.scala
Outdated

Comment threadeclair-core/src/main/scala/fr/acinq/eclair/wire/protocol/CommonCodecs.scala
Outdated

Comment threadeclair-core/src/main/scala/fr/acinq/eclair/wire/protocol/LightningMessageTypes.scala
Outdated

@codecov-commenter
codecov-commenter
commented
Aug 15, 2022

Copy link


Copy Markdown

Codecov Report
Merging #2234 (c2df6d2) into master (33e6fac) will decrease coverage by 0.06%.

The diff coverage is 96.15%.
@@ Coverage Diff @@## master #2234 +/- ##
==========================================
- Coverage 84.95% 84.89% -0.07% 
==========================================
Files 198 198 Lines 15255 15277 +22 Branches 633 640 +7 ==========================================
+ Hits 12960 12969 +9 - Misses 2295 2308 +13 
Impacted FilesCoverage Δ
...re/src/main/scala/fr/acinq/eclair/NodeParams.scala93.11% <87.50%> (-0.17%)⬇️
...ore/src/main/scala/fr/acinq/eclair/io/Client.scala56.60% <100.00%> (+0.83%)⬆️
...in/scala/fr/acinq/eclair/io/ReconnectionTask.scala98.07% <100.00%> (ø)
...n/scala/fr/acinq/eclair/router/Announcements.scala100.00% <100.00%> (ø)
...main/scala/fr/acinq/eclair/router/Validation.scala94.11% <100.00%> (-1.24%)⬇️
...n/scala/fr/acinq/eclair/tor/Socks5Connection.scala9.37% <100.00%> (+0.71%)⬆️
...a/fr/acinq/eclair/wire/protocol/CommonCodecs.scala97.05% <100.00%> (+0.04%)⬆️
...q/eclair/wire/protocol/LightningMessageTypes.scala94.64% <100.00%> (+0.52%)⬆️
...q/eclair/channel/publish/ReplaceableTxFunder.scala86.91% <0.00%> (-3.67%)⬇️
...cala/fr/acinq/eclair/payment/relay/NodeRelay.scala95.93% <0.00%> (-1.63%)⬇️
... and 5 more
t-bast
t-bast
approved these changes
Aug 16, 2022
View reviewed changes
@t-bastt-bast
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good job 💯
@t-bast
t-bast
merged commit bb6148e
into
ACINQ:masterAug 16, 2022
@remyers
remyers
deleted the

dnshostnames

branch
August 16, 2022 07:38
@m-schmoockm-schmoock
mentioned this pull request
Nov 30, 2022
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pm47pm47pm47 left review comments
@t-bastt-bastt-bast approved these changes

Assignees


No one assigned


Labels

Optech Make Me Famous!

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@remyers@codecov-commenter@pm47@t-bast

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Support DNS hostnames in node announcements - #2234
Merged
t-bast merged 16 commits into
ACINQ:masterfrom 
remyers:dnshostnames
Aug 16, 2022
Merged
Support DNS hostnames in node announcements#2234
t-bast merged 16 commits into
ACINQ:masterfrom 
remyers:dnshostnames
Conversation
@remyers
@remyersremyers
commented
Apr 12, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
Add support for DNS host names
Notable changes:
  • you can now specify a DNS host name as one of your server.public-ips addresses (see PR #911). Note: you can not specify more than one DNS host name.
  • An IPv4, IPv6 or DNS hostname with port of 0 is invalid as per Bolt #7.
  • DNS host names will not be resolved until Client attempts to connect to a peer.
  • will not rebroadcast a NodeAnnouncement that contains more than one DNS host name
  • the codec does not implement punycode parsing; we should create an issue if we want to support non-ASCII character sets for DNS host names
  • DNS host name addresses must be resolved to determine if they are IPv4 or IPv6 when deciding whether or not to use a proxy.
To do:
See also PR #2202 - Use NodeAddress everywhere

and PR #2296 - drop Tor v2 support
@remyers
remyers
commented
Apr 29, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Simple interop testing with CLN v0.10.2-252-gc0e3155 configured with:
./configure --enable-experimental-features --enable-developer
Overview of setup:
Alice [Eclair] @ dnstest1.co.fr <---> Bob [CLN] @ dnstest2.co.fr <---> Carol [Eclair] @ dnstest3.co.fr
Added to local /etc/hosts:
127.0.0.1 dnstest1.co.fr
127.0.1.1 dnstest2.co.fr
127.0.2.1 dnstest3.co.fr

Created a script dns_gossip.sh to test that DNS hostnames are gossiped between Eclair and CLN.
dns_gossip.sh
Launch bicoind with ./scripts/start-bitcoin.sh, run nodes: alice-eclair & bob-clightning & carol-eclair & and then run the test script ./scripts/dns_gossip.sh.
Example result:
$ ./scripts/dns_gossip.sh Alice is 02ca09b2d0fdab441e7e41019e021db360838478484ff191feaf0e49cc13e7a9ba
Bob is 02a821bf4d075dcb88104ab2784ee87ece8979c1e2492c50cac5cdbcaedf686cfc
Carol is 0384f3fca93a670a854f1b9732965b22920c02745f3d91e8084793bf0c7b69f5b5
Adding some Bitcoin to wallets...
Generating a few blocks to confirm wallet balances...
Opening channels between Alice and Bob...
Opening channels between Bob and Carol...
Generating a few blocks to confirm channels...
Creating invoices...
Awaiting gossip sync...
Gossip sync took 14 seconds
Paying invoices...
1. BOB -> CAROL [10,000]
complete
2. ALICE -> BOB [10,000]
payment-sent
3. CAROl -> BOB -> ALICE [5,000]
payment-sent
4. ALICE -> BOB -> CAROL [20,000]
payment-sent
5. BOB -> ALICE [10,000]
complete
6. CAROL -> BOB [5,000]
payment-sent
All invoices paid
"echo All invoices paid" command filed with exit code 0.

To re-run dns_gossip.sh you first must kill the three nodes, reset their databases with ./scripts/reset_all_nodes.sh and then start the nodes again.
remyers
remyers
commented
May 23, 2022
View reviewed changes
Comment threadeclair-core/src/test/scala/fr/acinq/eclair/io/PeerSpec.scala
 // this actor listens to connection requests and creates connections
 system.actorOf(ClientSpawner.props(nodeParams.keyPair, nodeParams.socksProxy_opt, nodeParams.peerConnectionConf, TestProbe().ref, TestProbe().ref))

 val invalidDnsHostname_opt = NodeAddress.fromParts("eclair.invalid", 9735).toOption
@remyersremyersMay 23, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: the .invalid top level domain will never resolve.
@rorprorp
mentioned this pull request
Jun 1, 2022
 Merged

t-bast
t-bast
reviewed
Jul 26, 2022
View reviewed changes
@t-bastt-bast
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic looks good to me, I only have small cosmetic/architectural comments, good job!

This does need a rebase though.
Comment threaddocs/release-notes/eclair-vnext.md
Outdated

Comment threadeclair-core/src/main/scala/fr/acinq/eclair/router/Announcements.scala
Outdated

Comment threadeclair-core/src/main/scala/fr/acinq/eclair/router/Announcements.scala
Outdated

Comment threadeclair-core/src/main/scala/fr/acinq/eclair/tor/Socks5Connection.scala
Outdated

Comment threadeclair-core/src/main/scala/fr/acinq/eclair/router/Validation.scala
Outdated

Comment threadeclair-core/src/main/scala/fr/acinq/eclair/wire/protocol/LightningMessageTypes.scala
Outdated

Comment threadeclair-core/src/test/scala/fr/acinq/eclair/StartupSpec.scala
Comment threadeclair-core/src/test/scala/fr/acinq/eclair/StartupSpec.scala
Outdated

Comment threadeclair-core/src/test/scala/fr/acinq/eclair/db/NetworkDbSpec.scala
Outdated

Comment threadeclair-core/src/test/scala/fr/acinq/eclair/io/PeerSpec.scala
@remyersremyers
changed the title
Support DNS hostnames and deprecate Torv2 addresses in announcementsSupport DNS hostnames in node announcementsJul 26, 2022
@remyers
remyers
commented
Aug 1, 2022

Copy link


Copy Markdown

ContributorAuthor
As per Roasbeef at today's meeting, LND 0.15 will propagate DNS hostnames, so nodes running a version from about a month ago should not disappear if they add dns host names to their node announcements.
@remyers
remyers
marked this pull request as ready for review
August 12, 2022 10:10
t-bast
t-bast
reviewed
Aug 12, 2022
View reviewed changes
@t-bastt-bast
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a couple of nits and a question for @pm47 about the sun.net dependency.

This needs a rebase, which should be trivial.
Comment threadeclair-core/src/main/scala/fr/acinq/eclair/wire/protocol/LightningMessageTypes.scala
Outdated

Comment threadeclair-core/src/main/scala/fr/acinq/eclair/wire/protocol/CommonCodecs.scala
Outdated

Comment threadeclair-core/src/main/scala/fr/acinq/eclair/wire/protocol/LightningMessageTypes.scala
Outdated

@codecov-commenter
codecov-commenter
commented
Aug 15, 2022

Copy link


Copy Markdown

Codecov Report
Merging #2234 (c2df6d2) into master (33e6fac) will decrease coverage by 0.06%.

The diff coverage is 96.15%.
@@ Coverage Diff @@## master #2234 +/- ##
==========================================
- Coverage 84.95% 84.89% -0.07% 
==========================================
Files 198 198 Lines 15255 15277 +22 Branches 633 640 +7 ==========================================
+ Hits 12960 12969 +9 - Misses 2295 2308 +13 
Impacted FilesCoverage Δ
...re/src/main/scala/fr/acinq/eclair/NodeParams.scala93.11% <87.50%> (-0.17%)⬇️
...ore/src/main/scala/fr/acinq/eclair/io/Client.scala56.60% <100.00%> (+0.83%)⬆️
...in/scala/fr/acinq/eclair/io/ReconnectionTask.scala98.07% <100.00%> (ø)
...n/scala/fr/acinq/eclair/router/Announcements.scala100.00% <100.00%> (ø)
...main/scala/fr/acinq/eclair/router/Validation.scala94.11% <100.00%> (-1.24%)⬇️
...n/scala/fr/acinq/eclair/tor/Socks5Connection.scala9.37% <100.00%> (+0.71%)⬆️
...a/fr/acinq/eclair/wire/protocol/CommonCodecs.scala97.05% <100.00%> (+0.04%)⬆️
...q/eclair/wire/protocol/LightningMessageTypes.scala94.64% <100.00%> (+0.52%)⬆️
...q/eclair/channel/publish/ReplaceableTxFunder.scala86.91% <0.00%> (-3.67%)⬇️
...cala/fr/acinq/eclair/payment/relay/NodeRelay.scala95.93% <0.00%> (-1.63%)⬇️
... and 5 more
t-bast
t-bast
approved these changes
Aug 16, 2022
View reviewed changes
@t-bastt-bast
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good job 💯
@t-bast
t-bast
merged commit bb6148e
into
ACINQ:masterAug 16, 2022
@remyers
remyers
deleted the

dnshostnames

branch
August 16, 2022 07:38
@m-schmoockm-schmoock
mentioned this pull request
Nov 30, 2022
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pm47pm47pm47 left review comments
@t-bastt-bastt-bast approved these changes

Assignees


No one assigned


Labels

Optech Make Me Famous!

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@remyers@codecov-commenter@pm47@t-bast

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Support DNS hostnames in node announcements - #2234
Merged
t-bast merged 16 commits into
ACINQ:masterfrom 
remyers:dnshostnames
Aug 16, 2022
Merged
Support DNS hostnames in node announcements#2234
t-bast merged 16 commits into
ACINQ:masterfrom 
remyers:dnshostnames
Conversation
@remyers
@remyersremyers
commented
Apr 12, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
Add support for DNS host names
Notable changes:
  • you can now specify a DNS host name as one of your server.public-ips addresses (see PR #911). Note: you can not specify more than one DNS host name.
  • An IPv4, IPv6 or DNS hostname with port of 0 is invalid as per Bolt #7.
  • DNS host names will not be resolved until Client attempts to connect to a peer.
  • will not rebroadcast a NodeAnnouncement that contains more than one DNS host name
  • the codec does not implement punycode parsing; we should create an issue if we want to support non-ASCII character sets for DNS host names
  • DNS host name addresses must be resolved to determine if they are IPv4 or IPv6 when deciding whether or not to use a proxy.
To do:
See also PR #2202 - Use NodeAddress everywhere

and PR #2296 - drop Tor v2 support
@remyers
remyers
commented
Apr 29, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Simple interop testing with CLN v0.10.2-252-gc0e3155 configured with:
./configure --enable-experimental-features --enable-developer
Overview of setup:
Alice [Eclair] @ dnstest1.co.fr <---> Bob [CLN] @ dnstest2.co.fr <---> Carol [Eclair] @ dnstest3.co.fr
Added to local /etc/hosts:
127.0.0.1 dnstest1.co.fr
127.0.1.1 dnstest2.co.fr
127.0.2.1 dnstest3.co.fr

Created a script dns_gossip.sh to test that DNS hostnames are gossiped between Eclair and CLN.
dns_gossip.sh
Launch bicoind with ./scripts/start-bitcoin.sh, run nodes: alice-eclair & bob-clightning & carol-eclair & and then run the test script ./scripts/dns_gossip.sh.
Example result:
$ ./scripts/dns_gossip.sh Alice is 02ca09b2d0fdab441e7e41019e021db360838478484ff191feaf0e49cc13e7a9ba
Bob is 02a821bf4d075dcb88104ab2784ee87ece8979c1e2492c50cac5cdbcaedf686cfc
Carol is 0384f3fca93a670a854f1b9732965b22920c02745f3d91e8084793bf0c7b69f5b5
Adding some Bitcoin to wallets...
Generating a few blocks to confirm wallet balances...
Opening channels between Alice and Bob...
Opening channels between Bob and Carol...
Generating a few blocks to confirm channels...
Creating invoices...
Awaiting gossip sync...
Gossip sync took 14 seconds
Paying invoices...
1. BOB -> CAROL [10,000]
complete
2. ALICE -> BOB [10,000]
payment-sent
3. CAROl -> BOB -> ALICE [5,000]
payment-sent
4. ALICE -> BOB -> CAROL [20,000]
payment-sent
5. BOB -> ALICE [10,000]
complete
6. CAROL -> BOB [5,000]
payment-sent
All invoices paid
"echo All invoices paid" command filed with exit code 0.

To re-run dns_gossip.sh you first must kill the three nodes, reset their databases with ./scripts/reset_all_nodes.sh and then start the nodes again.
remyers
remyers
commented
May 23, 2022
View reviewed changes
Comment threadeclair-core/src/test/scala/fr/acinq/eclair/io/PeerSpec.scala
 // this actor listens to connection requests and creates connections
 system.actorOf(ClientSpawner.props(nodeParams.keyPair, nodeParams.socksProxy_opt, nodeParams.peerConnectionConf, TestProbe().ref, TestProbe().ref))

 val invalidDnsHostname_opt = NodeAddress.fromParts("eclair.invalid", 9735).toOption
@remyersremyersMay 23, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: the .invalid top level domain will never resolve.
@rorprorp
mentioned this pull request
Jun 1, 2022
 Merged

t-bast
t-bast
reviewed
Jul 26, 2022
View reviewed changes
@t-bastt-bast
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic looks good to me, I only have small cosmetic/architectural comments, good job!

This does need a rebase though.
Comment threaddocs/release-notes/eclair-vnext.md
Outdated

Comment threadeclair-core/src/main/scala/fr/acinq/eclair/router/Announcements.scala
Outdated

Comment threadeclair-core/src/main/scala/fr/acinq/eclair/router/Announcements.scala
Outdated

Comment threadeclair-core/src/main/scala/fr/acinq/eclair/tor/Socks5Connection.scala
Outdated

Comment threadeclair-core/src/main/scala/fr/acinq/eclair/router/Validation.scala
Outdated

Comment threadeclair-core/src/main/scala/fr/acinq/eclair/wire/protocol/LightningMessageTypes.scala
Outdated

Comment threadeclair-core/src/test/scala/fr/acinq/eclair/StartupSpec.scala
Comment threadeclair-core/src/test/scala/fr/acinq/eclair/StartupSpec.scala
Outdated

Comment threadeclair-core/src/test/scala/fr/acinq/eclair/db/NetworkDbSpec.scala
Outdated

Comment threadeclair-core/src/test/scala/fr/acinq/eclair/io/PeerSpec.scala
@remyersremyers
changed the title
Support DNS hostnames and deprecate Torv2 addresses in announcementsSupport DNS hostnames in node announcementsJul 26, 2022
@remyers
remyers
commented
Aug 1, 2022

Copy link


Copy Markdown

ContributorAuthor
As per Roasbeef at today's meeting, LND 0.15 will propagate DNS hostnames, so nodes running a version from about a month ago should not disappear if they add dns host names to their node announcements.
@remyers
remyers
marked this pull request as ready for review
August 12, 2022 10:10
t-bast
t-bast
reviewed
Aug 12, 2022
View reviewed changes
@t-bastt-bast
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a couple of nits and a question for @pm47 about the sun.net dependency.

This needs a rebase, which should be trivial.
Comment threadeclair-core/src/main/scala/fr/acinq/eclair/wire/protocol/LightningMessageTypes.scala
Outdated

Comment threadeclair-core/src/main/scala/fr/acinq/eclair/wire/protocol/CommonCodecs.scala
Outdated

Comment threadeclair-core/src/main/scala/fr/acinq/eclair/wire/protocol/LightningMessageTypes.scala
Outdated

@codecov-commenter
codecov-commenter
commented
Aug 15, 2022

Copy link


Copy Markdown

Codecov Report
Merging #2234 (c2df6d2) into master (33e6fac) will decrease coverage by 0.06%.

The diff coverage is 96.15%.
@@ Coverage Diff @@## master #2234 +/- ##
==========================================
- Coverage 84.95% 84.89% -0.07% 
==========================================
Files 198 198 Lines 15255 15277 +22 Branches 633 640 +7 ==========================================
+ Hits 12960 12969 +9 - Misses 2295 2308 +13 
Impacted FilesCoverage Δ
...re/src/main/scala/fr/acinq/eclair/NodeParams.scala93.11% <87.50%> (-0.17%)⬇️
...ore/src/main/scala/fr/acinq/eclair/io/Client.scala56.60% <100.00%> (+0.83%)⬆️
...in/scala/fr/acinq/eclair/io/ReconnectionTask.scala98.07% <100.00%> (ø)
...n/scala/fr/acinq/eclair/router/Announcements.scala100.00% <100.00%> (ø)
...main/scala/fr/acinq/eclair/router/Validation.scala94.11% <100.00%> (-1.24%)⬇️
...n/scala/fr/acinq/eclair/tor/Socks5Connection.scala9.37% <100.00%> (+0.71%)⬆️
...a/fr/acinq/eclair/wire/protocol/CommonCodecs.scala97.05% <100.00%> (+0.04%)⬆️
...q/eclair/wire/protocol/LightningMessageTypes.scala94.64% <100.00%> (+0.52%)⬆️
...q/eclair/channel/publish/ReplaceableTxFunder.scala86.91% <0.00%> (-3.67%)⬇️
...cala/fr/acinq/eclair/payment/relay/NodeRelay.scala95.93% <0.00%> (-1.63%)⬇️
... and 5 more
t-bast
t-bast
approved these changes
Aug 16, 2022
View reviewed changes
@t-bastt-bast
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good job 💯
@t-bast
t-bast
merged commit bb6148e
into
ACINQ:masterAug 16, 2022
@remyers
remyers
deleted the

dnshostnames

branch
August 16, 2022 07:38
@m-schmoockm-schmoock
mentioned this pull request
Nov 30, 2022
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pm47pm47pm47 left review comments
@t-bastt-bastt-bast approved these changes

Assignees


No one assigned


Labels

Optech Make Me Famous!

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@remyers@codecov-commenter@pm47@t-bast

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Support DNS hostnames in node announcements - #2234
Merged
t-bast merged 16 commits into
ACINQ:masterfrom 
remyers:dnshostnames
Aug 16, 2022
Merged
Support DNS hostnames in node announcements#2234
t-bast merged 16 commits into
ACINQ:masterfrom 
remyers:dnshostnames
Conversation
@remyers
@remyersremyers
commented
Apr 12, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
Add support for DNS host names
Notable changes:
  • you can now specify a DNS host name as one of your server.public-ips addresses (see PR #911). Note: you can not specify more than one DNS host name.
  • An IPv4, IPv6 or DNS hostname with port of 0 is invalid as per Bolt #7.
  • DNS host names will not be resolved until Client attempts to connect to a peer.
  • will not rebroadcast a NodeAnnouncement that contains more than one DNS host name
  • the codec does not implement punycode parsing; we should create an issue if we want to support non-ASCII character sets for DNS host names
  • DNS host name addresses must be resolved to determine if they are IPv4 or IPv6 when deciding whether or not to use a proxy.
To do:
See also PR #2202 - Use NodeAddress everywhere

and PR #2296 - drop Tor v2 support
@remyers
remyers
commented
Apr 29, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Simple interop testing with CLN v0.10.2-252-gc0e3155 configured with:
./configure --enable-experimental-features --enable-developer
Overview of setup:
Alice [Eclair] @ dnstest1.co.fr <---> Bob [CLN] @ dnstest2.co.fr <---> Carol [Eclair] @ dnstest3.co.fr
Added to local /etc/hosts:
127.0.0.1 dnstest1.co.fr
127.0.1.1 dnstest2.co.fr
127.0.2.1 dnstest3.co.fr

Created a script dns_gossip.sh to test that DNS hostnames are gossiped between Eclair and CLN.
dns_gossip.sh
Launch bicoind with ./scripts/start-bitcoin.sh, run nodes: alice-eclair & bob-clightning & carol-eclair & and then run the test script ./scripts/dns_gossip.sh.
Example result:
$ ./scripts/dns_gossip.sh Alice is 02ca09b2d0fdab441e7e41019e021db360838478484ff191feaf0e49cc13e7a9ba
Bob is 02a821bf4d075dcb88104ab2784ee87ece8979c1e2492c50cac5cdbcaedf686cfc
Carol is 0384f3fca93a670a854f1b9732965b22920c02745f3d91e8084793bf0c7b69f5b5
Adding some Bitcoin to wallets...
Generating a few blocks to confirm wallet balances...
Opening channels between Alice and Bob...
Opening channels between Bob and Carol...
Generating a few blocks to confirm channels...
Creating invoices...
Awaiting gossip sync...
Gossip sync took 14 seconds
Paying invoices...
1. BOB -> CAROL [10,000]
complete
2. ALICE -> BOB [10,000]
payment-sent
3. CAROl -> BOB -> ALICE [5,000]
payment-sent
4. ALICE -> BOB -> CAROL [20,000]
payment-sent
5. BOB -> ALICE [10,000]
complete
6. CAROL -> BOB [5,000]
payment-sent
All invoices paid
"echo All invoices paid" command filed with exit code 0.

To re-run dns_gossip.sh you first must kill the three nodes, reset their databases with ./scripts/reset_all_nodes.sh and then start the nodes again.
remyers
remyers
commented
May 23, 2022
View reviewed changes
Comment threadeclair-core/src/test/scala/fr/acinq/eclair/io/PeerSpec.scala
 // this actor listens to connection requests and creates connections
 system.actorOf(ClientSpawner.props(nodeParams.keyPair, nodeParams.socksProxy_opt, nodeParams.peerConnectionConf, TestProbe().ref, TestProbe().ref))

 val invalidDnsHostname_opt = NodeAddress.fromParts("eclair.invalid", 9735).toOption
@remyersremyersMay 23, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: the .invalid top level domain will never resolve.
@rorprorp
mentioned this pull request
Jun 1, 2022
 Merged

t-bast
t-bast
reviewed
Jul 26, 2022
View reviewed changes
@t-bastt-bast
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic looks good to me, I only have small cosmetic/architectural comments, good job!

This does need a rebase though.
Comment threaddocs/release-notes/eclair-vnext.md
Outdated

Comment threadeclair-core/src/main/scala/fr/acinq/eclair/router/Announcements.scala
Outdated

Comment threadeclair-core/src/main/scala/fr/acinq/eclair/router/Announcements.scala
Outdated

Comment threadeclair-core/src/main/scala/fr/acinq/eclair/tor/Socks5Connection.scala
Outdated

Comment threadeclair-core/src/main/scala/fr/acinq/eclair/router/Validation.scala
Outdated

Comment threadeclair-core/src/main/scala/fr/acinq/eclair/wire/protocol/LightningMessageTypes.scala
Outdated

Comment threadeclair-core/src/test/scala/fr/acinq/eclair/StartupSpec.scala
Comment threadeclair-core/src/test/scala/fr/acinq/eclair/StartupSpec.scala
Outdated

Comment threadeclair-core/src/test/scala/fr/acinq/eclair/db/NetworkDbSpec.scala
Outdated

Comment threadeclair-core/src/test/scala/fr/acinq/eclair/io/PeerSpec.scala
@remyersremyers
changed the title
Support DNS hostnames and deprecate Torv2 addresses in announcementsSupport DNS hostnames in node announcementsJul 26, 2022
@remyers
remyers
commented
Aug 1, 2022

Copy link


Copy Markdown

ContributorAuthor
As per Roasbeef at today's meeting, LND 0.15 will propagate DNS hostnames, so nodes running a version from about a month ago should not disappear if they add dns host names to their node announcements.
@remyers
remyers
marked this pull request as ready for review
August 12, 2022 10:10
t-bast
t-bast
reviewed
Aug 12, 2022
View reviewed changes
@t-bastt-bast
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a couple of nits and a question for @pm47 about the sun.net dependency.

This needs a rebase, which should be trivial.
Comment threadeclair-core/src/main/scala/fr/acinq/eclair/wire/protocol/LightningMessageTypes.scala
Outdated

Comment threadeclair-core/src/main/scala/fr/acinq/eclair/wire/protocol/CommonCodecs.scala
Outdated

Comment threadeclair-core/src/main/scala/fr/acinq/eclair/wire/protocol/LightningMessageTypes.scala
Outdated

@codecov-commenter
codecov-commenter
commented
Aug 15, 2022

Copy link


Copy Markdown

Codecov Report
Merging #2234 (c2df6d2) into master (33e6fac) will decrease coverage by 0.06%.

The diff coverage is 96.15%.
@@ Coverage Diff @@## master #2234 +/- ##
==========================================
- Coverage 84.95% 84.89% -0.07% 
==========================================
Files 198 198 Lines 15255 15277 +22 Branches 633 640 +7 ==========================================
+ Hits 12960 12969 +9 - Misses 2295 2308 +13 
Impacted FilesCoverage Δ
...re/src/main/scala/fr/acinq/eclair/NodeParams.scala93.11% <87.50%> (-0.17%)⬇️
...ore/src/main/scala/fr/acinq/eclair/io/Client.scala56.60% <100.00%> (+0.83%)⬆️
...in/scala/fr/acinq/eclair/io/ReconnectionTask.scala98.07% <100.00%> (ø)
...n/scala/fr/acinq/eclair/router/Announcements.scala100.00% <100.00%> (ø)
...main/scala/fr/acinq/eclair/router/Validation.scala94.11% <100.00%> (-1.24%)⬇️
...n/scala/fr/acinq/eclair/tor/Socks5Connection.scala9.37% <100.00%> (+0.71%)⬆️
...a/fr/acinq/eclair/wire/protocol/CommonCodecs.scala97.05% <100.00%> (+0.04%)⬆️
...q/eclair/wire/protocol/LightningMessageTypes.scala94.64% <100.00%> (+0.52%)⬆️
...q/eclair/channel/publish/ReplaceableTxFunder.scala86.91% <0.00%> (-3.67%)⬇️
...cala/fr/acinq/eclair/payment/relay/NodeRelay.scala95.93% <0.00%> (-1.63%)⬇️
... and 5 more
t-bast
t-bast
approved these changes
Aug 16, 2022
View reviewed changes
@t-bastt-bast
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good job 💯
@t-bast
t-bast
merged commit bb6148e
into
ACINQ:masterAug 16, 2022
@remyers
remyers
deleted the

dnshostnames

branch
August 16, 2022 07:38
@m-schmoockm-schmoock
mentioned this pull request
Nov 30, 2022
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pm47pm47pm47 left review comments
@t-bastt-bastt-bast approved these changes

Assignees


No one assigned


Labels

Optech Make Me Famous!

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@remyers@codecov-commenter@pm47@t-bast