Add DNSHostname to NetAddress mssgs by a-mpch · Pull Request #1329 · lightningdevkit/rust-lightning

a-mpch · 2022-02-23T01:26:02Z

Support Bolt 7 DNS Hostnames Check lightning/bolts#911

I'm missing the test in this one if someone could guide me would be nice

TheBlueMatt

Thanks for taking a crack at this!

TheBlueMatt · 2022-02-24T00:51:49Z

 	},
+	DNSHostname {
+ /// The hostname length
+ hostname_len: u8,


You don't need an explicit length if its implicit in the Vec below :).

TheBlueMatt · 2022-02-24T00:51:59Z

+ /// The hostname length
+ hostname_len: u8,
+ /// The dns hostname on which the node is listening, length hostname len 
+ hostname: Vec<u8>,


Probably just make this a String, no?

TheBlueMatt · 2022-02-24T00:52:27Z

 &NetAddress::IPv6 { .. } => { 18 },
 &NetAddress::OnionV2(_) => { 12 },
 &NetAddress::OnionV3 { .. } => { 37 },
+ &NetAddress::DNSHostname { .. } => { 258 }


This should return the real serialized length, using the length of the hostname itself.

a-mpch · 2022-03-22T00:18:12Z

@TheBlueMatt sorry the delay, I changed the comments.
Kinda learning rust with these. I hope looks better :)

TheBlueMatt · 2022-03-22T01:52:19Z

 port: u16,
 	},
+	DNSHostname {
+ /// The dns hostname on which the node is listening, length hostname len 


s/, length hostname len //?

TheBlueMatt · 2022-03-22T01:55:05Z

 }
+ &NetAddress::DNSHostname { ref hostname, ref port } => {
+ 5u8.write(writer)?;
+ hostname.write(writer)?;


The default String write writes a two-byte length, whereas we need one here. You'll need to manually write the string. That said, you may actually want to use a different type, given we're required to write out hostnames in ASCII, and the tight size length, we'll want to enforce that on users.

TheBlueMatt · 2022-03-22T01:55:08Z

+ 5 => {
+ Readable::read(reader)?;
+ Ok(Ok(NetAddress::DNSHostname {
+ hostname: Readable::read(reader)?,


We should enforce the ASCII-ness of the string here.

TheBlueMatt · 2022-04-20T20:31:33Z

Do you intend to revisit this @mauricepoirrier?

a-mpch · 2022-04-21T13:16:29Z

Do you intend to revisit this @mauricepoirrier?

Yes @TheBlueMatt. I was thinking on this weekend.

TheBlueMatt · 2022-05-24T21:35:48Z

Do you still intend to revisit this @mauricepoirrier?

a-mpch · 2022-05-25T12:31:44Z

@TheBlueMatt sorry, I haven't found the time. Should I close this?

TheBlueMatt · 2022-05-25T16:49:46Z

Up to you, you're welcome to leave it open if you think you'll get back to it, if you don't think you'll find the time feel free to close.

a-mpch · 2022-02-23T01:26:02Z

Support Bolt 7 DNS Hostnames Check lightning/bolts#911

I'm missing the test in this one if someone could guide me would be nice

Fixes#1313

TheBlueMatt

Thanks for taking a crack at this!

TheBlueMatt · 2022-02-24T00:51:49Z

 	},
+	DNSHostname {
+ /// The hostname length
+ hostname_len: u8,


You don't need an explicit length if its implicit in the Vec below :).

TheBlueMatt · 2022-02-24T00:51:59Z

+ /// The hostname length
+ hostname_len: u8,
+ /// The dns hostname on which the node is listening, length hostname len 
+ hostname: Vec<u8>,


Probably just make this a String, no?

TheBlueMatt · 2022-02-24T00:52:27Z

 &NetAddress::IPv6 { .. } => { 18 },
 &NetAddress::OnionV2(_) => { 12 },
 &NetAddress::OnionV3 { .. } => { 37 },
+ &NetAddress::DNSHostname { .. } => { 258 }


This should return the real serialized length, using the length of the hostname itself.

a-mpch · 2022-03-22T00:18:12Z

@TheBlueMatt sorry the delay, I changed the comments.
Kinda learning rust with these. I hope looks better :)

TheBlueMatt · 2022-03-22T01:52:19Z

 port: u16,
 	},
+	DNSHostname {
+ /// The dns hostname on which the node is listening, length hostname len 


s/, length hostname len //?

TheBlueMatt · 2022-03-22T01:55:05Z

 }
+ &NetAddress::DNSHostname { ref hostname, ref port } => {
+ 5u8.write(writer)?;
+ hostname.write(writer)?;


The default String write writes a two-byte length, whereas we need one here. You'll need to manually write the string. That said, you may actually want to use a different type, given we're required to write out hostnames in ASCII, and the tight size length, we'll want to enforce that on users.

TheBlueMatt · 2022-03-22T01:55:08Z

+ 5 => {
+ Readable::read(reader)?;
+ Ok(Ok(NetAddress::DNSHostname {
+ hostname: Readable::read(reader)?,


We should enforce the ASCII-ness of the string here.

TheBlueMatt · 2022-04-20T20:31:33Z

Do you intend to revisit this @mauricepoirrier?

a-mpch · 2022-04-21T13:16:29Z

Do you intend to revisit this @mauricepoirrier?

Yes @TheBlueMatt. I was thinking on this weekend.

TheBlueMatt · 2022-05-24T21:35:48Z

Do you still intend to revisit this @mauricepoirrier?

a-mpch · 2022-05-25T12:31:44Z

@TheBlueMatt sorry, I haven't found the time. Should I close this?

TheBlueMatt · 2022-05-25T16:49:46Z

Up to you, you're welcome to leave it open if you think you'll get back to it, if you don't think you'll find the time feel free to close.

a-mpch · 2022-02-23T01:26:02Z

Support Bolt 7 DNS Hostnames Check lightning/bolts#911

I'm missing the test in this one if someone could guide me would be nice

Fixes#1313

TheBlueMatt

Thanks for taking a crack at this!

TheBlueMatt · 2022-02-24T00:51:49Z

 	},
+	DNSHostname {
+ /// The hostname length
+ hostname_len: u8,


You don't need an explicit length if its implicit in the Vec below :).

TheBlueMatt · 2022-02-24T00:51:59Z

+ /// The hostname length
+ hostname_len: u8,
+ /// The dns hostname on which the node is listening, length hostname len 
+ hostname: Vec<u8>,


Probably just make this a String, no?

TheBlueMatt · 2022-02-24T00:52:27Z

 &NetAddress::IPv6 { .. } => { 18 },
 &NetAddress::OnionV2(_) => { 12 },
 &NetAddress::OnionV3 { .. } => { 37 },
+ &NetAddress::DNSHostname { .. } => { 258 }


This should return the real serialized length, using the length of the hostname itself.

a-mpch · 2022-03-22T00:18:12Z

@TheBlueMatt sorry the delay, I changed the comments.
Kinda learning rust with these. I hope looks better :)

TheBlueMatt · 2022-03-22T01:52:19Z

 port: u16,
 	},
+	DNSHostname {
+ /// The dns hostname on which the node is listening, length hostname len 


s/, length hostname len //?

TheBlueMatt · 2022-03-22T01:55:05Z

 }
+ &NetAddress::DNSHostname { ref hostname, ref port } => {
+ 5u8.write(writer)?;
+ hostname.write(writer)?;


The default String write writes a two-byte length, whereas we need one here. You'll need to manually write the string. That said, you may actually want to use a different type, given we're required to write out hostnames in ASCII, and the tight size length, we'll want to enforce that on users.

TheBlueMatt · 2022-03-22T01:55:08Z

+ 5 => {
+ Readable::read(reader)?;
+ Ok(Ok(NetAddress::DNSHostname {
+ hostname: Readable::read(reader)?,


We should enforce the ASCII-ness of the string here.

TheBlueMatt · 2022-04-20T20:31:33Z

Do you intend to revisit this @mauricepoirrier?

a-mpch · 2022-04-21T13:16:29Z

Do you intend to revisit this @mauricepoirrier?

Yes @TheBlueMatt. I was thinking on this weekend.

TheBlueMatt · 2022-05-24T21:35:48Z

Do you still intend to revisit this @mauricepoirrier?

a-mpch · 2022-05-25T12:31:44Z

@TheBlueMatt sorry, I haven't found the time. Should I close this?

TheBlueMatt · 2022-05-25T16:49:46Z

Up to you, you're welcome to leave it open if you think you'll get back to it, if you don't think you'll find the time feel free to close.

a-mpch · 2022-02-23T01:26:02Z

Support Bolt 7 DNS Hostnames Check lightning/bolts#911

I'm missing the test in this one if someone could guide me would be nice

Fixes#1313

TheBlueMatt

Thanks for taking a crack at this!

TheBlueMatt · 2022-02-24T00:51:49Z

 	},
+	DNSHostname {
+ /// The hostname length
+ hostname_len: u8,


You don't need an explicit length if its implicit in the Vec below :).

TheBlueMatt · 2022-02-24T00:51:59Z

+ /// The hostname length
+ hostname_len: u8,
+ /// The dns hostname on which the node is listening, length hostname len 
+ hostname: Vec<u8>,


Probably just make this a String, no?

TheBlueMatt · 2022-02-24T00:52:27Z

 &NetAddress::IPv6 { .. } => { 18 },
 &NetAddress::OnionV2(_) => { 12 },
 &NetAddress::OnionV3 { .. } => { 37 },
+ &NetAddress::DNSHostname { .. } => { 258 }


This should return the real serialized length, using the length of the hostname itself.

a-mpch · 2022-03-22T00:18:12Z

@TheBlueMatt sorry the delay, I changed the comments.
Kinda learning rust with these. I hope looks better :)

TheBlueMatt · 2022-03-22T01:52:19Z

 port: u16,
 	},
+	DNSHostname {
+ /// The dns hostname on which the node is listening, length hostname len 


s/, length hostname len //?

TheBlueMatt · 2022-03-22T01:55:05Z

 }
+ &NetAddress::DNSHostname { ref hostname, ref port } => {
+ 5u8.write(writer)?;
+ hostname.write(writer)?;


The default String write writes a two-byte length, whereas we need one here. You'll need to manually write the string. That said, you may actually want to use a different type, given we're required to write out hostnames in ASCII, and the tight size length, we'll want to enforce that on users.

TheBlueMatt · 2022-03-22T01:55:08Z

+ 5 => {
+ Readable::read(reader)?;
+ Ok(Ok(NetAddress::DNSHostname {
+ hostname: Readable::read(reader)?,


We should enforce the ASCII-ness of the string here.

TheBlueMatt · 2022-04-20T20:31:33Z

Do you intend to revisit this @mauricepoirrier?

a-mpch · 2022-04-21T13:16:29Z

Do you intend to revisit this @mauricepoirrier?

Yes @TheBlueMatt. I was thinking on this weekend.

TheBlueMatt · 2022-05-24T21:35:48Z

Do you still intend to revisit this @mauricepoirrier?

a-mpch · 2022-05-25T12:31:44Z

@TheBlueMatt sorry, I haven't found the time. Should I close this?

TheBlueMatt · 2022-05-25T16:49:46Z

Up to you, you're welcome to leave it open if you think you'll get back to it, if you don't think you'll find the time feel free to close.

a-mpch · 2022-02-23T01:26:02Z

Support Bolt 7 DNS Hostnames Check lightning/bolts#911

I'm missing the test in this one if someone could guide me would be nice

Fixes#1313

TheBlueMatt

Thanks for taking a crack at this!

TheBlueMatt · 2022-02-24T00:51:49Z

 	},
+	DNSHostname {
+ /// The hostname length
+ hostname_len: u8,


You don't need an explicit length if its implicit in the Vec below :).

TheBlueMatt · 2022-02-24T00:51:59Z

+ /// The hostname length
+ hostname_len: u8,
+ /// The dns hostname on which the node is listening, length hostname len 
+ hostname: Vec<u8>,


Probably just make this a String, no?

TheBlueMatt · 2022-02-24T00:52:27Z

 &NetAddress::IPv6 { .. } => { 18 },
 &NetAddress::OnionV2(_) => { 12 },
 &NetAddress::OnionV3 { .. } => { 37 },
+ &NetAddress::DNSHostname { .. } => { 258 }


This should return the real serialized length, using the length of the hostname itself.

a-mpch · 2022-03-22T00:18:12Z

@TheBlueMatt sorry the delay, I changed the comments.
Kinda learning rust with these. I hope looks better :)

TheBlueMatt · 2022-03-22T01:52:19Z

 port: u16,
 	},
+	DNSHostname {
+ /// The dns hostname on which the node is listening, length hostname len 


s/, length hostname len //?

TheBlueMatt · 2022-03-22T01:55:05Z

 }
+ &NetAddress::DNSHostname { ref hostname, ref port } => {
+ 5u8.write(writer)?;
+ hostname.write(writer)?;


The default String write writes a two-byte length, whereas we need one here. You'll need to manually write the string. That said, you may actually want to use a different type, given we're required to write out hostnames in ASCII, and the tight size length, we'll want to enforce that on users.

TheBlueMatt · 2022-03-22T01:55:08Z

+ 5 => {
+ Readable::read(reader)?;
+ Ok(Ok(NetAddress::DNSHostname {
+ hostname: Readable::read(reader)?,


We should enforce the ASCII-ness of the string here.

TheBlueMatt · 2022-04-20T20:31:33Z

Do you intend to revisit this @mauricepoirrier?

a-mpch · 2022-04-21T13:16:29Z

Do you intend to revisit this @mauricepoirrier?

Yes @TheBlueMatt. I was thinking on this weekend.

TheBlueMatt · 2022-05-24T21:35:48Z

Do you still intend to revisit this @mauricepoirrier?

a-mpch · 2022-05-25T12:31:44Z

@TheBlueMatt sorry, I haven't found the time. Should I close this?

TheBlueMatt · 2022-05-25T16:49:46Z

Up to you, you're welcome to leave it open if you think you'll get back to it, if you don't think you'll find the time feel free to close.

a-mpch · 2022-02-23T01:26:02Z

Support Bolt 7 DNS Hostnames Check lightning/bolts#911

I'm missing the test in this one if someone could guide me would be nice

Fixes#1313

TheBlueMatt

Thanks for taking a crack at this!

TheBlueMatt · 2022-02-24T00:51:49Z

 	},
+	DNSHostname {
+ /// The hostname length
+ hostname_len: u8,


You don't need an explicit length if its implicit in the Vec below :).

TheBlueMatt · 2022-02-24T00:51:59Z

+ /// The hostname length
+ hostname_len: u8,
+ /// The dns hostname on which the node is listening, length hostname len 
+ hostname: Vec<u8>,


Probably just make this a String, no?

TheBlueMatt · 2022-02-24T00:52:27Z

 &NetAddress::IPv6 { .. } => { 18 },
 &NetAddress::OnionV2(_) => { 12 },
 &NetAddress::OnionV3 { .. } => { 37 },
+ &NetAddress::DNSHostname { .. } => { 258 }


This should return the real serialized length, using the length of the hostname itself.

a-mpch · 2022-03-22T00:18:12Z

@TheBlueMatt sorry the delay, I changed the comments.
Kinda learning rust with these. I hope looks better :)

TheBlueMatt · 2022-03-22T01:52:19Z

 port: u16,
 	},
+	DNSHostname {
+ /// The dns hostname on which the node is listening, length hostname len 


s/, length hostname len //?

TheBlueMatt · 2022-03-22T01:55:05Z

 }
+ &NetAddress::DNSHostname { ref hostname, ref port } => {
+ 5u8.write(writer)?;
+ hostname.write(writer)?;


The default String write writes a two-byte length, whereas we need one here. You'll need to manually write the string. That said, you may actually want to use a different type, given we're required to write out hostnames in ASCII, and the tight size length, we'll want to enforce that on users.

TheBlueMatt · 2022-03-22T01:55:08Z

+ 5 => {
+ Readable::read(reader)?;
+ Ok(Ok(NetAddress::DNSHostname {
+ hostname: Readable::read(reader)?,


We should enforce the ASCII-ness of the string here.

TheBlueMatt · 2022-04-20T20:31:33Z

Do you intend to revisit this @mauricepoirrier?

a-mpch · 2022-04-21T13:16:29Z

Do you intend to revisit this @mauricepoirrier?

Yes @TheBlueMatt. I was thinking on this weekend.

TheBlueMatt · 2022-05-24T21:35:48Z

Do you still intend to revisit this @mauricepoirrier?

a-mpch · 2022-05-25T12:31:44Z

@TheBlueMatt sorry, I haven't found the time. Should I close this?

TheBlueMatt · 2022-05-25T16:49:46Z

Up to you, you're welcome to leave it open if you think you'll get back to it, if you don't think you'll find the time feel free to close.

a-mpch · 2022-02-23T01:26:02Z

Support Bolt 7 DNS Hostnames Check lightning/bolts#911

I'm missing the test in this one if someone could guide me would be nice

Fixes#1313

TheBlueMatt

Thanks for taking a crack at this!

TheBlueMatt · 2022-02-24T00:51:49Z

 	},
+	DNSHostname {
+ /// The hostname length
+ hostname_len: u8,


You don't need an explicit length if its implicit in the Vec below :).

TheBlueMatt · 2022-02-24T00:51:59Z

+ /// The hostname length
+ hostname_len: u8,
+ /// The dns hostname on which the node is listening, length hostname len 
+ hostname: Vec<u8>,


Probably just make this a String, no?

TheBlueMatt · 2022-02-24T00:52:27Z

 &NetAddress::IPv6 { .. } => { 18 },
 &NetAddress::OnionV2(_) => { 12 },
 &NetAddress::OnionV3 { .. } => { 37 },
+ &NetAddress::DNSHostname { .. } => { 258 }


This should return the real serialized length, using the length of the hostname itself.

a-mpch · 2022-03-22T00:18:12Z

@TheBlueMatt sorry the delay, I changed the comments.
Kinda learning rust with these. I hope looks better :)

TheBlueMatt · 2022-03-22T01:52:19Z

 port: u16,
 	},
+	DNSHostname {
+ /// The dns hostname on which the node is listening, length hostname len 


s/, length hostname len //?

TheBlueMatt · 2022-03-22T01:55:05Z

 }
+ &NetAddress::DNSHostname { ref hostname, ref port } => {
+ 5u8.write(writer)?;
+ hostname.write(writer)?;


The default String write writes a two-byte length, whereas we need one here. You'll need to manually write the string. That said, you may actually want to use a different type, given we're required to write out hostnames in ASCII, and the tight size length, we'll want to enforce that on users.

TheBlueMatt · 2022-03-22T01:55:08Z

+ 5 => {
+ Readable::read(reader)?;
+ Ok(Ok(NetAddress::DNSHostname {
+ hostname: Readable::read(reader)?,


We should enforce the ASCII-ness of the string here.

TheBlueMatt · 2022-04-20T20:31:33Z

Do you intend to revisit this @mauricepoirrier?

a-mpch · 2022-04-21T13:16:29Z

Do you intend to revisit this @mauricepoirrier?

Yes @TheBlueMatt. I was thinking on this weekend.

TheBlueMatt · 2022-05-24T21:35:48Z

Do you still intend to revisit this @mauricepoirrier?

a-mpch · 2022-05-25T12:31:44Z

@TheBlueMatt sorry, I haven't found the time. Should I close this?

TheBlueMatt · 2022-05-25T16:49:46Z

Up to you, you're welcome to leave it open if you think you'll get back to it, if you don't think you'll find the time feel free to close.

a-mpch · 2022-02-23T01:26:02Z

Support Bolt 7 DNS Hostnames Check lightning/bolts#911

I'm missing the test in this one if someone could guide me would be nice

Fixes#1313

TheBlueMatt

Thanks for taking a crack at this!

TheBlueMatt · 2022-02-24T00:51:49Z

 	},
+	DNSHostname {
+ /// The hostname length
+ hostname_len: u8,


You don't need an explicit length if its implicit in the Vec below :).

TheBlueMatt · 2022-02-24T00:51:59Z

+ /// The hostname length
+ hostname_len: u8,
+ /// The dns hostname on which the node is listening, length hostname len 
+ hostname: Vec<u8>,


Probably just make this a String, no?

TheBlueMatt · 2022-02-24T00:52:27Z

 &NetAddress::IPv6 { .. } => { 18 },
 &NetAddress::OnionV2(_) => { 12 },
 &NetAddress::OnionV3 { .. } => { 37 },
+ &NetAddress::DNSHostname { .. } => { 258 }


This should return the real serialized length, using the length of the hostname itself.

a-mpch · 2022-03-22T00:18:12Z

@TheBlueMatt sorry the delay, I changed the comments.
Kinda learning rust with these. I hope looks better :)

TheBlueMatt · 2022-03-22T01:52:19Z

 port: u16,
 	},
+	DNSHostname {
+ /// The dns hostname on which the node is listening, length hostname len 


s/, length hostname len //?

TheBlueMatt · 2022-03-22T01:55:05Z

 }
+ &NetAddress::DNSHostname { ref hostname, ref port } => {
+ 5u8.write(writer)?;
+ hostname.write(writer)?;


The default String write writes a two-byte length, whereas we need one here. You'll need to manually write the string. That said, you may actually want to use a different type, given we're required to write out hostnames in ASCII, and the tight size length, we'll want to enforce that on users.

TheBlueMatt · 2022-03-22T01:55:08Z

+ 5 => {
+ Readable::read(reader)?;
+ Ok(Ok(NetAddress::DNSHostname {
+ hostname: Readable::read(reader)?,


We should enforce the ASCII-ness of the string here.

TheBlueMatt · 2022-04-20T20:31:33Z

Do you intend to revisit this @mauricepoirrier?

a-mpch · 2022-04-21T13:16:29Z

Do you intend to revisit this @mauricepoirrier?

Yes @TheBlueMatt. I was thinking on this weekend.

TheBlueMatt · 2022-05-24T21:35:48Z

Do you still intend to revisit this @mauricepoirrier?

a-mpch · 2022-05-25T12:31:44Z

@TheBlueMatt sorry, I haven't found the time. Should I close this?

TheBlueMatt · 2022-05-25T16:49:46Z

Up to you, you're welcome to leave it open if you think you'll get back to it, if you don't think you'll find the time feel free to close.

a-mpch marked this pull request as draft February 23, 2022 01:27

m-schmoock mentioned this pull request Feb 23, 2022
bolt7: dns support ElementsProject/lightning#4829
Merged

TheBlueMatt reviewed Feb 24, 2022
View reviewed changes

m-schmoock mentioned this pull request Mar 7, 2022
dns: only allow one DNS announcement ElementsProject/lightning#4996
Merged

Add DNSHostname to NetAddress mssgs
b104ae5

a-mpch force-pushed the feat/addDNSHostname branch from 73b3a7a to b104ae5Compare March 22, 2022 00:17

TheBlueMatt reviewed Mar 22, 2022
View reviewed changes

remyers mentioned this pull request Apr 12, 2022
Support DNS hostnames in node announcements ACINQ/eclair#2234
Merged
3 tasks

a-mpch closed this Jul 5, 2022

a-mpch marked this pull request as draft February 23, 2022 01:27

m-schmoock mentioned this pull request Feb 23, 2022
bolt7: dns support ElementsProject/lightning#4829
Merged

TheBlueMatt reviewed Feb 24, 2022
View reviewed changes

m-schmoock mentioned this pull request Mar 7, 2022
dns: only allow one DNS announcement ElementsProject/lightning#4996
Merged

Add DNSHostname to NetAddress mssgs
b104ae5

a-mpch force-pushed the feat/addDNSHostname branch from 73b3a7a to b104ae5Compare March 22, 2022 00:17

TheBlueMatt reviewed Mar 22, 2022
View reviewed changes

remyers mentioned this pull request Apr 12, 2022
Support DNS hostnames in node announcements ACINQ/eclair#2234
Merged
3 tasks

a-mpch closed this Jul 5, 2022

a-mpch marked this pull request as draft February 23, 2022 01:27

m-schmoock mentioned this pull request Feb 23, 2022
bolt7: dns support ElementsProject/lightning#4829
Merged

TheBlueMatt reviewed Feb 24, 2022
View reviewed changes

m-schmoock mentioned this pull request Mar 7, 2022
dns: only allow one DNS announcement ElementsProject/lightning#4996
Merged

Add DNSHostname to NetAddress mssgs
b104ae5

a-mpch force-pushed the feat/addDNSHostname branch from 73b3a7a to b104ae5Compare March 22, 2022 00:17

TheBlueMatt reviewed Mar 22, 2022
View reviewed changes

remyers mentioned this pull request Apr 12, 2022
Support DNS hostnames in node announcements ACINQ/eclair#2234
Merged
3 tasks

a-mpch closed this Jul 5, 2022

a-mpch marked this pull request as draft February 23, 2022 01:27

m-schmoock mentioned this pull request Feb 23, 2022
bolt7: dns support ElementsProject/lightning#4829
Merged

TheBlueMatt reviewed Feb 24, 2022
View reviewed changes

m-schmoock mentioned this pull request Mar 7, 2022
dns: only allow one DNS announcement ElementsProject/lightning#4996
Merged

Add DNSHostname to NetAddress mssgs
b104ae5

a-mpch force-pushed the feat/addDNSHostname branch from 73b3a7a to b104ae5Compare March 22, 2022 00:17

TheBlueMatt reviewed Mar 22, 2022
View reviewed changes

remyers mentioned this pull request Apr 12, 2022
Support DNS hostnames in node announcements ACINQ/eclair#2234
Merged
3 tasks

a-mpch closed this Jul 5, 2022

a-mpch marked this pull request as draft February 23, 2022 01:27

m-schmoock mentioned this pull request Feb 23, 2022
bolt7: dns support ElementsProject/lightning#4829
Merged

TheBlueMatt reviewed Feb 24, 2022
View reviewed changes

m-schmoock mentioned this pull request Mar 7, 2022
dns: only allow one DNS announcement ElementsProject/lightning#4996
Merged

Add DNSHostname to NetAddress mssgs
b104ae5

a-mpch force-pushed the feat/addDNSHostname branch from 73b3a7a to b104ae5Compare March 22, 2022 00:17

TheBlueMatt reviewed Mar 22, 2022
View reviewed changes

remyers mentioned this pull request Apr 12, 2022
Support DNS hostnames in node announcements ACINQ/eclair#2234
Merged
3 tasks

a-mpch closed this Jul 5, 2022

a-mpch marked this pull request as draft February 23, 2022 01:27

m-schmoock mentioned this pull request Feb 23, 2022
bolt7: dns support ElementsProject/lightning#4829
Merged

TheBlueMatt reviewed Feb 24, 2022
View reviewed changes

m-schmoock mentioned this pull request Mar 7, 2022
dns: only allow one DNS announcement ElementsProject/lightning#4996
Merged

Add DNSHostname to NetAddress mssgs
b104ae5

a-mpch force-pushed the feat/addDNSHostname branch from 73b3a7a to b104ae5Compare March 22, 2022 00:17

TheBlueMatt reviewed Mar 22, 2022
View reviewed changes

remyers mentioned this pull request Apr 12, 2022
Support DNS hostnames in node announcements ACINQ/eclair#2234
Merged
3 tasks

a-mpch closed this Jul 5, 2022

a-mpch marked this pull request as draft February 23, 2022 01:27

m-schmoock mentioned this pull request Feb 23, 2022
bolt7: dns support ElementsProject/lightning#4829
Merged

TheBlueMatt reviewed Feb 24, 2022
View reviewed changes

m-schmoock mentioned this pull request Mar 7, 2022
dns: only allow one DNS announcement ElementsProject/lightning#4996
Merged

Add DNSHostname to NetAddress mssgs
b104ae5

a-mpch force-pushed the feat/addDNSHostname branch from 73b3a7a to b104ae5Compare March 22, 2022 00:17

TheBlueMatt reviewed Mar 22, 2022
View reviewed changes

remyers mentioned this pull request Apr 12, 2022
Support DNS hostnames in node announcements ACINQ/eclair#2234
Merged
3 tasks

a-mpch closed this Jul 5, 2022

a-mpch marked this pull request as draft February 23, 2022 01:27

m-schmoock mentioned this pull request Feb 23, 2022
bolt7: dns support ElementsProject/lightning#4829
Merged

TheBlueMatt reviewed Feb 24, 2022
View reviewed changes

m-schmoock mentioned this pull request Mar 7, 2022
dns: only allow one DNS announcement ElementsProject/lightning#4996
Merged

Add DNSHostname to NetAddress mssgs
b104ae5

a-mpch force-pushed the feat/addDNSHostname branch from 73b3a7a to b104ae5Compare March 22, 2022 00:17

TheBlueMatt reviewed Mar 22, 2022
View reviewed changes

remyers mentioned this pull request Apr 12, 2022
Support DNS hostnames in node announcements ACINQ/eclair#2234
Merged
3 tasks

a-mpch closed this Jul 5, 2022

Uh oh!

Conversation

a-mpch commented Feb 23, 2022

Uh oh!

TheBlueMatt left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

a-mpch commented Mar 22, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TheBlueMatt commented Apr 20, 2022

Uh oh!

a-mpch commented Apr 21, 2022

Uh oh!

TheBlueMatt commented May 24, 2022

Uh oh!

a-mpch commented May 25, 2022

Uh oh!

TheBlueMatt commented May 25, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

a-mpch commented Feb 23, 2022

Uh oh!

TheBlueMatt left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

a-mpch commented Mar 22, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TheBlueMatt commented Apr 20, 2022

Uh oh!

a-mpch commented Apr 21, 2022

Uh oh!

TheBlueMatt commented May 24, 2022

Uh oh!

a-mpch commented May 25, 2022

Uh oh!

TheBlueMatt commented May 25, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation