Faciliate Multibank Fitting

[briantoby]

Allow grouping of histograms in sequential fitting: combined fits or for TOF instruments that produce multiple histograms.

Needs a tool (in controls) to select groups histograms into groups and save them (nested list?). Then in sequential fit, iterate over groups of histograms. Need to think how to display results in sequential fit table.

[briantoby]

From discussion with @mguthriem: could group histograms by run number for ORNL. 1st step in this seems to be to creation of a structure that would link together related histograms (probably only of value for multi-bank TOF) and then have a command that builds the structure based on a string in the PWDR names.

Two other related things here, would be great to have:

• A composite plot with all histograms in a group. It would be crowded but would give a full view of a fit in a single plot.

• GUI that gives access in a single window to 1) profile terms (for calibration) and 2) HAP terms in user fits for all grouped histograms.

  Put everything in a single large grid? Perhaps a custom grid element that shows value, refinement flag, delta from start/default along with a custom element editor. Would want to make changes by column or perhaps by row.

[mguthriem]

Thanks for keeping track of these ideas. If I manage to get anywhere with my prototyping, I'll post updates here.

[briantoby]

Have code to create groups. Can't do anything with the groups yet.

[briantoby]

Now can plot grouped histograms:

[briantoby]

From Malcolm: would be useful to specify a "zoom" range (in Q/d) that would be applied to all histograms to look at fitting of specific peaks.

• could be a menu item (with another to reset); copy zoom range? Push change on Zoom stack?

After discussion: grouping the x-axes would allow the existing zoom/pan controls to allow one to zoom in on a group of peaks (provided plot is in d/Q)

• implement as "x" key (shared x-axis implemented as 3985cbe)
• Need to document the new plotting mode

[briantoby]

Things to do:

• setting/reseting grouped mode should cause a save & reload of .gpx file

• would like to do the same with Hist/Phase option

• "Show multiple" in instrument parameters -- can we have a control to set/clear all flags in row?
  (added to main in ed0deeb)

• with grouped histograms, create a Group entry in tree that has sub entries that display tables for selected parameters in a group

• Selecting any entry in the group should cause the grouped plot to be shown

Subentries to add under Group entry:

• instrument parameters (model on "show multiple", but selected by group)

• background

• limits

• HAP

• Sample params?

• N.B. each needs a command to copy to other groups in matrix fashion

[briantoby]

Issues from e-mails (1/7 & 1/8):

• Revisit x & y grouped scaling. At present there are two modes: individual x with a single adjustable y-axis scale (relative) & grouped x-axis where the y-axis is automatically adjusted to fit the portion of the data in the range (OK as is -- at least for now)

• add background subtraction as option for grouped plot

• Is there a better label/icon for Set & Clear buttons? (How about ☐ and ☑)

• Easy way to reset instrumental parameters. Add R button to instrument-delta (not working w/test dataset?)

• Easy way to change number of background terms?

• show shift/sigma as background color for parameters

• Have liveplot (during fit) remain as group plot [probably messy to code and slow] -- could turn off liveplot when in group mode. Note bugs below related to plotting after Group refinement.

• liveplot now requires selection of PWDR item or child of PWDR. Much cleaner way to go.

• Easy way to switch between single bank & grouped plot mode: click on histogram number to go to single plot. How to go back? Preserve zoom settings for group plot? -- perhaps plot single as modal

• cross-hair cursor

• Include other parameters into notebook and offer plotting -- moved to new issue (Refinement tracking improvements #288)

Bugs: (seen in RHEL Linux)

• In TOFgroup view, (w/shared-x) changing from to sample params to HAP, window is cleared but not updated (can group plot be updated after a fit?)

• don't want to try to get the group plot to be updated as a liveplot (updating each histogram would be pretty demanding), but now the group plot will not change during a fit, but should be updated after the fit is over

• Group HAP selection for 2nd (etc) phase not working -- display goes blank (probably same issue as above); N.B. selection of other tree item and return resets to 1st phase.
• wx Crash while clicking on phase tabs in HAP
• instrument-delta mode fails on Linux

• I wonder if the problem here was that there were no lines to display (all deviations were zero) -- now has msg

• When refining from phases with Group plot showing, the plot is not updated after the fit (likely it is deleted)

• group plot is now updated after a refinement

I could see a lot of the problems in MacOS once I tested with the same .gpx file, but all the bugs I saw have been addressed. Testing with RHEL did not show anything different