[PWGLF] added QC task for nuclei, moved nucleiUtils.h to the appropriate folder by GiorgioAlbertoLucia · Pull Request #13212 · AliceO2Group/O2Physics

GiorgioAlbertoLucia · 2025-10-02T16:08:22Z

nucleiQC.cxx is added for QC of nuclei and producing output tables upon request for studies of primary fractions (this will be used for the p-He3 analysis)
A small table is added for this reason to LFSlimNucleiTable.h
nucleiUtils.h is moved too the Utils folder, paths in tasks depending on this header file is updated accordingly
new utilities are added to nucleiUtils.h

…ion selection and histogram registry generator

github-actions · 2025-10-02T16:08:37Z

O2 linter results: ❌ 95 errors, ⚠️ 0 warnings, 🔕 0 disabled

Please consider the following formatting changes to AliceO2Group#13212

alibuild · 2025-10-03T07:48:54Z

Error while checking build/O2Physics/o2 for 1f13e26 at 2025-10-03 09:48:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/13212-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:233:5: error: 'base' in namespace 'o2' does not name a type
/sw/SOURCES/O2Physics/13212-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:289:73: error: 'o2::aod::evsel' has not been declared
/sw/SOURCES/O2Physics/13212-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:299:78: error: 'o2::aod::evsel' has not been declared
/sw/SOURCES/O2Physics/13212-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:304:82: error: 'o2::aod::evsel' has not been declared
/sw/SOURCES/O2Physics/13212-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:309:87: error: 'o2::aod::evsel' has not been declared
/sw/SOURCES/O2Physics/13212-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:314:87: error: 'o2::aod::evsel' has not been declared
/sw/SOURCES/O2Physics/13212-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:319:88: error: 'o2::aod::evsel' has not been declared
/sw/SOURCES/O2Physics/13212-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:551:12: error: 'ITSResponse' in namespace 'o2::aod' does not name a type
/sw/SOURCES/O2Physics/13212-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:473:12: error: 'mResponseITS' was not declared in this scope
/sw/SOURCES/O2Physics/13212-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:478:12: error: 'mResponseITS' was not declared in this scope
/sw/SOURCES/O2Physics/13212-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:486:16: error: 'mResponseITS' was not declared in this scope
/sw/SOURCES/O2Physics/13212-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:508:12: error: 'tpc' has not been declared
/sw/SOURCES/O2Physics/13212-slc9_x86-64/0/PWGLF/TableProducer/QC/nucleiQC.cxx:132:13: error: 'lut' is not a member of 'nuclei'
/sw/SOURCES/O2Physics/13212-slc9_x86-64/0/PWGLF/TableProducer/QC/nucleiQC.cxx:177:57: error: 'lut' is not a member of 'nuclei'
/sw/SOURCES/O2Physics/13212-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:492:92: error: value computed is not used [-Werror=unused-value]
/sw/SOURCES/O2Physics/13212-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:494:90: error: value computed is not used [-Werror=unused-value]
ninja: build stopped: subcommand failed.

Full log here.

Please consider the following formatting changes to AliceO2Group#13212

vkucera · 2025-10-03T16:35:11Z

@GiorgioAlbertoLucia @maciacco Please do not leave PRs which do not pass required checks as "ready for review".

GiorgioAlbertoLucia · 2025-10-03T16:56:41Z

Hi @vkucera, thank you for your comment. I think the change that made the PR formatting fail happened during the last alibuild merge and we were not expecting this behavior. We will be more cautious next time!

vkucera · 2025-10-05T13:17:11Z

@GiorgioAlbertoLucia @maciacco The new PWGLF/Utils/nucleiUtils.h header has 4 using directives, reported by the O2 linter. Please do not leave these issues unfixed.

…ate folder (AliceO2Group#13212) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>

vkucera · 2025-11-25T21:51:16Z

+using namespace o2;
+using namespace o2::framework;
+using namespace o2::framework::expressions;
+using namespace o2::constants::physics;


How about fixing these?

vkucera · 2026-03-06T22:56:11Z

+ {
+ constexpr int kIndex = iSpecies;
+ if (!nuclei::checkSpeciesValidity(kIndex)) {
+ std::runtime_error("species contains invalid nucleus kIndex");


Missing throw

vkucera · 2026-03-06T22:56:28Z

+ nuclei::SlimCandidate fillCandidate(const int iSpecies, Tcollision const& collision, Ttrack const& track)
+ {
+ if (!nuclei::checkSpeciesValidity(iSpecies)) {
+ std::runtime_error("species contains invalid nucleus index");


Missing throw

vkucera · 2026-03-06T22:56:33Z

+ {
+ constexpr int kIndex = iSpecies;
+ if (!nuclei::checkSpeciesValidity(kIndex)) {
+ std::runtime_error("species contains invalid nucleus kIndex");


Missing throw

vkucera · 2026-03-06T22:59:44Z

+
+ constexpr int index = iSpecies;
+ if (!checkSpeciesValidity(index)) {
+ std::runtime_error("species contains invalid nucleus index");


Missing throw.

vkucera · 2026-04-11T19:39:22Z

@GiorgioAlbertoLucia Your bugs are still unfixed.

vkucera · 2026-04-23T06:58:08Z

@GiorgioAlbertoLucia Still there.

GiorgioAlbertoLucia added 3 commits October 2, 2025 18:03

uploading nucleiQC, moving nucleiUtils.h and updating dependancies
eef7474

moved to the appropriate directory, added pid manager, central collis…
ea32ba0
…ion selection and histogram registry generator

added new qc task for nuclei, with tablefor dca studies
ac8847f

GiorgioAlbertoLucia requested review from abmodak, alibuild, dmallick2, ercolessi, fmazzasc, gbencedi, maciacco, mpuccio, romainschotter, skundu692 and smaff92 as code owners October 2, 2025 16:08

github-actionsBot added pwglf datamodel labels Oct 2, 2025

Please consider the following formatting changes
f436d6e

alibuild mentioned this pull request Oct 2, 2025
Please consider the following formatting changes to #13212 GiorgioAlbertoLucia/O2Physics#13
Merged

GiorgioAlbertoLucia added 2 commits October 2, 2025 18:10

Merge pull request#13from alibuild/alibot-cleanup-13212
ecb88fa
Please consider the following formatting changes to AliceO2Group#13212

MegaLinter fix
1f13e26

maciacco previously approved these changes Oct 2, 2025
View reviewed changes

fixed build errors spotted during the PR
e530ae8

GiorgioAlbertoLucia dismissed maciacco’s stale review via e530ae8October 3, 2025 08:02

Please consider the following formatting changes
3a5b78c

alibuild mentioned this pull request Oct 3, 2025
Please consider the following formatting changes to #13212 GiorgioAlbertoLucia/O2Physics#14
Merged

Merge pull request#14from alibuild/alibot-cleanup-13212
4c02153
Please consider the following formatting changes to AliceO2Group#13212

maciacco enabled auto-merge (squash) October 3, 2025 08:19

maciacco previously approved these changes Oct 3, 2025
View reviewed changes

fixed compilation errors spotted during PR
c0ee2c4

auto-merge was automatically disabled October 3, 2025 08:48
Head branch was pushed to by a user without write access

GiorgioAlbertoLucia dismissed maciacco’s stale review via c0ee2c4October 3, 2025 08:48

alibuild mentioned this pull request Oct 3, 2025
Please consider the following formatting changes to #13212 GiorgioAlbertoLucia/O2Physics#15
Closed

vkucera marked this pull request as draft October 3, 2025 16:34

clang format
60d9f7b

GiorgioAlbertoLucia marked this pull request as ready for review October 3, 2025 16:56

maciacco enabled auto-merge (squash) October 5, 2025 13:01

maciacco approved these changes Oct 5, 2025
View reviewed changes

maciacco merged commit 70cef59 into AliceO2Group:masterOct 5, 2025
12 of 13 checks passed

GiorgioAlbertoLucia deleted the nucleiqc branch October 5, 2025 14:17

jinhyunni pushed a commit to jinhyunni/O2Physics that referenced this pull request Oct 11, 2025
[PWGLF] added QC task for nuclei, moved nucleiUtils.h to the appropri…
84d1b5b
…ate folder (AliceO2Group#13212) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>

ArkaprabhaSaha001 pushed a commit to ArkaprabhaSaha001/O2Physics that referenced this pull request Oct 21, 2025
[PWGLF] added QC task for nuclei, moved nucleiUtils.h to the appropri…
33ccba5
…ate folder (AliceO2Group#13212) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>

ThePhDane pushed a commit to ThePhDane/O2Physics that referenced this pull request Nov 3, 2025
[PWGLF] added QC task for nuclei, moved nucleiUtils.h to the appropri…
6139101
…ate folder (AliceO2Group#13212) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>

jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
[PWGLF] added QC task for nuclei, moved nucleiUtils.h to the appropri…
c2f6fa3
…ate folder (AliceO2Group#13212) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>

vkucera reviewed Nov 25, 2025
View reviewed changes

vkucera reviewed Mar 6, 2026
View reviewed changes

Navigation Menu

Uh oh!

[PWGLF] added QC task for nuclei, moved nucleiUtils.h to the appropriate folder - #13212

[PWGLF] added QC task for nuclei, moved nucleiUtils.h to the appropriate folder#13212
maciacco merged 11 commits into
AliceO2Group:masterfrom
GiorgioAlbertoLucia:nucleiqc

GiorgioAlbertoLucia commented Oct 2, 2025

Uh oh!

github-actionsBot commented Oct 2, 2025•
edited
Loading

Uh oh!

alibuild commented Oct 3, 2025

Uh oh!

vkucera commented Oct 3, 2025

Uh oh!

GiorgioAlbertoLucia commented Oct 3, 2025

Uh oh!

Uh oh!

vkucera commented Oct 5, 2025

Uh oh!

vkuceraNov 25, 2025

Uh oh!

vkuceraMar 6, 2026

Uh oh!

vkuceraMar 6, 2026

Uh oh!

vkuceraMar 6, 2026

Uh oh!

vkuceraMar 6, 2026

Uh oh!

vkucera commented Apr 11, 2026

Uh oh!

vkucera commented Apr 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

GiorgioAlbertoLucia commented Oct 2, 2025

Uh oh!

github-actionsBot commented Oct 2, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alibuild commented Oct 3, 2025

Uh oh!

vkucera commented Oct 3, 2025

Uh oh!

GiorgioAlbertoLucia commented Oct 3, 2025

Uh oh!

Uh oh!

vkucera commented Oct 5, 2025

Uh oh!

vkuceraNov 25, 2025

Choose a reason for hiding this comment

Uh oh!

vkuceraMar 6, 2026

Choose a reason for hiding this comment

Uh oh!

vkuceraMar 6, 2026

Choose a reason for hiding this comment

Uh oh!

vkuceraMar 6, 2026

Choose a reason for hiding this comment

Uh oh!

vkuceraMar 6, 2026

Choose a reason for hiding this comment

Uh oh!

vkucera commented Apr 11, 2026

Uh oh!

vkucera commented Apr 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

github-actionsBot commented Oct 2, 2025•
edited
Loading