Skip to content

TrackSelectorPID, PWGHF: Remove dependencies on unnecessary tables - #3244

Merged
vkucera merged 40 commits into
AliceO2Group:masterfrom
vkucera:track-selector-pid
Aug 4, 2023
Merged

TrackSelectorPID, PWGHF: Remove dependencies on unnecessary tables#3244
vkucera merged 40 commits into
AliceO2Group:masterfrom
vkucera:track-selector-pid

Conversation

@vkucera

@vkuceravkucera commented Aug 1, 2023•
edited
Loading

Copy link
Copy Markdown
Collaborator

Removes subscriptions to unnecessary tables.

TrackSelectorPID class:

  • Template on single particle species (El, Mu, Pi, Ka, Pr).
  • Define type aliases for supported species (TrackSelectorEl,...).
  • Copying settings between objects of different types possible via templated copy operator.
  • Improve logic of getStatusTrackPID... functions.
  • Shorten names of functions and statuses.

PWGHF code:

  • Initialise selector objects in the init functions.
  • Remove unnecessary copies of selector objects.
  • Replace BigTracks... aliases with aliases for more granular joins with the Tracks table (TracksWCov, TracksWDca, TracksWCovDca,...).
  • Define aliases for TOF+TPC joins of PID tables for supported species (TracksPidEl,...).
  • Remove subscriptions to unnecessary tables.

vkucera added 30 commits July 24, 2023 18:03
@vkucera
Template on species flags
c25b67a
@vkucera
Complete constexpr. Add general fatal message. Define presets.
d892a7f
@vkucera
Remove default template argument values
a1fcaa9
@vkucera
Define PID tables for species
61112bc
@vkucera
Adjust types of selectors in selector tasks
460e7b1
@vkucera
Template on a single species
d9bfd12
@vkucera
Fix if else
aed2074
@vkucera
Move selector initialisation to init
cec8f4f
@vkucera
Fix more selectors and tasks
ea9e31c
@vkucera
Remove commented daughterSelection
a8852ae
@vkucera
Remove testing getter
bc9b18b
@vkucera
Simplify logic in getStatusTrackPID
69e0c95
@vkucera
Remove calls of Status
6635e74
@vkucera
Fix mini task
d551be6
@vkucera
Fix Bplus
049b3c9
@vkucera
Shorten Status names
2da49b2
@vkucera
Rename member and functions
ef5bfb7
@vkucera
Rename types
4b8439a
@vkucera
Update mini task subscriptions
e42dc96
@vkucera
Remove comments
a9d6e03
@vkucera
Specify explicit return type of status functions
1842c8e
@vkucera
Fix PID table subscriptions of selector tasks
039b2a7
@vkucera
Unify PID track aliases in selectors
44c7665
@vkucera
Reduce and fix subscriptions
2b99534
@vkucera
Remove BigTracksPIDExtended
73d11a5
@vkucera
Remove BigTracksPidPiKaPr
8305687
@vkucera
Remove BigTracksPID from selectors
0093120
@vkucera
Remove BigTracksPID completely
4e52242
@vkucera
Remove TracksPidAll
3429b7d
@vkucera
Undefine HFCAND_COLUMNS at the end of the header
ca22203
@vkucera
vkucera marked this pull request as draft August 3, 2023 05:34
@vkuceravkucera mentioned this pull request Aug 3, 2023
Merged
@vkucera
vkuceraforce-pushed the track-selector-pid branch from f9d0f89 to b76dbbeCompareAugust 3, 2023 10:06
@vkucera
vkucera marked this pull request as ready for review August 3, 2023 21:43
@vkucera

vkucera commented Aug 4, 2023

Copy link
Copy Markdown
CollaboratorAuthor

Hi @ddobrigk , this has been tested and is ready for merging now.

This was referenced Aug 4, 2023
Closed
Closed
Closed
ddobrigk
ddobrigk approved these changes Aug 4, 2023
View reviewed changes

@ddobrigkddobrigk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks ok far as as I can tell for the Common part, approving. Thanks @vkucera

@vkucera
vkucera enabled auto-merge (squash) August 4, 2023 11:05
alibuild
alibuild approved these changes Aug 4, 2023
View reviewed changes

@alibuildalibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @vkucera.

@vkucera
vkucera merged commit bb1726d into AliceO2Group:masterAug 4, 2023
@vkucera
vkucera deleted the track-selector-pid branch August 4, 2023 11:05
pstahlhu added a commit to pstahlhu/O2Physics that referenced this pull request Aug 4, 2023
@pstahlhu
Implement changes from PRAliceO2Group#3244
51c2687
pstahlhu added a commit to pstahlhu/O2Physics that referenced this pull request Aug 8, 2023
@pstahlhu
Implement changes from PRAliceO2Group#3244
5359c9d
hahassan7 pushed a commit to hahassan7/O2Physics that referenced this pull request Oct 6, 2023
@vkucera@alibuild@hahassan7
TrackSelectorPID, PWGHF: Remove dependencies on unnecessary tables (A…
56f1afa
…liceO2Group#3244)
* Template on species flags
* Complete constexpr. Add general fatal message. Define presets.
* Remove default template argument values
* Define PID tables for species
* Adjust types of selectors in selector tasks
* Template on a single species
* Fix if else
* Move selector initialisation to init
* Fix more selectors and tasks
* Remove commented daughterSelection
* Remove testing getter
* Simplify logic in getStatusTrackPID
* Remove calls of Status
* Fix mini task
* Fix Bplus
* Shorten Status names
* Rename member and functions
* Rename types
* Update mini task subscriptions
* Remove comments
* Specify explicit return type of status functions
* Fix PID table subscriptions of selector tasks
* Unify PID track aliases in selectors
* Reduce and fix subscriptions
* Remove BigTracksPIDExtended
* Remove BigTracksPidPiKaPr
* Remove BigTracksPID from selectors
* Remove BigTracksPID completely
* Remove TracksPidAll
* Undefine HFCAND_COLUMNS at the end of the header
* Remove BigTracksExtended
* Remove TracksExtra from BigTracks
* Remove TracksCov from BigTracks
* Remove BigTracks
* Rename BigTracksMC
* Move up
* Rename TracksPid
* Remove trivial aliases
* Please consider the following formatting changes (AliceO2Group#18)
---------
Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
hahassan7 pushed a commit to hahassan7/O2Physics that referenced this pull request Oct 7, 2023
@vkucera@alibuild@hahassan7
TrackSelectorPID, PWGHF: Remove dependencies on unnecessary tables (A…
38ded56
…liceO2Group#3244)
* Template on species flags
* Complete constexpr. Add general fatal message. Define presets.
* Remove default template argument values
* Define PID tables for species
* Adjust types of selectors in selector tasks
* Template on a single species
* Fix if else
* Move selector initialisation to init
* Fix more selectors and tasks
* Remove commented daughterSelection
* Remove testing getter
* Simplify logic in getStatusTrackPID
* Remove calls of Status
* Fix mini task
* Fix Bplus
* Shorten Status names
* Rename member and functions
* Rename types
* Update mini task subscriptions
* Remove comments
* Specify explicit return type of status functions
* Fix PID table subscriptions of selector tasks
* Unify PID track aliases in selectors
* Reduce and fix subscriptions
* Remove BigTracksPIDExtended
* Remove BigTracksPidPiKaPr
* Remove BigTracksPID from selectors
* Remove BigTracksPID completely
* Remove TracksPidAll
* Undefine HFCAND_COLUMNS at the end of the header
* Remove BigTracksExtended
* Remove TracksExtra from BigTracks
* Remove TracksCov from BigTracks
* Remove BigTracks
* Rename BigTracksMC
* Move up
* Rename TracksPid
* Remove trivial aliases
* Please consider the following formatting changes (AliceO2Group#18)
---------
Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
zconesa pushed a commit to zconesa/O2Physics that referenced this pull request Oct 27, 2023
@vkucera@alibuild@zconesa
TrackSelectorPID, PWGHF: Remove dependencies on unnecessary tables (A…
92e38f6
…liceO2Group#3244)
* Template on species flags
* Complete constexpr. Add general fatal message. Define presets.
* Remove default template argument values
* Define PID tables for species
* Adjust types of selectors in selector tasks
* Template on a single species
* Fix if else
* Move selector initialisation to init
* Fix more selectors and tasks
* Remove commented daughterSelection
* Remove testing getter
* Simplify logic in getStatusTrackPID
* Remove calls of Status
* Fix mini task
* Fix Bplus
* Shorten Status names
* Rename member and functions
* Rename types
* Update mini task subscriptions
* Remove comments
* Specify explicit return type of status functions
* Fix PID table subscriptions of selector tasks
* Unify PID track aliases in selectors
* Reduce and fix subscriptions
* Remove BigTracksPIDExtended
* Remove BigTracksPidPiKaPr
* Remove BigTracksPID from selectors
* Remove BigTracksPID completely
* Remove TracksPidAll
* Undefine HFCAND_COLUMNS at the end of the header
* Remove BigTracksExtended
* Remove TracksExtra from BigTracks
* Remove TracksCov from BigTracks
* Remove BigTracks
* Rename BigTracksMC
* Move up
* Rename TracksPid
* Remove trivial aliases
* Please consider the following formatting changes (AliceO2Group#18)
---------
Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
chengtt0406 pushed a commit to chengtt0406/O2Physics that referenced this pull request Dec 6, 2023
@vkucera@alibuild@chengtt0406
TrackSelectorPID, PWGHF: Remove dependencies on unnecessary tables (A…
ec42bf1
…liceO2Group#3244)
* Template on species flags
* Complete constexpr. Add general fatal message. Define presets.
* Remove default template argument values
* Define PID tables for species
* Adjust types of selectors in selector tasks
* Template on a single species
* Fix if else
* Move selector initialisation to init
* Fix more selectors and tasks
* Remove commented daughterSelection
* Remove testing getter
* Simplify logic in getStatusTrackPID
* Remove calls of Status
* Fix mini task
* Fix Bplus
* Shorten Status names
* Rename member and functions
* Rename types
* Update mini task subscriptions
* Remove comments
* Specify explicit return type of status functions
* Fix PID table subscriptions of selector tasks
* Unify PID track aliases in selectors
* Reduce and fix subscriptions
* Remove BigTracksPIDExtended
* Remove BigTracksPidPiKaPr
* Remove BigTracksPID from selectors
* Remove BigTracksPID completely
* Remove TracksPidAll
* Undefine HFCAND_COLUMNS at the end of the header
* Remove BigTracksExtended
* Remove TracksExtra from BigTracks
* Remove TracksCov from BigTracks
* Remove BigTracks
* Rename BigTracksMC
* Move up
* Rename TracksPid
* Remove trivial aliases
* Please consider the following formatting changes (AliceO2Group#18)
---------
Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alibuildalibuildalibuild approved these changes
@ddobrigkddobrigkddobrigk approved these changes
@fcolamarfcolamarAwaiting requested review from fcolamarfcolamar is a code owner
@adublaadublaAwaiting requested review from adubla
@mmazzillimmazzilliAwaiting requested review from mmazzillimmazzilli is a code owner
@deepathomsdeepathomsAwaiting requested review from deepathomsdeepathoms is a code owner
@fcatalan92fcatalan92Awaiting requested review from fcatalan92fcatalan92 is a code owner
@lvermuntlvermuntAwaiting requested review from lvermunt
@jgrosseojgrosseoAwaiting requested review from jgrosseojgrosseo is a code owner
@iarseneiarseneAwaiting requested review from iarseneiarsene is a code owner
@ktfktfAwaiting requested review from ktfktf is a code owner

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vkucera@alibuild@ddobrigk