Skip to content

PWGHF: Add Bs workflow - #3252

Merged
vkucera merged 9 commits into
AliceO2Group:masterfrom
pstahlhu:master
Aug 9, 2023
Merged

PWGHF: Add Bs workflow#3252
vkucera merged 9 commits into
AliceO2Group:masterfrom
pstahlhu:master

Conversation

@pstahlhu

@pstahlhupstahlhu commented Aug 2, 2023

Copy link
Copy Markdown
Contributor

First implementation of the Bs workflow @fcatalan92@fgrosa

pstahlhu added a commit to pstahlhu/O2Physics that referenced this pull request Aug 2, 2023
@pstahlhu
Merge pull request#1from alibuild/alibot-cleanup-3252
dff8df7
Please consider the following formatting changes to AliceO2Group#3252
@vkucera
vkucera marked this pull request as draft August 3, 2023 08:31
@vkucera

vkucera commented Aug 3, 2023•
edited
Loading

Copy link
Copy Markdown
Collaborator

Hi @pstahlhu , thanks for your contribution. I converted the PR to a draft for now, since some changes will be required after #3244 is merged, which should be done today.
Also please fix the errors first, so that the review can be done with a clean code.

@pstahlhu
pstahlhu marked this pull request as ready for review August 3, 2023 13:55
@vkucera
vkucera marked this pull request as draft August 3, 2023 15:15
@vkucera

vkucera commented Aug 3, 2023

Copy link
Copy Markdown
Collaborator

Please do not mark the PR as ready for review. As I mentioned, changes are required.

@pstahlhu
pstahlhu marked this pull request as ready for review August 4, 2023 14:08
fgrosa
fgrosa reviewed Aug 7, 2023
View reviewed changes

@fgrosafgrosa left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pstahlhu, thanks a lot for the work! I just have a couple of minor comments (see below).

Comment threadPWGHF/DataModel/CandidateSelectionTables.h Outdated
Comment threadPWGHF/TableProducer/candidateCreatorBs.cxx Outdated
fcatalan92
fcatalan92 reviewed Aug 7, 2023
View reviewed changes

@fcatalan92fcatalan92 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pstahlhu, thanks a lot for the very nice developments. I added some line-by-line comments/suggestions. Besides those, the PR looks good to me.

Comment threadPWGHF/Core/SelectorCuts.h Outdated
Comment threadPWGHF/DataModel/CandidateSelectionTables.h Outdated
Comment threadPWGHF/TableProducer/candidateCreatorBs.cxx Outdated
Comment threadPWGHF/TableProducer/candidateCreatorBs.cxx Outdated
Comment threadPWGHF/TableProducer/candidateCreatorBs.cxx Outdated
Comment threadPWGHF/TableProducer/candidateCreatorBs.cxx Outdated
Comment threadPWGHF/TableProducer/candidateSelectorBsToDsPi.cxx Outdated
Comment threadPWGHF/TableProducer/candidateSelectorBsToDsPi.cxx Outdated
Comment threadPWGHF/TableProducer/candidateSelectorBsToDsPi.cxx Outdated
Comment threadPWGHF/TableProducer/candidateSelectorBsToDsPi.cxx Outdated
vkucera
vkucera requested changes Aug 7, 2023
View reviewed changes
Comment threadPWGHF/TableProducer/CMakeLists.txt Outdated
Comment threadPWGHF/TableProducer/CMakeLists.txt Outdated
Comment threadPWGHF/TableProducer/candidateCreatorBs.cxx Outdated
Comment threadPWGHF/TableProducer/candidateCreatorBs.cxx Outdated
Comment threadPWGHF/DataModel/CandidateReconstructionTables.h Outdated
vkucera
vkucera reviewed Aug 8, 2023
View reviewed changes
Comment threadPWGHF/DataModel/CandidateReconstructionTables.h Outdated
vkucera
vkucera reviewed Aug 8, 2023
View reviewed changes
Comment threadPWGHF/D2H/Tasks/taskBs.cxx Outdated
fcatalan92
fcatalan92 approved these changes Aug 9, 2023
View reviewed changes

@fcatalan92fcatalan92 left a comment •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pstahlhu, thanks a lot for implementing the comments!
@vkucera This PR is ready to be merged for me

vkucera
vkucera approved these changes Aug 9, 2023
View reviewed changes

@vkuceravkucera left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pstahlhu for your contribution.
Thanks @fcatalan92@fgrosa for your reviews.

@vkucera
vkucera merged commit 0bf667f into AliceO2Group:masterAug 9, 2023
@pstahlhu

pstahlhu commented Aug 9, 2023

Copy link
Copy Markdown
ContributorAuthor

Thank you very much for your comments @vkucera@fcatalan92@fgrosa!

hahassan7 pushed a commit to hahassan7/O2Physics that referenced this pull request Oct 6, 2023
@pstahlhu@hahassan7
PWGHF: Add Bs workflow (AliceO2Group#3252)
ba951ab
hahassan7 pushed a commit to hahassan7/O2Physics that referenced this pull request Oct 7, 2023
@pstahlhu@hahassan7
PWGHF: Add Bs workflow (AliceO2Group#3252)
8b43abe
samrangy pushed a commit to samrangy/O2Physics that referenced this pull request Oct 11, 2023
@pstahlhu@samrangy
PWGHF: Add Bs workflow (AliceO2Group#3252)
f6fd1ec
zconesa pushed a commit to zconesa/O2Physics that referenced this pull request Oct 27, 2023
@pstahlhu@zconesa
PWGHF: Add Bs workflow (AliceO2Group#3252)
de5a954
chengtt0406 pushed a commit to chengtt0406/O2Physics that referenced this pull request Dec 6, 2023
@pstahlhu@chengtt0406
PWGHF: Add Bs workflow (AliceO2Group#3252)
7f78732
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fgrosafgrosafgrosa left review comments
@fcatalan92fcatalan92fcatalan92 approved these changes
@vkuceravkuceravkucera approved these changes
@alibuildalibuildAwaiting requested review from alibuildalibuild is a code owner
@fcolamarfcolamarAwaiting requested review from fcolamarfcolamar is a code owner
@adublaadublaAwaiting requested review from adubla
@lvermuntlvermuntAwaiting requested review from lvermunt

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pstahlhu@vkucera@fcatalan92@fgrosa