Uh oh!
There was an error while loading. Please reload this page.
PWGHF: Adding sliceby in HF flow task - #5342
Merged
vkucera merged 2 commits intoApr 10, 2024
Merged
Conversation
stefanopolitano
requested review from
NicoleBastid, alibuild, deepathoms, fcatalan92, fcolamar, fgrosa, mfaggin, mmazzilli, nzardosh and vkucera
as code ownersMarch 25, 2024 13:32
fgrosa
previously approved these changes
Mar 25, 2024
fgrosa
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @stefanopolitano! Informing also @Libeiyu
vkucera
commented
Mar 25, 2024
Collaborator
Thanks @stefanopolitano |
vkucera
requested changes
Mar 25, 2024
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
aalkin
reviewed
Mar 28, 2024
| std::vector<float> outputMl = {-999., -999.}; | ||
| if constexpr (std::is_same<T1, Partition<CandDsData>>::value || std::is_same<T1, Partition<CandDsDataWMl>>::value) { | ||
| if constexpr (std::is_same<T1, CandDsData>::value || std::is_same<T1, CandDsDataWMl>::value) { |
Member
There was a problem hiding this comment.
There is std::is_same_v<,> shortcut, so you do not need to add ::value.
stefanopolitanoforce-pushed
the
dev_spolitan_flow_d0
branch
from
April 8, 2024 09:28
f5e6bd6 to
aa17cd5Comparestefanopolitano
commented
Apr 8, 2024
CollaboratorAuthor
vkucera
commented
Apr 10, 2024
Collaborator
Please do not overwrite the PR history with force-push. |
vkucera
approved these changes
Apr 10, 2024
vkucera
commented
Apr 10, 2024
Collaborator
Otherwise looks good to me. Thanks @stefanopolitano |
christianreckziegel pushed a commit
to christianreckziegel/O2Physics
that referenced
this pull request
May 2, 2024
hahassan7 pushed a commit
to hahassan7/O2Physics
that referenced
this pull request
May 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the
sliceByin the taskFlowCharmHadrons.cxx as discussed in #5089