PWGHF: Adding D0 to taskFlowCharmHadrons, including Ml.

[wuctlby]

No description provided.

[fgrosa]

Hi @Libeiyu thanks a lot for the development! I have a few comments that have to be addressed before merging, see below

[fgrosa]

Hi @Libeiyu thanks a lot for implementing my comments! I just have two minor suggestions remaining, then for me it can be merged.
Also notifying @stefanopolitano that the enum for the centrality estimator has been modified.

[vkucera]

• runFlowAnalysis is called with a collision iterator and a partition as arguments but I don't see any slicing of the partition by the collision index.
• Also the second template argument of runFlowAnalysis should be deduced from the partition type but you are providing it explicitly.

[vkucera]

• runFlowAnalysis is called with a collision iterator and a partition as arguments but I don't see any slicing of the partition by the collision index.

• Also the second template argument of runFlowAnalysis should be deduced from the partition type but you are providing it explicitly.

You reacted with 👍🏻 but I don't see any related changes.

[vkucera]

@Libeiyu Sorry for a blunt question, but who are you? I cannot find anyone called Libeiyu in ALICE.

[wuctlby]

• runFlowAnalysis is called with a collision iterator and a partition as arguments but I don't see any slicing of the partition by the collision index.
• Also the second template argument of runFlowAnalysis should be deduced from the partition type but you are providing it explicitly.

You reacted with 👍🏻 but I don't see any related changes.

• For the first point, they should be already sliced since the collision and the d meson tables possess the global index.

• For the second point, I thought you were talking about the DecayChannel. I already added a new commit about this.

[wuctlby]

@Libeiyu Sorry for a blunt question, but who are you? I cannot find anyone called Libeiyu in ALICE.

Yes. "Libeiyu" is just a username, or online alias. My true name is Chuntai

[vkucera]

• runFlowAnalysis is called with a collision iterator and a partition as arguments but I don't see any slicing of the partition by the collision index.
• Also the second template argument of runFlowAnalysis should be deduced from the partition type but you are providing it explicitly.

You reacted with 👍🏻 but I don't see any related changes.

* For the first point, they should be already sliced since the collision and the d meson tables possess the global index.
* For the second point, I thought you were talking about the `DecayChannel`. I already added a new commit about this.

• Presence of global indices does not imply any slicing. You have to do it explicitly.
• I was talking about the second template argument, which is T1.

[vkucera]

@Libeiyu Sorry for a blunt question, but who are you? I cannot find anyone called Libeiyu in ALICE.

Yes. "Libeiyu" is just a username, or online alias. My true name is Chuntai

OK, so please update your GitHub profile to show your real name and add an \author line in the code documentation.

[stefanopolitano]

• runFlowAnalysis is called with a collision iterator and a partition as arguments but I don't see any slicing of the partition by the collision index.
• Also the second template argument of runFlowAnalysis should be deduced from the partition type but you are providing it explicitly.

You reacted with 👍🏻 but I don't see any related changes.

* For the first point, they should be already sliced since the collision and the d meson tables possess the global index.
* For the second point, I thought you were talking about the `DecayChannel`. I already added a new commit about this.

* Presence of global indices does not imply any slicing. You have to do it explicitly.
* I was talking about the _second_ template argument, which is `T1`.

Hi @vkucera ! Sorry for jumping in and thanks a lot for pointing this out. Indeed, as @Libeiyu said, I thought the iterator was sufficient to point to the "sliced" D mesons too. We will fix this by adding a preslice on the 2- and 3-prongs tables and a sliceby() in the process functions. However, I think this can be done in a different PR since it is a bit out of topic with respect to this one. What do you think?

[vkucera]

• runFlowAnalysis is called with a collision iterator and a partition as arguments but I don't see any slicing of the partition by the collision index.
• Also the second template argument of runFlowAnalysis should be deduced from the partition type but you are providing it explicitly.

You reacted with 👍🏻 but I don't see any related changes.

* For the first point, they should be already sliced since the collision and the d meson tables possess the global index.
* For the second point, I thought you were talking about the `DecayChannel`. I already added a new commit about this.

* Presence of global indices does not imply any slicing. You have to do it explicitly.
* I was talking about the _second_ template argument, which is `T1`.

Hi @vkucera ! Sorry for jumping in and thanks a lot for pointing this out. Indeed, as @Libeiyu said, I thought the iterator was sufficient to point to the "sliced" D mesons too. We will fix this by adding a preslice on the 2- and 3-prongs tables and a sliceby() in the process functions. However, I think this can be done in a different PR since it is a bit out of topic with respect to this one. What do you think?

Hi @stefanopolitano , fine with me, if you link this PR in the description of the new one that fixes the raised points.