Uh oh!
There was an error while loading. Please reload this page.
implementation of TuneOnData for MC in TPC PID - #5633
Conversation
jezwilkinson
commented
Apr 16, 2024
alibuild
commented
Apr 16, 2024
Error while checking build/O2Physics/o2 for 7a30be3 at 2024-04-16 13:16: Full log here. |
njacazio
commented
Apr 23, 2024
Hi, this looks good, shall we release it and enable a test wagon so that analysers can test it? |
wiechula
commented
Apr 23, 2024
Fine from my side. But I would not enable it by default. |
njacazio
commented
Apr 23, 2024
I fully agree |
njacazio
commented
Apr 24, 2024
Hi @jezwilkinson what do you think? Can we go ahead? |
Hi @njacazio ,
Indeed the process switch is defaulted to false (not least because the TuneOnData process loop requires subscription to MC info and so wouldn't work on real data). We can announce in the mattermost how to use it |
njacazio
commented
Apr 29, 2024
Hi, I propose that we add a debug wagon with the tune on data enabled. I will do this tomorrow with the new tag and test it |
jgrosseo
commented
May 2, 2024
@jezwilkinson@ddobrigk This PR introduced a problem: Now TPC full and TPC tiny produce both the same table which means on Hyperloop wagons which require full and wagons which require tiny cannot be combined into a train anymore. It should be removed from one of the two, and if that is not good, be moved to a separate executable... |
Indeed, for now we could split the two tables #5946 |
* implementation of TuneOnData in TPC PID * adding missing headers
* implementation of TuneOnData in TPC PID * adding missing headers

Original pull request for TuneOnData #4733 had diverged due to large conflicting changes made in #5563. This commit resolves the conflicts and re-implements the tuneondata option based on the new NN configurables (beta-gamma cutoff and per-species "useNetwork" flags).