Skip to content

[PID] Split tables for tiny and full tune on data - #5946

Merged
jgrosseo merged 3 commits into
AliceO2Group:masterfrom
njacazio:nj-pidtpctinyfull
May 2, 2024
Merged

[PID] Split tables for tiny and full tune on data#5946
jgrosseo merged 3 commits into
AliceO2Group:masterfrom
njacazio:nj-pidtpctinyfull

Conversation

@njacazio

Copy link
Copy Markdown
Collaborator

No description provided.

@njacazio
njacazio marked this pull request as draft May 2, 2024 09:28
@njacazio

Copy link
Copy Markdown
CollaboratorAuthor

@jezwilkinson we realized that now we cannot run anymore the full and tiny tables in the same workflow. This should fix it but it's not perfect. A solution would be to start merging the two workflow into one.
We can decide to rename the full table instead
What do you think?

@jezwilkinson

Copy link
Copy Markdown
Contributor

@njacazio This seems like a reasonable workaround to me (just for info what does the "Mark<1>" in the "tiny" table do?)
And yes, I think next goal will be to merge the executables to clean this situation up.

@njacazio

Copy link
Copy Markdown
CollaboratorAuthor

It allows to have the same table twice, I think otherwise the metadata will be the same and the compiler will complain that the table is defined twice

@njacazio
njacazio marked this pull request as ready for review May 2, 2024 10:33
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for dcd619e at 2024-05-02 13:17:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/5946-slc7_x86-64/0/Common/DataModel/PIDResponse.h:614:102: error: 'Mark' is not a member of 'o2::soa'; did you mean 'Marker'?
/sw/SOURCES/O2Physics/5946-slc7_x86-64/0/Common/DataModel/PIDResponse.h:614:108: error: template argument 2 is invalid
/sw/SOURCES/O2Physics/5946-slc7_x86-64/0/Common/DataModel/PIDResponse.h:614:1: error: '<expression error>' in namespace 'o2::soa' does not name a type
/sw/SOURCES/O2Physics/5946-slc7_x86-64/0/Common/DataModel/PIDResponse.h:614:19: error: 'mcTPCTuneOnDataTiny' does not name a type; did you mean 'mcTPCTuneOnData'?
/sw/SOURCES/O2Physics/5946-slc7_x86-64/0/Common/DataModel/PIDResponse.h:614:47: error: initializer-string for 'const char [16]' is too long [-fpermissive]
/sw/SOURCES/O2Physics/5946-slc7_x86-64/0/Common/DataModel/PIDResponse.h:614:19: error: 'mcTPCTuneOnDataTiny' was not declared in this scope; did you mean 'mcTPCTuneOnData'?
/sw/SOURCES/O2Physics/5946-slc7_x86-64/0/Common/DataModel/PIDResponse.h:614:1: error: template argument 1 is invalid
/sw/SOURCES/O2Physics/5946-slc7_x86-64/0/Common/DataModel/PIDResponse.h:614:19: error: 'mcTPCTuneOnDataTiny' was not declared in this scope; did you mean 'mcTPCTuneOnData'?
/sw/SOURCES/O2Physics/5946-slc7_x86-64/0/Common/DataModel/PIDResponse.h:614:1: error: template argument 1 is invalid
/sw/SOURCES/O2Physics/5946-slc7_x86-64/0/Common/DataModel/PIDResponse.h:614:102: error: 'Mark' is not a member of 'o2::soa'; did you mean 'Marker'?
/sw/SOURCES/O2Physics/5946-slc7_x86-64/0/Common/DataModel/PIDResponse.h:614:108: error: template argument 2 is invalid
/sw/SOURCES/O2Physics/5946-slc7_x86-64/0/Common/DataModel/PIDResponse.h:614:1: error: '<expression error>' in namespace 'o2::soa' does not name a type
/sw/SOURCES/O2Physics/5946-slc7_x86-64/0/Common/DataModel/PIDResponse.h:614:19: error: 'mcTPCTuneOnDataTiny' does not name a type; did you mean 'mcTPCTuneOnData'?
/sw/SOURCES/O2Physics/5946-slc7_x86-64/0/Common/DataModel/PIDResponse.h:614:47: error: initializer-string for 'const char [16]' is too long [-fpermissive]
/sw/SOURCES/O2Physics/5946-slc7_x86-64/0/Common/DataModel/PIDResponse.h:614:19: error: 'mcTPCTuneOnDataTiny' was not declared in this scope; did you mean 'mcTPCTuneOnData'?
/sw/SOURCES/O2Physics/5946-slc7_x86-64/0/Common/DataModel/PIDResponse.h:614:1: error: template argument 1 is invalid
/sw/SOURCES/O2Physics/5946-slc7_x86-64/0/Common/DataModel/PIDResponse.h:614:19: error: 'mcTPCTuneOnDataTiny' was not declared in this scope; did you mean 'mcTPCTuneOnData'?
/sw/SOURCES/O2Physics/5946-slc7_x86-64/0/Common/DataModel/PIDResponse.h:614:1: error: template argument 1 is invalid
ninja: build stopped: subcommand failed.

Full log here.

Comment threadCommon/DataModel/PIDResponse.h Outdated
jgrosseo
jgrosseo previously approved these changes May 2, 2024
@jgrosseo
jgrosseo enabled auto-merge (squash) May 2, 2024 15:16
@jgrosseo

Copy link
Copy Markdown
Contributor

@njacazio This seems like a reasonable workaround to me (just for info what does the "Mark<1>" in the "tiny" table do?) And yes, I think next goal will be to merge the executables to clean this situation up.

And it is called Marker :-D

@njacazio

Copy link
Copy Markdown
CollaboratorAuthor

Thanks @jgrosseo !

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for f3021b4 at 2024-05-02 20:01:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/5946-slc7_x86-64/0/Common/DataModel/PIDResponse.h:614:47: error: initializer-string for 'const char [16]' is too long [-fpermissive]
/sw/SOURCES/O2Physics/5946-slc7_x86-64/0/Common/DataModel/PIDResponse.h:614:47: error: initializer-string for 'const char [16]' is too long [-fpermissive]
ninja: build stopped: subcommand failed.

Full log here.

@jgrosseo
jgrosseo merged commit fb6992d into AliceO2Group:masterMay 2, 2024
@njacazio
njacazio deleted the nj-pidtpctinyfull branch May 3, 2024 07:38
christianreckziegel pushed a commit to christianreckziegel/O2Physics that referenced this pull request May 7, 2024
hahassan7 pushed a commit to hahassan7/O2Physics that referenced this pull request May 17, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@njacazio@jezwilkinson@alibuild@jgrosseo@ddobrigk