Uh oh!
There was an error while loading. Please reload this page.
[Event plane] add vectors columns for multiple event planes - #6577
Conversation
Please consider the following formatting changes to AliceO2Group#6577
strogolo
commented
Jun 18, 2024
Dear @jikim1290, |
jikim1290
commented
Jun 18, 2024
@strogolo This PR is what we discussed in the previous AOT meeting and I locally tested this. I was thinking these proposals were accepted in the meeting if I remember correctly. |
ddobrigk
commented
Jun 18, 2024
@jikim1290 please clarify @strogolo's point before doing the (auto-)merge. Thanks! |
strogolo
commented
Jun 18, 2024
@jikim1290 yes the modification was fine but we agreed on having a test and a report of this test. We need to be sure that what you are asking to include in this code is not creating troubles or reducing the performances of other analysers, that's why asked you a test on a reasonable sample and report on the performance. |
jikim1290
commented
Jun 18, 2024
@strogolo Do you want me to close this first and come back with local test results? I can run the task for 5k events in my local |
strogolo
commented
Jun 18, 2024
@jikim1290 there is no need to close the PR, you can move it to "draft mode", do the test and once we see that the test is satisfactory we can agree to move it back for approval. |
Please consider the following formatting changes to AliceO2Group#6577
@strogolo The results on the event plane determination and CPU usage obtained from the local test were shared with you so could you please approve this? |
…roup#6577) * add vectors for multiple event plane * add vectors for multiple event plane * fix * fix * Please consider the following formatting changes --------- Co-authored-by: junleekim <junleekim@maccbookjunlee2024.dyndns.cern.ch> Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
…roup#6577) * add vectors for multiple event plane * add vectors for multiple event plane * fix * fix * Please consider the following formatting changes --------- Co-authored-by: junleekim <junleekim@maccbookjunlee2024.dyndns.cern.ch> Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
…roup#6577) * add vectors for multiple event plane * add vectors for multiple event plane * fix * fix * Please consider the following formatting changes --------- Co-authored-by: junleekim <junleekim@maccbookjunlee2024.dyndns.cern.ch> Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
add vectors columns for multiple event planes
Q-vector from TPC full tracks