Uh oh!
There was an error while loading. Please reload this page.
Common/TableProducer/qVectorTable.cxx: bug fix to support vector of Qvector - #6666
Merged
Conversation
dsekihat
requested review from
a team, alibuild, ddobrigk, iarsene, jgrosseo and ktf
as code ownersJune 26, 2024 22:02
dsekihat
commented
Jun 26, 2024
CollaboratorAuthor
Dear @ddobrigk , @strogolo , @jikim1290 , could you check this PR, please? Thank you. |
jikim1290
commented
Jun 27, 2024
Contributor
@dsekihat Thank you for spotting this. It is indeed needed to call QvecXXX and QvecXXXVecs at the same time. |
ddobrigk
approved these changes
Jun 27, 2024
GiorgioAlbertoLucia pushed a commit
to GiorgioAlbertoLucia/O2Physics
that referenced
this pull request
Jul 9, 2024
echizzal pushed a commit
to echizzal/O2Physics
that referenced
this pull request
Jul 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to support vector of Qvector (#6577). In the previous version, only aod::QvectorXXXXs (FT0C, etc) or aod::Qvectors were accepted by comparing string. But, aod::QvectorXXXXVecs were not supported, and q vectors were -999.
In addition, suppress warning about comparison between int and size_t.