Skip to content

[PWGHF,Trigger] Beauty 2nd Vertex in triggers - #8895

Merged
fgrosa merged 5 commits into
AliceO2Group:masterfrom
apalasciano:bplus
Dec 13, 2024
Merged

[PWGHF,Trigger] Beauty 2nd Vertex in triggers#8895
fgrosa merged 5 commits into
AliceO2Group:masterfrom
apalasciano:bplus

Conversation

@apalasciano

@apalascianoapalasciano commented Dec 10, 2024

Copy link
Copy Markdown
Collaborator

Hi @fgrosa , @zhangbiao-phy ,
This is the first draft for reconstructing secondary vertices in triggers.
This PR is for testing the B+(->D0).
Selections (CPA, DecLength, ImpactParameterProduct) are implemented for beauty candidates.

@apalasciano
apalasciano marked this pull request as draft December 10, 2024 10:19
@github-actionsgithub-actionsBot changed the title [Trigger][PWGHF] Beauty 2nd Vertex in triggers[PWGHF,Trigger] [Trigger][PWGHF] Beauty 2nd Vertex in triggersDec 10, 2024
@apalascianoapalasciano changed the title [PWGHF,Trigger] [Trigger][PWGHF] Beauty 2nd Vertex in triggers[PWGHF,Trigger] Beauty 2nd Vertex in triggersDec 10, 2024
@zhangbiao-phy

zhangbiao-phy commented Dec 10, 2024•
edited
Loading

Copy link
Copy Markdown
Collaborator

Hi @fgrosa , @zhangbiao-phy , This is the first draft for reconstructing secondary vertices in triggers. This PR is for testing the B+(->D0). Selections (CPA, DecLength, ImpactParameterProduct) are implemented for beauty candidates.

Hi @apalasciano, Thanks a lot for the very important implementation! All looks good to me! let's see if fabrizio has comments or suggestions on this.

fgrosa
fgrosa requested changes Dec 11, 2024
View reviewed changes

@fgrosafgrosa left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ciao @apalasciano many thanks!
The main features are there, but I would suggest a few changes (see comments below)

Comment threadEventFiltering/PWGHF/HFFilter.cxx Outdated
Comment threadEventFiltering/PWGHF/HFFilter.cxx Outdated
Comment threadEventFiltering/PWGHF/HFFilter.cxx Outdated
Comment threadEventFiltering/PWGHF/HFFilter.cxx Outdated
Comment threadEventFiltering/PWGHF/HFFilter.cxx Outdated
Comment threadEventFiltering/PWGHF/HFFilter.cxx Outdated
@zhangbiao-phyzhangbiao-phy mentioned this pull request Dec 11, 2024
Merged
@alibuildalibuild mentioned this pull request Dec 11, 2024
Closed
fgrosa
fgrosa requested changes Dec 12, 2024
View reviewed changes

@fgrosafgrosa left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @apalasciano thanks for considering my comments, I just have one remaining (in any case you can mark the PR ready for review)

Comment threadEventFiltering/PWGHF/HFFilterHelpers.h Outdated
@apalasciano
apalasciano marked this pull request as ready for review December 12, 2024 18:04
@fgrosa
fgrosa merged commit c24e71c into AliceO2Group:masterDec 13, 2024
@apalasciano
apalasciano deleted the bplus branch December 13, 2024 14:12
hernasab pushed a commit to hernasab/O2Physics that referenced this pull request Dec 20, 2024
@apalascianoSabrina Hernandez
[PWGHF,Trigger] Beauty 2nd Vertex in triggers (AliceO2Group#8895)
f54c9af
feisenhu pushed a commit to feisenhu/O2Physics that referenced this pull request Jan 8, 2025
@apalasciano@feisenhu
[PWGHF,Trigger] Beauty 2nd Vertex in triggers (AliceO2Group#8895)
ed97c95
smaff92 pushed a commit to smaff92/O2Physics that referenced this pull request Feb 17, 2025
@apalasciano@smaff92
[PWGHF,Trigger] Beauty 2nd Vertex in triggers (AliceO2Group#8895)
59b3ba0
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fgrosafgrosafgrosa approved these changes
@alibuildalibuildAwaiting requested review from alibuildalibuild is a code owner
@zhangbiao-phyzhangbiao-phyAwaiting requested review from zhangbiao-phyzhangbiao-phy is a code owner
@mpucciompuccioAwaiting requested review from mpucciompuccio is a code owner
@lietavalietavaAwaiting requested review from lietavalietava is a code owner

Assignees

No one assigned

Labels

pwghfPWG-HFtrigger

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@apalasciano@zhangbiao-phy@fgrosa