Skip to content

[PWGHF,Trigger] Add de-Lc femto trigger channel into the HFFilter task - #8937

Merged
zhangbiao-phy merged 20 commits into
AliceO2Group:masterfrom
zhangbiao-phy:lc-de_femto_trigger_dev
Dec 15, 2024
Merged

[PWGHF,Trigger] Add de-Lc femto trigger channel into the HFFilter task#8937
zhangbiao-phy merged 20 commits into
AliceO2Group:masterfrom
zhangbiao-phy:lc-de_femto_trigger_dev

Conversation

@zhangbiao-phy

@zhangbiao-phyzhangbiao-phy commented Dec 11, 2024

Copy link
Copy Markdown
Collaborator
  • Add deuteron case for the Femto selected track
  • Add deuteron pid case for the TPC post-calibration even we don't use it anymore

@github-actionsgithub-actionsBot changed the title [PWGHF, Trigger] Add de-Lc femto trigger channel into the HFFilter task[PWGHF,Trigger] Add de-Lc femto trigger channel into the HFFilter taskDec 11, 2024
@zhangbiao-phy

zhangbiao-phy commented Dec 11, 2024

Copy link
Copy Markdown
CollaboratorAuthor

hi @fgrosa, here is the PR for the de-Lc femto. This pr should be merged behind 8895. I will rebase and fix conflicts (if needed). Let me know if you have any comments and suggestions, Thanks a lot!

@alibuildalibuild mentioned this pull request Dec 12, 2024
Merged
fgrosa
fgrosa requested changes Dec 12, 2024
View reviewed changes

@fgrosafgrosa left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @zhangbiao-phy, thanks a lot! I agree to wait for @apalasciano PR before merging this one. I have anyway a couple of comments about the deuteron selection (see below). Good that you adapted the code for possible recalibrations, even if we do not use them it's good to have the possibility to apply them.

Comment threadEventFiltering/PWGHF/HFFilterHelpers.h Outdated
Comment threadEventFiltering/PWGHF/HFFilterHelpers.h Outdated
Comment threadEventFiltering/PWGHF/HFFilterHelpers.h Outdated
Comment threadEventFiltering/PWGHF/HFFilterHelpers.h Outdated
zhangbiao-phyand others added 2 commits December 13, 2024 11:33
@zhangbiao-phy@fgrosa
Update EventFiltering/PWGHF/HFFilterHelpers.h
52ae9f1
Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch>
@zhangbiao-phy@fgrosa
Update EventFiltering/PWGHF/HFFilterHelpers.h
f11271c
Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch>
@alibuildalibuild mentioned this pull request Dec 13, 2024
Merged
@zhangbiao-phy
zhangbiao-phy marked this pull request as ready for review December 13, 2024 14:31
fgrosa
fgrosa requested changes Dec 13, 2024
View reviewed changes

@fgrosafgrosa left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ciao @zhangbiao-phy thanks, I just have a remaining minor comment, then we can merge it I would say

Comment threadEventFiltering/PWGHF/HFFilterHelpers.h Outdated
Comment threadEventFiltering/PWGHF/HFFilterHelpers.h Outdated
@alibuildalibuild mentioned this pull request Dec 13, 2024
Merged
@zhangbiao-phy
Merge pull request#17from alibuild/alibot-cleanup-8937
2f44bc7
Please consider the following formatting changes to AliceO2Group#8937
@zhangbiao-phy
zhangbiao-phy enabled auto-merge (squash) December 13, 2024 19:54
alibuild
alibuild approved these changes Dec 13, 2024
View reviewed changes

@alibuildalibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @zhangbiao-phy.

@zhangbiao-phy
zhangbiao-phy merged commit 427e25c into AliceO2Group:masterDec 15, 2024
hernasab pushed a commit to hernasab/O2Physics that referenced this pull request Dec 20, 2024
@zhangbiao-phy@alibuild
@fgrosaSabrina Hernandez
[PWGHF,Trigger] Add de-Lc femto trigger channel into the HFFilter task (
c5554ce
AliceO2Group#8937)
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch>
feisenhu pushed a commit to feisenhu/O2Physics that referenced this pull request Jan 8, 2025
@zhangbiao-phy@alibuild
@fgrosa@feisenhu
[PWGHF,Trigger] Add de-Lc femto trigger channel into the HFFilter task (
7c9cc12
AliceO2Group#8937)
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch>
smaff92 pushed a commit to smaff92/O2Physics that referenced this pull request Feb 17, 2025
@zhangbiao-phy@alibuild
@fgrosa@smaff92
[PWGHF,Trigger] Add de-Lc femto trigger channel into the HFFilter task (
b1660d1
AliceO2Group#8937)
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch>
@zhangbiao-phy
zhangbiao-phy deleted the lc-de_femto_trigger_dev branch July 28, 2025 16:18
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alibuildalibuildalibuild approved these changes
@fgrosafgrosafgrosa approved these changes
@mpucciompuccioAwaiting requested review from mpucciompuccio is a code owner
@lietavalietavaAwaiting requested review from lietavalietava is a code owner

Assignees

No one assigned

Labels

pwghfPWG-HFtrigger

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zhangbiao-phy@alibuild@fgrosa