Add JE validation by Archita-Dash · Pull Request #424 · AliceO2Group/Run3AnalysisValidation

Archita-Dash · 2023-10-25T07:57:09Z

Hi @vkucera @nzardosh . This PR does the following:

creates a separate codeJE directory that will be used to run the jet validation framework between AliPhysics and O2Physics
within the codeJE,

the input data configuration in config_input.sh and also the JE analysis task configurations in config_tasks.sh
the rest of the JE workflow configurations namely the analysis task dependencies are to be found inside the workflow database workflows.yml
Run 3 jet parameters are contained within the dpl-config.json file

the whole jet validation machinery is launched by running bash runtest.sh .
(runtest.sh is symlinked in codeJE)

vkucera · 2023-10-25T08:33:37Z

Hi @Archita-Dash , thanks for the nice contribution.

Please try to fix the errors related to your files. (I can fix the missing header guard in plot utils.)
Fix the missing workflows in the yaml database.
Make sure it can run on (Run 2, Run 3) * (real data, MC data).
Remove unnecessary lines that are commented out and not expected to be used in future.
Organise the code structure in the same way as in HF (e.g. blocks in config_tasks.sh, order of workflows in workflows.yml.

vkucera

Thanks @Archita-Dash , there are some problems that need to be fixed before merging. Please see my comments.

* MegaLinter run on pull_request_target * Try the merge commit * Checkout the right merge commit * Fix MegaLinter issues * Tmp * Update config for PR fixes on push * Test markdown fixes * Change permissions * Write all * Write * Write all * Fix permissions and improve PR config * Report formatter errors * Exit with error when fixes needed * Update Megalinter (AliceO2Group#420) * Update code owners (AliceO2Group#421) * Add configuration for HF jets (AliceO2Group#422) * Add first version of HF jet finding and matching * Fix bugs and improve task logic * adding jets to Run 3 Validation adding hf-jets pre-rebase commit adding HF-jet comparisons intermdeiate Adding Jets to the HF framework * adding tree output for HF substructure task * Fix configuration for jets * Rename jet variables * Move jets to a separate group * Simplify jet options * Fix jet finders * Fix jet matching * Fix jet substructure * Fix jet substructure output * Organise jet workflows * Add matching tables * Only warn for duplicate workflows * Set process function switches for jet substructure * Move jet json block * Add configuration for jet substructure output * Add jet finder QA * Fix workflow suffixes * Move correlation json block * Fix workflow suffixes * Restore default settings * [MegaLinter] Apply linters automatic fixes (#11) Co-authored-by: vkucera <vkucera@users.noreply.github.com> --------- Co-authored-by: Jochen Klein <jochen.klein@cern.ch> Co-authored-by: Nima Zardoshti <nzardosh@alicecerno2.cern.ch> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: vkucera <vkucera@users.noreply.github.com> * Add KFParticle to D0 creator (AliceO2Group#423) * HF: Add hf-tree-creator-lc-to-k0s-p (AliceO2Group#418) * Add tracks-extra-converter, update D0 selector config (AliceO2Group#426) * New MCs in config_input (AliceO2Group#429) * Add JE validation (AliceO2Group#424) * Update skimming configuration (AliceO2Group#432) * Update configurables and workflow (AliceO2Group#430) * Update and sync HF and JE configuration (AliceO2Group#433) * Refactor validation code (AliceO2Group#431) * Refactor utilities * Add copyright. Add tuple header. Fix path. * Add header guards * Move compare.py * Factor out plotting part of validation * Fix plotting factorisation * Factor out MakePlots into a header file. * Fix casting * Break line * Rename headers * Fix header guards * Improve logging * Improve legends in validation plots * Fix JE validation plots and factor out code * Remove link to utils_plot.h * Improve y-range calculation and plotting, add protections * Improve AliPhysics task macros * Add documentation comments in AliPhysics macros * Adjust validation legend (AliceO2Group#434) * codeJE: Add event histo and disable sel7 event selection (AliceO2Group#435) * Add configurables for proton PID in skimming (AliceO2Group#437) * renamed VtxZ histogram (AliceO2Group#436) * Removing HFPlot dependency from the hf_ptspectrum macro (AliceO2Group#438) * codeJE - update workflow (AliceO2Group#440) * Bump black from 19.10b0 to 24.3.0 in /codeQA/o2qaplots (AliceO2Group#442) Bumps [black](https://github.com/psf/black) from 19.10b0 to 24.3.0. - [Release notes](https://github.com/psf/black/releases) - [Changelog](https://github.com/psf/black/blob/main/CHANGES.md) - [Commits](https://github.com/psf/black/commits/24.3.0) --- updated-dependencies: - dependency-name: black dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Improve C++ linting (AliceO2Group#443) * Remove clang-format badge (AliceO2Group#444) * [MegaLinter] Apply linters automatic fixes (#10) Co-authored-by: vkucera <vkucera@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Jochen Klein <jochen.klein@cern.ch> Co-authored-by: Nima Zardoshti <nzardosh@alicecerno2.cern.ch> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: vkucera <vkucera@users.noreply.github.com> Co-authored-by: Lu, Pengzhong <55934557+lupengzhong@users.noreply.github.com> Co-authored-by: Daniel Samitz <69901155+DanielSamitz@users.noreply.github.com> Co-authored-by: Maja Karwowska (Kabus) <8majak8@gmail.com> Co-authored-by: Archita-Dash <91664849+Archita-Dash@users.noreply.github.com> Co-authored-by: Maja Karwowska (Kabus) <mkabus@cern.ch> Co-authored-by: Johanna Lömker <jloemker@yahoo.de> Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch> Co-authored-by: ldellost <47105254+DelloStritto@users.noreply.github.com> Co-authored-by: aimeric-landou <46970521+aimeric-landou@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Archita-Dashand others added 15 commits October 6, 2023 14:57

adding codeJE for Jet O2 Validation
4b3a24e

output after execution of jet validation inside of codeJE
1627f48

matching event selection between converter task and validation task
10b83e1

matching event selection between converter task and validation task
e222b00

matching event selection between converter task and validation task
842afdd

implementing AliEvent cuts
fa0d268

Merge branch 'AliceO2Group:master' into master
7ee72c2

adding configurations and dependencies for jet validation
ac174c1

config file for Run3 jet parameters
15a9f96

defining configurations and workflows for jet validation
6ba5708

cleaning up the code
0f337e4

debugging
513aced

creating relative symlink for runtest
ec03bfd

cleaning of the codes
729bf16

updated workflow dependencies for track selection and track extension
d0f8dfd

Archita-Dash requested a review from vkucera as a code owner October 25, 2023 07:57

checking for bad spacings.
6664150

Archita-Dash force-pushed the master branch from 3639333 to 6664150Compare October 25, 2023 08:31

Archita-Dash closed this Oct 25, 2023

vkucera mentioned this pull request Oct 25, 2023
creating codeJE for JE O2 Vaidation #425
Closed

vkucera reopened this Oct 25, 2023

vkucera changed the title ~~creating "codeJE" within the Run3Analysisvalidation framework for JE O2 Validation~~Add JE validationNov 5, 2023

Archita-Dash added 7 commits November 14, 2023 19:42

removed bad spacings
92a4677

removed bad spacings
704140d

removed bad spacings
e5e8b1b

removed bad spacings
4e6c2db

organised code structure
1910526

checked binnings
130ad3e

removed bad spacings
543cd24

Archita-Dashand others added 5 commits November 14, 2023 20:51

added missing workflows
d898318

added missing workflows
821e626

Merge branch 'AliceO2Group:master' into master
cced490

removed redundant code lines
8032d0e

removed redundant code lines
54175c9

vkucera requested changes Nov 15, 2023
View reviewed changes

Comment threadcodeJE/clean.sh Outdated
Comment threadcodeJE/config_input.sh Outdated
Comment threadcodeJE/config_input.sh Outdated
Comment threadcodeJE/config_input.sh Outdated
Comment threadcodeJE/runtest.sh

Archita-Dash added 2 commits November 15, 2023 19:22

fixed code structure+ added missing wokflows
5bb9386

removed unwanted escape character
e7df54b

vkucera requested changes Nov 17, 2023
View reviewed changes

Archita-Dashand others added 5 commits November 20, 2023 17:12

fixed bugs+ updated json and workflows
081e087

Merge branch 'master' into master
85f43e5

fixed workflow blocknames to match with PWGJE
d980ad4

renaming of the code blocks to match with PWGJE workflows
f72fdea

renaming of the code blocks to match with PWGJE workflows
1c06949

vkucera approved these changes Nov 20, 2023
View reviewed changes

vkucera merged commit a3a728e into AliceO2Group:masterNov 20, 2023

Navigation Menu

Uh oh!

Add JE validation - #424

Add JE validation#424
vkucera merged 35 commits into
AliceO2Group:masterfrom
Archita-Dash:master

Archita-Dash commented Oct 25, 2023

Uh oh!

vkucera commented Oct 25, 2023•
edited
Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vkucera left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Archita-Dash commented Oct 25, 2023

Uh oh!

vkucera commented Oct 25, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vkucera left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vkucera commented Oct 25, 2023•
edited
Loading