Uh oh!
There was an error while loading. Please reload this page.
Update configurables and workflow - #430
Merged
Merged
Conversation
vkucera
requested changes
Nov 17, 2023
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
vkucera
commented
Nov 17, 2023
Collaborator
To answer your question 1. |
saganatt
commented
Nov 20, 2023
Uh oh!
There was an error while loading. Please reload this page.
saganattforce-pushed
the
update-workflows-config
branch
2 times, most recently
from
November 20, 2023 14:09
a39cb7d to
a84fbc5CompareCollaborator
Thanks for the update @saganatt . Can you confirm that it works fine on Run 2 as well as on Run 3? |
saganattforce-pushed
the
update-workflows-config
branch
from
November 21, 2023 13:10
a84fbc5 to
4d7bad3Comparesaganatt
commented
Nov 21, 2023
ContributorAuthor
@vkucera it works now with both Run 2 and Run 3 |
vkucera
approved these changes
Nov 21, 2023
vkucera added a commit
to vkucera/Run3AnalysisValidation
that referenced
this pull request
Apr 8, 2024
* MegaLinter run on pull_request_target * Try the merge commit * Checkout the right merge commit * Fix MegaLinter issues * Tmp * Update config for PR fixes on push * Test markdown fixes * Change permissions * Write all * Write * Write all * Fix permissions and improve PR config * Report formatter errors * Exit with error when fixes needed * Update Megalinter (AliceO2Group#420) * Update code owners (AliceO2Group#421) * Add configuration for HF jets (AliceO2Group#422) * Add first version of HF jet finding and matching * Fix bugs and improve task logic * adding jets to Run 3 Validation adding hf-jets pre-rebase commit adding HF-jet comparisons intermdeiate Adding Jets to the HF framework * adding tree output for HF substructure task * Fix configuration for jets * Rename jet variables * Move jets to a separate group * Simplify jet options * Fix jet finders * Fix jet matching * Fix jet substructure * Fix jet substructure output * Organise jet workflows * Add matching tables * Only warn for duplicate workflows * Set process function switches for jet substructure * Move jet json block * Add configuration for jet substructure output * Add jet finder QA * Fix workflow suffixes * Move correlation json block * Fix workflow suffixes * Restore default settings * [MegaLinter] Apply linters automatic fixes (#11) Co-authored-by: vkucera <vkucera@users.noreply.github.com> --------- Co-authored-by: Jochen Klein <jochen.klein@cern.ch> Co-authored-by: Nima Zardoshti <nzardosh@alicecerno2.cern.ch> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: vkucera <vkucera@users.noreply.github.com> * Add KFParticle to D0 creator (AliceO2Group#423) * HF: Add hf-tree-creator-lc-to-k0s-p (AliceO2Group#418) * Add tracks-extra-converter, update D0 selector config (AliceO2Group#426) * New MCs in config_input (AliceO2Group#429) * Add JE validation (AliceO2Group#424) * Update skimming configuration (AliceO2Group#432) * Update configurables and workflow (AliceO2Group#430) * Update and sync HF and JE configuration (AliceO2Group#433) * Refactor validation code (AliceO2Group#431) * Refactor utilities * Add copyright. Add tuple header. Fix path. * Add header guards * Move compare.py * Factor out plotting part of validation * Fix plotting factorisation * Factor out MakePlots into a header file. * Fix casting * Break line * Rename headers * Fix header guards * Improve logging * Improve legends in validation plots * Fix JE validation plots and factor out code * Remove link to utils_plot.h * Improve y-range calculation and plotting, add protections * Improve AliPhysics task macros * Add documentation comments in AliPhysics macros * Adjust validation legend (AliceO2Group#434) * codeJE: Add event histo and disable sel7 event selection (AliceO2Group#435) * Add configurables for proton PID in skimming (AliceO2Group#437) * renamed VtxZ histogram (AliceO2Group#436) * Removing HFPlot dependency from the hf_ptspectrum macro (AliceO2Group#438) * codeJE - update workflow (AliceO2Group#440) * Bump black from 19.10b0 to 24.3.0 in /codeQA/o2qaplots (AliceO2Group#442) Bumps [black](https://github.com/psf/black) from 19.10b0 to 24.3.0. - [Release notes](https://github.com/psf/black/releases) - [Changelog](https://github.com/psf/black/blob/main/CHANGES.md) - [Commits](https://github.com/psf/black/commits/24.3.0) --- updated-dependencies: - dependency-name: black dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Improve C++ linting (AliceO2Group#443) * Remove clang-format badge (AliceO2Group#444) * [MegaLinter] Apply linters automatic fixes (#10) Co-authored-by: vkucera <vkucera@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Jochen Klein <jochen.klein@cern.ch> Co-authored-by: Nima Zardoshti <nzardosh@alicecerno2.cern.ch> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: vkucera <vkucera@users.noreply.github.com> Co-authored-by: Lu, Pengzhong <55934557+lupengzhong@users.noreply.github.com> Co-authored-by: Daniel Samitz <69901155+DanielSamitz@users.noreply.github.com> Co-authored-by: Maja Karwowska (Kabus) <8majak8@gmail.com> Co-authored-by: Archita-Dash <91664849+Archita-Dash@users.noreply.github.com> Co-authored-by: Maja Karwowska (Kabus) <mkabus@cern.ch> Co-authored-by: Johanna Lömker <jloemker@yahoo.de> Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch> Co-authored-by: ldellost <47105254+DelloStritto@users.noreply.github.com> Co-authored-by: aimeric-landou <46970521+aimeric-landou@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @vkucera and @DelloStritto ,
Updates based on adjustments I needed to run with Luigi's configuration (Hyperloop wagon HfTrackIndexSkimCreator_SaveDD). Let me know if there should be other default values for the new configurables.
Questions:
Should doCutQuality always be false for Run 3 data now? In Luigi's Hyperloop settings it is true.
https://github.com/AliceO2Group/Run3Analysisvalidation/blob/master/codeHF/config_tasks.sh#L218
Similarly, for Run 3, we assume no FT0 processing, but Luigi switched it on. That's why I needed to add ft0 dependency in workflows.yml to tof-base. Are these lines still valid?
https://github.com/AliceO2Group/Run3Analysisvalidation/blob/master/codeHF/config_tasks.sh#L257