Skip to content

feat(nav): Add deps for slam building and a tool for pcd saving - #55

Merged
creeper5820 merged 1 commit into
mainfrom
feature/navigation-debug-support
Mar 13, 2026
Merged

feat(nav): Add deps for slam building and a tool for pcd saving#55
creeper5820 merged 1 commit into
mainfrom
feature/navigation-debug-support

Conversation

@creeper5820

@creeper5820creeper5820 commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

PR摘要

本PR为SLAM构建添加必要依赖,并引入一个用于保存 PCD 地图的命令行工具与其补全脚本。

主要改动

  1. 新增 PCD 地图保存工具(.script/save-map-once)
  • 可执行 Zsh 脚本:Usage: save-map-once <remote|local>
  • 支持两种模式:
    • remote:通过 ssh-remote 在机器人端触发 ROS2 服务 /save_pcd_map
    • local:在本地(容器)环境触发 /save_pcd_map
  • 使用严格的 shell 选项(set -euo pipefail),包含参数检查与帮助信息
  • 通过 source ~/env_setup.bash 设置环境,service 调用由变量 service_call 指定
  1. 新增 Zsh 补全脚本(.script/complete/_save-map-once)
  • 为 save-map-once 命令添加补全,限定第一个参数可选值为 remote 和 local
  1. Dockerfile 依赖更新
  • 在 llvm-toolchain 安装阶段添加 libomp-${LLVM_VERSION}-dev,以支持 OpenMP(利于 SLAM 构建的并行需求)

@coderabbitai

coderabbitaiBot commented Mar 12, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e4b24fff-2c74-4f3c-a53c-4e82750f9254

📥 Commits

Reviewing files that changed from the base of the PR and between 3925994 and 38c8e01.

📒 Files selected for processing (3)
  • .script/complete/_save-map-once
  • .script/save-map-once
  • Dockerfile
🚧 Files skipped from review as they are similar to previous changes (3)
  • .script/complete/_save-map-once
  • Dockerfile
  • .script/save-map-once

Walkthrough

引入 save-map-once 命令的可执行 Shell 实现与 Zsh 完成脚本;脚本支持本地或通过 SSH 的远程两种模式来调用 ROS 2 /save_pcd_map 服务;同时在 Dockerfile 的 LLVM 工具链安装阶段添加 libomp-${LLVM_VERSION}-dev 依赖。

Changes

Cohort / File(s)Summary
Shell 完成与命令
\.script/complete/_save-map-once, \.script/save-map-once
新增 Zsh 补全脚本(定义 save-map-once 的 `remote
构建依赖
Dockerfile
在 LLVM 工具链安装阶段将 libomp-${LLVM_VERSION}-dev 添加到 apt-get 安装列表中。

Sequence Diagram(s)

sequenceDiagram
participant User as "用户"
participant CLI as "save-map-once 脚本"
participant Env as "本地环境 (env_setup.bash)"
participant SSH as "远程主机 (ssh)"
participant ROS as "ROS2 /save_pcd_map 服务"
User->>CLI: 运行 `save-map-once [local|remote]`
CLI->>CLI: 验证参数
alt local
CLI->>Env: source env_setup.bash
Env->>ROS: ros2 service call /save_pcd_map
ROS-->>CLI: 返回结果
else remote
CLI->>SSH: ssh <host> 'source env_setup.bash && ros2 service call /save_pcd_map'
SSH-->>ROS: 在远端调用服务
ROS-->>SSH: 返回结果
SSH-->>CLI: 将远端输出返回
end
CLI-->>User: 显示结果或错误
Loading

预估代码审查工作量

🎯 2 (简单) | ⏱️ ~10 分钟

🐰 我来跳一跳,脚本轻轻响,
本地与远端,映射一次成章,
ROS 在呼唤,SSH 来帮忙,
编译依赖到位,跑得更欢畅,
小兔鼓掌,路遥共赏 ⭐

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately reflects the main changes: adding dependencies for SLAM building (libomp in Dockerfile) and introducing a new tool for PCD map saving (save-map-once script and its completion).
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/navigation-debug-support
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@creeper5820
creeper5820 requested a review from qzhhhiMarch 12, 2026 22:49

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.script/complete/_save-map-once:
- Around line 3-4: 补全定义 `_arguments` 中目前只列出 `'1:mode:(remote local)'`,与
`.script/save-map-once` 第37-39行支持的 `-h/--help` 不一致;在该补全文件(标识符 `_arguments` 和字符串
`'1:mode:(remote local)'`)中添加对 `-h` 和 `--help` 的补全项(或将其作为可选
flag)以匹配脚本实际参数并确保帮助选项可补全。
In @.script/save-map-once:
- Around line 5-11: The usage() function's help text currently only shows
"save-map-once <remote|local>" but omits the supported help flags; update the
usage() message to list the supported --help and -h options alongside
remote|local so users know help is available; locate the usage() function in the
.script/save-map-once script and add "--help|-h" (or a brief "[-h|--help]") into
the Usage and short description lines so the printed help matches the parsing
logic in the option handling around lines 37-39.
In `@Dockerfile`:
- Line 99: 修复 Dockerfile 中错误的 libomp 包名:将出现的 libomp-22-${LLVM_VERSION}(使用
LLVM_VERSION 变量时会展开成错误的 libomp-22-22)替换为正确的包名格式 libomp-${LLVM_VERSION}-dev,确保在使用
LLVM_VERSION(例如 22)时生成 libomp-22-dev;更新 Dockerfile 中相应安装列表项(搜索字符串
libomp-22-${LLVM_VERSION} 或使用变量 LLVM_VERSION 的那一行)并替换为
libomp-${LLVM_VERSION}-dev。

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 281d09b2-f211-48f3-8ead-54ba7ef449af

📥 Commits

Reviewing files that changed from the base of the PR and between 5c7f3fb and 3925994.

📒 Files selected for processing (3)
  • .script/complete/_save-map-once
  • .script/save-map-once
  • Dockerfile

Comment thread.script/complete/_save-map-once
Comment thread.script/save-map-once
Comment threadDockerfile Outdated
@creeper5820
creeper5820force-pushed the feature/navigation-debug-support branch from 3925994 to 38c8e01CompareMarch 12, 2026 23:03

@qzhhhiqzhhhi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@creeper5820
creeper5820 merged commit a5f2820 into mainMar 13, 2026
1 check passed
@github-project-automationgithub-project-automationBot moved this from Todo to Done in RMCSMar 13, 2026
@creeper5820
creeper5820 deleted the feature/navigation-debug-support branch March 13, 2026 16:15
zhzy-star pushed a commit that referenced this pull request Jul 3, 2026
…for temporary debugging by qzhhhi · Pull Request #55 · Allia)
ZGZ713912 added a commit that referenced this pull request Jul 22, 2026
commit 4d1b9fc
Author: creeper5820 <cqq1960180796@163.com>
Date: Mon Jul 20 23:13:59 2026 +0800
feat: Refine auto-aim fire control and bringup configs
commit 94da5b9
Author: creeper5820 <cqq1960180796@163.com>
Date: Sun Jul 19 20:18:47 2026 +0800
chore: Clean up code and apply format
commit eb9d651
Author: creeper5820 <cqq1960180796@163.com>
Date: Sun Jul 19 19:09:06 2026 +0800
chore: Update auto aim submodule
commit ef4ef90
Author: FloatPigeon <floatpigeon@proton.me>
Date: Sun Jul 19 20:11:54 2026 +0800
feat: Add VT13 remote control and dual control arbitration (#93)
commit d49071c
Author: creeper5820 <cqq1960180796@163.com>
Date: Sun Jul 19 11:09:07 2026 +0800
feat: Adapt rune single shoot mode
commit 91aaa6b
Author: creeper5820 <cqq1960180796@163.com>
Date: Sat Jul 18 17:55:26 2026 +0800
fix: No response of switching item in scan-remote
commit b868fd3
Author: creeper5820 <cqq1960180796@163.com>
Date: Sat Jul 18 17:35:00 2026 +0800
chore: Add auto aim as submodule
commit 0d84265
Author: creeper5820 <cqq1960180796@163.com>
Date: Sat Jul 18 17:29:59 2026 +0800
merge(robot): Merge sentry impl into this branch
commit e588f08
Author: creeper5820 <cqq1960180796@163.com>
Date: Sat Jul 18 11:20:01 2026 +0800
fix(hero): Update auto-aim config and should_control gating
commit 77444dd
Author: creeper5820 <cqq1960180796@163.com>
Date: Sat Jul 18 10:37:57 2026 +0800
fix: Correct hero friction order
commit 768369c
Author: creeper5820 <cqq1960180796@163.com>
Date: Sat Jul 18 08:55:39 2026 +0800
wip: Merge hero and infantry 3/4, remove unused robot
commit 5b9d180
Merge: fbe3ec51fd53eb
Author: creeper5820 <cqq1960180796@163.com>
Date: Sat Jul 18 01:39:23 2026 +0800
Merge branch 'merge/hero' into merge/robots
commit 1fd53eb
Author: creeper5820 <cqq1960180796@163.com>
Date: Thu Jul 16 00:41:59 2026 +0800
chore: Modify hero config
commit 38f562d
Author: creeper5820 <cqq1960180796@163.com>
Date: Wed Jul 15 21:12:29 2026 +0800
wip: Adapt auto aim control
commit 4a8722d
Author: creeper5820 <cqq1960180796@163.com>
Date: Wed Jul 15 19:14:09 2026 +0800
wip: Adapt auto aim for hardware and clean config
commit de27628
Author: dwx5 <1591215786@qq.com>
Date: Wed Jul 15 22:32:11 2026 +0800
parameter changes for 12m/s
commit afda3ee
Author: creeper5820 <cqq1960180796@163.com>
Date: Wed Jul 15 18:47:45 2026 +0800
wip: Rebase with main branch
commit 81a0232
Author: dwx5 <1591215786@qq.com>
Date: Wed Jul 15 15:16:50 2026 +0800
stable
commit 143cee6
Author: dwx5 <1591215786@qq.com>
Date: Wed Jul 8 23:39:08 2026 +0800
friction_sweep and parameter changes
commit 016bd08
Author: qzhhhi <zihanqin2048@gmail.com>
Date: Fri May 22 13:21:21 2026 +0800
vt13 test (rmcs_board need : chore(rmcs_board): Raise UART0 baudrate for temporary debugging by qzhhhi · Pull Request #55 · Allia)
commit 119730e
Author: dwx5 <1591215786@qq.com>
Date: Thu Jul 2 22:10:14 2026 +0800
1、lk_motor: multiple angle dynamically transform
2、interfere clean
3、six_friction: rename and reset parameter
4、putter return
commit 3c061e8
Author: dwx5 <1591215786@qq.com>
Date: Wed Jul 1 20:39:00 2026 +0800
six-friction
commit 8ad0751
Author: dwx5 <1591215786@qq.com>
Date: Sat Jun 6 20:11:57 2026 +0800
add yaw brake
commit f398929
Author: dwx5 <1591215786@qq.com>
Date: Thu Jun 4 21:08:50 2026 +0800
update after merge main
commit ad17156
Author: qzhhhi <zihanqin2048@gmail.com>
Date: Sun Jul 12 02:19:02 2026 +0800
feat: success buff
ZGZ713912 added a commit that referenced this pull request Jul 22, 2026
commit 0e1e1ad
Author: creeper5820 <cqq1960180796@163.com>
Date: Wed Jul 22 03:12:17 2026 +0800
wip: Develop sentry navigation
commit 97020e1
Author: creeper5820 <cqq1960180796@163.com>
Date: Wed Jul 22 02:12:15 2026 +0800
wip: Adjust 17mm bullet feeder behavior, improve rmcs host util and
update auto_aim
commit 4d1b9fc
Author: creeper5820 <cqq1960180796@163.com>
Date: Mon Jul 20 23:13:59 2026 +0800
feat: Refine auto-aim fire control and bringup configs
commit 94da5b9
Author: creeper5820 <cqq1960180796@163.com>
Date: Sun Jul 19 20:18:47 2026 +0800
chore: Clean up code and apply format
commit eb9d651
Author: creeper5820 <cqq1960180796@163.com>
Date: Sun Jul 19 19:09:06 2026 +0800
chore: Update auto aim submodule
commit ef4ef90
Author: FloatPigeon <floatpigeon@proton.me>
Date: Sun Jul 19 20:11:54 2026 +0800
feat: Add VT13 remote control and dual control arbitration (#93)
commit d49071c
Author: creeper5820 <cqq1960180796@163.com>
Date: Sun Jul 19 11:09:07 2026 +0800
feat: Adapt rune single shoot mode
commit 91aaa6b
Author: creeper5820 <cqq1960180796@163.com>
Date: Sat Jul 18 17:55:26 2026 +0800
fix: No response of switching item in scan-remote
commit b868fd3
Author: creeper5820 <cqq1960180796@163.com>
Date: Sat Jul 18 17:35:00 2026 +0800
chore: Add auto aim as submodule
commit 0d84265
Author: creeper5820 <cqq1960180796@163.com>
Date: Sat Jul 18 17:29:59 2026 +0800
merge(robot): Merge sentry impl into this branch
commit e588f08
Author: creeper5820 <cqq1960180796@163.com>
Date: Sat Jul 18 11:20:01 2026 +0800
fix(hero): Update auto-aim config and should_control gating
commit 77444dd
Author: creeper5820 <cqq1960180796@163.com>
Date: Sat Jul 18 10:37:57 2026 +0800
fix: Correct hero friction order
commit 768369c
Author: creeper5820 <cqq1960180796@163.com>
Date: Sat Jul 18 08:55:39 2026 +0800
wip: Merge hero and infantry 3/4, remove unused robot
commit 5b9d180
Merge: fbe3ec51fd53eb
Author: creeper5820 <cqq1960180796@163.com>
Date: Sat Jul 18 01:39:23 2026 +0800
Merge branch 'merge/hero' into merge/robots
commit 1fd53eb
Author: creeper5820 <cqq1960180796@163.com>
Date: Thu Jul 16 00:41:59 2026 +0800
chore: Modify hero config
commit 38f562d
Author: creeper5820 <cqq1960180796@163.com>
Date: Wed Jul 15 21:12:29 2026 +0800
wip: Adapt auto aim control
commit 4a8722d
Author: creeper5820 <cqq1960180796@163.com>
Date: Wed Jul 15 19:14:09 2026 +0800
wip: Adapt auto aim for hardware and clean config
commit de27628
Author: dwx5 <1591215786@qq.com>
Date: Wed Jul 15 22:32:11 2026 +0800
parameter changes for 12m/s
commit afda3ee
Author: creeper5820 <cqq1960180796@163.com>
Date: Wed Jul 15 18:47:45 2026 +0800
wip: Rebase with main branch
commit 81a0232
Author: dwx5 <1591215786@qq.com>
Date: Wed Jul 15 15:16:50 2026 +0800
stable
commit 143cee6
Author: dwx5 <1591215786@qq.com>
Date: Wed Jul 8 23:39:08 2026 +0800
friction_sweep and parameter changes
commit 016bd08
Author: qzhhhi <zihanqin2048@gmail.com>
Date: Fri May 22 13:21:21 2026 +0800
vt13 test (rmcs_board need : chore(rmcs_board): Raise UART0 baudrate for temporary debugging by qzhhhi · Pull Request #55 · Allia)
commit 119730e
Author: dwx5 <1591215786@qq.com>
Date: Thu Jul 2 22:10:14 2026 +0800
1、lk_motor: multiple angle dynamically transform
2、interfere clean
3、six_friction: rename and reset parameter
4、putter return
commit 3c061e8
Author: dwx5 <1591215786@qq.com>
Date: Wed Jul 1 20:39:00 2026 +0800
six-friction
commit 8ad0751
Author: dwx5 <1591215786@qq.com>
Date: Sat Jun 6 20:11:57 2026 +0800
add yaw brake
commit f398929
Author: dwx5 <1591215786@qq.com>
Date: Thu Jun 4 21:08:50 2026 +0800
update after merge main
commit ad17156
Author: qzhhhi <zihanqin2048@gmail.com>
Date: Sun Jul 12 02:19:02 2026 +0800
feat: success buff
ZGZ713912 pushed a commit that referenced this pull request Aug 11, 2026
…for temporary debugging by qzhhhi · Pull Request #55 · Allia)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants

@creeper5820@qzhhhi