Uh oh!
There was an error while loading. Please reload this page.
feat(nav): Add deps for slam building and a tool for pcd saving - #55
Conversation
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
Walkthrough引入 Changes
Sequence Diagram(s)sequenceDiagram
participant User as "用户"
participant CLI as "save-map-once 脚本"
participant Env as "本地环境 (env_setup.bash)"
participant SSH as "远程主机 (ssh)"
participant ROS as "ROS2 /save_pcd_map 服务"
User->>CLI: 运行 `save-map-once [local|remote]`
CLI->>CLI: 验证参数
alt local
CLI->>Env: source env_setup.bash
Env->>ROS: ros2 service call /save_pcd_map
ROS-->>CLI: 返回结果
else remote
CLI->>SSH: ssh <host> 'source env_setup.bash && ros2 service call /save_pcd_map'
SSH-->>ROS: 在远端调用服务
ROS-->>SSH: 返回结果
SSH-->>CLI: 将远端输出返回
end
CLI-->>User: 显示结果或错误
预估代码审查工作量🎯 2 (简单) | ⏱️ ~10 分钟 诗
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.script/complete/_save-map-once:
- Around line 3-4: 补全定义 `_arguments` 中目前只列出 `'1:mode:(remote local)'`,与
`.script/save-map-once` 第37-39行支持的 `-h/--help` 不一致;在该补全文件(标识符 `_arguments` 和字符串
`'1:mode:(remote local)'`)中添加对 `-h` 和 `--help` 的补全项(或将其作为可选
flag)以匹配脚本实际参数并确保帮助选项可补全。
In @.script/save-map-once:
- Around line 5-11: The usage() function's help text currently only shows
"save-map-once <remote|local>" but omits the supported help flags; update the
usage() message to list the supported --help and -h options alongside
remote|local so users know help is available; locate the usage() function in the
.script/save-map-once script and add "--help|-h" (or a brief "[-h|--help]") into
the Usage and short description lines so the printed help matches the parsing
logic in the option handling around lines 37-39.
In `@Dockerfile`:
- Line 99: 修复 Dockerfile 中错误的 libomp 包名:将出现的 libomp-22-${LLVM_VERSION}(使用
LLVM_VERSION 变量时会展开成错误的 libomp-22-22)替换为正确的包名格式 libomp-${LLVM_VERSION}-dev,确保在使用
LLVM_VERSION(例如 22)时生成 libomp-22-dev;更新 Dockerfile 中相应安装列表项(搜索字符串
libomp-22-${LLVM_VERSION} 或使用变量 LLVM_VERSION 的那一行)并替换为
libomp-${LLVM_VERSION}-dev。
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 281d09b2-f211-48f3-8ead-54ba7ef449af
📒 Files selected for processing (3)
.script/complete/_save-map-once.script/save-map-onceDockerfile
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
3925994 to
38c8e01CompareUh oh!
There was an error while loading. Please reload this page.
…for temporary debugging by qzhhhi · Pull Request #55 · Allia)
commit 4d1b9fc Author: creeper5820 <cqq1960180796@163.com> Date: Mon Jul 20 23:13:59 2026 +0800 feat: Refine auto-aim fire control and bringup configs commit 94da5b9 Author: creeper5820 <cqq1960180796@163.com> Date: Sun Jul 19 20:18:47 2026 +0800 chore: Clean up code and apply format commit eb9d651 Author: creeper5820 <cqq1960180796@163.com> Date: Sun Jul 19 19:09:06 2026 +0800 chore: Update auto aim submodule commit ef4ef90 Author: FloatPigeon <floatpigeon@proton.me> Date: Sun Jul 19 20:11:54 2026 +0800 feat: Add VT13 remote control and dual control arbitration (#93) commit d49071c Author: creeper5820 <cqq1960180796@163.com> Date: Sun Jul 19 11:09:07 2026 +0800 feat: Adapt rune single shoot mode commit 91aaa6b Author: creeper5820 <cqq1960180796@163.com> Date: Sat Jul 18 17:55:26 2026 +0800 fix: No response of switching item in scan-remote commit b868fd3 Author: creeper5820 <cqq1960180796@163.com> Date: Sat Jul 18 17:35:00 2026 +0800 chore: Add auto aim as submodule commit 0d84265 Author: creeper5820 <cqq1960180796@163.com> Date: Sat Jul 18 17:29:59 2026 +0800 merge(robot): Merge sentry impl into this branch commit e588f08 Author: creeper5820 <cqq1960180796@163.com> Date: Sat Jul 18 11:20:01 2026 +0800 fix(hero): Update auto-aim config and should_control gating commit 77444dd Author: creeper5820 <cqq1960180796@163.com> Date: Sat Jul 18 10:37:57 2026 +0800 fix: Correct hero friction order commit 768369c Author: creeper5820 <cqq1960180796@163.com> Date: Sat Jul 18 08:55:39 2026 +0800 wip: Merge hero and infantry 3/4, remove unused robot commit 5b9d180 Merge: fbe3ec51fd53eb Author: creeper5820 <cqq1960180796@163.com> Date: Sat Jul 18 01:39:23 2026 +0800 Merge branch 'merge/hero' into merge/robots commit 1fd53eb Author: creeper5820 <cqq1960180796@163.com> Date: Thu Jul 16 00:41:59 2026 +0800 chore: Modify hero config commit 38f562d Author: creeper5820 <cqq1960180796@163.com> Date: Wed Jul 15 21:12:29 2026 +0800 wip: Adapt auto aim control commit 4a8722d Author: creeper5820 <cqq1960180796@163.com> Date: Wed Jul 15 19:14:09 2026 +0800 wip: Adapt auto aim for hardware and clean config commit de27628 Author: dwx5 <1591215786@qq.com> Date: Wed Jul 15 22:32:11 2026 +0800 parameter changes for 12m/s commit afda3ee Author: creeper5820 <cqq1960180796@163.com> Date: Wed Jul 15 18:47:45 2026 +0800 wip: Rebase with main branch commit 81a0232 Author: dwx5 <1591215786@qq.com> Date: Wed Jul 15 15:16:50 2026 +0800 stable commit 143cee6 Author: dwx5 <1591215786@qq.com> Date: Wed Jul 8 23:39:08 2026 +0800 friction_sweep and parameter changes commit 016bd08 Author: qzhhhi <zihanqin2048@gmail.com> Date: Fri May 22 13:21:21 2026 +0800 vt13 test (rmcs_board need : chore(rmcs_board): Raise UART0 baudrate for temporary debugging by qzhhhi · Pull Request #55 · Allia) commit 119730e Author: dwx5 <1591215786@qq.com> Date: Thu Jul 2 22:10:14 2026 +0800 1、lk_motor: multiple angle dynamically transform 2、interfere clean 3、six_friction: rename and reset parameter 4、putter return commit 3c061e8 Author: dwx5 <1591215786@qq.com> Date: Wed Jul 1 20:39:00 2026 +0800 six-friction commit 8ad0751 Author: dwx5 <1591215786@qq.com> Date: Sat Jun 6 20:11:57 2026 +0800 add yaw brake commit f398929 Author: dwx5 <1591215786@qq.com> Date: Thu Jun 4 21:08:50 2026 +0800 update after merge main commit ad17156 Author: qzhhhi <zihanqin2048@gmail.com> Date: Sun Jul 12 02:19:02 2026 +0800 feat: success buff
commit 0e1e1ad Author: creeper5820 <cqq1960180796@163.com> Date: Wed Jul 22 03:12:17 2026 +0800 wip: Develop sentry navigation commit 97020e1 Author: creeper5820 <cqq1960180796@163.com> Date: Wed Jul 22 02:12:15 2026 +0800 wip: Adjust 17mm bullet feeder behavior, improve rmcs host util and update auto_aim commit 4d1b9fc Author: creeper5820 <cqq1960180796@163.com> Date: Mon Jul 20 23:13:59 2026 +0800 feat: Refine auto-aim fire control and bringup configs commit 94da5b9 Author: creeper5820 <cqq1960180796@163.com> Date: Sun Jul 19 20:18:47 2026 +0800 chore: Clean up code and apply format commit eb9d651 Author: creeper5820 <cqq1960180796@163.com> Date: Sun Jul 19 19:09:06 2026 +0800 chore: Update auto aim submodule commit ef4ef90 Author: FloatPigeon <floatpigeon@proton.me> Date: Sun Jul 19 20:11:54 2026 +0800 feat: Add VT13 remote control and dual control arbitration (#93) commit d49071c Author: creeper5820 <cqq1960180796@163.com> Date: Sun Jul 19 11:09:07 2026 +0800 feat: Adapt rune single shoot mode commit 91aaa6b Author: creeper5820 <cqq1960180796@163.com> Date: Sat Jul 18 17:55:26 2026 +0800 fix: No response of switching item in scan-remote commit b868fd3 Author: creeper5820 <cqq1960180796@163.com> Date: Sat Jul 18 17:35:00 2026 +0800 chore: Add auto aim as submodule commit 0d84265 Author: creeper5820 <cqq1960180796@163.com> Date: Sat Jul 18 17:29:59 2026 +0800 merge(robot): Merge sentry impl into this branch commit e588f08 Author: creeper5820 <cqq1960180796@163.com> Date: Sat Jul 18 11:20:01 2026 +0800 fix(hero): Update auto-aim config and should_control gating commit 77444dd Author: creeper5820 <cqq1960180796@163.com> Date: Sat Jul 18 10:37:57 2026 +0800 fix: Correct hero friction order commit 768369c Author: creeper5820 <cqq1960180796@163.com> Date: Sat Jul 18 08:55:39 2026 +0800 wip: Merge hero and infantry 3/4, remove unused robot commit 5b9d180 Merge: fbe3ec51fd53eb Author: creeper5820 <cqq1960180796@163.com> Date: Sat Jul 18 01:39:23 2026 +0800 Merge branch 'merge/hero' into merge/robots commit 1fd53eb Author: creeper5820 <cqq1960180796@163.com> Date: Thu Jul 16 00:41:59 2026 +0800 chore: Modify hero config commit 38f562d Author: creeper5820 <cqq1960180796@163.com> Date: Wed Jul 15 21:12:29 2026 +0800 wip: Adapt auto aim control commit 4a8722d Author: creeper5820 <cqq1960180796@163.com> Date: Wed Jul 15 19:14:09 2026 +0800 wip: Adapt auto aim for hardware and clean config commit de27628 Author: dwx5 <1591215786@qq.com> Date: Wed Jul 15 22:32:11 2026 +0800 parameter changes for 12m/s commit afda3ee Author: creeper5820 <cqq1960180796@163.com> Date: Wed Jul 15 18:47:45 2026 +0800 wip: Rebase with main branch commit 81a0232 Author: dwx5 <1591215786@qq.com> Date: Wed Jul 15 15:16:50 2026 +0800 stable commit 143cee6 Author: dwx5 <1591215786@qq.com> Date: Wed Jul 8 23:39:08 2026 +0800 friction_sweep and parameter changes commit 016bd08 Author: qzhhhi <zihanqin2048@gmail.com> Date: Fri May 22 13:21:21 2026 +0800 vt13 test (rmcs_board need : chore(rmcs_board): Raise UART0 baudrate for temporary debugging by qzhhhi · Pull Request #55 · Allia) commit 119730e Author: dwx5 <1591215786@qq.com> Date: Thu Jul 2 22:10:14 2026 +0800 1、lk_motor: multiple angle dynamically transform 2、interfere clean 3、six_friction: rename and reset parameter 4、putter return commit 3c061e8 Author: dwx5 <1591215786@qq.com> Date: Wed Jul 1 20:39:00 2026 +0800 six-friction commit 8ad0751 Author: dwx5 <1591215786@qq.com> Date: Sat Jun 6 20:11:57 2026 +0800 add yaw brake commit f398929 Author: dwx5 <1591215786@qq.com> Date: Thu Jun 4 21:08:50 2026 +0800 update after merge main commit ad17156 Author: qzhhhi <zihanqin2048@gmail.com> Date: Sun Jul 12 02:19:02 2026 +0800 feat: success buff
…for temporary debugging by qzhhhi · Pull Request #55 · Allia)
PR摘要
本PR为SLAM构建添加必要依赖,并引入一个用于保存 PCD 地图的命令行工具与其补全脚本。
主要改动