Skip to content

Feat/eccentric dual yaw solver - #86

Merged
creeper5820 merged 3 commits into
dev/sentryfrom
feat/eccentric-dual-yaw-solver
Jul 7, 2026
Merged

Feat/eccentric dual yaw solver#86
creeper5820 merged 3 commits into
dev/sentryfrom
feat/eccentric-dual-yaw-solver

Conversation

@zlq04222

@zlq04222zlq04222 commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

feat(gimbal): eccentric dual yaw solver & config update

变更概述

  • 新增“eccentric dual yaw”求解器,用于统一处理自动瞄准、导航和手动模式下的底盘/云台误差计算。
  • 重构云台控制链路:由求解器输出 bottom yaw、top yaw 和 pitch 误差,再由控制器执行控制量合成。
  • 更新 sentry 配置,调整云台标定与底部偏航相关 PID/摩擦补偿参数。

主要改动

  • 新增 EccentricDualYawSolver,支持:
    • AutoAim:基于 TF 和姿态计算误差;
    • Navigation:基于期望方向和当前状态计算误差;
    • SetDisabled:禁用状态处理。
  • gimbal 控制逻辑改为直接接收三轴误差,移除原先的 AxisCommand / ControlTarget 结构及相关自动瞄准输入字段。
  • 修正 Navigation 求解中的误差计算,使其使用当前状态;同时确保导航/手动模式下顶部 yaw 被驱动到 0。
  • 清理不再使用的 top yaw feedforward 相关代码、参数,以及 kUpdateRate 常量;并移除额外未使用的 feedforward 输入。
  • sentry.yaml 中更新了底部 yaw 零点、PID 参数,并补充/启用底部 yaw 摩擦补偿配置。

影响

  • 云台控制逻辑更集中,三种模式的误差计算方式更清晰。
  • 配置参数与控制模型同步更新,便于新双 yaw 方案落地。

zlq04222and others added 3 commits July 5, 2026 23:06
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)
Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
- Fix Navigation solver to compute errors against current state instead of stored target
- Fix top yaw not driven to zero in Navigation and Manual modes
- Remove unused top yaw inertia/jerk feedforward code and params
- Extract kEpsilon/kMinDt constants
@coderabbitai

coderabbitaiBot commented Jul 7, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d75072c8-de04-4c74-9a60-a7d096dfa057

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • ✅ Review completed - (🔄 Check again to review again)
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/eccentric-dual-yaw-solver

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

};

private:
static constexpr double kNaN_ = std::numeric_limits<double>::quiet_NaN();

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1

@creeper5820
creeper5820 merged commit a373148 into dev/sentryJul 7, 2026
1 check passed
@github-project-automationgithub-project-automationBot moved this from Todo to Done in RMCSJul 7, 2026
@creeper5820
creeper5820 deleted the feat/eccentric-dual-yaw-solver branch July 7, 2026 12:35
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants

@zlq04222@creeper5820