Skip to content

Add MRVR to MRI reporting plugin - #10470

Merged
raymondjacobson merged 8 commits into
mainfrom
rj-mrvr
Nov 22, 2024
Merged

Add MRVR to MRI reporting plugin#10470
raymondjacobson merged 8 commits into
mainfrom
rj-mrvr

Conversation

@raymondjacobson

@raymondjacobsonraymondjacobson commented Nov 19, 2024

Copy link
Copy Markdown
Member

Description

These queries work and were used to generated the two attached reports.

I'm ok with checking this in and iterating on perf improvements.

Affirmative query: 5sec
CBS query: 25min

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.

Ran both queries against db locally. Will test wrapping code on stage.

@changeset-bot

changeset-botBot commented Nov 19, 2024

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: fab038b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gitguardian

Copy link
Copy Markdown

⚠️ GitGuardian has uncovered 14 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian idGitGuardian statusSecretCommitFilename
8370415TriggeredAlchemy API Keyfab038bcmd/audiusd/env/prod.envView secret
2460749TriggeredGeneric High Entropy Secretfab038bcmd/audiusd/env/prod.envView secret
8370414TriggeredAlchemy API Keyfab038bcmd/audiusd/env/prod.envView secret
8370413TriggeredAlchemy API Keyfab038bcmd/audiusd/env/prod.envView secret
14086629TriggeredGeneric Passwordfab038bcmd/audiusd/entrypoint.shView secret
2416686TriggeredGeneric High Entropy Secretfab038bcmd/audiusd/env/stage.envView secret
2416685TriggeredGeneric High Entropy Secretfab038bcmd/audiusd/env/stage.envView secret
688750TriggeredGeneric High Entropy Secretfab038bcmd/audiusd/env/prod.envView secret
2416684TriggeredGeneric High Entropy Secretfab038bcmd/audiusd/env/stage.envView secret
8370416TriggeredAlchemy API Keyfab038bcmd/audiusd/env/prod.envView secret
3249666TriggeredGeneric Passwordfab038bpackages/commands/src/utils.mjsView secret
2460750TriggeredGeneric High Entropy Secretfab038bcmd/audiusd/env/prod.envView secret
2460751TriggeredGeneric High Entropy Secretfab038bcmd/audiusd/env/prod.envView secret
688750TriggeredGeneric High Entropy Secretfab038bcmd/audiusd/env/stage.envView secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@raymondjacobson
raymondjacobson enabled auto-merge (squash) November 21, 2024 22:35
@raymondjacobson
raymondjacobson merged commit f5f7a1a into mainNov 22, 2024
@raymondjacobson
raymondjacobson deleted the rj-mrvr branch November 22, 2024 00:21
audius-infra pushed a commit that referenced this pull request Nov 22, 2024
[80c700e] Revert "[C-5342] Upgrade react-native to 0.75 (#10301)" (#10497) Andrew Mendelsohn
[f5f7a1a] Add MRVR to MRI reporting plugin (#10470) Raymond Jacobson
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@raymondjacobson@stereosteve