Skip to content

Revert "[C-5342] Upgrade react-native to 0.75 (#10301)" - #10497

Merged
amendelsohn merged 9 commits into
mainfrom
am-revert-rn-75
Nov 22, 2024
Merged

Revert "[C-5342] Upgrade react-native to 0.75 (#10301)"#10497
amendelsohn merged 9 commits into
mainfrom
am-revert-rn-75

Conversation

@amendelsohn

@amendelsohnamendelsohn commented Nov 20, 2024•
edited by dharit-tan
Loading

Copy link
Copy Markdown
Contributor

This reverts commit ae6d881.

Description

PAY-3610

RN upgrade made us slower 😢
Reverted and cleaned up some deps

How Has This Been Tested?

Navigation on press is feeling way snappier already 🎉

@changeset-bot

changeset-botBot commented Nov 20, 2024•
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: c2d3733

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@audius-infra

audius-infra commented Nov 20, 2024

Copy link
Copy Markdown
Collaborator

Preview this change https://demo.audius.co/am-revert-rn-75

@amendelsohn
amendelsohn requested review from a team and Kyle-Shanks and removed request for a teamNovember 20, 2024 22:38
raymondjacobson
raymondjacobson approved these changes Nov 20, 2024
View reviewed changes

@raymondjacobsonraymondjacobson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any idea why CI is failing?

@amendelsohn

amendelsohn commented Nov 21, 2024

Copy link
Copy Markdown
ContributorAuthor

any idea why CI is failing?

Not yet. Looking into it

dharit-tan
dharit-tan approved these changes Nov 21, 2024
View reviewed changes

@dharit-tandharit-tan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we also want to revert this if we;re dowgrading react?
#10315

@dharit-tan

dharit-tan commented Nov 21, 2024

Copy link
Copy Markdown
Contributor

do we also want to revert this if we;re dowgrading react? #10315

nvm i guess those changes are largely reverted in this PR.

@audius-infra

audius-infra commented Nov 21, 2024

Copy link
Copy Markdown
Collaborator

Preview this change https://demo.audius.co/am-revert-rn-75

@gitguardian

gitguardianBot commented Nov 21, 2024•
edited
Loading

Copy link
Copy Markdown

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian idGitGuardian statusSecretCommitFilename
3249666TriggeredGeneric Password60d4091packages/commands/src/utils.mjsView secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@socket-security

socket-securityBot commented Nov 22, 2024

Copy link
Copy Markdown

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

PackageNew capabilitiesTransitivesSizePublisher
npm/@alch/alchemy-web3@1.4.6network06.65 MBbrian-alchemy
npm/@amplitude/analytics-browser@2.11.9Transitive: network+94.01 MBsdk.dev
npm/@amplitude/node@1.9.2network+4590 kBkevinpagtakhan
npm/@amplitude/plugin-session-replay-browser@1.8.2Transitive: network+1413.8 MBsdk.dev
npm/@amplitude/react-native@2.17.2None0187 kBhao.yu
npm/@apollo/client@3.3.7environment, network Transitive: eval+13.3 MBapollo-bot
npm/@apollo/usage-reporting-protobuf@4.1.1None01.02 MBapollo-bot
npm/@apollo/utils.dropunuseddefinitions@2.0.1None06.58 kBapollo-bot
npm/@apollo/utils.keyvaluecache@2.1.1None034.1 kBapollo-bot
npm/@apollo/utils.logger@2.0.1None07.64 kBapollo-bot
npm/@apollo/utils.printwithreducedwhitespace@2.0.1None06.83 kBapollo-bot
npm/@apollo/utils.removealiases@2.0.1None04.95 kBapollo-bot
npm/@apollo/utils.sortast@2.0.1None08.93 kBapollo-bot
npm/@apollo/utils.stripsensitiveliterals@2.0.1None09.43 kBapollo-bot
npm/@apollo/utils.usagereporting@2.1.0None026.7 kBapollo-bot
npm/@assemblyscript/loader@0.9.4None033.1 kBassemblyscript
npm/@audius/fetch-nft@0.2.7network+21.12 MBmarcus_audius
npm/@audius/hedgehog@3.0.0-alpha.1Transitive: filesystem+4403 kBaudius-project
npm/@babel/cli@7.7.0Transitive: environment, filesystem, shell, unsafe+81.79 MBnicolo-ribaudo
npm/@babel/code-frame@7.23.5None023.3 kBnicolo-ribaudo
npm/@babel/compat-data@7.23.5None064.6 kBnicolo-ribaudo
npm/@babel/generator@7.23.6None0492 kBnicolo-ribaudo
npm/@babel/helper-annotate-as-pure@7.22.5None04.02 kBnicolo-ribaudo
npm/@babel/helper-compilation-targets@7.23.6Transitive: environment, filesystem, unsafe+71.75 MBnicolo-ribaudo
npm/@babel/helper-environment-visitor@7.22.20None06.56 kBnicolo-ribaudo
npm/@babel/helper-function-name@7.23.0None021.6 kBnicolo-ribaudo
npm/@babel/helper-hoist-variables@7.22.5None07.03 kBnicolo-ribaudo
npm/@babel/helper-module-imports@7.22.15None054.4 kBnicolo-ribaudo
npm/@babel/helper-plugin-utils@7.22.5None011.9 kBnicolo-ribaudo
npm/@babel/helper-split-export-declaration@7.22.6None010.7 kBnicolo-ribaudo
npm/@babel/helper-validator-identifier@7.22.20None049.1 kBnicolo-ribaudo
npm/@babel/helper-validator-option@7.23.5None011.7 kBnicolo-ribaudo
npm/@babel/highlight@7.23.4None018.4 kBnicolo-ribaudo
npm/@babel/parser@7.24.1None01.88 MBnicolo-ribaudo
npm/@babel/plugin-proposal-class-static-block@7.21.0Transitive: environment, filesystem, unsafe+132 MBnicolo-ribaudo
npm/@babel/plugin-transform-react-jsx@7.21.0Transitive: environment, filesystem, unsafe+81.78 MBnicolo-ribaudo
npm/@babel/plugin-transform-runtime@7.18.2unsafe Transitive: environment, filesystem+71.71 MBnicolo-ribaudo
npm/@babel/preset-env@7.22.15environment Transitive: filesystem, unsafe+903.73 MBnicolo-ribaudo
npm/@babel/preset-typescript@7.22.15Transitive: environment, filesystem, unsafe+162.19 MBnicolo-ribaudo
npm/@babel/register@7.7.0environment, filesystem Transitive: unsafe+71.7 MBnicolo-ribaudo
npm/@babel/runtime@7.18.3None0201 kBnicolo-ribaudo
npm/@babel/template@7.22.15None069.2 kBnicolo-ribaudo
npm/@babel/traverse@7.23.6None0610 kBnicolo-ribaudo
npm/@babel/types@7.23.6environment02.41 MBnicolo-ribaudo
npm/@certusone/wormhole-sdk@0.1.1filesystem Transitive: environment+215.2 MBevan-gray
npm/@changesets/cli@2.27.1environment, filesystem, shell+271.43 MBchangesets-release-bot
npm/@cloudflare/kv-asset-handler@0.3.1None+1126 kBwrangler-publisher
npm/@coinbase/cbpay-js@1.2.0None0172 kBlachiet
npm/@coinflowlabs/react@3.1.5network+2222 kBmeeder-coinflow
npm/@coral-xyz/anchor@0.29.0environment, filesystem, network+22.21 MBacheroncrypto
npm/@coral-xyz/borsh@0.29.0None022.2 kBacheroncrypto
npm/@elastic/elasticsearch@8.1.0Transitive: network+22.46 MBdelvedor
npm/@emotion/babel-plugin@11.11.0environment+3283 kBemotion-release-bot
npm/@emotion/babel-preset-css-prop@11.11.0environment Transitive: filesystem, unsafe+91.73 MBemotion-release-bot
npm/@emotion/css@11.11.2environment+6516 kBemotion-release-bot
npm/@emotion/eslint-plugin@11.11.0environment0101 kBemotion-release-bot
npm/@emotion/is-prop-valid@1.2.1environment029.1 kBemotion-release-bot
npm/@emotion/memoize@0.8.1environment04.29 kBemotion-release-bot
npm/@emotion/native@11.11.0environment+175.3 kBemotion-release-bot
npm/@emotion/react@11.11.1environment+7845 kBemotion-release-bot
npm/@emotion/server@11.11.0environment+277.7 kBemotion-release-bot
npm/@emotion/styled@11.11.0environment+4271 kBemotion-release-bot
npm/@emotion/stylis@0.8.5environment0105 kBemotion-release-bot
npm/@emotion/unitless@0.8.1environment07.05 kBemotion-release-bot
npm/@esbuild-plugins/node-globals-polyfill@0.2.3None0105 kBxmorse
npm/@escape.tech/mookme@2.4.1environment, filesystem, shell+4271 kBsteffthestunt
npm/@eslint-community/regexpp@4.10.0None0431 kBeslint-community-bot
npm/@ethereumjs/common@3.2.0None+2585 kBholgerd77
npm/@ethereumjs/tx@4.2.0None0275 kBholgerd77
npm/@ethersproject/abi@5.4.1None0495 kBricmoo
npm/@ethersproject/abstract-provider@5.4.1None059.6 kBricmoo
npm/@ethersproject/abstract-signer@5.4.1None082.3 kBricmoo
npm/@ethersproject/address@5.4.0None032.9 kBricmoo
npm/@ethersproject/base64@5.4.0None011.2 kBricmoo
npm/@ethersproject/basex@5.4.0None030.1 kBricmoo
npm/@ethersproject/contracts@5.4.1None0245 kBricmoo
npm/@ethersproject/hash@5.4.0None0120 kBricmoo
npm/@ethersproject/hdnode@5.4.0None080.4 kBricmoo
npm/@ethersproject/json-wallets@5.4.0None0124 kBricmoo
npm/@ethersproject/networks@5.4.2None041.1 kBricmoo
npm/@ethersproject/pbkdf2@5.4.0None017.2 kBricmoo
npm/@ethersproject/properties@5.4.1None031 kBricmoo
npm/@ethersproject/providers@5.4.5network+21.19 MBricmoo
npm/@ethersproject/random@5.4.0None016.6 kBricmoo
npm/@ethersproject/rlp@5.4.0None029.5 kBricmoo
npm/@ethersproject/signing-key@5.4.0None0243 kBricmoo
npm/@ethersproject/transactions@5.4.0None089.5 kBricmoo
npm/@ethersproject/units@5.4.0None020.2 kBricmoo
npm/@ethersproject/wallet@5.4.0None055.2 kBricmoo
npm/@ethersproject/web@5.4.0network0113 kBricmoo
npm/@ethersproject/wordlists@5.4.0None0392 kBricmoo
npm/@fingerprintjs/fingerprintjs-pro-server-api@4.1.2network0184 kBfp-pro
npm/@fingerprintjs/fingerprintjs-pro@3.5.6eval, network+1852 kBsurgie
npm/@google/model-viewer@3.3.0network030.9 MBgoogle-wombot
npm/@gorhom/bottom-sheet@4.6.4None+11.43 MBgorhom
npm/@gorhom/portal@1.0.9None089.6 kBgorhom
npm/@graphql-tools/merge@8.4.2None0100 kBardatan
npm/@grpc/grpc-js@1.12.0environment, filesystem, network01.94 MBmurgatroid99
npm/@grpc/proto-loader@0.7.13filesystem Transitive: network+23.01 MBmurgatroid99
npm/@hcaptcha/react-hcaptcha@0.3.6None030.8 kBbrdlyptrs
npm/@humanwhocodes/config-array@0.11.13None+1110 kBnzakas
npm/@improbable-eng/grpc-web-node-http-transport@0.15.0network012.1 kBmarcuslongmuir
npm/@improbable-eng/grpc-web@0.14.1network065.7 kBmarcuslongmuir
npm/@ipld/dag-pb@2.1.18None0236 kBnpm-service-account-ipld
npm/@isaacs/cliui@8.0.2None+6171 kBisaacs
npm/alchemy-sdk@2.0.1None01.44 MBbrian-alchemy
npm/prom-client@14.0.1filesystem, network, unsafe0105 kBsimenb

🚮 Removed packages:npm/@aragon/court@1.1.3, npm/@cloudflare/kv-asset-handler@0.0.12, npm/@openzeppelin/contracts-ethereum-package@2.5.0, npm/@openzeppelin/test-helpers@0.5.5, npm/@openzeppelin/truffle-upgrades@1.17.0, npm/@openzeppelin/upgrades@2.8.0, npm/@truffle/hdwallet-provider@1.7.0, npm/@typescript-eslint/eslint-plugin@5.55.0, npm/@typescript-eslint/parser@5.55.0, npm/async@2.6.4, npm/babel-polyfill@6.26.0, npm/babel-preset-env@1.7.0, npm/babel-register@6.26.0, npm/bignumber.js@8.0.1

View full report↗︎

@audius-infra

audius-infra commented Nov 22, 2024

Copy link
Copy Markdown
Collaborator

Preview this change https://demo.audius.co/am-revert-rn-75

@amendelsohn
amendelsohn merged commit 80c700e into mainNov 22, 2024
@amendelsohn
amendelsohn deleted the am-revert-rn-75 branch November 22, 2024 01:51
raymondjacobson pushed a commit that referenced this pull request Nov 22, 2024
@amendelsohn@dharit-tan@raymondjacobson
Revert "[C-5342] Upgrade react-native to 0.75 (#10301)" (#10497)
8cc1dd8
Co-authored-by: Dharit Tantiviramanond <dharit.tan@gmail.com>
audius-infra pushed a commit that referenced this pull request Nov 22, 2024
audius-infra
Audius Protocol v0.7.40
f93a34d
[80c700e] Revert "[C-5342] Upgrade react-native to 0.75 (#10301)" (#10497) Andrew Mendelsohn
[f5f7a1a] Add MRVR to MRI reporting plugin (#10470) Raymond Jacobson
audius-infra pushed a commit that referenced this pull request Nov 23, 2024
audius-infra
Audius Client (Web and Mobile) v1.5.110
218d5a3
[34d450f] QA ticket grab bag (#10514) Raymond Jacobson
[ccb7082] [PAY-3607] Migrate explore tracks to sdk (#10509) Reed
[bb6828e] [PAY-3503] Update no longer can message user UI (#10505) Reed
[80c700e] Revert "[C-5342] Upgrade react-native to 0.75 (#10301)" (#10497) Andrew Mendelsohn
[bb06fba] Fix sidebar playlists account sync (#10495) Isaac Solo
[047598a] [C-5405] Update upload flow with file replace (#10494) Kyle Shanks
[e1bc4ca] [QA-1842] Fix web date picker time default (#10491) Isaac Solo
[2fdfd7b] Remove PREFER_HIGHER_PATCH_FOR_PRIMARY/SECONDARIES feature flags (#10480) Reed
[2736806] [C-5410] Add ReplaceTrackConfirmation modal (#10489) Kyle Shanks
[8c52795] [C-5408] Move delete track action to overflow menu (#10487) Kyle Shanks
[4cfea48] [C-5395 & C-5396] Upgrade to amplitude v2 and enable session replay (#10463) JD Francis
[d6f43a6] Fix watchQueueAutoplay test (#10488) Andrew Mendelsohn
[4d15579] [C-5430] Add feature flag for track audio replace (#10482) Kyle Shanks
[7820db8] Remove AI_ATTRIBUTION feature flag (#10476) Reed
[09ec89b] [C-5404] Add FileReplaceContainer component to web (#10462) Kyle Shanks
[14756ed] Remove DISCOVERY_TIP_REACTIONS feature flag (#10479) Reed
[92eed35] Remove DEVELOPER_APPS_PAGE feature flag (#10477) Reed
[f242d87] Remove SDK_DISCOVERY_NODE_SELECTOR feature flag (#10474) Reed
[ec135ba] Remove LAZY_USERBANK_CREATION_ENABLED feature flag (#10473) Reed
[bc4452e] Remove misc feature flags (#10478) Reed
[980e2b0] Remove RELATED_ARTISTS_ON_PROFILE_ENABLED feature flag (#10475) Reed
[4d76fbe] Remove PODCAST_CONTROL_UPDATES_ENABLED feature flag (#10471) Reed
[914b46b] Remove EARLY_ACCESS feature flag (#10469) Reed
[5d0a9ed] Remove RATE_CTA_ENABLED feature flag (#10467) Reed
[61e9ddf] Remove OFFLINE_MODE_RELEASE feature flag (#10466) Reed
[85fb740] [C-5403, C-5411] Add Upload icon to harmony (#10459) Kyle Shanks
[d51cc3c] [QA-1840] Fix Offline Mode errors (#10460) Andrew Mendelsohn
[9a0603f] [C-5416] Basic guest checkout behind feature flag (#10447) Isaac Solo
[38e007c] [C-5417] Update track audio replace for sdk change (#10458) Kyle Shanks
[8455921] Remove TIPPING_ENABLED feature flag (#10457) Reed
[0403468] Remove SOLANA_LISTEN_ENABLED feature flag (#10456) Reed
[a93a826] Fix track edit sdk issues (#10450) Sebastian Klingler
[5484dac] [QA-1827] Fix queuing short profile lineups issue (#10451) Randy Schott
[c4ef1e0] Fix bad useEffects calls in PremiumContentPurchaseDrawer (#10454) Randy Schott
dylanjeffers added a commit that referenced this pull request Nov 27, 2024
@dylanjeffers
Reapply "[C-5342] Upgrade react-native to 0.75 (#10301)" (#10497)
4007c08
This reverts commit 80c700e.
dylanjeffers added a commit that referenced this pull request Dec 5, 2024
@dylanjeffers
Reapply "[C-5342] Upgrade react-native to 0.75 (#10301)" (#10497)
2030fdb
This reverts commit 80c700e.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raymondjacobsonraymondjacobsonraymondjacobson approved these changes
@Kyle-ShanksKyle-ShanksAwaiting requested review from Kyle-Shanks
+1 more reviewer
@dharit-tandharit-tandharit-tan approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/XXL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@amendelsohn@audius-infra@dharit-tan@raymondjacobson