Skip to content

[PE-5843] Migrate user selector usages to tan-query - #11653

Merged
amendelsohn merged 8 commits into
mainfrom
am-C-5843-user-selectors
Mar 26, 2025
Merged

[PE-5843] Migrate user selector usages to tan-query#11653
amendelsohn merged 8 commits into
mainfrom
am-C-5843-user-selectors

Conversation

@amendelsohn

@amendelsohnamendelsohn commented Mar 24, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Migrated all usages of userCacheSelectors in react components

  • useSelector(getUser) -> useUser
  • useSelector(getUsers) -> useUsers
  • useSelector(getUserByHandle) -> useUserByHandle

Future Work

  • selectors can't yet be removed because they are used in other selectors and sagas

How Has This Been Tested?

profile edit, userLink, tiles, user references generally working

@changeset-bot

changeset-botBot commented Mar 24, 2025•
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 1a2b977

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@amendelsohnamendelsohn changed the title [C-5843] Migrate user selector usages to tan-query[PE-5843] Migrate user selector usages to tan-queryMar 24, 2025
DejayJD
DejayJD reviewed Mar 26, 2025
View reviewed changes
Comment threadpackages/common/src/store/cache/users/selectors.ts
DejayJD
DejayJD reviewed Mar 26, 2025
View reviewed changes
Comment threadpackages/mobile/src/components/audio/AudioPlayer.tsx
DejayJD
DejayJD reviewed Mar 26, 2025
View reviewed changes
Comment threadpackages/mobile/src/components/core/UserDisplayName.tsx
DejayJD
DejayJD reviewed Mar 26, 2025
View reviewed changes
Comment threadpackages/mobile/src/components/core/UserGeneratedText.tsx Outdated
DejayJD
DejayJD reviewed Mar 26, 2025
View reviewed changes
Comment threadpackages/mobile/src/components/overflow-menu-drawer/ProfileOverflowMenuDrawer.tsx Outdated
DejayJD
DejayJD reviewed Mar 26, 2025
View reviewed changes
Comment threadpackages/mobile/src/components/image/UserImage.tsx Outdated
DejayJD
DejayJD reviewed Mar 26, 2025
View reviewed changes
Comment threadpackages/mobile/src/components/image/CoverPhoto.tsx Outdated
DejayJD
DejayJD reviewed Mar 26, 2025
View reviewed changes
Comment threadpackages/mobile/src/components/user-list/UserCard.tsx Outdated
DejayJD
DejayJD reviewed Mar 26, 2025
View reviewed changes
Comment threadpackages/mobile/src/screens/notifications-screen/Notifications/TierChangeNotification.tsx Outdated
DejayJD
DejayJD reviewed Mar 26, 2025
View reviewed changes
Comment threadpackages/web/src/components/avatar/Avatar.tsx Outdated
DejayJD
DejayJD reviewed Mar 26, 2025
View reviewed changes
Comment threadpackages/web/src/components/collection/CollectionCard.test.tsx
@amendelsohn

amendelsohn commented Mar 26, 2025

Copy link
Copy Markdown
ContributorAuthor

@DejayJD nice review. Good eyes on the selectors and mapping thing!

DejayJD
DejayJD approved these changes Mar 26, 2025
View reviewed changes

@DejayJDDejayJD left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - only comments are select opportunities, but mergeable as-is!

Comment threadpackages/web/src/components/user-card/UserCard.tsx Outdated
Comment threadpackages/web/src/hooks/useCoverPhoto.ts Outdated
Comment threadpackages/web/src/hooks/useProfilePicture.ts Outdated
@amendelsohn
amendelsohn merged commit 6b773ad into mainMar 26, 2025
@amendelsohn
amendelsohn deleted the am-C-5843-user-selectors branch March 26, 2025 21:31
schottra added a commit that referenced this pull request Mar 27, 2025
@schottra
Merge remote-tracking branch 'origin/main' into stems-downloads
e42cf12
* origin/main:
Tastemaker challenge block-gating fix (#11679)
Remove extraneous useUser string from ArtistChip (#11683)
[C-5834] Migrate user lists to tan-query (#11618)
Add prefetch for mobile notifications (#11681)
TrackListItem selector -> hook fixes (#11682)
potential undefined (#11680)
Notifications performance improvements (#11677)
Audius Protocol v0.7.120
[PE-5845] Migrate collection selector usages to tan-query (#11665)
Manual block/allow from AAO (#11654)
Fix search layout issues (#11673)
Fix buy audio swap and polling (#11671)
[PE-5843] Migrate user selector usages to tan-query (#11653)
Fix track screen params (#11670)
[PE-5865] Fix list index out of range for audio matching challenges (#11669)
Gate new listen streak specifier on block number (#11668)
[PE-5863] Migrate Follow/Unfollow user to tan-query (#11316) (#11664)
Audius Protocol v0.7.119
hotfix: Prioritize users with handles when fetching users by wallet (#11667)
audius-infra pushed a commit that referenced this pull request Mar 29, 2025
audius-infra
Audius Client (Web and Mobile) v1.5.128
0e9951c
[67201f6] Fix tracks search + tq search optimizations (#11689) JD Francis
[226b897] [PE-5853] Add pinned comment challenge (#11678) Farid Salau
[24645ab] [PE-5861] Select tan-query entities from sagas (#11691) Andrew Mendelsohn
[50ed5e1] [API-11] Provide default API gateway for discovery node selection override (#11676) Raymond Jacobson
[c5475b6] Fix settings page layout (#11688) Dylan Jeffers
[c039480] fix alignment of profile picture change button (#11684) Randy Schott
[c43212b] [C-5647] Migrate audio transactions to tan-query (#10980) (#11652) Dylan Jeffers
[2837678] Fix incorrect status label for aggregate challenges (#11674) Reed
[74eb16a] Remove extraneous useUser string from ArtistChip (#11683) Andrew Mendelsohn
[f9edc31] [C-5834] Migrate user lists to tan-query (#11618) Dylan Jeffers
[184991c] Add prefetch for mobile notifications (#11681) Dylan Jeffers
[74c1f63] TrackListItem selector -> hook fixes (#11682) Andrew Mendelsohn
[44dfabb] [PE-5845] Migrate collection selector usages to tan-query (#11665) Andrew Mendelsohn
[55eaba5] Fix search layout issues (#11673) Randy Schott
[7d915e1] Fix buy audio swap and polling (#11671) Raymond Jacobson
[6b773ad] [PE-5843] Migrate user selector usages to tan-query (#11653) Andrew Mendelsohn
[f1d77c7] Fix track screen params (#11670) Dylan Jeffers
[797fa40] [PE-5863] Migrate Follow/Unfollow user to tan-query (#11316) (#11664) Dylan Jeffers
[48290f6] [PE-5844] Migrate track selector usages to tan-query (#11655) Andrew Mendelsohn
[313b885] [C-5833] Avoid spreading tan-query results (#11628) Andrew Mendelsohn
[2ed81b5] [C-5839] Profile tracks to main (web) (#11620) JD Francis
[74b29b9] Raise stem limit to 200 (#11646) Isaac Solo
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dylanjeffersdylanjeffersAwaiting requested review from dylanjeffers
1 more reviewer
@DejayJDDejayJDDejayJD approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/XL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@amendelsohn@DejayJD