Uh oh!
There was an error while loading. Please reload this page.
[PE-5845] Migrate collection selector usages to tan-query - #11665
Merged
Conversation
|
DejayJD
reviewed
Mar 26, 2025
Uh oh!
There was an error while loading. Please reload this page.
DejayJD
reviewed
Mar 26, 2025
Uh oh!
There was an error while loading. Please reload this page.
DejayJD
reviewed
Mar 26, 2025
Uh oh!
There was an error while loading. Please reload this page.
DejayJD
reviewed
Mar 26, 2025
Uh oh!
There was an error while loading. Please reload this page.
DejayJD
reviewed
Mar 26, 2025
Comment on lines
+62
to
+65
| const tracksWithUsers: UserTrackMetadata[] = tracks?.map((t) => ({ | ||
| ...t, | ||
| user: users?.find((u) => u.user_id === t.owner_id) | ||
| })) as UserTrackMetadata[] |
Contributor
There was a problem hiding this comment.
nit: probs not worthy of this PR but I bet we could move this users to leaf nodes and not have to attach it like this
DejayJD
approved these changes
Mar 26, 2025
DejayJD
left a comment
Contributor
There was a problem hiding this comment.
Nice! Loving to see all these selectors
schottra added a commit
that referenced
this pull request
Mar 27, 2025
* origin/main: Tastemaker challenge block-gating fix (#11679) Remove extraneous useUser string from ArtistChip (#11683) [C-5834] Migrate user lists to tan-query (#11618) Add prefetch for mobile notifications (#11681) TrackListItem selector -> hook fixes (#11682) potential undefined (#11680) Notifications performance improvements (#11677) Audius Protocol v0.7.120 [PE-5845] Migrate collection selector usages to tan-query (#11665) Manual block/allow from AAO (#11654) Fix search layout issues (#11673) Fix buy audio swap and polling (#11671) [PE-5843] Migrate user selector usages to tan-query (#11653) Fix track screen params (#11670) [PE-5865] Fix list index out of range for audio matching challenges (#11669) Gate new listen streak specifier on block number (#11668) [PE-5863] Migrate Follow/Unfollow user to tan-query (#11316) (#11664) Audius Protocol v0.7.119 hotfix: Prioritize users with handles when fetching users by wallet (#11667)
audius-infra pushed a commit
that referenced
this pull request
Mar 29, 2025
[67201f6] Fix tracks search + tq search optimizations (#11689) JD Francis [226b897] [PE-5853] Add pinned comment challenge (#11678) Farid Salau [24645ab] [PE-5861] Select tan-query entities from sagas (#11691) Andrew Mendelsohn [50ed5e1] [API-11] Provide default API gateway for discovery node selection override (#11676) Raymond Jacobson [c5475b6] Fix settings page layout (#11688) Dylan Jeffers [c039480] fix alignment of profile picture change button (#11684) Randy Schott [c43212b] [C-5647] Migrate audio transactions to tan-query (#10980) (#11652) Dylan Jeffers [2837678] Fix incorrect status label for aggregate challenges (#11674) Reed [74eb16a] Remove extraneous useUser string from ArtistChip (#11683) Andrew Mendelsohn [f9edc31] [C-5834] Migrate user lists to tan-query (#11618) Dylan Jeffers [184991c] Add prefetch for mobile notifications (#11681) Dylan Jeffers [74c1f63] TrackListItem selector -> hook fixes (#11682) Andrew Mendelsohn [44dfabb] [PE-5845] Migrate collection selector usages to tan-query (#11665) Andrew Mendelsohn [55eaba5] Fix search layout issues (#11673) Randy Schott [7d915e1] Fix buy audio swap and polling (#11671) Raymond Jacobson [6b773ad] [PE-5843] Migrate user selector usages to tan-query (#11653) Andrew Mendelsohn [f1d77c7] Fix track screen params (#11670) Dylan Jeffers [797fa40] [PE-5863] Migrate Follow/Unfollow user to tan-query (#11316) (#11664) Dylan Jeffers [48290f6] [PE-5844] Migrate track selector usages to tan-query (#11655) Andrew Mendelsohn [313b885] [C-5833] Avoid spreading tan-query results (#11628) Andrew Mendelsohn [2ed81b5] [C-5839] Profile tracks to main (web) (#11620) JD Francis [74b29b9] Raise stem limit to 200 (#11646) Isaac Solo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace component usages of cacheCollectionSelectors
getCollection->useCollectiongetCollections->useCollectionscollectionHasHiddenTracksandgetIsCollectionEmptywhich were only used onceHow Has This Been Tested?
playlist playback, edit, save, lineups, all working