Uh oh!
There was an error while loading. Please reload this page.
[PE-6542] Replace msw with CoinsApi - #12589
Conversation
|
There was a problem hiding this comment.
Bugbot free trial expires on July 29, 2025
Learn more in the Cursor dashboard.
| mint: mintAddress, | ||
| limit: pageSize, | ||
| offset: pageParam, | ||
| sortDirection |
There was a problem hiding this comment.
Bug: Missing minBalance Parameter in SDK Call
The minBalance parameter in useArtistCoinMembers is not passed to the sdk.coins.getCoinMembers API call. While the previous implementation correctly included minBalance (as min_balance) in the request, the new SDK-based call omits it from the params object, breaking the minimum balance filtering functionality.
There was a problem hiding this comment.
i didn't export min balance to the sdk on purpose... but it does exist on the BE should we want it later...
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| { | ||
| value: '514K', | ||
| label: messages.totalTransfers | ||
| // Helper function to format numbers |
There was a problem hiding this comment.
does this not already exist?
| } | ||
| // Helper function to format currency | ||
| const formatCurrency = (num: number): string => { |
| } | ||
| // Helper function to format percentage | ||
| const formatPercentage = (num: number): string => { |
There was a problem hiding this comment.
do we want these helpers to be somewhere shared?
There was a problem hiding this comment.
definitely, ill have farid take a look at this part. @faridsalau
e65b9be to
f45dc87Compare| value: formatPercentage(coin.tokenInfo.trade24hChangePercent), | ||
| isPositive: coin.tokenInfo.trade24hChangePercent >= 0 | ||
| } | ||
| } |
There was a problem hiding this comment.
Bug: Asset Insights Component Fails Handling Null Token Info
The AssetInsights component inconsistently handles potentially null or undefinedcoin.tokenInfo properties from the useCoin API. While some properties use fallbacks (e.g., uniqueWallet24h || 0), others like priceChange24hPercent, uniqueWallet24hChangePercent, and trade24hChangePercent are accessed directly. This can cause runtime errors (e.g., undefined.toFixed()), incorrect boolean evaluations for change direction, and "NaN%" display for percentage values.
Uh oh!
There was an error while loading. Please reload this page.
[181df25] Fix search autocomplete (#12584) Ray Jacobson [70c7782] [PE-6542] Replace msw with CoinsApi (#12589) Dylan Jeffers [c489cc6] Update rate limit mechanism in solana relay (#12582) Ray Jacobson [192fb07] Update commentId types and fix mobile notification linking (#12588) Dylan Jeffers [c9b32a9] QA-2243 fix deep links (#12583) Dylan Jeffers [2675e3f] [PAY-3974] Add NOT /check to ASA (#12585) Ray Jacobson [0d7bf55] [QA-2240] Fix track search bottom padding (#12578) Dylan Jeffers [a4d5e53] [QA-2239] Fix unable to start new chat (#12577) Dylan Jeffers [fda0576] [QA-2237] Fix collection image regression (#12575) Dylan Jeffers [6967039] [PE-6553] Add underground trending to explore page (#12573) Randy Schott [c35c9d1] [QA-2238] Fix unresponsive mobile tiles (#12576) Dylan Jeffers [d219a23] Update og image urls in web app and ssr (#12574) Dylan Jeffers [901123e] [PE-6563] Mobile web comment highlighting (#12572) Dylan Jeffers [3610e8f] [PE-6557] Adds most shared section to Search/Explore (#12570) Randy Schott [ba739f6] Temp fix missing comment_id in notification endpoint (#12571) Dylan Jeffers [e7a36fe] Fix playback issue clicking multiple tracks in lineup (#12568) Dylan Jeffers [53dd38a] Set ruby bundler version (#12569) Dylan Jeffers [5e4311d] Make asset detail page more generic (#12561) Farid Salau [a2ffd08] Restore gesture handler (#12564) JD Francis [0900d9d] Fix mobile lint (#12567) Dylan Jeffers
Description
Replaces msw with coins-api from sdk
Still a few areas where we need to replace mock-data, but this sets us up in the right direction