Skip to content

[PE-6558][PE-6559][PE-6560] Empty search/explore states - #12639

Merged
schottra merged 7 commits into
mainfrom
empty-track-search-state
Aug 4, 2025
Merged

[PE-6558][PE-6559][PE-6560] Empty search/explore states#12639
schottra merged 7 commits into
mainfrom
empty-track-search-state

Conversation

@schottra

@schottraschottra commented Aug 1, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Apologies for the largeness. The web part of this got away from me due to code reorg.

  • Moved most sections into their own component files to make future perf optimization re: delayed loading easier. The idea is I want each component to fetch its own data and we were running a bunch of simultaneous hooks in the top-level page on web.
  • Cleaned up layout so the the outer container on all platforms is doing the gap instead of using bottom margins in some places
  • Fixed all of the hooks that supply data for these sections to properly use InifiniteQuery and allow passing values for all of the SDK parameters to them
    • Note here: I took an approach of wrapping the underlying SDK get params types with helpers that coerce the types into infinite query style params (i.e. use of pageSize instead of limit and offset). The goal is that we don't need to manually implement all of the underlying SDK parameters, they are just transparently passed through and show up in the types when using the hooks. Definitely open to feedback on this pattern. It could be turned into code generation or something more generic, but I'm wary of too much magic here (there is already a lot).
    • Also fun fact, we were fetching 30 items for some of these queries because that's the default...They are all set to 10 now and I made sure that all usages of the hooks in search/explore explicitly pass values for timeRange and pageSize so that we don't accidentally mess up this page if we change those defaults in the future.
  • Added boolean conditions for the various tabs to control which content should show and updated the content sections for search/explore pages to conditionally render the sections
  • Removed the placeholder content, updated logic to either show search results or the empty content for each tab.
  • Fixed moods grid to update the current category with a mood instead of hard-coding to 'tracks'

Going to do mobile web in a separate PR as it needs additional reorg

How Has This Been Tested?

Lots of visual comparison of the clients against Figma :-)

@changeset-bot

changeset-botBot commented Aug 1, 2025•
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 8220bc6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

dylanjeffers
dylanjeffers approved these changes Aug 1, 2025
View reviewed changes

@dylanjeffersdylanjeffers left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah great stuff here

Comment threadpackages/common/src/api/tan-query/explore/useBestSelling.ts Outdated
Comment threadpackages/common/src/api/types.ts
* and `userId` (which for SDK is a hashed string, while we want to use IDs
* internally for query keys). It also adds the `pageSize` field, which all
* infinite queries will need. */
export type SDKInfiniteQueryArgs<T> = Omit<

@dylanjeffersdylanjeffersAug 1, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sg

Comment threadpackages/mobile/src/screens/explore-screen/components/ExploreContent.tsx
FeatureFlags.SEARCH_EXPLORE_GOODIES
)

const showTrackContent = category === 'tracks' || category === 'all'

@dylanjeffersdylanjeffersAug 1, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

Comment threadpackages/mobile/src/services/env/index.ts Outdated
Comment threadpackages/mobile/src/services/remote-config/remote-config-instance.ts Outdated
Comment threadpackages/web/src/pages/explore-page/components/desktop/NewExplorePage.tsx
FeatureFlags.SEARCH_EXPLORE_GOODIES
)

const { data: exploreContent } = useExploreContent()

@dylanjeffersdylanjeffersAug 1, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bye

@schottra
schottraforce-pushed the empty-track-search-state branch from 94d3db9 to 8220bc6CompareAugust 4, 2025 14:48
@schottra
schottra merged commit ea26b0c into mainAug 4, 2025
9 of 10 checks passed
@schottra
schottra deleted the empty-track-search-state branch August 4, 2025 17:30
audius-infra pushed a commit that referenced this pull request Aug 9, 2025
audius-infra
Audius Client (Web and Mobile) v1.5.147
b00e892
[e0f1d8e] Fix ssr dn selection to use api (#12701) Ray Jacobson
[fe31aa0] [PE-6570] Hide user contextual content when logged out (#12695) Randy Schott
[5870def] Replace SSR hosts (#12696) Ray Jacobson
[7297c53] Artist coin blast UI improvements (#12693) Reed
[359f262] Improve shadow performance (#12688) Dylan Jeffers
[c52e96d] [PE-6336] Fix web track/collection tile overflow (#12691) Dylan Jeffers
[3373d8e] Add API as dn for ssr (#12694) Ray Jacobson
[33efa0b] [PE-6626][PE-6580][PE-6581] Fix slow loading when switching explore tabs on web (#12687) Randy Schott
[196861f] [QA-2278] Fix layout left align on small screens (#12689) Dylan Jeffers
[5c57bd3] Unrevert #12658 - Add artist coin discord logic (#12670) JD Francis
[ae1535a] Drop user-link touch target in track-list-item (#12651) Dylan Jeffers
[9e9666c] Add address lookup table to minimize swap size (#12685) Farid Salau
[4ab4f36] Remove top playlists method (#12690) Ray Jacobson
[0f40128] Fix animated value warning (#12678) Dylan Jeffers
[ca7af01] [QA-2275] Fix hidden playlist artwork validation (#12659) Dylan Jeffers
[e350114] Update create chat modal to fetch chat permissions for user results (#12681) KJ
[6740a78] Increase the debounce time of the chat user search (#12680) KJ
[9fc7f15] Fix supporter error for chat user search results (#12679) KJ
[9fc4b4c] [QA-2255] Revert "[QA-2193] Fix android playback stuck on one track (#12460)" (#12677) Reed
[aa7dfb8] Fix web test failures with TOKEN_LISTING_MAP and USDC_MINT_ADDRESS (#12676) Farid Salau
[9c2238f] Fix rich push notifications (#12672) Dylan Jeffers
[45fbd54] Version Packages (#12675) github-actions[bot]
[e8b67c8] Fix race condition of social icons not being loaded before being used (#12673) Marcus Pasell
[c7727b4] Remove get valid types from notifications query (#12669) Ray Jacobson
[5e7342d] Version Packages (#12223) github-actions[bot]
[20cb3bc] [QA-2264] File replace should not change title (#12657) Dylan Jeffers
[60431a4] Fix mobile lint (#12668) Farid Salau
[eef890e] Revert the breaking changes from getWalletAudioBalance (#12667) Marcus Pasell
[fa78f43] [QA-2272] Fix X share (#12666) Reed
[6c27b7e] Add optimistic token balance updates for Jupiter swaps (#12665) Farid Salau
[922a917] [PE-6592] Update chat composer line indexing logic (#12662) KJ
[fadbab1] Add artist coins feature branch to main (#12661) Farid Salau
[ddadd0e] Revert "[PE-6578] Add artist coin discord button logic " (#12663) Farid Salau
[83031b4] [PE-6578] Add artist coin discord button logic (#12658) JD Francis
[4b71284] [PE-6601] Enable communication notifs (#12647) Dylan Jeffers
[714cf76] [PE-6562][PE-6568][PE-6599] Bring mobile web S/E up to speed (#12649) Randy Schott
[293783d] [QA-2268] Fix X sign-up button (#12653) Reed
[edff607] [QA-2274] Fix cosign icon (#12656) Dylan Jeffers
[e16f582] [QA-2273] Fix type issue in useAudioBalance (#12652) Marcus Pasell
[38a6a8e] [QA-2224] Remove dm unfurl message bottom border (#12655) KJ
[74c3732] Fix web card user links (#12654) Dylan Jeffers
[2d816ca] Update copy for sharing with X (#12650) Farid Salau
[6eac232] Fix provisioning profiles for local dev (#12648) Ray Jacobson
[c1b8557] [PE-6535] Optimize list performance (lineups & more) with FlashList (#12622) JD Francis
[ea26b0c] [PE-6558][PE-6559][PE-6560] Empty search/explore states (#12639) Randy Schott
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dylanjeffersdylanjeffersdylanjeffers approved these changes

Assignees

No one assigned

Labels

size/XXL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@schottra@dylanjeffers