Skip to content

[PE-6336] Fix web track/collection tile overflow - #12691

Merged
dylanjeffers merged 4 commits into
mainfrom
pe-6336-fix-track-collection-tile-overflow
Aug 8, 2025
Merged

[PE-6336] Fix web track/collection tile overflow#12691
dylanjeffers merged 4 commits into
mainfrom
pe-6336-fix-track-collection-tile-overflow

Conversation

@dylanjeffers

@dylanjeffersdylanjeffers commented Aug 8, 2025

Copy link
Copy Markdown
Contributor

Description

Fixes web track/collection title overflow
Fixes issues where duration would be underneath the title
Fixes issues where podcast progress would not show up on track tiles due to incorrect genre casing
Fixes issue where podcast progress would be underneath title

@changeset-bot

changeset-botBot commented Aug 8, 2025•
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 861e449

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

DejayJD
DejayJD reviewed Aug 8, 2025
View reviewed changes
Comment threadpackages/common/src/utils/isLongFormContent.ts Outdated
export const isLongFormContent = (
track: Maybe<Pick<TrackMetadata, 'genre'> | null>
) => track?.genre === 'podcast' || track?.genre === 'audiobook'
) => track?.genre === 'Podcasts' || track?.genre === 'audiobook'

@DejayJDDejayJDAug 8, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is Genre an enum? We should probably use it here (or make it an enum if not)

@dylanjeffersdylanjeffersAug 8, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah good call

DejayJD
DejayJD reviewed Aug 8, 2025
View reviewed changes
Comment threadpackages/web/src/components/track/desktop/CollectionTile.tsx
</Box>
</Flex>
<Flex direction='column' justifyContent='space-between' flex={1}>
<Flex>

@DejayJDDejayJDAug 8, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦

@dylanjeffers
dylanjeffers merged commit c52e96d into mainAug 8, 2025
3 of 5 checks passed
@dylanjeffers
dylanjeffers deleted the pe-6336-fix-track-collection-tile-overflow branch August 8, 2025 20:18
@cursor

cursorBot commented Aug 8, 2025

Copy link
Copy Markdown
Contributor

Bugbot found 1 bug

To see it, activate your membership in the Cursor dashboard.

audius-infra pushed a commit that referenced this pull request Aug 9, 2025
audius-infra
Audius Client (Web and Mobile) v1.5.147
b00e892
[e0f1d8e] Fix ssr dn selection to use api (#12701) Ray Jacobson
[fe31aa0] [PE-6570] Hide user contextual content when logged out (#12695) Randy Schott
[5870def] Replace SSR hosts (#12696) Ray Jacobson
[7297c53] Artist coin blast UI improvements (#12693) Reed
[359f262] Improve shadow performance (#12688) Dylan Jeffers
[c52e96d] [PE-6336] Fix web track/collection tile overflow (#12691) Dylan Jeffers
[3373d8e] Add API as dn for ssr (#12694) Ray Jacobson
[33efa0b] [PE-6626][PE-6580][PE-6581] Fix slow loading when switching explore tabs on web (#12687) Randy Schott
[196861f] [QA-2278] Fix layout left align on small screens (#12689) Dylan Jeffers
[5c57bd3] Unrevert #12658 - Add artist coin discord logic (#12670) JD Francis
[ae1535a] Drop user-link touch target in track-list-item (#12651) Dylan Jeffers
[9e9666c] Add address lookup table to minimize swap size (#12685) Farid Salau
[4ab4f36] Remove top playlists method (#12690) Ray Jacobson
[0f40128] Fix animated value warning (#12678) Dylan Jeffers
[ca7af01] [QA-2275] Fix hidden playlist artwork validation (#12659) Dylan Jeffers
[e350114] Update create chat modal to fetch chat permissions for user results (#12681) KJ
[6740a78] Increase the debounce time of the chat user search (#12680) KJ
[9fc7f15] Fix supporter error for chat user search results (#12679) KJ
[9fc4b4c] [QA-2255] Revert "[QA-2193] Fix android playback stuck on one track (#12460)" (#12677) Reed
[aa7dfb8] Fix web test failures with TOKEN_LISTING_MAP and USDC_MINT_ADDRESS (#12676) Farid Salau
[9c2238f] Fix rich push notifications (#12672) Dylan Jeffers
[45fbd54] Version Packages (#12675) github-actions[bot]
[e8b67c8] Fix race condition of social icons not being loaded before being used (#12673) Marcus Pasell
[c7727b4] Remove get valid types from notifications query (#12669) Ray Jacobson
[5e7342d] Version Packages (#12223) github-actions[bot]
[20cb3bc] [QA-2264] File replace should not change title (#12657) Dylan Jeffers
[60431a4] Fix mobile lint (#12668) Farid Salau
[eef890e] Revert the breaking changes from getWalletAudioBalance (#12667) Marcus Pasell
[fa78f43] [QA-2272] Fix X share (#12666) Reed
[6c27b7e] Add optimistic token balance updates for Jupiter swaps (#12665) Farid Salau
[922a917] [PE-6592] Update chat composer line indexing logic (#12662) KJ
[fadbab1] Add artist coins feature branch to main (#12661) Farid Salau
[ddadd0e] Revert "[PE-6578] Add artist coin discord button logic " (#12663) Farid Salau
[83031b4] [PE-6578] Add artist coin discord button logic (#12658) JD Francis
[4b71284] [PE-6601] Enable communication notifs (#12647) Dylan Jeffers
[714cf76] [PE-6562][PE-6568][PE-6599] Bring mobile web S/E up to speed (#12649) Randy Schott
[293783d] [QA-2268] Fix X sign-up button (#12653) Reed
[edff607] [QA-2274] Fix cosign icon (#12656) Dylan Jeffers
[e16f582] [QA-2273] Fix type issue in useAudioBalance (#12652) Marcus Pasell
[38a6a8e] [QA-2224] Remove dm unfurl message bottom border (#12655) KJ
[74c3732] Fix web card user links (#12654) Dylan Jeffers
[2d816ca] Update copy for sharing with X (#12650) Farid Salau
[6eac232] Fix provisioning profiles for local dev (#12648) Ray Jacobson
[c1b8557] [PE-6535] Optimize list performance (lineups & more) with FlashList (#12622) JD Francis
[ea26b0c] [PE-6558][PE-6559][PE-6560] Empty search/explore states (#12639) Randy Schott
@schottraschottra mentioned this pull request Aug 11, 2025
Merged
schottra added a commit that referenced this pull request Aug 11, 2025
@schottra
Fix skeletons for title/artist on track tiles (#12707)
6e8f43b
### Description
Fixes TrackTile only showing a skeleton for title and stats after #12691
### How Has This Been Tested?
Manually toggled loading state on tracks via react dev tools and checked
rendered content
schottra added a commit that referenced this pull request Aug 11, 2025
@schottra
Fix skeletons for title/artist on track tiles (#12707)
105ba79
### Description
Fixes TrackTile only showing a skeleton for title and stats after #12691
### How Has This Been Tested?
Manually toggled loading state on tracks via react dev tools and checked
rendered content
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@DejayJDDejayJDDejayJD approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dylanjeffers@DejayJD