[PE-6708][PE-6713] Fixes to artist coin members leaderboard by DejayJD · Pull Request #12794 · AudiusProject/apps

DejayJD · 2025-08-22T23:04:22Z

Description

Fixed the issue where the members leaderboard card would show a load state as you scrolled through the leaderboard modal
Fixed the issue where it was showing the total user count from whatever we loaded in the first page, now it shows the total number based on the insights endpoint. (this is audio on prod)

One thing I did run into with this was that the insights endpoint still is kind of slow sometimes, and previously the userlist component assumed you would always have the total count whenever you have data. Instead of halting all rendering I just made the "+xyz" count not show if undefined/null

How Has This Been Tested?

web:prod

changeset-bot · 2025-08-22T23:04:26Z

⚠️ No Changeset found

Latest commit: 4269a25

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

DejayJD · 2025-08-22T23:05:26Z

+ options?: Pick<
+ UseInfiniteQueryOptions<CoinMember[], Error, TResult>,
+ 'select' | 'enabled'
+ >


TIL that we rarely pass select as an option infiniteQueries - typing this was a bit finnickier - maybe can package this up a bit like our SelectableQueryOptions 🤔

DejayJD · 2025-08-22T23:06:31Z

+ select: (data) => {
+ return data.pages.flat().slice(0, numUsersShowing)
+ }


I wonder if this helps perf a little bit because we're not loading a potentially big list anymore 🤔
maybe a pattern to look out for 🤔

anyway to know empirically?

Technically yes but is it worth the time? eh 🤷

[2ea203a] Finalize send audio flow (#12824) Dylan Jeffers [538bbb2] [PE-6773] Make indirect swaps use userbanks for all interactions and use confirmed for commitment level (#12825) Farid Salau [2a7161a] [QA-2313] Fix receive button on audio page (#12823) Dylan Jeffers [cb15e5e] Hide tier for official Audius account (#12819) Reed [84c191e] [PE-6710] Fix optimistic updates after token swaps (#12818) Reed [4a3cff0] [PE-6752][PE-6697] Swap flow QA updates (#12811) Farid Salau [30bb833] [QA-2295] Fix web chat messages getting cut off (#12817) Reed [c1a9683] [PE-6737] Connect the buy/sell flow to the mobile coin details balance card (#12808) KJ [5b3b909] Fix audio matching copy that got missed (#12816) Randy Schott [ca80e02] Fix explore screen feature flags (#12815) Dylan Jeffers [0b26b53] [QA-2255] Fix mobile lineup & playback bugs (continues playing same track after playing a new lineup page) (#12814) JD Francis [9f8b7dc] [QA-2299] "View Profile" instead of "Artist Page" (#12813) Reed [365d66f] [QA-2296|QA-2298] RC QA Fixes (#12812) JD Francis [07378e7] [PE-6691] Show AUDIO card if user doesn't have any other assets (#12807) Farid Salau [143e376] [PE-6722] Only show badge that user created if they have one (#12806) Farid Salau [4828631] [PE-6641|PE-6642] Artist coin popover fixes (#12804) JD Francis [cdaa316] Fix connected wallet copying wrong address (#12805) JD Francis [4cf1222] [QA-2287] Use X handles in x shares (#12803) Reed [80ec4c6] [PE-6540] Fix artist coin blast logos (#12798) Reed [d6e82d5] Fix flakey ampm test (#12778) Ray Jacobson [9726cb7] [PE-6716] Fix AssetDetailsPage wrong bottom padding (#12802) Reed [c0b6b6a] [PE-6745] Change 'likes' to 'favorites' on remix sort dropdown (#12796) Reed [a70db6e] [PE-6706] Fix userbadge gap (#12801) Reed [dd249a7] Several QA fixes and UI updates (#12795) Farid Salau [31710a0] [PE-6742] Make swaps work for low liquidity AUDIO pair coins (#12786) Farid Salau [ac41903] [PE-6731] Update discord oauth url (#12799) JD Francis [6e2df32] [PE-6681] Fix DMs Header right padding issue (#12800) KJ [84ae6cb] [QA-2255] Fix android playback issue (#12797) JD Francis [6faaad9] [PE-6708][PE-6713] Fixes to artist coin members leaderboard (#12794) JD Francis

DejayJD · 2025-08-22T23:04:22Z

Description

Fixed the issue where the members leaderboard card would show a load state as you scrolled through the leaderboard modal
Fixed the issue where it was showing the total user count from whatever we loaded in the first page, now it shows the total number based on the insights endpoint. (this is audio on prod)

One thing I did run into with this was that the insights endpoint still is kind of slow sometimes, and previously the userlist component assumed you would always have the total count whenever you have data. Instead of halting all rendering I just made the "+xyz" count not show if undefined/null

How Has This Been Tested?

web:prod

changeset-bot · 2025-08-22T23:04:26Z

⚠️ No Changeset found

Latest commit: 4269a25

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

DejayJD · 2025-08-22T23:05:26Z

+ options?: Pick<
+ UseInfiniteQueryOptions<CoinMember[], Error, TResult>,
+ 'select' | 'enabled'
+ >


TIL that we rarely pass select as an option infiniteQueries - typing this was a bit finnickier - maybe can package this up a bit like our SelectableQueryOptions 🤔

DejayJD · 2025-08-22T23:06:31Z

+ select: (data) => {
+ return data.pages.flat().slice(0, numUsersShowing)
+ }


I wonder if this helps perf a little bit because we're not loading a potentially big list anymore 🤔
maybe a pattern to look out for 🤔

anyway to know empirically?

Technically yes but is it worth the time? eh 🤷

[2ea203a] Finalize send audio flow (#12824) Dylan Jeffers [538bbb2] [PE-6773] Make indirect swaps use userbanks for all interactions and use confirmed for commitment level (#12825) Farid Salau [2a7161a] [QA-2313] Fix receive button on audio page (#12823) Dylan Jeffers [cb15e5e] Hide tier for official Audius account (#12819) Reed [84c191e] [PE-6710] Fix optimistic updates after token swaps (#12818) Reed [4a3cff0] [PE-6752][PE-6697] Swap flow QA updates (#12811) Farid Salau [30bb833] [QA-2295] Fix web chat messages getting cut off (#12817) Reed [c1a9683] [PE-6737] Connect the buy/sell flow to the mobile coin details balance card (#12808) KJ [5b3b909] Fix audio matching copy that got missed (#12816) Randy Schott [ca80e02] Fix explore screen feature flags (#12815) Dylan Jeffers [0b26b53] [QA-2255] Fix mobile lineup & playback bugs (continues playing same track after playing a new lineup page) (#12814) JD Francis [9f8b7dc] [QA-2299] "View Profile" instead of "Artist Page" (#12813) Reed [365d66f] [QA-2296|QA-2298] RC QA Fixes (#12812) JD Francis [07378e7] [PE-6691] Show AUDIO card if user doesn't have any other assets (#12807) Farid Salau [143e376] [PE-6722] Only show badge that user created if they have one (#12806) Farid Salau [4828631] [PE-6641|PE-6642] Artist coin popover fixes (#12804) JD Francis [cdaa316] Fix connected wallet copying wrong address (#12805) JD Francis [4cf1222] [QA-2287] Use X handles in x shares (#12803) Reed [80ec4c6] [PE-6540] Fix artist coin blast logos (#12798) Reed [d6e82d5] Fix flakey ampm test (#12778) Ray Jacobson [9726cb7] [PE-6716] Fix AssetDetailsPage wrong bottom padding (#12802) Reed [c0b6b6a] [PE-6745] Change 'likes' to 'favorites' on remix sort dropdown (#12796) Reed [a70db6e] [PE-6706] Fix userbadge gap (#12801) Reed [dd249a7] Several QA fixes and UI updates (#12795) Farid Salau [31710a0] [PE-6742] Make swaps work for low liquidity AUDIO pair coins (#12786) Farid Salau [ac41903] [PE-6731] Update discord oauth url (#12799) JD Francis [6e2df32] [PE-6681] Fix DMs Header right padding issue (#12800) KJ [84ae6cb] [QA-2255] Fix android playback issue (#12797) JD Francis [6faaad9] [PE-6708][PE-6713] Fixes to artist coin members leaderboard (#12794) JD Francis

DejayJD · 2025-08-22T23:04:22Z

Description

Fixed the issue where the members leaderboard card would show a load state as you scrolled through the leaderboard modal
Fixed the issue where it was showing the total user count from whatever we loaded in the first page, now it shows the total number based on the insights endpoint. (this is audio on prod)

One thing I did run into with this was that the insights endpoint still is kind of slow sometimes, and previously the userlist component assumed you would always have the total count whenever you have data. Instead of halting all rendering I just made the "+xyz" count not show if undefined/null

How Has This Been Tested?

web:prod

changeset-bot · 2025-08-22T23:04:26Z

⚠️ No Changeset found

Latest commit: 4269a25

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

DejayJD · 2025-08-22T23:05:26Z

+ options?: Pick<
+ UseInfiniteQueryOptions<CoinMember[], Error, TResult>,
+ 'select' | 'enabled'
+ >


TIL that we rarely pass select as an option infiniteQueries - typing this was a bit finnickier - maybe can package this up a bit like our SelectableQueryOptions 🤔

DejayJD · 2025-08-22T23:06:31Z

+ select: (data) => {
+ return data.pages.flat().slice(0, numUsersShowing)
+ }


I wonder if this helps perf a little bit because we're not loading a potentially big list anymore 🤔
maybe a pattern to look out for 🤔

anyway to know empirically?

Technically yes but is it worth the time? eh 🤷

[2ea203a] Finalize send audio flow (#12824) Dylan Jeffers [538bbb2] [PE-6773] Make indirect swaps use userbanks for all interactions and use confirmed for commitment level (#12825) Farid Salau [2a7161a] [QA-2313] Fix receive button on audio page (#12823) Dylan Jeffers [cb15e5e] Hide tier for official Audius account (#12819) Reed [84c191e] [PE-6710] Fix optimistic updates after token swaps (#12818) Reed [4a3cff0] [PE-6752][PE-6697] Swap flow QA updates (#12811) Farid Salau [30bb833] [QA-2295] Fix web chat messages getting cut off (#12817) Reed [c1a9683] [PE-6737] Connect the buy/sell flow to the mobile coin details balance card (#12808) KJ [5b3b909] Fix audio matching copy that got missed (#12816) Randy Schott [ca80e02] Fix explore screen feature flags (#12815) Dylan Jeffers [0b26b53] [QA-2255] Fix mobile lineup & playback bugs (continues playing same track after playing a new lineup page) (#12814) JD Francis [9f8b7dc] [QA-2299] "View Profile" instead of "Artist Page" (#12813) Reed [365d66f] [QA-2296|QA-2298] RC QA Fixes (#12812) JD Francis [07378e7] [PE-6691] Show AUDIO card if user doesn't have any other assets (#12807) Farid Salau [143e376] [PE-6722] Only show badge that user created if they have one (#12806) Farid Salau [4828631] [PE-6641|PE-6642] Artist coin popover fixes (#12804) JD Francis [cdaa316] Fix connected wallet copying wrong address (#12805) JD Francis [4cf1222] [QA-2287] Use X handles in x shares (#12803) Reed [80ec4c6] [PE-6540] Fix artist coin blast logos (#12798) Reed [d6e82d5] Fix flakey ampm test (#12778) Ray Jacobson [9726cb7] [PE-6716] Fix AssetDetailsPage wrong bottom padding (#12802) Reed [c0b6b6a] [PE-6745] Change 'likes' to 'favorites' on remix sort dropdown (#12796) Reed [a70db6e] [PE-6706] Fix userbadge gap (#12801) Reed [dd249a7] Several QA fixes and UI updates (#12795) Farid Salau [31710a0] [PE-6742] Make swaps work for low liquidity AUDIO pair coins (#12786) Farid Salau [ac41903] [PE-6731] Update discord oauth url (#12799) JD Francis [6e2df32] [PE-6681] Fix DMs Header right padding issue (#12800) KJ [84ae6cb] [QA-2255] Fix android playback issue (#12797) JD Francis [6faaad9] [PE-6708][PE-6713] Fixes to artist coin members leaderboard (#12794) JD Francis

DejayJD · 2025-08-22T23:04:22Z

Description

Fixed the issue where the members leaderboard card would show a load state as you scrolled through the leaderboard modal
Fixed the issue where it was showing the total user count from whatever we loaded in the first page, now it shows the total number based on the insights endpoint. (this is audio on prod)

One thing I did run into with this was that the insights endpoint still is kind of slow sometimes, and previously the userlist component assumed you would always have the total count whenever you have data. Instead of halting all rendering I just made the "+xyz" count not show if undefined/null

How Has This Been Tested?

web:prod

changeset-bot · 2025-08-22T23:04:26Z

⚠️ No Changeset found

Latest commit: 4269a25

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

DejayJD · 2025-08-22T23:05:26Z

+ options?: Pick<
+ UseInfiniteQueryOptions<CoinMember[], Error, TResult>,
+ 'select' | 'enabled'
+ >


TIL that we rarely pass select as an option infiniteQueries - typing this was a bit finnickier - maybe can package this up a bit like our SelectableQueryOptions 🤔

DejayJD · 2025-08-22T23:06:31Z

+ select: (data) => {
+ return data.pages.flat().slice(0, numUsersShowing)
+ }


I wonder if this helps perf a little bit because we're not loading a potentially big list anymore 🤔
maybe a pattern to look out for 🤔

anyway to know empirically?

Technically yes but is it worth the time? eh 🤷

[2ea203a] Finalize send audio flow (#12824) Dylan Jeffers [538bbb2] [PE-6773] Make indirect swaps use userbanks for all interactions and use confirmed for commitment level (#12825) Farid Salau [2a7161a] [QA-2313] Fix receive button on audio page (#12823) Dylan Jeffers [cb15e5e] Hide tier for official Audius account (#12819) Reed [84c191e] [PE-6710] Fix optimistic updates after token swaps (#12818) Reed [4a3cff0] [PE-6752][PE-6697] Swap flow QA updates (#12811) Farid Salau [30bb833] [QA-2295] Fix web chat messages getting cut off (#12817) Reed [c1a9683] [PE-6737] Connect the buy/sell flow to the mobile coin details balance card (#12808) KJ [5b3b909] Fix audio matching copy that got missed (#12816) Randy Schott [ca80e02] Fix explore screen feature flags (#12815) Dylan Jeffers [0b26b53] [QA-2255] Fix mobile lineup & playback bugs (continues playing same track after playing a new lineup page) (#12814) JD Francis [9f8b7dc] [QA-2299] "View Profile" instead of "Artist Page" (#12813) Reed [365d66f] [QA-2296|QA-2298] RC QA Fixes (#12812) JD Francis [07378e7] [PE-6691] Show AUDIO card if user doesn't have any other assets (#12807) Farid Salau [143e376] [PE-6722] Only show badge that user created if they have one (#12806) Farid Salau [4828631] [PE-6641|PE-6642] Artist coin popover fixes (#12804) JD Francis [cdaa316] Fix connected wallet copying wrong address (#12805) JD Francis [4cf1222] [QA-2287] Use X handles in x shares (#12803) Reed [80ec4c6] [PE-6540] Fix artist coin blast logos (#12798) Reed [d6e82d5] Fix flakey ampm test (#12778) Ray Jacobson [9726cb7] [PE-6716] Fix AssetDetailsPage wrong bottom padding (#12802) Reed [c0b6b6a] [PE-6745] Change 'likes' to 'favorites' on remix sort dropdown (#12796) Reed [a70db6e] [PE-6706] Fix userbadge gap (#12801) Reed [dd249a7] Several QA fixes and UI updates (#12795) Farid Salau [31710a0] [PE-6742] Make swaps work for low liquidity AUDIO pair coins (#12786) Farid Salau [ac41903] [PE-6731] Update discord oauth url (#12799) JD Francis [6e2df32] [PE-6681] Fix DMs Header right padding issue (#12800) KJ [84ae6cb] [QA-2255] Fix android playback issue (#12797) JD Francis [6faaad9] [PE-6708][PE-6713] Fixes to artist coin members leaderboard (#12794) JD Francis

DejayJD · 2025-08-22T23:04:22Z

Description

Fixed the issue where the members leaderboard card would show a load state as you scrolled through the leaderboard modal
Fixed the issue where it was showing the total user count from whatever we loaded in the first page, now it shows the total number based on the insights endpoint. (this is audio on prod)

One thing I did run into with this was that the insights endpoint still is kind of slow sometimes, and previously the userlist component assumed you would always have the total count whenever you have data. Instead of halting all rendering I just made the "+xyz" count not show if undefined/null

How Has This Been Tested?

web:prod

changeset-bot · 2025-08-22T23:04:26Z

⚠️ No Changeset found

Latest commit: 4269a25

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

DejayJD · 2025-08-22T23:05:26Z

+ options?: Pick<
+ UseInfiniteQueryOptions<CoinMember[], Error, TResult>,
+ 'select' | 'enabled'
+ >


TIL that we rarely pass select as an option infiniteQueries - typing this was a bit finnickier - maybe can package this up a bit like our SelectableQueryOptions 🤔

DejayJD · 2025-08-22T23:06:31Z

+ select: (data) => {
+ return data.pages.flat().slice(0, numUsersShowing)
+ }


I wonder if this helps perf a little bit because we're not loading a potentially big list anymore 🤔
maybe a pattern to look out for 🤔

anyway to know empirically?

Technically yes but is it worth the time? eh 🤷

[2ea203a] Finalize send audio flow (#12824) Dylan Jeffers [538bbb2] [PE-6773] Make indirect swaps use userbanks for all interactions and use confirmed for commitment level (#12825) Farid Salau [2a7161a] [QA-2313] Fix receive button on audio page (#12823) Dylan Jeffers [cb15e5e] Hide tier for official Audius account (#12819) Reed [84c191e] [PE-6710] Fix optimistic updates after token swaps (#12818) Reed [4a3cff0] [PE-6752][PE-6697] Swap flow QA updates (#12811) Farid Salau [30bb833] [QA-2295] Fix web chat messages getting cut off (#12817) Reed [c1a9683] [PE-6737] Connect the buy/sell flow to the mobile coin details balance card (#12808) KJ [5b3b909] Fix audio matching copy that got missed (#12816) Randy Schott [ca80e02] Fix explore screen feature flags (#12815) Dylan Jeffers [0b26b53] [QA-2255] Fix mobile lineup & playback bugs (continues playing same track after playing a new lineup page) (#12814) JD Francis [9f8b7dc] [QA-2299] "View Profile" instead of "Artist Page" (#12813) Reed [365d66f] [QA-2296|QA-2298] RC QA Fixes (#12812) JD Francis [07378e7] [PE-6691] Show AUDIO card if user doesn't have any other assets (#12807) Farid Salau [143e376] [PE-6722] Only show badge that user created if they have one (#12806) Farid Salau [4828631] [PE-6641|PE-6642] Artist coin popover fixes (#12804) JD Francis [cdaa316] Fix connected wallet copying wrong address (#12805) JD Francis [4cf1222] [QA-2287] Use X handles in x shares (#12803) Reed [80ec4c6] [PE-6540] Fix artist coin blast logos (#12798) Reed [d6e82d5] Fix flakey ampm test (#12778) Ray Jacobson [9726cb7] [PE-6716] Fix AssetDetailsPage wrong bottom padding (#12802) Reed [c0b6b6a] [PE-6745] Change 'likes' to 'favorites' on remix sort dropdown (#12796) Reed [a70db6e] [PE-6706] Fix userbadge gap (#12801) Reed [dd249a7] Several QA fixes and UI updates (#12795) Farid Salau [31710a0] [PE-6742] Make swaps work for low liquidity AUDIO pair coins (#12786) Farid Salau [ac41903] [PE-6731] Update discord oauth url (#12799) JD Francis [6e2df32] [PE-6681] Fix DMs Header right padding issue (#12800) KJ [84ae6cb] [QA-2255] Fix android playback issue (#12797) JD Francis [6faaad9] [PE-6708][PE-6713] Fixes to artist coin members leaderboard (#12794) JD Francis

DejayJD · 2025-08-22T23:04:22Z

Description

Fixed the issue where the members leaderboard card would show a load state as you scrolled through the leaderboard modal
Fixed the issue where it was showing the total user count from whatever we loaded in the first page, now it shows the total number based on the insights endpoint. (this is audio on prod)

One thing I did run into with this was that the insights endpoint still is kind of slow sometimes, and previously the userlist component assumed you would always have the total count whenever you have data. Instead of halting all rendering I just made the "+xyz" count not show if undefined/null

How Has This Been Tested?

web:prod

changeset-bot · 2025-08-22T23:04:26Z

⚠️ No Changeset found

Latest commit: 4269a25

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

DejayJD · 2025-08-22T23:05:26Z

+ options?: Pick<
+ UseInfiniteQueryOptions<CoinMember[], Error, TResult>,
+ 'select' | 'enabled'
+ >


TIL that we rarely pass select as an option infiniteQueries - typing this was a bit finnickier - maybe can package this up a bit like our SelectableQueryOptions 🤔

DejayJD · 2025-08-22T23:06:31Z

+ select: (data) => {
+ return data.pages.flat().slice(0, numUsersShowing)
+ }


I wonder if this helps perf a little bit because we're not loading a potentially big list anymore 🤔
maybe a pattern to look out for 🤔

anyway to know empirically?

Technically yes but is it worth the time? eh 🤷

[2ea203a] Finalize send audio flow (#12824) Dylan Jeffers [538bbb2] [PE-6773] Make indirect swaps use userbanks for all interactions and use confirmed for commitment level (#12825) Farid Salau [2a7161a] [QA-2313] Fix receive button on audio page (#12823) Dylan Jeffers [cb15e5e] Hide tier for official Audius account (#12819) Reed [84c191e] [PE-6710] Fix optimistic updates after token swaps (#12818) Reed [4a3cff0] [PE-6752][PE-6697] Swap flow QA updates (#12811) Farid Salau [30bb833] [QA-2295] Fix web chat messages getting cut off (#12817) Reed [c1a9683] [PE-6737] Connect the buy/sell flow to the mobile coin details balance card (#12808) KJ [5b3b909] Fix audio matching copy that got missed (#12816) Randy Schott [ca80e02] Fix explore screen feature flags (#12815) Dylan Jeffers [0b26b53] [QA-2255] Fix mobile lineup & playback bugs (continues playing same track after playing a new lineup page) (#12814) JD Francis [9f8b7dc] [QA-2299] "View Profile" instead of "Artist Page" (#12813) Reed [365d66f] [QA-2296|QA-2298] RC QA Fixes (#12812) JD Francis [07378e7] [PE-6691] Show AUDIO card if user doesn't have any other assets (#12807) Farid Salau [143e376] [PE-6722] Only show badge that user created if they have one (#12806) Farid Salau [4828631] [PE-6641|PE-6642] Artist coin popover fixes (#12804) JD Francis [cdaa316] Fix connected wallet copying wrong address (#12805) JD Francis [4cf1222] [QA-2287] Use X handles in x shares (#12803) Reed [80ec4c6] [PE-6540] Fix artist coin blast logos (#12798) Reed [d6e82d5] Fix flakey ampm test (#12778) Ray Jacobson [9726cb7] [PE-6716] Fix AssetDetailsPage wrong bottom padding (#12802) Reed [c0b6b6a] [PE-6745] Change 'likes' to 'favorites' on remix sort dropdown (#12796) Reed [a70db6e] [PE-6706] Fix userbadge gap (#12801) Reed [dd249a7] Several QA fixes and UI updates (#12795) Farid Salau [31710a0] [PE-6742] Make swaps work for low liquidity AUDIO pair coins (#12786) Farid Salau [ac41903] [PE-6731] Update discord oauth url (#12799) JD Francis [6e2df32] [PE-6681] Fix DMs Header right padding issue (#12800) KJ [84ae6cb] [QA-2255] Fix android playback issue (#12797) JD Francis [6faaad9] [PE-6708][PE-6713] Fixes to artist coin members leaderboard (#12794) JD Francis

DejayJD · 2025-08-22T23:04:22Z

Description

Fixed the issue where the members leaderboard card would show a load state as you scrolled through the leaderboard modal
Fixed the issue where it was showing the total user count from whatever we loaded in the first page, now it shows the total number based on the insights endpoint. (this is audio on prod)

One thing I did run into with this was that the insights endpoint still is kind of slow sometimes, and previously the userlist component assumed you would always have the total count whenever you have data. Instead of halting all rendering I just made the "+xyz" count not show if undefined/null

How Has This Been Tested?

web:prod

changeset-bot · 2025-08-22T23:04:26Z

⚠️ No Changeset found

Latest commit: 4269a25

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

DejayJD · 2025-08-22T23:05:26Z

+ options?: Pick<
+ UseInfiniteQueryOptions<CoinMember[], Error, TResult>,
+ 'select' | 'enabled'
+ >


TIL that we rarely pass select as an option infiniteQueries - typing this was a bit finnickier - maybe can package this up a bit like our SelectableQueryOptions 🤔

DejayJD · 2025-08-22T23:06:31Z

+ select: (data) => {
+ return data.pages.flat().slice(0, numUsersShowing)
+ }


I wonder if this helps perf a little bit because we're not loading a potentially big list anymore 🤔
maybe a pattern to look out for 🤔

anyway to know empirically?

Technically yes but is it worth the time? eh 🤷

[2ea203a] Finalize send audio flow (#12824) Dylan Jeffers [538bbb2] [PE-6773] Make indirect swaps use userbanks for all interactions and use confirmed for commitment level (#12825) Farid Salau [2a7161a] [QA-2313] Fix receive button on audio page (#12823) Dylan Jeffers [cb15e5e] Hide tier for official Audius account (#12819) Reed [84c191e] [PE-6710] Fix optimistic updates after token swaps (#12818) Reed [4a3cff0] [PE-6752][PE-6697] Swap flow QA updates (#12811) Farid Salau [30bb833] [QA-2295] Fix web chat messages getting cut off (#12817) Reed [c1a9683] [PE-6737] Connect the buy/sell flow to the mobile coin details balance card (#12808) KJ [5b3b909] Fix audio matching copy that got missed (#12816) Randy Schott [ca80e02] Fix explore screen feature flags (#12815) Dylan Jeffers [0b26b53] [QA-2255] Fix mobile lineup & playback bugs (continues playing same track after playing a new lineup page) (#12814) JD Francis [9f8b7dc] [QA-2299] "View Profile" instead of "Artist Page" (#12813) Reed [365d66f] [QA-2296|QA-2298] RC QA Fixes (#12812) JD Francis [07378e7] [PE-6691] Show AUDIO card if user doesn't have any other assets (#12807) Farid Salau [143e376] [PE-6722] Only show badge that user created if they have one (#12806) Farid Salau [4828631] [PE-6641|PE-6642] Artist coin popover fixes (#12804) JD Francis [cdaa316] Fix connected wallet copying wrong address (#12805) JD Francis [4cf1222] [QA-2287] Use X handles in x shares (#12803) Reed [80ec4c6] [PE-6540] Fix artist coin blast logos (#12798) Reed [d6e82d5] Fix flakey ampm test (#12778) Ray Jacobson [9726cb7] [PE-6716] Fix AssetDetailsPage wrong bottom padding (#12802) Reed [c0b6b6a] [PE-6745] Change 'likes' to 'favorites' on remix sort dropdown (#12796) Reed [a70db6e] [PE-6706] Fix userbadge gap (#12801) Reed [dd249a7] Several QA fixes and UI updates (#12795) Farid Salau [31710a0] [PE-6742] Make swaps work for low liquidity AUDIO pair coins (#12786) Farid Salau [ac41903] [PE-6731] Update discord oauth url (#12799) JD Francis [6e2df32] [PE-6681] Fix DMs Header right padding issue (#12800) KJ [84ae6cb] [QA-2255] Fix android playback issue (#12797) JD Francis [6faaad9] [PE-6708][PE-6713] Fixes to artist coin members leaderboard (#12794) JD Francis

DejayJD · 2025-08-22T23:04:22Z

Description

Fixed the issue where the members leaderboard card would show a load state as you scrolled through the leaderboard modal
Fixed the issue where it was showing the total user count from whatever we loaded in the first page, now it shows the total number based on the insights endpoint. (this is audio on prod)

One thing I did run into with this was that the insights endpoint still is kind of slow sometimes, and previously the userlist component assumed you would always have the total count whenever you have data. Instead of halting all rendering I just made the "+xyz" count not show if undefined/null

How Has This Been Tested?

web:prod

changeset-bot · 2025-08-22T23:04:26Z

⚠️ No Changeset found

Latest commit: 4269a25

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

DejayJD · 2025-08-22T23:05:26Z

+ options?: Pick<
+ UseInfiniteQueryOptions<CoinMember[], Error, TResult>,
+ 'select' | 'enabled'
+ >


TIL that we rarely pass select as an option infiniteQueries - typing this was a bit finnickier - maybe can package this up a bit like our SelectableQueryOptions 🤔

DejayJD · 2025-08-22T23:06:31Z

+ select: (data) => {
+ return data.pages.flat().slice(0, numUsersShowing)
+ }


I wonder if this helps perf a little bit because we're not loading a potentially big list anymore 🤔
maybe a pattern to look out for 🤔

anyway to know empirically?

Technically yes but is it worth the time? eh 🤷

[2ea203a] Finalize send audio flow (#12824) Dylan Jeffers [538bbb2] [PE-6773] Make indirect swaps use userbanks for all interactions and use confirmed for commitment level (#12825) Farid Salau [2a7161a] [QA-2313] Fix receive button on audio page (#12823) Dylan Jeffers [cb15e5e] Hide tier for official Audius account (#12819) Reed [84c191e] [PE-6710] Fix optimistic updates after token swaps (#12818) Reed [4a3cff0] [PE-6752][PE-6697] Swap flow QA updates (#12811) Farid Salau [30bb833] [QA-2295] Fix web chat messages getting cut off (#12817) Reed [c1a9683] [PE-6737] Connect the buy/sell flow to the mobile coin details balance card (#12808) KJ [5b3b909] Fix audio matching copy that got missed (#12816) Randy Schott [ca80e02] Fix explore screen feature flags (#12815) Dylan Jeffers [0b26b53] [QA-2255] Fix mobile lineup & playback bugs (continues playing same track after playing a new lineup page) (#12814) JD Francis [9f8b7dc] [QA-2299] "View Profile" instead of "Artist Page" (#12813) Reed [365d66f] [QA-2296|QA-2298] RC QA Fixes (#12812) JD Francis [07378e7] [PE-6691] Show AUDIO card if user doesn't have any other assets (#12807) Farid Salau [143e376] [PE-6722] Only show badge that user created if they have one (#12806) Farid Salau [4828631] [PE-6641|PE-6642] Artist coin popover fixes (#12804) JD Francis [cdaa316] Fix connected wallet copying wrong address (#12805) JD Francis [4cf1222] [QA-2287] Use X handles in x shares (#12803) Reed [80ec4c6] [PE-6540] Fix artist coin blast logos (#12798) Reed [d6e82d5] Fix flakey ampm test (#12778) Ray Jacobson [9726cb7] [PE-6716] Fix AssetDetailsPage wrong bottom padding (#12802) Reed [c0b6b6a] [PE-6745] Change 'likes' to 'favorites' on remix sort dropdown (#12796) Reed [a70db6e] [PE-6706] Fix userbadge gap (#12801) Reed [dd249a7] Several QA fixes and UI updates (#12795) Farid Salau [31710a0] [PE-6742] Make swaps work for low liquidity AUDIO pair coins (#12786) Farid Salau [ac41903] [PE-6731] Update discord oauth url (#12799) JD Francis [6e2df32] [PE-6681] Fix DMs Header right padding issue (#12800) KJ [84ae6cb] [QA-2255] Fix android playback issue (#12797) JD Francis [6faaad9] [PE-6708][PE-6713] Fixes to artist coin members leaderboard (#12794) JD Francis

fix loading state weirdness and total member count issue
e291b3e

pull-request-sizeBot added the size/M label Aug 22, 2025

DejayJD commented Aug 22, 2025
View reviewed changes

DejayJD requested review from Kyle-Shanks, dharit-tan and faridsalau August 22, 2025 23:06

faridsalau approved these changes Aug 24, 2025
View reviewed changes

faridsalau changed the title ~~[PE-6708] Fixes to artist coin members leaderboard~~[PE-6708][PE-6713] Fixes to artist coin members leaderboardAug 24, 2025

fix lint
4269a25

DejayJD merged commit 6faaad9 into mainAug 25, 2025
7 of 10 checks passed

DejayJD deleted the jd/members-leaderboard-tweaks branch August 25, 2025 16:36

fix loading state weirdness and total member count issue
e291b3e

pull-request-sizeBot added the size/M label Aug 22, 2025

DejayJD commented Aug 22, 2025
View reviewed changes

DejayJD requested review from Kyle-Shanks, dharit-tan and faridsalau August 22, 2025 23:06

faridsalau approved these changes Aug 24, 2025
View reviewed changes

faridsalau changed the title ~~[PE-6708] Fixes to artist coin members leaderboard~~[PE-6708][PE-6713] Fixes to artist coin members leaderboardAug 24, 2025

fix lint
4269a25

DejayJD merged commit 6faaad9 into mainAug 25, 2025
7 of 10 checks passed

DejayJD deleted the jd/members-leaderboard-tweaks branch August 25, 2025 16:36

fix loading state weirdness and total member count issue
e291b3e

pull-request-sizeBot added the size/M label Aug 22, 2025

DejayJD commented Aug 22, 2025
View reviewed changes

DejayJD requested review from Kyle-Shanks, dharit-tan and faridsalau August 22, 2025 23:06

faridsalau approved these changes Aug 24, 2025
View reviewed changes

faridsalau changed the title ~~[PE-6708] Fixes to artist coin members leaderboard~~[PE-6708][PE-6713] Fixes to artist coin members leaderboardAug 24, 2025

fix lint
4269a25

DejayJD merged commit 6faaad9 into mainAug 25, 2025
7 of 10 checks passed

DejayJD deleted the jd/members-leaderboard-tweaks branch August 25, 2025 16:36

fix loading state weirdness and total member count issue
e291b3e

pull-request-sizeBot added the size/M label Aug 22, 2025

DejayJD commented Aug 22, 2025
View reviewed changes

DejayJD requested review from Kyle-Shanks, dharit-tan and faridsalau August 22, 2025 23:06

faridsalau approved these changes Aug 24, 2025
View reviewed changes

faridsalau changed the title ~~[PE-6708] Fixes to artist coin members leaderboard~~[PE-6708][PE-6713] Fixes to artist coin members leaderboardAug 24, 2025

fix lint
4269a25

DejayJD merged commit 6faaad9 into mainAug 25, 2025
7 of 10 checks passed

DejayJD deleted the jd/members-leaderboard-tweaks branch August 25, 2025 16:36

fix loading state weirdness and total member count issue
e291b3e

pull-request-sizeBot added the size/M label Aug 22, 2025

DejayJD commented Aug 22, 2025
View reviewed changes

DejayJD requested review from Kyle-Shanks, dharit-tan and faridsalau August 22, 2025 23:06

faridsalau approved these changes Aug 24, 2025
View reviewed changes

faridsalau changed the title ~~[PE-6708] Fixes to artist coin members leaderboard~~[PE-6708][PE-6713] Fixes to artist coin members leaderboardAug 24, 2025

fix lint
4269a25

DejayJD merged commit 6faaad9 into mainAug 25, 2025
7 of 10 checks passed

DejayJD deleted the jd/members-leaderboard-tweaks branch August 25, 2025 16:36

fix loading state weirdness and total member count issue
e291b3e

pull-request-sizeBot added the size/M label Aug 22, 2025

DejayJD commented Aug 22, 2025
View reviewed changes

DejayJD requested review from Kyle-Shanks, dharit-tan and faridsalau August 22, 2025 23:06

faridsalau approved these changes Aug 24, 2025
View reviewed changes

faridsalau changed the title ~~[PE-6708] Fixes to artist coin members leaderboard~~[PE-6708][PE-6713] Fixes to artist coin members leaderboardAug 24, 2025

fix lint
4269a25

DejayJD merged commit 6faaad9 into mainAug 25, 2025
7 of 10 checks passed

DejayJD deleted the jd/members-leaderboard-tweaks branch August 25, 2025 16:36

fix loading state weirdness and total member count issue
e291b3e

pull-request-sizeBot added the size/M label Aug 22, 2025

DejayJD commented Aug 22, 2025
View reviewed changes

DejayJD requested review from Kyle-Shanks, dharit-tan and faridsalau August 22, 2025 23:06

faridsalau approved these changes Aug 24, 2025
View reviewed changes

faridsalau changed the title ~~[PE-6708] Fixes to artist coin members leaderboard~~[PE-6708][PE-6713] Fixes to artist coin members leaderboardAug 24, 2025

fix lint
4269a25

DejayJD merged commit 6faaad9 into mainAug 25, 2025
7 of 10 checks passed

DejayJD deleted the jd/members-leaderboard-tweaks branch August 25, 2025 16:36

fix loading state weirdness and total member count issue
e291b3e

pull-request-sizeBot added the size/M label Aug 22, 2025

DejayJD commented Aug 22, 2025
View reviewed changes

DejayJD requested review from Kyle-Shanks, dharit-tan and faridsalau August 22, 2025 23:06

faridsalau approved these changes Aug 24, 2025
View reviewed changes

faridsalau changed the title ~~[PE-6708] Fixes to artist coin members leaderboard~~[PE-6708][PE-6713] Fixes to artist coin members leaderboardAug 24, 2025

fix lint
4269a25

DejayJD merged commit 6faaad9 into mainAug 25, 2025
7 of 10 checks passed

DejayJD deleted the jd/members-leaderboard-tweaks branch August 25, 2025 16:36

Uh oh!

Conversation

DejayJD commented Aug 22, 2025

Description

How Has This Been Tested?

Uh oh!

changeset-botBot commented Aug 22, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

faridsalauAug 24, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

DejayJD commented Aug 22, 2025

Description

How Has This Been Tested?

Uh oh!

changeset-botBot commented Aug 22, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

faridsalauAug 24, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

DejayJD commented Aug 22, 2025

Description

How Has This Been Tested?

Uh oh!

changeset-botBot commented Aug 22, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

faridsalauAug 24, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

changeset-botBot commented Aug 22, 2025•
edited
Loading

faridsalauAug 24, 2025•
edited
Loading

changeset-botBot commented Aug 22, 2025•
edited
Loading

faridsalauAug 24, 2025•
edited
Loading

changeset-botBot commented Aug 22, 2025•
edited
Loading

faridsalauAug 24, 2025•
edited
Loading

changeset-botBot commented Aug 22, 2025•
edited
Loading

faridsalauAug 24, 2025•
edited
Loading