[PE-6773] Make indirect swaps use userbanks for all interactions and use confirmed for commitment level - #12825

Merged
faridsalau merged 2 commits into
mainfrom
fs-ac-swap-ata
Aug 29, 2025
Merged

[PE-6773] Make indirect swaps use userbanks for all interactions and use confirmed for commitment level#12825
faridsalau merged 2 commits into
mainfrom
fs-ac-swap-ata

Conversation

@faridsalau

@faridsalaufaridsalau commented Aug 29, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Changes Made

Swap Flow Optimization

  • User Bank Integration: Modified indirect swap flow to use user banks as intermediate storage between swaps

Key Modifications

  1. After First Swap: AUDIO is now transferred back to user bank instead of remaining in intermediate ATA
  2. Before Second Swap: AUDIO is transferred from user bank to new source ATA for Jupiter swap
  3. Cleanup Logic: Updated to close the correct ATA created for the second swap
  4. Commitment Level: Changed from 'finalized' to 'confirmed' for faster transaction processing

How Has This Been Tested?

npm run web:prod and play with swaps

@changeset-bot

changeset-botBot commented Aug 29, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: ccfb694

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@faridsalaufaridsalau changed the title Fs ac swap ata[PE-6773] Make indirect swaps use userbanks for all interactions and use confirmed for commitment levelAug 29, 2025
@faridsalau
faridsalau marked this pull request as ready for review August 29, 2025 15:08
dylanjeffers
dylanjeffers approved these changes Aug 29, 2025
View reviewed changes

@dylanjeffersdylanjeffers left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent

raymondjacobson
raymondjacobson requested changes Aug 29, 2025
View reviewed changes
Comment threadpackages/common/src/api/tan-query/jupiter/indirectSwapViaAudio.ts

const { inputTokenConfig, outputTokenConfig } = tokenConfigsResult

// Create AUDIO token config for transfers

@raymondjacobsonraymondjacobsonAug 29, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't necessary - the tokens record<string, TokenInfo> already has this - this would introduce an extra RPC call

@faridsalaufaridsalauAug 29, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure i understand? this doesn't make any requests, just does this

export const createTokenConfig = (
token: TokenInfo
): UserBankManagedTokenInfo => ({
mintAddress: token.address,
claimableTokenMint: getClaimableTokenMint(token),
decimals: token.decimals
})

@raymondjacobsonraymondjacobsonAug 29, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah nvm i misread this, this is just a helper to translate the config

raymondjacobson
raymondjacobson approved these changes Aug 29, 2025
View reviewed changes
Comment threadpackages/common/src/api/tan-query/jupiter/indirectSwapViaAudio.ts

const { inputTokenConfig, outputTokenConfig } = tokenConfigsResult

// Create AUDIO token config for transfers

@raymondjacobsonraymondjacobsonAug 29, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah nvm i misread this, this is just a helper to translate the config

@faridsalau
faridsalau merged commit 538bbb2 into mainAug 29, 2025
9 of 11 checks passed
@faridsalau
faridsalau deleted the fs-ac-swap-ata branch August 29, 2025 16:36
audius-infra pushed a commit that referenced this pull request Aug 30, 2025
audius-infra
Audius Client (Web and Mobile) v1.5.150
08ab54a
[2ea203a] Finalize send audio flow (#12824) Dylan Jeffers
[538bbb2] [PE-6773] Make indirect swaps use userbanks for all interactions and use confirmed for commitment level (#12825) Farid Salau
[2a7161a] [QA-2313] Fix receive button on audio page (#12823) Dylan Jeffers
[cb15e5e] Hide tier for official Audius account (#12819) Reed
[84c191e] [PE-6710] Fix optimistic updates after token swaps (#12818) Reed
[4a3cff0] [PE-6752][PE-6697] Swap flow QA updates (#12811) Farid Salau
[30bb833] [QA-2295] Fix web chat messages getting cut off (#12817) Reed
[c1a9683] [PE-6737] Connect the buy/sell flow to the mobile coin details balance card (#12808) KJ
[5b3b909] Fix audio matching copy that got missed (#12816) Randy Schott
[ca80e02] Fix explore screen feature flags (#12815) Dylan Jeffers
[0b26b53] [QA-2255] Fix mobile lineup & playback bugs (continues playing same track after playing a new lineup page) (#12814) JD Francis
[9f8b7dc] [QA-2299] "View Profile" instead of "Artist Page" (#12813) Reed
[365d66f] [QA-2296|QA-2298] RC QA Fixes (#12812) JD Francis
[07378e7] [PE-6691] Show AUDIO card if user doesn't have any other assets (#12807) Farid Salau
[143e376] [PE-6722] Only show badge that user created if they have one (#12806) Farid Salau
[4828631] [PE-6641|PE-6642] Artist coin popover fixes (#12804) JD Francis
[cdaa316] Fix connected wallet copying wrong address (#12805) JD Francis
[4cf1222] [QA-2287] Use X handles in x shares (#12803) Reed
[80ec4c6] [PE-6540] Fix artist coin blast logos (#12798) Reed
[d6e82d5] Fix flakey ampm test (#12778) Ray Jacobson
[9726cb7] [PE-6716] Fix AssetDetailsPage wrong bottom padding (#12802) Reed
[c0b6b6a] [PE-6745] Change 'likes' to 'favorites' on remix sort dropdown (#12796) Reed
[a70db6e] [PE-6706] Fix userbadge gap (#12801) Reed
[dd249a7] Several QA fixes and UI updates (#12795) Farid Salau
[31710a0] [PE-6742] Make swaps work for low liquidity AUDIO pair coins (#12786) Farid Salau
[ac41903] [PE-6731] Update discord oauth url (#12799) JD Francis
[6e2df32] [PE-6681] Fix DMs Header right padding issue (#12800) KJ
[84ae6cb] [QA-2255] Fix android playback issue (#12797) JD Francis
[6faaad9] [PE-6708][PE-6713] Fixes to artist coin members leaderboard (#12794) JD Francis
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raymondjacobsonraymondjacobsonraymondjacobson approved these changes
@dylanjeffersdylanjeffersdylanjeffers approved these changes
@dharit-tandharit-tanAwaiting requested review from dharit-tan
@Kyle-ShanksKyle-ShanksAwaiting requested review from Kyle-Shanks

Assignees

No one assigned

Labels

size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@faridsalau@raymondjacobson@dylanjeffers
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
[PE-6773] Make indirect swaps use userbanks for all interactions and use confirmed for commitment level - #12825
Merged
faridsalau merged 2 commits into
mainfrom 
fs-ac-swap-ata
Aug 29, 2025
Merged
[PE-6773] Make indirect swaps use userbanks for all interactions and use confirmed for commitment level#12825
faridsalau merged 2 commits into
mainfrom 
fs-ac-swap-ata
Conversation
@faridsalau
@faridsalaufaridsalau
commented
Aug 29, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Description
Changes Made
Swap Flow Optimization
  • User Bank Integration: Modified indirect swap flow to use user banks as intermediate storage between swaps
Key Modifications
  1. After First Swap: AUDIO is now transferred back to user bank instead of remaining in intermediate ATA
  2. Before Second Swap: AUDIO is transferred from user bank to new source ATA for Jupiter swap
  3. Cleanup Logic: Updated to close the correct ATA created for the second swap
  4. Commitment Level: Changed from 'finalized' to 'confirmed' for faster transaction processing
How Has This Been Tested?
npm run web:prod and play with swaps
@changeset-bot
changeset-botBot
commented
Aug 29, 2025

Copy link


Copy Markdown

⚠️ No Changeset found
Latest commit: ccfb694
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
@faridsalaufaridsalau
changed the title
Fs ac swap ata[PE-6773] Make indirect swaps use userbanks for all interactions and use confirmed for commitment levelAug 29, 2025
@faridsalau
faridsalau
marked this pull request as ready for review
August 29, 2025 15:08
dylanjeffers
dylanjeffers
approved these changes
Aug 29, 2025
View reviewed changes
@dylanjeffersdylanjeffers
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent
raymondjacobson
raymondjacobson
requested changes
Aug 29, 2025
View reviewed changes
Comment threadpackages/common/src/api/tan-query/jupiter/indirectSwapViaAudio.ts

 const { inputTokenConfig, outputTokenConfig } = tokenConfigsResult

 // Create AUDIO token config for transfers
@raymondjacobsonraymondjacobsonAug 29, 2025

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't necessary - the tokens record<string, TokenInfo> already has this - this would introduce an extra RPC call
@faridsalaufaridsalauAug 29, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure i understand? this doesn't make any requests, just does this
export const createTokenConfig = (
token: TokenInfo
): UserBankManagedTokenInfo => ({
mintAddress: token.address,
claimableTokenMint: getClaimableTokenMint(token),
decimals: token.decimals
})

@raymondjacobsonraymondjacobsonAug 29, 2025

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah nvm i misread this, this is just a helper to translate the config
raymondjacobson
raymondjacobson
approved these changes
Aug 29, 2025
View reviewed changes
Comment threadpackages/common/src/api/tan-query/jupiter/indirectSwapViaAudio.ts

 const { inputTokenConfig, outputTokenConfig } = tokenConfigsResult

 // Create AUDIO token config for transfers
@raymondjacobsonraymondjacobsonAug 29, 2025

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah nvm i misread this, this is just a helper to translate the config
@faridsalau
faridsalau
merged commit 538bbb2
into
mainAug 29, 2025

9 of 11 checks passed

@faridsalau
faridsalau
deleted the

fs-ac-swap-ata

branch
August 29, 2025 16:36
audius-infra pushed a commit
that referenced
this pull request
Aug 30, 2025
audius-infra
Audius Client (Web and Mobile) v1.5.150
08ab54a
[2ea203a] Finalize send audio flow (#12824) Dylan Jeffers
[538bbb2] [PE-6773] Make indirect swaps use userbanks for all interactions and use confirmed for commitment level (#12825) Farid Salau
[2a7161a] [QA-2313] Fix receive button on audio page (#12823) Dylan Jeffers
[cb15e5e] Hide tier for official Audius account (#12819) Reed
[84c191e] [PE-6710] Fix optimistic updates after token swaps (#12818) Reed
[4a3cff0] [PE-6752][PE-6697] Swap flow QA updates (#12811) Farid Salau
[30bb833] [QA-2295] Fix web chat messages getting cut off (#12817) Reed
[c1a9683] [PE-6737] Connect the buy/sell flow to the mobile coin details balance card (#12808) KJ
[5b3b909] Fix audio matching copy that got missed (#12816) Randy Schott
[ca80e02] Fix explore screen feature flags (#12815) Dylan Jeffers
[0b26b53] [QA-2255] Fix mobile lineup & playback bugs (continues playing same track after playing a new lineup page) (#12814) JD Francis
[9f8b7dc] [QA-2299] "View Profile" instead of "Artist Page" (#12813) Reed
[365d66f] [QA-2296|QA-2298] RC QA Fixes (#12812) JD Francis
[07378e7] [PE-6691] Show AUDIO card if user doesn't have any other assets (#12807) Farid Salau
[143e376] [PE-6722] Only show badge that user created if they have one (#12806) Farid Salau
[4828631] [PE-6641|PE-6642] Artist coin popover fixes (#12804) JD Francis
[cdaa316] Fix connected wallet copying wrong address (#12805) JD Francis
[4cf1222] [QA-2287] Use X handles in x shares (#12803) Reed
[80ec4c6] [PE-6540] Fix artist coin blast logos (#12798) Reed
[d6e82d5] Fix flakey ampm test (#12778) Ray Jacobson
[9726cb7] [PE-6716] Fix AssetDetailsPage wrong bottom padding (#12802) Reed
[c0b6b6a] [PE-6745] Change 'likes' to 'favorites' on remix sort dropdown (#12796) Reed
[a70db6e] [PE-6706] Fix userbadge gap (#12801) Reed
[dd249a7] Several QA fixes and UI updates (#12795) Farid Salau
[31710a0] [PE-6742] Make swaps work for low liquidity AUDIO pair coins (#12786) Farid Salau
[ac41903] [PE-6731] Update discord oauth url (#12799) JD Francis
[6e2df32] [PE-6681] Fix DMs Header right padding issue (#12800) KJ
[84ae6cb] [QA-2255] Fix android playback issue (#12797) JD Francis
[6faaad9] [PE-6708][PE-6713] Fixes to artist coin members leaderboard (#12794) JD Francis
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@raymondjacobsonraymondjacobsonraymondjacobson approved these changes
@dylanjeffersdylanjeffersdylanjeffers approved these changes
@dharit-tandharit-tanAwaiting requested review from dharit-tan
@Kyle-ShanksKyle-ShanksAwaiting requested review from Kyle-Shanks

Assignees


No one assigned


Labels

size/M

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@faridsalau@raymondjacobson@dylanjeffers

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[PE-6773] Make indirect swaps use userbanks for all interactions and use confirmed for commitment level - #12825
Merged
faridsalau merged 2 commits into
mainfrom 
fs-ac-swap-ata
Aug 29, 2025
Merged
[PE-6773] Make indirect swaps use userbanks for all interactions and use confirmed for commitment level#12825
faridsalau merged 2 commits into
mainfrom 
fs-ac-swap-ata
Conversation
@faridsalau
@faridsalaufaridsalau
commented
Aug 29, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Description
Changes Made
Swap Flow Optimization
  • User Bank Integration: Modified indirect swap flow to use user banks as intermediate storage between swaps
Key Modifications
  1. After First Swap: AUDIO is now transferred back to user bank instead of remaining in intermediate ATA
  2. Before Second Swap: AUDIO is transferred from user bank to new source ATA for Jupiter swap
  3. Cleanup Logic: Updated to close the correct ATA created for the second swap
  4. Commitment Level: Changed from 'finalized' to 'confirmed' for faster transaction processing
How Has This Been Tested?
npm run web:prod and play with swaps
@changeset-bot
changeset-botBot
commented
Aug 29, 2025

Copy link


Copy Markdown

⚠️ No Changeset found
Latest commit: ccfb694
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
@faridsalaufaridsalau
changed the title
Fs ac swap ata[PE-6773] Make indirect swaps use userbanks for all interactions and use confirmed for commitment levelAug 29, 2025
@faridsalau
faridsalau
marked this pull request as ready for review
August 29, 2025 15:08
dylanjeffers
dylanjeffers
approved these changes
Aug 29, 2025
View reviewed changes
@dylanjeffersdylanjeffers
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent
raymondjacobson
raymondjacobson
requested changes
Aug 29, 2025
View reviewed changes
Comment threadpackages/common/src/api/tan-query/jupiter/indirectSwapViaAudio.ts

 const { inputTokenConfig, outputTokenConfig } = tokenConfigsResult

 // Create AUDIO token config for transfers
@raymondjacobsonraymondjacobsonAug 29, 2025

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't necessary - the tokens record<string, TokenInfo> already has this - this would introduce an extra RPC call
@faridsalaufaridsalauAug 29, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure i understand? this doesn't make any requests, just does this
export const createTokenConfig = (
token: TokenInfo
): UserBankManagedTokenInfo => ({
mintAddress: token.address,
claimableTokenMint: getClaimableTokenMint(token),
decimals: token.decimals
})

@raymondjacobsonraymondjacobsonAug 29, 2025

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah nvm i misread this, this is just a helper to translate the config
raymondjacobson
raymondjacobson
approved these changes
Aug 29, 2025
View reviewed changes
Comment threadpackages/common/src/api/tan-query/jupiter/indirectSwapViaAudio.ts

 const { inputTokenConfig, outputTokenConfig } = tokenConfigsResult

 // Create AUDIO token config for transfers
@raymondjacobsonraymondjacobsonAug 29, 2025

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah nvm i misread this, this is just a helper to translate the config
@faridsalau
faridsalau
merged commit 538bbb2
into
mainAug 29, 2025

9 of 11 checks passed

@faridsalau
faridsalau
deleted the

fs-ac-swap-ata

branch
August 29, 2025 16:36
audius-infra pushed a commit
that referenced
this pull request
Aug 30, 2025
audius-infra
Audius Client (Web and Mobile) v1.5.150
08ab54a
[2ea203a] Finalize send audio flow (#12824) Dylan Jeffers
[538bbb2] [PE-6773] Make indirect swaps use userbanks for all interactions and use confirmed for commitment level (#12825) Farid Salau
[2a7161a] [QA-2313] Fix receive button on audio page (#12823) Dylan Jeffers
[cb15e5e] Hide tier for official Audius account (#12819) Reed
[84c191e] [PE-6710] Fix optimistic updates after token swaps (#12818) Reed
[4a3cff0] [PE-6752][PE-6697] Swap flow QA updates (#12811) Farid Salau
[30bb833] [QA-2295] Fix web chat messages getting cut off (#12817) Reed
[c1a9683] [PE-6737] Connect the buy/sell flow to the mobile coin details balance card (#12808) KJ
[5b3b909] Fix audio matching copy that got missed (#12816) Randy Schott
[ca80e02] Fix explore screen feature flags (#12815) Dylan Jeffers
[0b26b53] [QA-2255] Fix mobile lineup & playback bugs (continues playing same track after playing a new lineup page) (#12814) JD Francis
[9f8b7dc] [QA-2299] "View Profile" instead of "Artist Page" (#12813) Reed
[365d66f] [QA-2296|QA-2298] RC QA Fixes (#12812) JD Francis
[07378e7] [PE-6691] Show AUDIO card if user doesn't have any other assets (#12807) Farid Salau
[143e376] [PE-6722] Only show badge that user created if they have one (#12806) Farid Salau
[4828631] [PE-6641|PE-6642] Artist coin popover fixes (#12804) JD Francis
[cdaa316] Fix connected wallet copying wrong address (#12805) JD Francis
[4cf1222] [QA-2287] Use X handles in x shares (#12803) Reed
[80ec4c6] [PE-6540] Fix artist coin blast logos (#12798) Reed
[d6e82d5] Fix flakey ampm test (#12778) Ray Jacobson
[9726cb7] [PE-6716] Fix AssetDetailsPage wrong bottom padding (#12802) Reed
[c0b6b6a] [PE-6745] Change 'likes' to 'favorites' on remix sort dropdown (#12796) Reed
[a70db6e] [PE-6706] Fix userbadge gap (#12801) Reed
[dd249a7] Several QA fixes and UI updates (#12795) Farid Salau
[31710a0] [PE-6742] Make swaps work for low liquidity AUDIO pair coins (#12786) Farid Salau
[ac41903] [PE-6731] Update discord oauth url (#12799) JD Francis
[6e2df32] [PE-6681] Fix DMs Header right padding issue (#12800) KJ
[84ae6cb] [QA-2255] Fix android playback issue (#12797) JD Francis
[6faaad9] [PE-6708][PE-6713] Fixes to artist coin members leaderboard (#12794) JD Francis
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@raymondjacobsonraymondjacobsonraymondjacobson approved these changes
@dylanjeffersdylanjeffersdylanjeffers approved these changes
@dharit-tandharit-tanAwaiting requested review from dharit-tan
@Kyle-ShanksKyle-ShanksAwaiting requested review from Kyle-Shanks

Assignees


No one assigned


Labels

size/M

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@faridsalau@raymondjacobson@dylanjeffers

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[PE-6773] Make indirect swaps use userbanks for all interactions and use confirmed for commitment level - #12825
Merged
faridsalau merged 2 commits into
mainfrom 
fs-ac-swap-ata
Aug 29, 2025
Merged
[PE-6773] Make indirect swaps use userbanks for all interactions and use confirmed for commitment level#12825
faridsalau merged 2 commits into
mainfrom 
fs-ac-swap-ata
Conversation
@faridsalau
@faridsalaufaridsalau
commented
Aug 29, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Description
Changes Made
Swap Flow Optimization
  • User Bank Integration: Modified indirect swap flow to use user banks as intermediate storage between swaps
Key Modifications
  1. After First Swap: AUDIO is now transferred back to user bank instead of remaining in intermediate ATA
  2. Before Second Swap: AUDIO is transferred from user bank to new source ATA for Jupiter swap
  3. Cleanup Logic: Updated to close the correct ATA created for the second swap
  4. Commitment Level: Changed from 'finalized' to 'confirmed' for faster transaction processing
How Has This Been Tested?
npm run web:prod and play with swaps
@changeset-bot
changeset-botBot
commented
Aug 29, 2025

Copy link


Copy Markdown

⚠️ No Changeset found
Latest commit: ccfb694
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
@faridsalaufaridsalau
changed the title
Fs ac swap ata[PE-6773] Make indirect swaps use userbanks for all interactions and use confirmed for commitment levelAug 29, 2025
@faridsalau
faridsalau
marked this pull request as ready for review
August 29, 2025 15:08
dylanjeffers
dylanjeffers
approved these changes
Aug 29, 2025
View reviewed changes
@dylanjeffersdylanjeffers
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent
raymondjacobson
raymondjacobson
requested changes
Aug 29, 2025
View reviewed changes
Comment threadpackages/common/src/api/tan-query/jupiter/indirectSwapViaAudio.ts

 const { inputTokenConfig, outputTokenConfig } = tokenConfigsResult

 // Create AUDIO token config for transfers
@raymondjacobsonraymondjacobsonAug 29, 2025

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't necessary - the tokens record<string, TokenInfo> already has this - this would introduce an extra RPC call
@faridsalaufaridsalauAug 29, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure i understand? this doesn't make any requests, just does this
export const createTokenConfig = (
token: TokenInfo
): UserBankManagedTokenInfo => ({
mintAddress: token.address,
claimableTokenMint: getClaimableTokenMint(token),
decimals: token.decimals
})

@raymondjacobsonraymondjacobsonAug 29, 2025

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah nvm i misread this, this is just a helper to translate the config
raymondjacobson
raymondjacobson
approved these changes
Aug 29, 2025
View reviewed changes
Comment threadpackages/common/src/api/tan-query/jupiter/indirectSwapViaAudio.ts

 const { inputTokenConfig, outputTokenConfig } = tokenConfigsResult

 // Create AUDIO token config for transfers
@raymondjacobsonraymondjacobsonAug 29, 2025

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah nvm i misread this, this is just a helper to translate the config
@faridsalau
faridsalau
merged commit 538bbb2
into
mainAug 29, 2025

9 of 11 checks passed

@faridsalau
faridsalau
deleted the

fs-ac-swap-ata

branch
August 29, 2025 16:36
audius-infra pushed a commit
that referenced
this pull request
Aug 30, 2025
audius-infra
Audius Client (Web and Mobile) v1.5.150
08ab54a
[2ea203a] Finalize send audio flow (#12824) Dylan Jeffers
[538bbb2] [PE-6773] Make indirect swaps use userbanks for all interactions and use confirmed for commitment level (#12825) Farid Salau
[2a7161a] [QA-2313] Fix receive button on audio page (#12823) Dylan Jeffers
[cb15e5e] Hide tier for official Audius account (#12819) Reed
[84c191e] [PE-6710] Fix optimistic updates after token swaps (#12818) Reed
[4a3cff0] [PE-6752][PE-6697] Swap flow QA updates (#12811) Farid Salau
[30bb833] [QA-2295] Fix web chat messages getting cut off (#12817) Reed
[c1a9683] [PE-6737] Connect the buy/sell flow to the mobile coin details balance card (#12808) KJ
[5b3b909] Fix audio matching copy that got missed (#12816) Randy Schott
[ca80e02] Fix explore screen feature flags (#12815) Dylan Jeffers
[0b26b53] [QA-2255] Fix mobile lineup & playback bugs (continues playing same track after playing a new lineup page) (#12814) JD Francis
[9f8b7dc] [QA-2299] "View Profile" instead of "Artist Page" (#12813) Reed
[365d66f] [QA-2296|QA-2298] RC QA Fixes (#12812) JD Francis
[07378e7] [PE-6691] Show AUDIO card if user doesn't have any other assets (#12807) Farid Salau
[143e376] [PE-6722] Only show badge that user created if they have one (#12806) Farid Salau
[4828631] [PE-6641|PE-6642] Artist coin popover fixes (#12804) JD Francis
[cdaa316] Fix connected wallet copying wrong address (#12805) JD Francis
[4cf1222] [QA-2287] Use X handles in x shares (#12803) Reed
[80ec4c6] [PE-6540] Fix artist coin blast logos (#12798) Reed
[d6e82d5] Fix flakey ampm test (#12778) Ray Jacobson
[9726cb7] [PE-6716] Fix AssetDetailsPage wrong bottom padding (#12802) Reed
[c0b6b6a] [PE-6745] Change 'likes' to 'favorites' on remix sort dropdown (#12796) Reed
[a70db6e] [PE-6706] Fix userbadge gap (#12801) Reed
[dd249a7] Several QA fixes and UI updates (#12795) Farid Salau
[31710a0] [PE-6742] Make swaps work for low liquidity AUDIO pair coins (#12786) Farid Salau
[ac41903] [PE-6731] Update discord oauth url (#12799) JD Francis
[6e2df32] [PE-6681] Fix DMs Header right padding issue (#12800) KJ
[84ae6cb] [QA-2255] Fix android playback issue (#12797) JD Francis
[6faaad9] [PE-6708][PE-6713] Fixes to artist coin members leaderboard (#12794) JD Francis
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@raymondjacobsonraymondjacobsonraymondjacobson approved these changes
@dylanjeffersdylanjeffersdylanjeffers approved these changes
@dharit-tandharit-tanAwaiting requested review from dharit-tan
@Kyle-ShanksKyle-ShanksAwaiting requested review from Kyle-Shanks

Assignees


No one assigned


Labels

size/M

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@faridsalau@raymondjacobson@dylanjeffers

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
[PE-6773] Make indirect swaps use userbanks for all interactions and use confirmed for commitment level - #12825
Merged
faridsalau merged 2 commits into
mainfrom 
fs-ac-swap-ata
Aug 29, 2025
Merged
[PE-6773] Make indirect swaps use userbanks for all interactions and use confirmed for commitment level#12825
faridsalau merged 2 commits into
mainfrom 
fs-ac-swap-ata
Conversation
@faridsalau
@faridsalaufaridsalau
commented
Aug 29, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Description
Changes Made
Swap Flow Optimization
  • User Bank Integration: Modified indirect swap flow to use user banks as intermediate storage between swaps
Key Modifications
  1. After First Swap: AUDIO is now transferred back to user bank instead of remaining in intermediate ATA
  2. Before Second Swap: AUDIO is transferred from user bank to new source ATA for Jupiter swap
  3. Cleanup Logic: Updated to close the correct ATA created for the second swap
  4. Commitment Level: Changed from 'finalized' to 'confirmed' for faster transaction processing
How Has This Been Tested?
npm run web:prod and play with swaps
@changeset-bot
changeset-botBot
commented
Aug 29, 2025

Copy link


Copy Markdown

⚠️ No Changeset found
Latest commit: ccfb694
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
@faridsalaufaridsalau
changed the title
Fs ac swap ata[PE-6773] Make indirect swaps use userbanks for all interactions and use confirmed for commitment levelAug 29, 2025
@faridsalau
faridsalau
marked this pull request as ready for review
August 29, 2025 15:08
dylanjeffers
dylanjeffers
approved these changes
Aug 29, 2025
View reviewed changes
@dylanjeffersdylanjeffers
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent
raymondjacobson
raymondjacobson
requested changes
Aug 29, 2025
View reviewed changes
Comment threadpackages/common/src/api/tan-query/jupiter/indirectSwapViaAudio.ts

 const { inputTokenConfig, outputTokenConfig } = tokenConfigsResult

 // Create AUDIO token config for transfers
@raymondjacobsonraymondjacobsonAug 29, 2025

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't necessary - the tokens record<string, TokenInfo> already has this - this would introduce an extra RPC call
@faridsalaufaridsalauAug 29, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure i understand? this doesn't make any requests, just does this
export const createTokenConfig = (
token: TokenInfo
): UserBankManagedTokenInfo => ({
mintAddress: token.address,
claimableTokenMint: getClaimableTokenMint(token),
decimals: token.decimals
})

@raymondjacobsonraymondjacobsonAug 29, 2025

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah nvm i misread this, this is just a helper to translate the config
raymondjacobson
raymondjacobson
approved these changes
Aug 29, 2025
View reviewed changes
Comment threadpackages/common/src/api/tan-query/jupiter/indirectSwapViaAudio.ts

 const { inputTokenConfig, outputTokenConfig } = tokenConfigsResult

 // Create AUDIO token config for transfers
@raymondjacobsonraymondjacobsonAug 29, 2025

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah nvm i misread this, this is just a helper to translate the config
@faridsalau
faridsalau
merged commit 538bbb2
into
mainAug 29, 2025

9 of 11 checks passed

@faridsalau
faridsalau
deleted the

fs-ac-swap-ata

branch
August 29, 2025 16:36
audius-infra pushed a commit
that referenced
this pull request
Aug 30, 2025
audius-infra
Audius Client (Web and Mobile) v1.5.150
08ab54a
[2ea203a] Finalize send audio flow (#12824) Dylan Jeffers
[538bbb2] [PE-6773] Make indirect swaps use userbanks for all interactions and use confirmed for commitment level (#12825) Farid Salau
[2a7161a] [QA-2313] Fix receive button on audio page (#12823) Dylan Jeffers
[cb15e5e] Hide tier for official Audius account (#12819) Reed
[84c191e] [PE-6710] Fix optimistic updates after token swaps (#12818) Reed
[4a3cff0] [PE-6752][PE-6697] Swap flow QA updates (#12811) Farid Salau
[30bb833] [QA-2295] Fix web chat messages getting cut off (#12817) Reed
[c1a9683] [PE-6737] Connect the buy/sell flow to the mobile coin details balance card (#12808) KJ
[5b3b909] Fix audio matching copy that got missed (#12816) Randy Schott
[ca80e02] Fix explore screen feature flags (#12815) Dylan Jeffers
[0b26b53] [QA-2255] Fix mobile lineup & playback bugs (continues playing same track after playing a new lineup page) (#12814) JD Francis
[9f8b7dc] [QA-2299] "View Profile" instead of "Artist Page" (#12813) Reed
[365d66f] [QA-2296|QA-2298] RC QA Fixes (#12812) JD Francis
[07378e7] [PE-6691] Show AUDIO card if user doesn't have any other assets (#12807) Farid Salau
[143e376] [PE-6722] Only show badge that user created if they have one (#12806) Farid Salau
[4828631] [PE-6641|PE-6642] Artist coin popover fixes (#12804) JD Francis
[cdaa316] Fix connected wallet copying wrong address (#12805) JD Francis
[4cf1222] [QA-2287] Use X handles in x shares (#12803) Reed
[80ec4c6] [PE-6540] Fix artist coin blast logos (#12798) Reed
[d6e82d5] Fix flakey ampm test (#12778) Ray Jacobson
[9726cb7] [PE-6716] Fix AssetDetailsPage wrong bottom padding (#12802) Reed
[c0b6b6a] [PE-6745] Change 'likes' to 'favorites' on remix sort dropdown (#12796) Reed
[a70db6e] [PE-6706] Fix userbadge gap (#12801) Reed
[dd249a7] Several QA fixes and UI updates (#12795) Farid Salau
[31710a0] [PE-6742] Make swaps work for low liquidity AUDIO pair coins (#12786) Farid Salau
[ac41903] [PE-6731] Update discord oauth url (#12799) JD Francis
[6e2df32] [PE-6681] Fix DMs Header right padding issue (#12800) KJ
[84ae6cb] [QA-2255] Fix android playback issue (#12797) JD Francis
[6faaad9] [PE-6708][PE-6713] Fixes to artist coin members leaderboard (#12794) JD Francis
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@raymondjacobsonraymondjacobsonraymondjacobson approved these changes
@dylanjeffersdylanjeffersdylanjeffers approved these changes
@dharit-tandharit-tanAwaiting requested review from dharit-tan
@Kyle-ShanksKyle-ShanksAwaiting requested review from Kyle-Shanks

Assignees


No one assigned


Labels

size/M

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@faridsalau@raymondjacobson@dylanjeffers

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[PE-6773] Make indirect swaps use userbanks for all interactions and use confirmed for commitment level - #12825
Merged
faridsalau merged 2 commits into
mainfrom 
fs-ac-swap-ata
Aug 29, 2025
Merged
[PE-6773] Make indirect swaps use userbanks for all interactions and use confirmed for commitment level#12825
faridsalau merged 2 commits into
mainfrom 
fs-ac-swap-ata
Conversation
@faridsalau
@faridsalaufaridsalau
commented
Aug 29, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Description
Changes Made
Swap Flow Optimization
  • User Bank Integration: Modified indirect swap flow to use user banks as intermediate storage between swaps
Key Modifications
  1. After First Swap: AUDIO is now transferred back to user bank instead of remaining in intermediate ATA
  2. Before Second Swap: AUDIO is transferred from user bank to new source ATA for Jupiter swap
  3. Cleanup Logic: Updated to close the correct ATA created for the second swap
  4. Commitment Level: Changed from 'finalized' to 'confirmed' for faster transaction processing
How Has This Been Tested?
npm run web:prod and play with swaps
@changeset-bot
changeset-botBot
commented
Aug 29, 2025

Copy link


Copy Markdown

⚠️ No Changeset found
Latest commit: ccfb694
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
@faridsalaufaridsalau
changed the title
Fs ac swap ata[PE-6773] Make indirect swaps use userbanks for all interactions and use confirmed for commitment levelAug 29, 2025
@faridsalau
faridsalau
marked this pull request as ready for review
August 29, 2025 15:08
dylanjeffers
dylanjeffers
approved these changes
Aug 29, 2025
View reviewed changes
@dylanjeffersdylanjeffers
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent
raymondjacobson
raymondjacobson
requested changes
Aug 29, 2025
View reviewed changes
Comment threadpackages/common/src/api/tan-query/jupiter/indirectSwapViaAudio.ts

 const { inputTokenConfig, outputTokenConfig } = tokenConfigsResult

 // Create AUDIO token config for transfers
@raymondjacobsonraymondjacobsonAug 29, 2025

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't necessary - the tokens record<string, TokenInfo> already has this - this would introduce an extra RPC call
@faridsalaufaridsalauAug 29, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure i understand? this doesn't make any requests, just does this
export const createTokenConfig = (
token: TokenInfo
): UserBankManagedTokenInfo => ({
mintAddress: token.address,
claimableTokenMint: getClaimableTokenMint(token),
decimals: token.decimals
})

@raymondjacobsonraymondjacobsonAug 29, 2025

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah nvm i misread this, this is just a helper to translate the config
raymondjacobson
raymondjacobson
approved these changes
Aug 29, 2025
View reviewed changes
Comment threadpackages/common/src/api/tan-query/jupiter/indirectSwapViaAudio.ts

 const { inputTokenConfig, outputTokenConfig } = tokenConfigsResult

 // Create AUDIO token config for transfers
@raymondjacobsonraymondjacobsonAug 29, 2025

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah nvm i misread this, this is just a helper to translate the config
@faridsalau
faridsalau
merged commit 538bbb2
into
mainAug 29, 2025

9 of 11 checks passed

@faridsalau
faridsalau
deleted the

fs-ac-swap-ata

branch
August 29, 2025 16:36
audius-infra pushed a commit
that referenced
this pull request
Aug 30, 2025
audius-infra
Audius Client (Web and Mobile) v1.5.150
08ab54a
[2ea203a] Finalize send audio flow (#12824) Dylan Jeffers
[538bbb2] [PE-6773] Make indirect swaps use userbanks for all interactions and use confirmed for commitment level (#12825) Farid Salau
[2a7161a] [QA-2313] Fix receive button on audio page (#12823) Dylan Jeffers
[cb15e5e] Hide tier for official Audius account (#12819) Reed
[84c191e] [PE-6710] Fix optimistic updates after token swaps (#12818) Reed
[4a3cff0] [PE-6752][PE-6697] Swap flow QA updates (#12811) Farid Salau
[30bb833] [QA-2295] Fix web chat messages getting cut off (#12817) Reed
[c1a9683] [PE-6737] Connect the buy/sell flow to the mobile coin details balance card (#12808) KJ
[5b3b909] Fix audio matching copy that got missed (#12816) Randy Schott
[ca80e02] Fix explore screen feature flags (#12815) Dylan Jeffers
[0b26b53] [QA-2255] Fix mobile lineup & playback bugs (continues playing same track after playing a new lineup page) (#12814) JD Francis
[9f8b7dc] [QA-2299] "View Profile" instead of "Artist Page" (#12813) Reed
[365d66f] [QA-2296|QA-2298] RC QA Fixes (#12812) JD Francis
[07378e7] [PE-6691] Show AUDIO card if user doesn't have any other assets (#12807) Farid Salau
[143e376] [PE-6722] Only show badge that user created if they have one (#12806) Farid Salau
[4828631] [PE-6641|PE-6642] Artist coin popover fixes (#12804) JD Francis
[cdaa316] Fix connected wallet copying wrong address (#12805) JD Francis
[4cf1222] [QA-2287] Use X handles in x shares (#12803) Reed
[80ec4c6] [PE-6540] Fix artist coin blast logos (#12798) Reed
[d6e82d5] Fix flakey ampm test (#12778) Ray Jacobson
[9726cb7] [PE-6716] Fix AssetDetailsPage wrong bottom padding (#12802) Reed
[c0b6b6a] [PE-6745] Change 'likes' to 'favorites' on remix sort dropdown (#12796) Reed
[a70db6e] [PE-6706] Fix userbadge gap (#12801) Reed
[dd249a7] Several QA fixes and UI updates (#12795) Farid Salau
[31710a0] [PE-6742] Make swaps work for low liquidity AUDIO pair coins (#12786) Farid Salau
[ac41903] [PE-6731] Update discord oauth url (#12799) JD Francis
[6e2df32] [PE-6681] Fix DMs Header right padding issue (#12800) KJ
[84ae6cb] [QA-2255] Fix android playback issue (#12797) JD Francis
[6faaad9] [PE-6708][PE-6713] Fixes to artist coin members leaderboard (#12794) JD Francis
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@raymondjacobsonraymondjacobsonraymondjacobson approved these changes
@dylanjeffersdylanjeffersdylanjeffers approved these changes
@dharit-tandharit-tanAwaiting requested review from dharit-tan
@Kyle-ShanksKyle-ShanksAwaiting requested review from Kyle-Shanks

Assignees


No one assigned


Labels

size/M

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@faridsalau@raymondjacobson@dylanjeffers

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[PE-6773] Make indirect swaps use userbanks for all interactions and use confirmed for commitment level - #12825
Merged
faridsalau merged 2 commits into
mainfrom 
fs-ac-swap-ata
Aug 29, 2025
Merged
[PE-6773] Make indirect swaps use userbanks for all interactions and use confirmed for commitment level#12825
faridsalau merged 2 commits into
mainfrom 
fs-ac-swap-ata
Conversation
@faridsalau
@faridsalaufaridsalau
commented
Aug 29, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Description
Changes Made
Swap Flow Optimization
  • User Bank Integration: Modified indirect swap flow to use user banks as intermediate storage between swaps
Key Modifications
  1. After First Swap: AUDIO is now transferred back to user bank instead of remaining in intermediate ATA
  2. Before Second Swap: AUDIO is transferred from user bank to new source ATA for Jupiter swap
  3. Cleanup Logic: Updated to close the correct ATA created for the second swap
  4. Commitment Level: Changed from 'finalized' to 'confirmed' for faster transaction processing
How Has This Been Tested?
npm run web:prod and play with swaps
@changeset-bot
changeset-botBot
commented
Aug 29, 2025

Copy link


Copy Markdown

⚠️ No Changeset found
Latest commit: ccfb694
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
@faridsalaufaridsalau
changed the title
Fs ac swap ata[PE-6773] Make indirect swaps use userbanks for all interactions and use confirmed for commitment levelAug 29, 2025
@faridsalau
faridsalau
marked this pull request as ready for review
August 29, 2025 15:08
dylanjeffers
dylanjeffers
approved these changes
Aug 29, 2025
View reviewed changes
@dylanjeffersdylanjeffers
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent
raymondjacobson
raymondjacobson
requested changes
Aug 29, 2025
View reviewed changes
Comment threadpackages/common/src/api/tan-query/jupiter/indirectSwapViaAudio.ts

 const { inputTokenConfig, outputTokenConfig } = tokenConfigsResult

 // Create AUDIO token config for transfers
@raymondjacobsonraymondjacobsonAug 29, 2025

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't necessary - the tokens record<string, TokenInfo> already has this - this would introduce an extra RPC call
@faridsalaufaridsalauAug 29, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure i understand? this doesn't make any requests, just does this
export const createTokenConfig = (
token: TokenInfo
): UserBankManagedTokenInfo => ({
mintAddress: token.address,
claimableTokenMint: getClaimableTokenMint(token),
decimals: token.decimals
})

@raymondjacobsonraymondjacobsonAug 29, 2025

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah nvm i misread this, this is just a helper to translate the config
raymondjacobson
raymondjacobson
approved these changes
Aug 29, 2025
View reviewed changes
Comment threadpackages/common/src/api/tan-query/jupiter/indirectSwapViaAudio.ts

 const { inputTokenConfig, outputTokenConfig } = tokenConfigsResult

 // Create AUDIO token config for transfers
@raymondjacobsonraymondjacobsonAug 29, 2025

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah nvm i misread this, this is just a helper to translate the config
@faridsalau
faridsalau
merged commit 538bbb2
into
mainAug 29, 2025

9 of 11 checks passed

@faridsalau
faridsalau
deleted the

fs-ac-swap-ata

branch
August 29, 2025 16:36
audius-infra pushed a commit
that referenced
this pull request
Aug 30, 2025
audius-infra
Audius Client (Web and Mobile) v1.5.150
08ab54a
[2ea203a] Finalize send audio flow (#12824) Dylan Jeffers
[538bbb2] [PE-6773] Make indirect swaps use userbanks for all interactions and use confirmed for commitment level (#12825) Farid Salau
[2a7161a] [QA-2313] Fix receive button on audio page (#12823) Dylan Jeffers
[cb15e5e] Hide tier for official Audius account (#12819) Reed
[84c191e] [PE-6710] Fix optimistic updates after token swaps (#12818) Reed
[4a3cff0] [PE-6752][PE-6697] Swap flow QA updates (#12811) Farid Salau
[30bb833] [QA-2295] Fix web chat messages getting cut off (#12817) Reed
[c1a9683] [PE-6737] Connect the buy/sell flow to the mobile coin details balance card (#12808) KJ
[5b3b909] Fix audio matching copy that got missed (#12816) Randy Schott
[ca80e02] Fix explore screen feature flags (#12815) Dylan Jeffers
[0b26b53] [QA-2255] Fix mobile lineup & playback bugs (continues playing same track after playing a new lineup page) (#12814) JD Francis
[9f8b7dc] [QA-2299] "View Profile" instead of "Artist Page" (#12813) Reed
[365d66f] [QA-2296|QA-2298] RC QA Fixes (#12812) JD Francis
[07378e7] [PE-6691] Show AUDIO card if user doesn't have any other assets (#12807) Farid Salau
[143e376] [PE-6722] Only show badge that user created if they have one (#12806) Farid Salau
[4828631] [PE-6641|PE-6642] Artist coin popover fixes (#12804) JD Francis
[cdaa316] Fix connected wallet copying wrong address (#12805) JD Francis
[4cf1222] [QA-2287] Use X handles in x shares (#12803) Reed
[80ec4c6] [PE-6540] Fix artist coin blast logos (#12798) Reed
[d6e82d5] Fix flakey ampm test (#12778) Ray Jacobson
[9726cb7] [PE-6716] Fix AssetDetailsPage wrong bottom padding (#12802) Reed
[c0b6b6a] [PE-6745] Change 'likes' to 'favorites' on remix sort dropdown (#12796) Reed
[a70db6e] [PE-6706] Fix userbadge gap (#12801) Reed
[dd249a7] Several QA fixes and UI updates (#12795) Farid Salau
[31710a0] [PE-6742] Make swaps work for low liquidity AUDIO pair coins (#12786) Farid Salau
[ac41903] [PE-6731] Update discord oauth url (#12799) JD Francis
[6e2df32] [PE-6681] Fix DMs Header right padding issue (#12800) KJ
[84ae6cb] [QA-2255] Fix android playback issue (#12797) JD Francis
[6faaad9] [PE-6708][PE-6713] Fixes to artist coin members leaderboard (#12794) JD Francis
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@raymondjacobsonraymondjacobsonraymondjacobson approved these changes
@dylanjeffersdylanjeffersdylanjeffers approved these changes
@dharit-tandharit-tanAwaiting requested review from dharit-tan
@Kyle-ShanksKyle-ShanksAwaiting requested review from Kyle-Shanks

Assignees


No one assigned


Labels

size/M

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@faridsalau@raymondjacobson@dylanjeffers

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
[PE-6773] Make indirect swaps use userbanks for all interactions and use confirmed for commitment level - #12825
Merged
faridsalau merged 2 commits into
mainfrom 
fs-ac-swap-ata
Aug 29, 2025
Merged
[PE-6773] Make indirect swaps use userbanks for all interactions and use confirmed for commitment level#12825
faridsalau merged 2 commits into
mainfrom 
fs-ac-swap-ata
Conversation
@faridsalau
@faridsalaufaridsalau
commented
Aug 29, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Description
Changes Made
Swap Flow Optimization
  • User Bank Integration: Modified indirect swap flow to use user banks as intermediate storage between swaps
Key Modifications
  1. After First Swap: AUDIO is now transferred back to user bank instead of remaining in intermediate ATA
  2. Before Second Swap: AUDIO is transferred from user bank to new source ATA for Jupiter swap
  3. Cleanup Logic: Updated to close the correct ATA created for the second swap
  4. Commitment Level: Changed from 'finalized' to 'confirmed' for faster transaction processing
How Has This Been Tested?
npm run web:prod and play with swaps
@changeset-bot
changeset-botBot
commented
Aug 29, 2025

Copy link


Copy Markdown

⚠️ No Changeset found
Latest commit: ccfb694
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
@faridsalaufaridsalau
changed the title
Fs ac swap ata[PE-6773] Make indirect swaps use userbanks for all interactions and use confirmed for commitment levelAug 29, 2025
@faridsalau
faridsalau
marked this pull request as ready for review
August 29, 2025 15:08
dylanjeffers
dylanjeffers
approved these changes
Aug 29, 2025
View reviewed changes
@dylanjeffersdylanjeffers
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent
raymondjacobson
raymondjacobson
requested changes
Aug 29, 2025
View reviewed changes
Comment threadpackages/common/src/api/tan-query/jupiter/indirectSwapViaAudio.ts

 const { inputTokenConfig, outputTokenConfig } = tokenConfigsResult

 // Create AUDIO token config for transfers
@raymondjacobsonraymondjacobsonAug 29, 2025

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't necessary - the tokens record<string, TokenInfo> already has this - this would introduce an extra RPC call
@faridsalaufaridsalauAug 29, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure i understand? this doesn't make any requests, just does this
export const createTokenConfig = (
token: TokenInfo
): UserBankManagedTokenInfo => ({
mintAddress: token.address,
claimableTokenMint: getClaimableTokenMint(token),
decimals: token.decimals
})

@raymondjacobsonraymondjacobsonAug 29, 2025

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah nvm i misread this, this is just a helper to translate the config
raymondjacobson
raymondjacobson
approved these changes
Aug 29, 2025
View reviewed changes
Comment threadpackages/common/src/api/tan-query/jupiter/indirectSwapViaAudio.ts

 const { inputTokenConfig, outputTokenConfig } = tokenConfigsResult

 // Create AUDIO token config for transfers
@raymondjacobsonraymondjacobsonAug 29, 2025

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah nvm i misread this, this is just a helper to translate the config
@faridsalau
faridsalau
merged commit 538bbb2
into
mainAug 29, 2025

9 of 11 checks passed

@faridsalau
faridsalau
deleted the

fs-ac-swap-ata

branch
August 29, 2025 16:36
audius-infra pushed a commit
that referenced
this pull request
Aug 30, 2025
audius-infra
Audius Client (Web and Mobile) v1.5.150
08ab54a
[2ea203a] Finalize send audio flow (#12824) Dylan Jeffers
[538bbb2] [PE-6773] Make indirect swaps use userbanks for all interactions and use confirmed for commitment level (#12825) Farid Salau
[2a7161a] [QA-2313] Fix receive button on audio page (#12823) Dylan Jeffers
[cb15e5e] Hide tier for official Audius account (#12819) Reed
[84c191e] [PE-6710] Fix optimistic updates after token swaps (#12818) Reed
[4a3cff0] [PE-6752][PE-6697] Swap flow QA updates (#12811) Farid Salau
[30bb833] [QA-2295] Fix web chat messages getting cut off (#12817) Reed
[c1a9683] [PE-6737] Connect the buy/sell flow to the mobile coin details balance card (#12808) KJ
[5b3b909] Fix audio matching copy that got missed (#12816) Randy Schott
[ca80e02] Fix explore screen feature flags (#12815) Dylan Jeffers
[0b26b53] [QA-2255] Fix mobile lineup & playback bugs (continues playing same track after playing a new lineup page) (#12814) JD Francis
[9f8b7dc] [QA-2299] "View Profile" instead of "Artist Page" (#12813) Reed
[365d66f] [QA-2296|QA-2298] RC QA Fixes (#12812) JD Francis
[07378e7] [PE-6691] Show AUDIO card if user doesn't have any other assets (#12807) Farid Salau
[143e376] [PE-6722] Only show badge that user created if they have one (#12806) Farid Salau
[4828631] [PE-6641|PE-6642] Artist coin popover fixes (#12804) JD Francis
[cdaa316] Fix connected wallet copying wrong address (#12805) JD Francis
[4cf1222] [QA-2287] Use X handles in x shares (#12803) Reed
[80ec4c6] [PE-6540] Fix artist coin blast logos (#12798) Reed
[d6e82d5] Fix flakey ampm test (#12778) Ray Jacobson
[9726cb7] [PE-6716] Fix AssetDetailsPage wrong bottom padding (#12802) Reed
[c0b6b6a] [PE-6745] Change 'likes' to 'favorites' on remix sort dropdown (#12796) Reed
[a70db6e] [PE-6706] Fix userbadge gap (#12801) Reed
[dd249a7] Several QA fixes and UI updates (#12795) Farid Salau
[31710a0] [PE-6742] Make swaps work for low liquidity AUDIO pair coins (#12786) Farid Salau
[ac41903] [PE-6731] Update discord oauth url (#12799) JD Francis
[6e2df32] [PE-6681] Fix DMs Header right padding issue (#12800) KJ
[84ae6cb] [QA-2255] Fix android playback issue (#12797) JD Francis
[6faaad9] [PE-6708][PE-6713] Fixes to artist coin members leaderboard (#12794) JD Francis
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@raymondjacobsonraymondjacobsonraymondjacobson approved these changes
@dylanjeffersdylanjeffersdylanjeffers approved these changes
@dharit-tandharit-tanAwaiting requested review from dharit-tan
@Kyle-ShanksKyle-ShanksAwaiting requested review from Kyle-Shanks

Assignees


No one assigned


Labels

size/M

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@faridsalau@raymondjacobson@dylanjeffers