Uh oh!
There was an error while loading. Please reload this page.
[ASI-756] PR #4 - primary sync from secondary - #2303
Closed
SidSethi wants to merge 70 commits into
Closed
Conversation
SidSethi
commented
Jan 19, 2022
| run_integration_tests () { | ||
| echo Running integration tests... | ||
| ./node_modules/mocha/bin/mocha test/*.test.js --timeout "${INTEGRATION_TIMEOUT}" --exit | ||
| ./node_modules/mocha/bin/mocha test/nodesync.test.js --timeout "${INTEGRATION_TIMEOUT}" --exit |
ContributorAuthor
There was a problem hiding this comment.
TODO revert full file changes
SidSethi
commented
Jan 19, 2022
| timeout: 300000 /* 5m = 300000ms */ | ||
| }) | ||
| // SIDNOTE - zero instances of this log on prod 14 days |
ContributorAuthor
There was a problem hiding this comment.
TODO remove underlying code
SidSethi
commented
Jan 31, 2022
| @@ -0,0 +1,47 @@ | |||
| /** | |||
ContributorAuthor
There was a problem hiding this comment.
copied from processSync.js with very slight modifications:
- rename
redisKeytologPrefix - wrpa in try-catch
SidSethiforce-pushed
the
ss-files-hash-bugfix-v2
branch
from
June 22, 2022 15:13
9490bd2 to
f69e157CompareSidSethiforce-pushed
the
ss-primary-should-sync-e2e
branch
from
June 30, 2022 14:16
c6924b1 to
6b68a46CompareSidSethi
commented
Jul 7, 2022
ContributorAuthor
closing in favor of #3399 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Tests
How will this change be monitored?