Uh oh!
There was an error while loading. Please reload this page.
Upgrade circleci base image used for docker build - #3210
Conversation
|
| GitGuardian id | Secret | Commit | Filename | |
|---|---|---|---|---|
| 3509188 | Generic High Entropy Secret | 90976b5 | .circleci/config.yml | View secret |
| 3509188 | Generic High Entropy Secret | 90976b5 | .circleci/config.yml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
879a5e9 to
90976b5Comparedmanjunath
commented
Jun 6, 2022
fixed the issues @joaquincasares |
joaquincasares
left a comment
There was a problem hiding this comment.
Looks good after this request!
Uh oh!
There was an error while loading. Please reload this page.
f78aa70 to
574a3e0Compare…o dm-upgrade-circleci-images-2
…o dm-upgrade-circleci-images-2
[f94ebec] [C-2442] Remove cognito (#3212) Dylan Jeffers [0733d0f] Gate v2 signups (#3217) Theo Ilie [07a4548] [C-2422] Update linkify links to navigate audius links in app and external links in new tab (#3223) Kyle Shanks [acfc8d4] Fix the entity id in supporter rank up notification (#3222) sabrina-kiam [1114535] Fix lint mobile (#3221) Raymond Jacobson [496dd87] Fix lint mobile (#3221) Raymond Jacobson [68269c8] [C-2452] Remove audio before setting new one (#3219) Raymond Jacobson [17c5271] Fix lint (#3220) Raymond Jacobson [b8d2daf] Read CID metadata from discovery (#3181) Michelle Brier [4624902] [PAY-827][PAY-1154] Use DN stream endpoint for track download and offline mode (#3202) Saliou Diallo [f3afb57] [C-2321] Update notification entity link styles to prevent overflow (#3216) Kyle Shanks [3954798] Fix safari refresh event not being captured (#3215) Reed [9c367ca] [C-2444] Fix notification panel notification count (#3213) Dylan Jeffers [acbb8ff] [C-2443] Dont show tip tile on empty feed (#3214) Dylan Jeffers [908b7fc] [PAY-748] Fix supporter count alignment (#3203) Randy Schott [e21d74e] [PAY-1156] Cache message link unfurl responses (#3193) Reed [8cdff9f] Attempt to update circle config to move off python2.7-jessie (#3210) Randy Schott [a9ceb58] Fix profile saga merge conflict (#3209) Dylan Jeffers [e554924] [C-2082] Fix busted profile edits (#3208) Raymond Jacobson [ae19d05] [C-2335] Fix smart collection track count (#3207) Dylan Jeffers [e608058] [C-2314] Update settings screen ui (#3205) Dylan Jeffers [62659ee] [C-2441] Improve icon-verified styles (#3204) Dylan Jeffers [cd6b934] [C-2406] Fix app crash when profile cid fails to fetch (#3158) Sebastian Klingler [b6b0a52] [C-2435] Fix issue with collectibles cache update (#3200) Dylan Jeffers [81e9af3] [PAY-1152] Chats selector to check if is equal to popupMessageId (#3199) Reed [36da8b1] [C-2332] Fix follow artist stat (#3198) Dylan Jeffers [1954b1d] [C-2434] Fix remix image styles (#3201) Dylan Jeffers [878e661] [PAY-918] Mobile chat link unfurling (#3185) Reed
Description
Successor to #3157.
We are currently using an outdated CircleCI image to kick off docker builds (has no impact on the actual docker builds). This just updates to the latest image as recommended by CircleCI
Tests
Tested building images on CI and running then on staging nodes to verify they work.
How will this change be monitored? Are there sufficient logs?
The build success will be displayed in github with the CircleCI checks. The actual containers will be tested when deployed to staging.