Uh oh!
There was an error while loading. Please reload this page.
CON-200 Make snapbackMaxLastSuccessfulRunDelayMs configurable - #3223
Merged
Conversation
vicky-g
approved these changes
Jun 9, 2022
vicky-g
left a comment
Contributor
There was a problem hiding this comment.
wondering if 1 hr is actually enough for the delay and bumping it to 5 is just a quick fix / this is a source of another issue. either way, lgtm!
SidSethi
commented
Jun 9, 2022
ContributorAuthor
agreed, this is def indicative of a larger issue, 1 hr should be more than enough hahaha, this is just a temporary fix until @theoilie 's refactor work ships :) |
…chineQueueLatestJobSuccess is set
ContributorAuthor
@vicky-g made one tiny change, pls re-review :) |
SidSethi
commented
Jun 9, 2022
ContributorAuthor
@vicky-g made one tiny change, pls re-review :) |
sliptype pushed a commit
that referenced
this pull request
Sep 10, 2023
…ernal links in new tab (#3223)
sliptype pushed a commit
that referenced
this pull request
Sep 10, 2023
[f94ebec] [C-2442] Remove cognito (#3212) Dylan Jeffers [0733d0f] Gate v2 signups (#3217) Theo Ilie [07a4548] [C-2422] Update linkify links to navigate audius links in app and external links in new tab (#3223) Kyle Shanks [acfc8d4] Fix the entity id in supporter rank up notification (#3222) sabrina-kiam [1114535] Fix lint mobile (#3221) Raymond Jacobson [496dd87] Fix lint mobile (#3221) Raymond Jacobson [68269c8] [C-2452] Remove audio before setting new one (#3219) Raymond Jacobson [17c5271] Fix lint (#3220) Raymond Jacobson [b8d2daf] Read CID metadata from discovery (#3181) Michelle Brier [4624902] [PAY-827][PAY-1154] Use DN stream endpoint for track download and offline mode (#3202) Saliou Diallo [f3afb57] [C-2321] Update notification entity link styles to prevent overflow (#3216) Kyle Shanks [3954798] Fix safari refresh event not being captured (#3215) Reed [9c367ca] [C-2444] Fix notification panel notification count (#3213) Dylan Jeffers [acbb8ff] [C-2443] Dont show tip tile on empty feed (#3214) Dylan Jeffers [908b7fc] [PAY-748] Fix supporter count alignment (#3203) Randy Schott [e21d74e] [PAY-1156] Cache message link unfurl responses (#3193) Reed [8cdff9f] Attempt to update circle config to move off python2.7-jessie (#3210) Randy Schott [a9ceb58] Fix profile saga merge conflict (#3209) Dylan Jeffers [e554924] [C-2082] Fix busted profile edits (#3208) Raymond Jacobson [ae19d05] [C-2335] Fix smart collection track count (#3207) Dylan Jeffers [e608058] [C-2314] Update settings screen ui (#3205) Dylan Jeffers [62659ee] [C-2441] Improve icon-verified styles (#3204) Dylan Jeffers [cd6b934] [C-2406] Fix app crash when profile cid fails to fetch (#3158) Sebastian Klingler [b6b0a52] [C-2435] Fix issue with collectibles cache update (#3200) Dylan Jeffers [81e9af3] [PAY-1152] Chats selector to check if is equal to popupMessageId (#3199) Reed [36da8b1] [C-2332] Fix follow artist stat (#3198) Dylan Jeffers [1954b1d] [C-2434] Fix remix image styles (#3201) Dylan Jeffers [878e661] [PAY-918] Mobile chat link unfurling (#3185) Reed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously, snapback health check used a hardcoded value, which is not sufficient for stage or prod nodes
Changing this to be configurable + increasing prod default value
Note - this is a temporary fix until larger stateMachine redesign ships
Tests
Existing test coverage is sufficient
This is already live and working correctly on https://creatornode11.staging.audius.co/health_check?enforceStateMachineQueueHealth=true
Monitoring - How will this change be monitored? Are there sufficient logs / alerts?
Any errors containing
StateMachineQueue not healthy - last successful runSlack alerts (via pingdom) for stateMachineQueue health, or directly checking
<endpoint>/health_check?enforceStateMachineQueueHealth=true